From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6ED63D8062F for ; Mon, 18 Dec 2023 04:25:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=w4E7/X2Ka7zkQulLYe0sgvulpWIMvyfKa7nYnBR/Q88=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702873551; v=1; b=B0CEnAh0eu5gsICVj4UHY2bmbeFFnCTeBiTRU2+Lim0KizhkyYgl1ZB6dM3LbxveE9S2pebJ c94M2e681fmMiVdvJjsjIZSRNpFquO3mDzFg/7c4YhJRxgQIAEJN8dO5UIuHnXyJIkDGSyTeUDQ ZOv2JD6uUh4F/P4y5RNi8dkg= X-Received: by 127.0.0.2 with SMTP id uSy8YY7687511xR213XzvUms; Sun, 17 Dec 2023 20:25:51 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.43]) by mx.groups.io with SMTP id smtpd.web10.35303.1702873550189150914 for ; Sun, 17 Dec 2023 20:25:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OC5yLB6Zw2U11dJwesXqGhU5QSks2c8i9zoqJMVWSdrwGf7QqqT+C9HPcqjPxgtTa4D0uW6J0c4t6hQ6hpoycL+/lI0u7bGu7jmg5DR0aZnXZbKaTlHaYDpg8qDCPf9nE7ovbJ4EV/faV5oG+LIfvD5gwf0d3sepRkZ530Ouf8btnqoYCHadlz2PhJmQH/dV+o/ElfrZbU1rJQPeRH8cqQGRSgXOGWaC1CPISu0tVfUh24Y8i0aqWFVU2Ib4IL2OkwbQU5+r1OwIK3KEu7h/b2sW2ImHmYU1vKcxeNS/9UImTI316/TDZH0Hy1ft/vs6ZrkzJhvWaOHfryS7XrL6ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TsS2Wl6SKPQ0L382UOfntsuA874dk1sSytbg2y84EP0=; b=gGGJ1IJM3LGfZmxwwJoNBh3voJ94QF4OvZztz6ep+r6rHIgpOCU1XUjxOnBJ9XRLzGZfzXXTFdriN4ymstgl48p/Dm9ryW3hECd7M0rEekQQqBjalcjrWtW1rH+X0Ox7xbgofHxML36Kgr9zzBx+hguqzajNBxDFqntjYk3/F/rz6LugxSToy+u2NpXIFXMCUSA/bTV2Cs3GXY1qusNLYaXnCghsjTBEdUkAVf7JqaPdDtD6ygT5qY2JuGK5RzhldKDVc+95l9VPPj3pP2ROBGLx5Bga/2cdP7V6IIWPLKipd6HJiVofjg27CGUHH0wgcS5SB7sd2EFii1puNhc1mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN6PR12MB8469.namprd12.prod.outlook.com (2603:10b6:208:46e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 04:25:42 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 04:25:42 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 10/14] RedfishDiscoverDxe: introduce InitInformationData helper function Thread-Topic: [PATCH v2 10/14] RedfishDiscoverDxe: introduce InitInformationData helper function Thread-Index: AQHaLuTJQh5Zh0AKXU6E2qO3l+KIVbCudfaA Date: Mon, 18 Dec 2023 04:25:41 +0000 Message-ID: References: <20231214232458.4636-1-mike.maslenkin@gmail.com> <20231214232458.4636-11-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-11-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=7d134b7a-a642-45b1-8fa0-c6407ec88089;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-18T04:22:56Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN6PR12MB8469:EE_ x-ms-office365-filtering-correlation-id: 5f4e196a-67a9-4e81-06fb-08dbff81655e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: QdUZPVYIpMi3sTcJq0S3yK1pNLxIOgW0aqIhC+H3e2DiJNV2hVTnwDeDx9SAIIa8T36Mlx3ZHUXSjhnj4NhEItB3YHc/5/uCfzZB535YMHEUEp4W/lM5T70jogd7rsXQD9h2aqUqZZIcdSvlTUW3eCl7qMkzRLPHK5OM5cAQpDXtVKxX7XLFx9v19UmMDDCaRb/Q09Pr2zcvS52dZAIRydntnaC0emgYFWe0TmAsPXwfCN7qhdxzY09UMeAFRbQBHRqnMLxBl/Urm0L1Y2E3JjuAxuP85fM25U4W2Yl/3vngjENTWPOK7zxS0eq5spTianKWDm7DIhazQQNaX42me9rwD1rcqRNgcWirvUZP6E8gKbwnwrdggONMGz+JrytDdRrbbmNtEdtd77+2VUqM9XiM78i3cg61SB/3ybC0a28KZkAoU3GDMjw0qXe2yVchHTpjSyHezxiUsCMShKewbhoiwKkObISvaZgsoQxz1a/6LEAz3SMltaItgWVEDgrLdZ1i/vytbIPX8p6CqHW1+Ba2FjV6jqO9meSuu+MsE50PjxUuXSjJVu0R31q5ptWjCMqo4Jvo8v3tjd/dj4Z3Emhq7ieXIJEyPg932Vv44lHVI4ZN6X4oxgp03UDGYtCxenvsMvkbB+Tz3JAY47ziyBJ7IUupU36QumJWIFbYB3s= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?70i/dBPu4QU2JZNG1gTRb/zuDp4p45jqJYjjTawbk7kKhJDPw6FONKbpb7wa?= =?us-ascii?Q?iyjtwB9k4p86qjV2BrW3vFAF5gV66/B4YxN8eVxxMdXm4ga9MDq4yW/Jfk9w?= =?us-ascii?Q?p5EEoi8fsdH2MOfxClOTjXC6RqbzPR+dfZxr/aGx2mmaikkEK0Hm04GjlMXJ?= =?us-ascii?Q?xsb29RegkEvRbaApkMt5kDWQdYrRxdPFLDp5GOIxPw3QQnYr2j2hnLtAt+U2?= =?us-ascii?Q?d2JO9p2XQ05kpy8erlabALyEN/48FcuPT0HDe9ucoG5hC9yq1PgZ4CQuzaFh?= =?us-ascii?Q?iEdnQ5Q420cV8yR/eYO0cB94vYF0C3Z+9/sDSLBOgYLCR2WohiA3V9utq6DJ?= =?us-ascii?Q?Jm7c01us7VLHDXknHbm+I6cDmLFTb0xGAjVueUjPJkh4dOUuF70wY02IRqC5?= =?us-ascii?Q?//RgCohEezl7NZMGLh9EOK05kAViIR6UsMUgUVpsAfX5sRBAXQFLY6A3fAns?= =?us-ascii?Q?MaEnimJIMMQ5tZUJIfAm/fI3TPxdi7SScEzO6q1o5N51Bkb5TOqbfupsu41/?= =?us-ascii?Q?PuvpeKoh1w4LyapizDIO8bDadCBx5MpsjT1wAtZnTphAIs+JFlbHosPJTq95?= =?us-ascii?Q?tZCfZ+bmC6fIlzZSQaGSn0LeF58LR7BcQrlq5fDsurD7tHO7d+7z7E3Lqvlp?= =?us-ascii?Q?Nq+B6h9y6F3+QZgN45z0tDo/daU3xyxJm+rwCNV71D3DHemZi1PXYTkLKMpR?= =?us-ascii?Q?6ifGfqEJEQJmA7s0khY1fo9KgYJJ3PK6c0nTKKkWBrXqFiFHa6ILzNwOdR13?= =?us-ascii?Q?HjKjRfQl6+7ymX3XNRaYzkP7uEONvkjvNzNyc8wr7Sq2T9f+mEOVhwL0eZoE?= =?us-ascii?Q?ybHknQWW8rtTVcQiGVnRvz4/NSyZ7caGeFiKdoyNSsIHt6qw/VMSv+MuG/9r?= =?us-ascii?Q?SFAsoiiG42UDexKfjNNYJiIVym/84t2dnERlfzxKMIuoUHLfPIIDxHkjibiX?= =?us-ascii?Q?uUQ1ux3bUUZ9J8PmHUuNaB1J8fyQ//WegAWqjS1UzRv1gssMtVH8sSSLsboy?= =?us-ascii?Q?4HiNOL6o4UQYeeO1VxWJXQV7QwVLw5JnAbOvY6j8ZB1N1+Q7yjxS9LsJUkbu?= =?us-ascii?Q?ubmYcqhFczhOhF9fCi7vmvZL2LF9MhuiUnjUF2FyagKD2WuZJqdI50EpYWCR?= =?us-ascii?Q?TKh+JbsOXWF4YNvbRK+AGVHijvbutSq6vuffAjHaQb/ojP8RauNhJp04yiV9?= =?us-ascii?Q?II//P6UtywXUG9hCZdv9asm618s6olq3vjYkUyuBr2mdt5edYKqciekUBNbY?= =?us-ascii?Q?9sSIMwBIXXo1/g7QZg2eXCfCxNtvHlCED+gY8WJHP+sKDqWw3/6NeEBBm0uZ?= =?us-ascii?Q?ryeVpp3/U3Q0ZNosl74qc1G8Z8EGdLv10FQVtQFGtq7Zo3ugjlTw70qWWyAR?= =?us-ascii?Q?1cwTkIZpJJvPhaj81ASaw18qSW2T0el0kNna6MI9rSCbeJrPl77URPtVrHcx?= =?us-ascii?Q?4ZUAmbciNoYB5HbHgu3v2qRzA65BiAylW1qk1cdbd6qEwb8y1WLz7R70mHSb?= =?us-ascii?Q?avhFIQTv9TCxRfiza8uteUyOhwH9DtX/U37Pu2O0m6rimdaV0xQdsPcc9qEO?= =?us-ascii?Q?lOJPH/mziyBHfJbdZmERfYCeORGHsvYZH61uiEFT?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f4e196a-67a9-4e81-06fb-08dbff81655e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 04:25:41.9495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VVxLbBa4jalfUkCYXsZjT5ql4BV+16OIsoB1DWB3cDSFzF8GJIvbbD4RwvvMWZ4CBKNEwK06DNNqB7tSHRDEQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8469 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sUyPeG0NRh2jbLjcyD52japfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=B0CEnAh0; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 10/14] RedfishDiscoverDxe: introduce InitInformationDa= ta > helper function > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 ++++++++++++------ > 1 file changed, 74 insertions(+), 34 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index e344e06d8dcc..724aa35431a8 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -711,6 +711,69 @@ DiscoverRedfishHostInterface ( > return Status; > > } > > > > +/** > > + The function initalizes particular strings into > EFI_REDFISH_DISCOVERED_INFORMATION structure > > + > > + @param[in] Information EFI_REDFISH_DISCOVERED_INFORMATION > > + @param[in] RedfishVersion Redfish version. > > + @param[in] RedfishLocation Redfish location. > > + @param[in] Uuid Service UUID string. > > + @param[in] Os OS string. > > + @param[in] OsVer OS version string. > > + @param[in] Product Product string. > > + @param[in] ProductVer Product version string. > > + > > +**/ > > +STATIC > > +VOID > > +InitInformationData ( > > + IN EFI_REDFISH_DISCOVERED_INFORMATION *Information, > > + IN UINTN *RedfishVersion OPTIONAL, > > + IN CHAR8 *RedfishLocation OPTIONAL, > > + IN CHAR8 *Uuid OPTIONAL, > > + IN CHAR8 *Os OPTIONAL, > > + IN CHAR8 *OsVer OPTIONAL, > > + IN CHAR8 *Product OPTIONAL, > > + IN CHAR8 *ProductVer OPTIONAL > > + ) > > +{ > > + if (RedfishVersion !=3D NULL) { > > + Information->RedfishVersion =3D *RedfishVersion; > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service version: %d.\n", > Information->RedfishVersion)); > > + } > > + > > + if (RedfishLocation !=3D NULL) { > > + Information->Location =3D (CHAR16 *)AllocatePool (AsciiStrSize ((con= st > CHAR8 *)RedfishLocation) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((const CHAR8 *)RedfishLocation, Information- > >Location, AsciiStrSize ((const CHAR8 *)RedfishLocation) * sizeof (CHAR16= )); Please use CONST instead of using const in this files as CONST is defined i= n Base.h. Thanks Abner > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > Information->Location)); > > + } > > + > > + if (Uuid !=3D NULL) { > > + Information->Uuid =3D (CHAR16 *)AllocatePool (AsciiStrSize ((const C= HAR8 > *)Uuid) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((const CHAR8 *)Uuid, Information->Uuid, > AsciiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); > > + DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information- > >Uuid)); > > + } > > + > > + if (Os !=3D NULL) { > > + Information->Os =3D (CHAR16 *)AllocatePool (AsciiStrSize ((const CHA= R8 > *)Os) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((const CHAR8 *)Os, Information->Os, AsciiStrS= ize > ((const CHAR8 *)Os) * sizeof (CHAR16)); > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, > Version:%s.\n", Information->Os, Information->OsVersion)); > > + } > > + > > + if (OsVer !=3D NULL) { > > + Information->OsVersion =3D (CHAR16 *)AllocatePool (AsciiStrSize ((co= nst > CHAR8 *)OsVer) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((const CHAR8 *)OsVer, Information->OsVersion, > AsciiStrSize ((const CHAR8 *)OsVer) * sizeof (CHAR16)); > > + } > > + > > + if ((Product !=3D NULL) && (ProductVer !=3D NULL)) { > > + Information->Product =3D (CHAR16 *)AllocatePool (AsciiStrSize ((cons= t > CHAR8 *)Product) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((const CHAR8 *)Product, Information->Product, > AsciiStrSize ((const CHAR8 *)Product) * sizeof (CHAR16)); > > + Information->ProductVer =3D (CHAR16 *)AllocatePool (AsciiStrSize ((c= onst > CHAR8 *)ProductVer) * sizeof (CHAR16)); > > + AsciiStrToUnicodeStrS ((const CHAR8 *)ProductVer, Information- > >ProductVer, AsciiStrSize ((const CHAR8 *)ProductVer) * sizeof (CHAR16)); > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, > Version:%s.\n", Information->Product, Information->ProductVer)); > > + } > > +} > > + > > /** > > The function adds a new found Redfish service to internal list and > > notify client. > > @@ -851,41 +915,17 @@ AddAndSignalNewRedfishService ( > DEBUG ((DEBUG_MANAGEABILITY, "*** Redfish Service Information > ***\n")); > > > > DiscoveredInstance->Information.UseHttps =3D UseHttps; > > - if (RedfishVersion !=3D NULL) { > > - DiscoveredInstance->Information.RedfishVersion =3D *RedfishVersion= ; > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service version: %d.\n", > DiscoveredInstance->Information.RedfishVersion)); > > - } > > > > - if (RedfishLocation !=3D NULL) { > > - DiscoveredInstance->Information.Location =3D (CHAR16 *)AllocatePoo= l > (AsciiStrSize ((const CHAR8 *)RedfishLocation) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)RedfishLocation, > DiscoveredInstance->Information.Location, AsciiStrSize ((const CHAR8 > *)RedfishLocation) * sizeof (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > DiscoveredInstance->Information.Location)); > > - } > > - > > - if (Uuid !=3D NULL) { > > - DiscoveredInstance->Information.Uuid =3D (CHAR16 *)AllocatePool > (AsciiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)Uuid, DiscoveredInstance- > >Information.Uuid, AsciiStrSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", > DiscoveredInstance->Information.Uuid)); > > - } > > - > > - if (Os !=3D NULL) { > > - DiscoveredInstance->Information.Os =3D (CHAR16 *)AllocatePool > (AsciiStrSize ((const CHAR8 *)Os) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)Os, DiscoveredInstance- > >Information.Os, AsciiStrSize ((const CHAR8 *)Os) * sizeof (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, > Version:%s.\n", DiscoveredInstance->Information.Os, DiscoveredInstance- > >Information.OsVersion)); > > - } > > - > > - if (OsVer !=3D NULL) { > > - DiscoveredInstance->Information.OsVersion =3D (CHAR16 *)AllocatePo= ol > (AsciiStrSize ((const CHAR8 *)OsVer) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)OsVer, DiscoveredInstance- > >Information.OsVersion, AsciiStrSize ((const CHAR8 *)OsVer) * sizeof > (CHAR16)); > > - } > > - > > - if ((Product !=3D NULL) && (ProductVer !=3D NULL)) { > > - DiscoveredInstance->Information.Product =3D (CHAR16 *)AllocatePool > (AsciiStrSize ((const CHAR8 *)Product) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)Product, DiscoveredInstance- > >Information.Product, AsciiStrSize ((const CHAR8 *)Product) * sizeof > (CHAR16)); > > - DiscoveredInstance->Information.ProductVer =3D (CHAR16 *)AllocateP= ool > (AsciiStrSize ((const CHAR8 *)ProductVer) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)ProductVer, DiscoveredInstan= ce- > >Information.ProductVer, AsciiStrSize ((const CHAR8 *)ProductVer) * sizeo= f > (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, > Version:%s.\n", DiscoveredInstance->Information.Product, > DiscoveredInstance->Information.ProductVer)); > > - } > > + InitInformationData ( > > + &DiscoveredInstance->Information, > > + RedfishVersion, > > + RedfishLocation, > > + Uuid, > > + Os, > > + OsVer, > > + Product, > > + ProductVer > > + ); > > > > if (RedfishLocation =3D=3D NULL) { > > // This is the Redfish reported from SMBIOS 42h > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112628): https://edk2.groups.io/g/devel/message/112628 Mute This Topic: https://groups.io/mt/103181045/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-