public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jake Garver" <jake@nvidia.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Jeff Brasen <jbrasen@nvidia.com>,
	Ashish Singhal <ashishsingha@nvidia.com>
Subject: Re: [PATCH] BaseTools: Generate deps for Arm targets
Date: Mon, 19 Dec 2022 16:36:23 +0000	[thread overview]
Message-ID: <MN2PR12MB448813752604174F9F066C22ADE59@MN2PR12MB4488.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2afe0ee929bbe7983216912b20a933405c67e1f8.1670516469.git.jake@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Hi, folks.  Is there interest in accepting this change?  Any comments?

Thanks,
Jake
________________________________
From: Jake Garver <jake@nvidia.com>
Sent: Thursday, December 8, 2022 11:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen <jbrasen@nvidia.com>; Ashish Singhal <ashishsingha@nvidia.com>
Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] BaseTools: Generate deps for Arm targets

Prior to this change, deps were not generated for Arm and AARCH64
libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That
resulted in bad incremental builds.

Signed-off-by: Jake Garver <jake@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
---
 BaseTools/Conf/build_rule.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index af4819de92..ec83638144 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -145,7 +145,7 @@
         $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj

     <Command.GCC>
-        "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
+        "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}

 [C-Header-File]
     <InputFile>
--
2.17.1


[-- Attachment #2: Type: text/html, Size: 3090 bytes --]

  reply	other threads:[~2022-12-19 16:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 16:22 [PATCH] BaseTools: Generate deps for Arm targets Jake Garver
2022-12-19 16:36 ` Jake Garver [this message]
2022-12-19 16:42   ` Jake Garver
2022-12-29 10:40 ` [edk2-devel] " Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB448813752604174F9F066C22ADE59@MN2PR12MB4488.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox