From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.61]) by mx.groups.io with SMTP id smtpd.web11.26793.1671467786193873104 for ; Mon, 19 Dec 2022 08:36:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=imGzhYUN; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.93.61, mailfrom: jake@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ESgPudtvVHIQ93oLPH9ry6fZXLOqWm7yt+dNsdyVB2etsn6msEsCnfMiQuHxl/W5RMS7UIZDFgB8/crw7FH+VJMqPL82HS+A7ZTEku6BEK2pIn7cei2HDRrXlkXiWcN+YcayM0lTuL2jPslm2VYr0Ai4/W4u1d8Ge9ZzPh3woTUNbt6lCFTcQeRCu3InTI5dMvfksapukuDQ/WFcYyzjsUJlggTDY3NsRbOVVmYiHheOoTIq6jRwoQacmAVw9g7+wgqm3U1Fznvh0p77hp2cP4gJunVDIlTmD49r/zijWd5Ufb2Z6816HBVMLKTs23BCSan3kJ6gBLpFU91dHmL6Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GRB4/zKLbByLNDG5gCasyW7Iv5HwBg0w2z+lNE0jPHo=; b=WZ8cEGtDJeTxAoSPfjLy0pUWcGQBBAZfbrajtqXLVT8z3xW6uZYowkyyaoosCgeYqP3cxFzvXayGIZbBLwwvGXIj84WG//5MzR2+b8CuNgi5/IbnCxYTM9ckfMqDsCyGyVIIo3GRxiXLvzGtZc1KB/kA5rBh/duTyZIWKaVdrDT2QxUMFLPD/95gFjZzey29bjOTZHGYYX7VgN5NYT14/EuPk3mwssM9I7TWZinT5iBAs1GSGIZzqQxatszBn3oxW0SiPwvo+OYJ8HL/jkpASt0DiiCc3GV2nZQOnN68WB9rhoYyQf61S6FlC3PV02Hdes5q3XtjmhhnwqABXiJ5rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRB4/zKLbByLNDG5gCasyW7Iv5HwBg0w2z+lNE0jPHo=; b=imGzhYUN052vQl0k/Js6/M3RUaJfX9IceeRU4mNdzyibOqs7V/NCrZyRtftWD0+5oPJnYnn99M3sbENmgw8JT/gIUXpOr42LnD/uZmO7KgBXzHpJnLDVV9voE6adqvvXYBc6ZaX/NxbUkCY7YF4o5xdMPhQgngUWVPlX3B+MIecigwvk8k7AUSqkacK/afFVJ2jzXfL3ZoVQE8/M5pOwZosrMYqaSSfbfxtItmj/dvhLeVi3Kodz+IMc0NaSnVk8lcztfxnNEkmGbjnLMFp4kXd7gujBmvoILzt+IIaq4W6Edx3CqSgSL5YbyEdcbJyUrlkB+tTu5clueeDjBxYxzw== Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by SA3PR12MB7859.namprd12.prod.outlook.com (2603:10b6:806:305::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 16:36:24 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06%4]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 16:36:24 +0000 From: "Jake Garver" To: "devel@edk2.groups.io" , Jeff Brasen , Ashish Singhal Subject: Re: [PATCH] BaseTools: Generate deps for Arm targets Thread-Topic: [PATCH] BaseTools: Generate deps for Arm targets Thread-Index: AQHZCyFYk6R6NJFp7kWtP9V3yDE6B651easz Date: Mon, 19 Dec 2022 16:36:23 +0000 Message-ID: References: <2afe0ee929bbe7983216912b20a933405c67e1f8.1670516469.git.jake@nvidia.com> In-Reply-To: <2afe0ee929bbe7983216912b20a933405c67e1f8.1670516469.git.jake@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB4488:EE_|SA3PR12MB7859:EE_ x-ms-office365-filtering-correlation-id: 5b9107c2-eb65-4233-9811-08dae1df2aca x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Gy3na6J6bVwnJMg5kE7269J0KpElCrANiHBpg9yMUh7KL+TtdrHwJRUO4Ec1uvYfr9Kx+gVRpwcjwuPBVGAIacvCsKRRM47G2JIDsU4TYAr36P8ZUIm87207GULgMQ40skN8vnsBx9E2a5bZnkFMGWjgVBMH+pLOEB5r1KpZ4cwV8bEwiNFUwG9/QR1YwXtGg2AVqMBgDABTgepmXwFCK6EA9yKvwIIZyuO9U98MpgM48MR8mXvxtC0J78Reu0K+Crv7RWxJLKICAcrJ4nlWmt/ipg9H+PByms2mNTGsljTSNyQbynwfOVZXyI4QkHnnErYui/d4fgQd7s9c2MOZxaC0tvKkjVMdHnYZE9sVUyZ8mqjc5+LhMibJ9wrqbtX9ufLQ2uQnZUmGG1QSR2LEsCkf13ReVTTdDymYD/ruH4on0wYmS5J84vTCwMSCX3W8KRZENV89mesGfytgs1P6FGjMj1qFeEmIjuh/f7MA0LOdk98HRANnPSJQeTg9093y/ZevkhG81IJUJy7wOzRCLC3tsAoowDN4SNaVYNWW6X1Lo8nwK4PoaOS87NPrnUJg8u7YVu4ktWd/0VvWc9XcekWnXEaVXdL93urdf/jUlZBdjZbLIrYamik/T8SCVnbzVnbBbolpHURVcbmhZ4k+TtvlV+H2oUqOuEBfqv7dUsNaOSZm61sg0qAPLjedhTqSO0mRkRLojjZw4oEXhjsOMg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4488.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(136003)(366004)(39860400002)(451199015)(83380400001)(55016003)(86362001)(33656002)(122000001)(38100700002)(316002)(38070700005)(8936002)(52536014)(66446008)(2906002)(64756008)(66476007)(66556008)(76116006)(66946007)(110136005)(8676002)(5660300002)(19627405001)(9686003)(7696005)(53546011)(41300700001)(6506007)(186003)(26005)(6636002)(71200400001)(478600001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?42V4IrbuI4zGom8Mq82p6N1kLvHG5Cz9pkf/s+YJdXELLEoT7+SaNqL40UuK?= =?us-ascii?Q?t7MWV/Syt8VJ3b1rtF0ESeo8g1YQ1D739JS8Dof2bUundZncXTAp8nuQiaC/?= =?us-ascii?Q?pF3N4z9NRsfypoTUJGEKkCV+a591oVCc4FBuudG561cm8FtLH6FAsz9wMiGC?= =?us-ascii?Q?EwE4OuL2L826k215R5LiQ8oGECanycQ5tJxIAoZ/NeEkpJ34qaLZs5q0z/9s?= =?us-ascii?Q?zjdY31Nom2L3uv3HYIVt6A6S2WJmgqMCJRXh43m++WQgQv1fpI8FinSow/qU?= =?us-ascii?Q?MiE08pLl6fNqyxmEexDKIx7IbPF3X2xoYiv/w/GyJL0OSWVAoeK3gnoxNlj8?= =?us-ascii?Q?7oEfn8dQfL2k1jxUFAOG2AEF/9x6tVokJUa0jaKGoeGVX8sAgCsXchKeVmH0?= =?us-ascii?Q?OqH9dpkrbaWnoHWWjDJ947Wd/cPTbsTB/ChBN+sPUtH01PFiuphPtPnDBXZ9?= =?us-ascii?Q?HFbFDIOCQzyIyypo/FcxhhR6174WXq4d5Hy6KlrP2tyaphXfnwN3b0UPcpPb?= =?us-ascii?Q?rWGEZ80ezH3fra5kWkAbM7CgiD8mjX/wk4XCB2I/8VcMEUXVcoWhcHuhmWqM?= =?us-ascii?Q?/LgSOtgpQ2ZpL9efsN6gIXn712akdbTpAdi+D1JlgdKslV/durE8LNWdF1tY?= =?us-ascii?Q?cb/9FQ5Avaww2wHtL93ASshwwTMGzszh6tuSyP6fLL4m0GVibLSbIf++Owdl?= =?us-ascii?Q?b6++hZwGEb39xUHnO3cACRUI6ah5cVKu4DbJHzG2QNvIFxlFw0vPs/xWFqfn?= =?us-ascii?Q?Aiznygb16yiUlRY/m9QW9dPMhO0PoM67B30KJSK0ldN8BDqxBZ829yUAsOYa?= =?us-ascii?Q?t0IUzi3Q16ZQ1xaPDgndEckicazCxfy4qocfPeZpEcymVLc7eKJTMFd6MiKb?= =?us-ascii?Q?ur41TsaoaeN2sX9bt/vDbRvQRHUVLEGqy8c5PInIkGRZ+xdcDxEUM8FishW1?= =?us-ascii?Q?fjdpQbZbXO9CErFzpmETOfomInqsY/1/zD5UzRDh7oopUn+LSTEVTOL/viEq?= =?us-ascii?Q?NJ40E7lJX41Ay18sIWEqPX7cChkqrGEt2pRdppjSWpO/etPpq1/vM5o3kYQJ?= =?us-ascii?Q?x7SOVK80CicyWpcMV++pTJnZYSR4oKetSdu+zp9OWOSvByycoIw2rW1TiJur?= =?us-ascii?Q?JSfX459Gs4rNjc48GMFtfmBmVw04DdtJa+X58plZDJ6UMn2uwe/RTeskS77O?= =?us-ascii?Q?aADzfO+6CVzVXuO6TCOuFDcXtgpQpJ7zhDMLsH1VpzXUTjy+XgzpkKcRGKAc?= =?us-ascii?Q?aeG4Y0Liq9Wadw+0NG8oyBDbikC4MKbjjVgwgB/E+0XNdsoZxTez+6kQvVXO?= =?us-ascii?Q?Al+HXaIfoClzo3BpJuYiD4DPIufPWul5NFDScomEzQVrV3Lu9SOobGcq1YhP?= =?us-ascii?Q?6Ih3fcf4+n2ibiS416mz93hFLQ61FdXXVIELfjhZFLbi+pCgVM2fEBWMukJl?= =?us-ascii?Q?+JoeScinVpcGTFL2fpNrHHxk6tGN4mjma5ECX5dtc7WJCN6+VRviv3VI9ltM?= =?us-ascii?Q?rVh8HeUTzSUpcZsXFPv/c8ipO3SdfBwIOIuY3I/eiXpemHyGvHi/uifaJ99g?= =?us-ascii?Q?ijrbNud+AL3RxZtF6nI=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b9107c2-eb65-4233-9811-08dae1df2aca X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 16:36:23.8067 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jy5WQPVRN36KCCDtxy1K+jS4DUjZtUtK5rZ+bbrIWO49jiRkQOSG8i2F1kTjxTxQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7859 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB448813752604174F9F066C22ADE59MN2PR12MB4488namp_" --_000_MN2PR12MB448813752604174F9F066C22ADE59MN2PR12MB4488namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, folks. Is there interest in accepting this change? Any comments? Thanks, Jake ________________________________ From: Jake Garver Sent: Thursday, December 8, 2022 11:22 AM To: devel@edk2.groups.io ; Jeff Brasen ; Ashish Singhal Cc: Jake Garver Subject: [PATCH] BaseTools: Generate deps for Arm targets Prior to this change, deps were not generated for Arm and AARCH64 libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That resulted in bad incremental builds. Signed-off-by: Jake Garver Reviewed-by: Jeff Brasen --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..ec83638144 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -145,7 +145,7 @@ $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj - "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src} + "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(IN= C) ${src} [C-Header-File] -- 2.17.1 --_000_MN2PR12MB448813752604174F9F066C22ADE59MN2PR12MB4488namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi, folks.  Is there = interest in accepting this change?  Any comments?

Thanks,
Jake
From: Jake Garver <jake@= nvidia.com>
Sent: Thursday, December 8, 2022 11:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen &= lt;jbrasen@nvidia.com>; Ashish Singhal <ashishsingha@nvidia.com> Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] BaseTools: Generate deps for Arm targets
 
Prior to this change, deps were not generated for = Arm and AARCH64
libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That
resulted in bad incremental builds.

Signed-off-by: Jake Garver <jake@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
---
 BaseTools/Conf/build_rule.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template
index af4819de92..ec83638144 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -145,7 +145,7 @@
         $(OUTPUT_DIR)(+)${s_dir}(+= )${s_base}.obj
 
     <Command.GCC>
-        "$(CC)" $(CC_FLAGS) $= (CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
+        "$(CC)" $(DEPS_FLAGS)= $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
 
 [C-Header-File]
     <InputFile>
--
2.17.1

--_000_MN2PR12MB448813752604174F9F066C22ADE59MN2PR12MB4488namp_--