From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.53]) by mx.groups.io with SMTP id smtpd.web11.26955.1671468128793344233 for ; Mon, 19 Dec 2022 08:42:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=KpzEeSb2; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.223.53, mailfrom: jake@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqhOGsiLHoouREGVfMWndSuGwYyf/ECwk0P4qQ4Zfh+Sx2rZT5ZfJRoUGDeAgW30eaVUIaGcVuwNI0Hu7qqZtm725xns0h0kg53dWuvkFloEIse58XuYulYl6Vqv4cmf5Hwmfr7TxDBzMD38QytczrltorMAypcan5r599NBXqdltiuz9UCLVWzVT3atFHL0v1NnHxXiYR93om1F5XFHADBjPr5sr1WyEa24BwwqjDRXcxIdrNBYBCRrghT9pxEyZzPzutQjdtII3QFSMtz8jDM11z35Jo4EnOSG4VfwvffcWuRylEF63Ga9gcphdpz4t3PFArSqdp4pS7jWweGu8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CeLXfiWSdDxV/f5lT4FzRidcV2B3L5pKVSXgoDbrl70=; b=nryg8B5qKCIAClPX04E4MqaUTRh9IPOm3sHk3HjACzBgEQoEnE3tx6B2wcOvob4tbCcWlo3EBIJ665JSMKHgMq8fDdPky9QmfRiJEuWogPkP7FZIQNywySN6Eg/8w+8r8XE4kVpeCzU4UKTzYDHM1FZcdrDaHC5d7jAl9qvZK4xJoEcxSWslmRcwAsw1jbO09x9LatLR3Kquq3vMxf2OjIjiKZ2EC7/PRx2ppS5eot58DZmMwugw0+CAi24jhVKNck0n7dMAGXVjv6e/+9xuqnakbpoz7iJjW4VkVKxWAApduIrHHhcddD2HrCEVc4/Hg6kMdChGekigLmAtThbN8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CeLXfiWSdDxV/f5lT4FzRidcV2B3L5pKVSXgoDbrl70=; b=KpzEeSb2o0t+62WUhctWUKJAHg2/xVfDr65yZkNYniIv7FxKrjU0wNxNSdwXXnsU6/hCoJ2XPJpUph9msLMVdB9wYVdxw127ijr2ccw/8ray8AtqwFKOiwsNcdNllXrHY3t+iGZf11aDv2ZSw+SJqcNMtqZGiwaaGCBV1vpQFipcVvmN0GRWeqe2dgfO+BgyQAxg7/SJKKPwZV63fMX3fnHVjGynM64mBpjRnLfPq9ZmDuvZ6hb9Nif40yFi3gT3m4y+JvrR3TkPTymHgQ4Xh59/aeFu2YwLB7A3PHKW2YknBAuburT059lsnHy4COTippa+UOcDlBcNovomwdR1GA== Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by DM6PR12MB4862.namprd12.prod.outlook.com (2603:10b6:5:1b7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 16:42:06 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06%4]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 16:42:06 +0000 From: "Jake Garver" To: "devel@edk2.groups.io" , Jeff Brasen , Ashish Singhal CC: "Feng, Bob C" , "gaoliming@byosoft.com.cn" , "yuwei.chen@intel.com" Subject: Re: [PATCH] BaseTools: Generate deps for Arm targets Thread-Topic: [PATCH] BaseTools: Generate deps for Arm targets Thread-Index: AQHZCyFYk6R6NJFp7kWtP9V3yDE6B651easzgAABV6U= Date: Mon, 19 Dec 2022 16:42:06 +0000 Message-ID: References: <2afe0ee929bbe7983216912b20a933405c67e1f8.1670516469.git.jake@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB4488:EE_|DM6PR12MB4862:EE_ x-ms-office365-filtering-correlation-id: 236e0cf4-a84b-4e40-0e47-08dae1dff6de x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6dek+1Q7fr6X2r0sqhkj5Sn4CtfciP2F0rxIFxpjvG0MCtvzsT7Khb67dpKMaz+1Odqi4T3c7vy9/UnmK4EP1050WezTHhGrvoXvVO5vYwC47FdwtTXTIxvfPtyjAjpIkOpYmUDNkLqd4uu59Ppkhss50d8fNz0p4QlaI+omoGxxBEPxZECox0kyJ7mFxu6JSiny9dKExJeA4EO9NJDeg6RbVPBYY47FftZNPXvnzucf1ufpYGUVCr8LClR0tU93JbcA3dbzjJeUVVdZc82/k10fysJBNT4bAwG/WI2HPoqV6UefKI+plrj6f7l6MWhmQoPpuHjtz6koEPSx6nz8h0fH4icvoFdyc0TLALb72KdcTKUe7P5+qvpPQR+d1edX7f3dFxNGAtbKrHznOXHc8quP4JBGMQi/9ITOFR347znlyJCvHOUy9P9jnds8WSRXBXIym5mKVJjQrzR9dM4eHI/Z7zjSvxRuvPkG8KriJGwVM9mE0t/IYq5W9OuXCYkA/2vMdLW4p9npa081JN6PpItKexsOVrJqazRb3JimV6ki7DNK6RpP6B01MzlX3sVQlC5ZtGtm2VdnlLYzk+54KJZqtleiDUT6nOyIGGT4qaSq4T5z0B3iN2MDiXT5rQ30jjIauNv3PNj9D2bPR4g3HP/Qk+knBAMxhglRI/ELYQdZ5XthcBWGcdtBa8Kbe5FcxMGBS4Ixk1PTL91pgVFnPQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4488.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(366004)(39860400002)(396003)(346002)(376002)(451199015)(55016003)(38100700002)(110136005)(122000001)(54906003)(478600001)(2906002)(6636002)(52536014)(316002)(8936002)(5660300002)(86362001)(66946007)(19627405001)(64756008)(4326008)(66556008)(76116006)(66476007)(66446008)(8676002)(83380400001)(38070700005)(26005)(71200400001)(33656002)(41300700001)(53546011)(6506007)(2940100002)(9686003)(186003)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bDXV3LM+IbWtxdXgU4WzL4ivDgpNhNioz1bRmcM4xziOANG/W+U5RzoaqZpi?= =?us-ascii?Q?ysLY+n9ZovQHv4wY6RDR+BUFTr8HH56J7QpS0tdPQCZ+jNNRypgqGc8GI1Bp?= =?us-ascii?Q?Zs0Kf7ThesWrb8GqngLLVyAPZCGrShOMm3WIcqbH3UjFz+B/yH6WiX6nNY2w?= =?us-ascii?Q?YpeeuvCqPvogdcVHAc8l4KYI/64nUU1etr14CnWyxY8LzQgitg1QBsTc1eWk?= =?us-ascii?Q?Wg3pu2tj9ZO6/6/lh7pcyGLSTI/TJnmMi85FNCmhnb9LjcbGHAhV+n8FGDus?= =?us-ascii?Q?Sdd/q1X4skBtyUQLCIJHur9OahUkb1HctTREBjBSfHiUCWgBtka+t5uvnlnz?= =?us-ascii?Q?wi1lxoDN7smGxuQbhFRkGlxIgOVQEYq0L+LPQVecet6NXwdNxvjniFb9smHV?= =?us-ascii?Q?JrxII8qVrnRyunyayEaVJdc2FeKboXlkdCWtMkCoqXLRs8BW0X9U5mlkPtYa?= =?us-ascii?Q?Nm17j061C0S9beRrQmwQIxiSn725/p287//Z4vVHaFNsQRJv3jqQnZwhOEDC?= =?us-ascii?Q?60ypiYt9BaF3fDdGhKi3tUmftGW5Y6Al5c9au7/AhEDCNE5dEfSZM9r99kNZ?= =?us-ascii?Q?STBezCbqyHJet9k8KAQVnNc/0GrLqs/uwk++L+P6r3GHyQa++RUGZs2VaCwC?= =?us-ascii?Q?a7XC2XI2AshP7+gKcHnYGaKWnZOe67SMNcB04pZTWpj6V+4OQM0SPios/Cjx?= =?us-ascii?Q?iRqHurZZDdCQW8OjdeqbMChJt5CNzBj9t9+P77Xoq0nzsrR/hOOsx9AfJlNS?= =?us-ascii?Q?3SdatvsWy4P8RQljTvTnqzzDNa/LPE72vYQAKDqJxbehvRdWPxYfdwtliJvc?= =?us-ascii?Q?GwhwfyyK99FkUE3J0g9Kiq5pHhyUIy2jZXIqvf9Tyn2ObZdqpfpzPowa2WZk?= =?us-ascii?Q?+ZqyhSkpQJOrMCvhXlhb1b2I26Bd6aNjQLRx859dpFAqblr4SpwDhuBjqGfC?= =?us-ascii?Q?kkSb2RFAsXEfxNxVauJG6SFTOzdy0wXSfWdz85nCF5vAgGtoT3Ag5FkD6EK+?= =?us-ascii?Q?YsCQqDerHC0ho4N8OpM+UvgZylYtDAdRqbmKzdN0T3rKeR8mBzdgcbVKLkuA?= =?us-ascii?Q?BrhHJg7i+E/Bo1EmbegFJREjlntzktGztkePKTYC/kCmGyRR4S9C9v9uYzLt?= =?us-ascii?Q?Si+FJyk0GoTWM0Aq9zyrVIyYiS2TRTnHwp/ChG18+mhYh/qCTUY/BPPVylQJ?= =?us-ascii?Q?rXJ5GsOC5bo196XfkWAlto4YMaIJ/jOxacsJWDyelU6Fh0zPHpaKKBcO74YK?= =?us-ascii?Q?0wOIGHrms6VLM+yiDyU8x0ANKtGiLG5aTnZ35ksGnfIViz7FJ9PpcDkd3Xg0?= =?us-ascii?Q?FsmqLbRO8Wc0bM5XYhU6+qdrj7yIfRzoH5QcYgcCVxat4JuwvKjjh/YqE2b9?= =?us-ascii?Q?gHm5wO1EGIXZXwjLliIOdgjSV8xl34gDnKomIonFoKKvc43Ot0cXBCyBnRi5?= =?us-ascii?Q?CYdichwyXWYmi5BUfcVdoLO8mpD4SS/J5fVjaIsUALlXCtVABhZNWneKpoa4?= =?us-ascii?Q?KFPbNhBx6zqXytZFk6LcZZ9ihEpYG88TWXUViWLo/BvXfm07UEZYYzrQFz9S?= =?us-ascii?Q?r40g6RnXSZNV5jmZafU=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 236e0cf4-a84b-4e40-0e47-08dae1dff6de X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 16:42:06.1426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U3LXFMQxPKZ/tqhbwh+sgu5xtf27G/nERy9lM3e9iyqazAkcL8zEvQdRP28jQ2zp X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4862 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB44887C417FFC7A4CA11EF90BADE59MN2PR12MB4488namp_" --_000_MN2PR12MB44887C417FFC7A4CA11EF90BADE59MN2PR12MB4488namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Resend with BaseTools maintainers CC'd. Hi, folks. Is there interest in accepting this change? Any comments? Thanks, Jake ________________________________ From: Jake Garver Sent: Monday, December 19, 2022 11:36 AM To: devel@edk2.groups.io ; Jeff Brasen ; Ashish Singhal Subject: Re: [PATCH] BaseTools: Generate deps for Arm targets Hi, folks. Is there interest in accepting this change? Any comments? Thanks, Jake ________________________________ From: Jake Garver Sent: Thursday, December 8, 2022 11:22 AM To: devel@edk2.groups.io ; Jeff Brasen ; Ashish Singhal Cc: Jake Garver Subject: [PATCH] BaseTools: Generate deps for Arm targets Prior to this change, deps were not generated for Arm and AARCH64 libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That resulted in bad incremental builds. Signed-off-by: Jake Garver Reviewed-by: Jeff Brasen --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..ec83638144 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -145,7 +145,7 @@ $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj - "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src} + "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(IN= C) ${src} [C-Header-File] -- 2.17.1 --_000_MN2PR12MB44887C417FFC7A4CA11EF90BADE59MN2PR12MB4488namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Resend with BaseTools maintainers CC'd.

Hi, folks.  Is there interest in accepting this change?  Any comment= s?

Thanks,
Jake

From: Jake Garver <jake@= nvidia.com>
Sent: Monday, December 19, 2022 11:36 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen &= lt;jbrasen@nvidia.com>; Ashish Singhal <ashishsingha@nvidia.com> Subject: Re: [PATCH] BaseTools: Generate deps for Arm targets
 
Hi, folks.  Is there interest= in accepting this change?  Any comments?

Thanks,
Jake

From: Jake Garver <jak= e@nvidia.com>
Sent: Thursday, December 8, 2022 11:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen &= lt;jbrasen@nvidia.com>; Ashish Singhal <ashishsingha@nvidia.com> Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] BaseTools: Generate deps for Arm targets
 
Prior to this change, deps were not generated fo= r Arm and AARCH64
libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That
resulted in bad incremental builds.

Signed-off-by: Jake Garver <jake@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
---
 BaseTools/Conf/build_rule.template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template
index af4819de92..ec83638144 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -145,7 +145,7 @@
         $(OUTPUT_DIR)(+)${s_dir}(+= )${s_base}.obj
 
     <Command.GCC>
-        "$(CC)" $(CC_FLAGS) $= (CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
+        "$(CC)" $(DEPS_FLAGS)= $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
 
 [C-Header-File]
     <InputFile>
--
2.17.1

--_000_MN2PR12MB44887C417FFC7A4CA11EF90BADE59MN2PR12MB4488namp_--