* [PATCH] BaseTools: Generate deps for Arm targets
@ 2022-12-08 16:22 Jake Garver
2022-12-19 16:36 ` Jake Garver
2022-12-29 10:40 ` [edk2-devel] " Bob Feng
0 siblings, 2 replies; 4+ messages in thread
From: Jake Garver @ 2022-12-08 16:22 UTC (permalink / raw)
To: devel, jbrasen, ashishsingha; +Cc: Jake Garver
Prior to this change, deps were not generated for Arm and AARCH64
libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That
resulted in bad incremental builds.
Signed-off-by: Jake Garver <jake@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
---
BaseTools/Conf/build_rule.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index af4819de92..ec83638144 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -145,7 +145,7 @@
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
<Command.GCC>
- "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
+ "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
[C-Header-File]
<InputFile>
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] BaseTools: Generate deps for Arm targets
2022-12-08 16:22 [PATCH] BaseTools: Generate deps for Arm targets Jake Garver
@ 2022-12-19 16:36 ` Jake Garver
2022-12-19 16:42 ` Jake Garver
2022-12-29 10:40 ` [edk2-devel] " Bob Feng
1 sibling, 1 reply; 4+ messages in thread
From: Jake Garver @ 2022-12-19 16:36 UTC (permalink / raw)
To: devel@edk2.groups.io, Jeff Brasen, Ashish Singhal
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
Hi, folks. Is there interest in accepting this change? Any comments?
Thanks,
Jake
________________________________
From: Jake Garver <jake@nvidia.com>
Sent: Thursday, December 8, 2022 11:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen <jbrasen@nvidia.com>; Ashish Singhal <ashishsingha@nvidia.com>
Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] BaseTools: Generate deps for Arm targets
Prior to this change, deps were not generated for Arm and AARCH64
libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That
resulted in bad incremental builds.
Signed-off-by: Jake Garver <jake@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
---
BaseTools/Conf/build_rule.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index af4819de92..ec83638144 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -145,7 +145,7 @@
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
<Command.GCC>
- "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
+ "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
[C-Header-File]
<InputFile>
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 3090 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] BaseTools: Generate deps for Arm targets
2022-12-19 16:36 ` Jake Garver
@ 2022-12-19 16:42 ` Jake Garver
0 siblings, 0 replies; 4+ messages in thread
From: Jake Garver @ 2022-12-19 16:42 UTC (permalink / raw)
To: devel@edk2.groups.io, Jeff Brasen, Ashish Singhal
Cc: Feng, Bob C, gaoliming@byosoft.com.cn, yuwei.chen@intel.com
[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]
Resend with BaseTools maintainers CC'd.
Hi, folks. Is there interest in accepting this change? Any comments?
Thanks,
Jake
________________________________
From: Jake Garver <jake@nvidia.com>
Sent: Monday, December 19, 2022 11:36 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen <jbrasen@nvidia.com>; Ashish Singhal <ashishsingha@nvidia.com>
Subject: Re: [PATCH] BaseTools: Generate deps for Arm targets
Hi, folks. Is there interest in accepting this change? Any comments?
Thanks,
Jake
________________________________
From: Jake Garver <jake@nvidia.com>
Sent: Thursday, December 8, 2022 11:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Jeff Brasen <jbrasen@nvidia.com>; Ashish Singhal <ashishsingha@nvidia.com>
Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] BaseTools: Generate deps for Arm targets
Prior to this change, deps were not generated for Arm and AARCH64
libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That
resulted in bad incremental builds.
Signed-off-by: Jake Garver <jake@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
---
BaseTools/Conf/build_rule.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index af4819de92..ec83638144 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -145,7 +145,7 @@
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
<Command.GCC>
- "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
+ "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
[C-Header-File]
<InputFile>
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 6337 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets
2022-12-08 16:22 [PATCH] BaseTools: Generate deps for Arm targets Jake Garver
2022-12-19 16:36 ` Jake Garver
@ 2022-12-29 10:40 ` Bob Feng
1 sibling, 0 replies; 4+ messages in thread
From: Bob Feng @ 2022-12-29 10:40 UTC (permalink / raw)
To: devel@edk2.groups.io, jake@nvidia.com, jbrasen@nvidia.com,
ashishsingha@nvidia.com
This patch is good to me.
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jake Garver via groups.io
Sent: Friday, December 9, 2022 12:22 AM
To: devel@edk2.groups.io; jbrasen@nvidia.com; ashishsingha@nvidia.com
Cc: Jake Garver <jake@nvidia.com>
Subject: [edk2-devel] [PATCH] BaseTools: Generate deps for Arm targets
Prior to this change, deps were not generated for Arm and AARCH64 libraries when MODULE_TYPE was BASE, SEC, PEI_CORE, or PIEM. That resulted in bad incremental builds.
Signed-off-by: Jake Garver <jake@nvidia.com>
Reviewed-by: Jeff Brasen <jbrasen@nvidia.com>
---
BaseTools/Conf/build_rule.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index af4819de92..ec83638144 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -145,7 +145,7 @@
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
<Command.GCC>
- "$(CC)" $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst} $(INC) ${src}
+ "$(CC)" $(DEPS_FLAGS) $(CC_FLAGS) $(CC_XIPFLAGS) -c -o ${dst}
+ $(INC) ${src}
[C-Header-File]
<InputFile>
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-29 10:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-08 16:22 [PATCH] BaseTools: Generate deps for Arm targets Jake Garver
2022-12-19 16:36 ` Jake Garver
2022-12-19 16:42 ` Jake Garver
2022-12-29 10:40 ` [edk2-devel] " Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox