From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.43]) by mx.groups.io with SMTP id smtpd.web10.46337.1670859353314056620 for ; Mon, 12 Dec 2022 07:35:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=dlGTA0i9; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.223.43, mailfrom: jake@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=efeztAtCMTfld1zz0uhVd1N4h9q9ARhdoUqxpQpCNnWStKe/xqEz55bo3hikoqUHXvrVVlMNPDqdN6JWK/LCe/UCb927WoHWejo+OMafZscV5k9nimE6EfAPkgU71LAdOgDTFzCZzObnEMvD4/UusGzBMLYV3AKgbBeSgDf5pUzsbf0q/pMS2rfe74YSg23utIwv4vrK1vHAXI7M5+qqlLfVMSFlgaACH7CT0rUAJxkLFJEf4ns/BEwGNorOUcM5crOiEahhQOwthasELTgj+M+2+iCnz3r5UUcIPfgwA7TWJLmabg+8C5gN45HMmCw+zm6TbcV9hdyKkqNYRG8YOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ySD3yQTz68y0i40HoAe7LmBaMy6YuGfTR0c2SJcUnK0=; b=ey7pAOGzka7yab2KVOMMqEdvgAEVClA+f/cHjBid1knPNIoGLG1eWTMEAZyi8aUMeaCimZ0tBRYVucmTDexEaqzBEL807gA5EVMXZ+COZxnE9ijKTextXVqcqB8SQakcIZ+unw/KT818AVN8aGtvRBQqxuoT0oClEET+jkCkUmVyNAEc5i9FaZUeqs92/0oHzoZ570BzZMbP7zusRkiKzbk9AEvz4QPX5W1AA5ZMQW+XdXRuqLWr1HxQypqhTsnPSSqk07ZVyqFx8U4mX0A6Hg8wH9ILKP2mbJ9HP8o63iHVQLbuqKAhlFCtfih5srsACaI37okIQn+5d4D/p4yD/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySD3yQTz68y0i40HoAe7LmBaMy6YuGfTR0c2SJcUnK0=; b=dlGTA0i9s1eN7neX/dl3+5ob2It/ELRqb2R1PicAM8+1KgqGeyO74QOKndFJPZw5blikashJC+NskKRK7LQzCGv5OAz6Vze3OzH2puZ7+RGSX2+0DzVqyKPmL/xyzpVawp6vgiO7+R9zJyxGYK7lwyN2CzULr08s/1m91OscD0CPFVFlBmxQOL+TlcrC3OjhCFhX2mvI7fdnH0xu/766U4IdzQUM0HClrvJWlkCiVO6J3BVnDfo4UZyTpLIHUkKfuT50ulJXigXbFpHB+vRx4jpdyz4x/8zeVM/UUEjyfWzbT868I1daaTnqHnlYxtht56m7KOSmw/zAhgCn+bCgEw== Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by DM4PR12MB7598.namprd12.prod.outlook.com (2603:10b6:8:10a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 15:35:51 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06%5]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 15:35:51 +0000 From: "Jake Garver" To: Konstantin Aladyshev , "devel@edk2.groups.io" CC: "bob.c.feng@intel.com" , "gaoliming@byosoft.com.cn" , "yuwei.chen@intel.com" Subject: Re: [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template" Thread-Topic: [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template" Thread-Index: AQHZDisHhqU6ZQqHH0CoH285ucXVP65qYXfN Date: Mon, 12 Dec 2022 15:35:51 +0000 Message-ID: References: <20221212130924.8156-1-aladyshev22@gmail.com> In-Reply-To: <20221212130924.8156-1-aladyshev22@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB4488:EE_|DM4PR12MB7598:EE_ x-ms-office365-filtering-correlation-id: 2cb8d3ac-92c2-4fb1-7e29-08dadc568cda x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IxMHaJ2stN7DY7vOZJOYjCFuPPT5OUxPNnN/on3+bFQycbJ6GrT0rWGW/O4bNEK8IPzIYRxEN4n7ZoQJlSE1DxZqfK1IJ9isxgo8ZUEJpBrls6Zf8NI4LUPZfKJtPIw/DiHsYcTRqdVAO0rEoAlNMCwY2U2xFN2fafQuEfB9PSbBx4omzpUhBdMzrpYSY8tLc9JvGnl4MYo0TH/hkQbf4xR+PkWRIRqpXbcUv6Ry9FnvQuXxMsRCXw+LZ4OoG0eywyBxDEUI7MzYGFOcFBbdH1Ua/BLArBqJ1EuFN655Ow1CJeVPaZ8gqcLgB/456PSaGoPd8AAPm4rz4ETvckNIufCTH9XiTrQloxGtOeTBPweSOK38+e3ahHFGREc/PkTskiMbOado5DQRmFvBO3V/xHQ/OngG/zcuURIzGyxx5zd6tUvp7/hp51D1XBuyhoyIszwO8xAOVbRZ8N6xW5LfN8WpUxsuzIli8IyJjfvpPcBFnXcOmIrP4MHEPD8AvOzpmXuPU/B7JF0b/TKTbvsoXjvGjSPcP/z96uPivzubI6Smh4Scsa50LXDybvwPcxV2wQ5lk5fZC41SZ8R2NrT0A9KiYPS68PuIMGcRrsMTGbqlep4zN2S0RR0mrqP56oQUS9pKZhRgDiDJDY8nup8STUo9D5V2nX8yXVRIilffgdEyamhNjV62kF0FCQvmRWd2 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4488.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(346002)(136003)(366004)(84040400005)(451199015)(71200400001)(19627405001)(478600001)(53546011)(33656002)(2906002)(6506007)(86362001)(7696005)(8936002)(52536014)(26005)(55016003)(38070700005)(9686003)(186003)(38100700002)(4326008)(66446008)(83380400001)(5660300002)(122000001)(54906003)(41300700001)(110136005)(64756008)(66946007)(66476007)(8676002)(66556008)(76116006)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uFpqEQ5liFCPETRCfBgbGRcgWcdVVMA6nU2UhFftHHQ6DximsmPreRf/aCJG?= =?us-ascii?Q?3oP4I72sju0Dt4svLppzlHUMuQFIQNcSqYDMHq6S3yKq3i+3wrKOJ2oqJqnp?= =?us-ascii?Q?IriCRDWNFcvOPzI44dQVb47zctKAVcKnVBORTQQsBrPyvnc4COR4Yx3PPhpV?= =?us-ascii?Q?J/heCMA8dSBir243pEjWMPs27g/80TtIRfmziv22Usnnth1Sro6Pp7syg86S?= =?us-ascii?Q?nqWhPfvvRXb8BfNuLBHdcki0S/l4C0Wn/57Q4wPpykd4azy7NcjW6LUKZaO8?= =?us-ascii?Q?UnK6BYBguuy8svHtoeb5Z7lMD3uZHp3tn5oAxjGLQkmtZ0zhYF5GDpPlYo/b?= =?us-ascii?Q?iK8UJw0ybVg+nfMLWhIWFV38lbJ6bl99cYoCOPlcgUQlF1OaIiY8MxKTNAJg?= =?us-ascii?Q?TUN67xqa0c0fyczxLFbfSl/bHmN9rZ6CRA6wcOlkNwneVvbgue2nEb1bwv9N?= =?us-ascii?Q?R+zH5J9N/y68w5aaZy9VAd+0JS4spLoB7pmKUldP/XSZPUErZB4ripIlhNvN?= =?us-ascii?Q?oN2Mktg/Pfdm9aaweSxVsh61Bi5nXCBGw8JtvLAAOEbp6OE5eZd1MVcRa18l?= =?us-ascii?Q?QlAXx5Fg7hBrGMCR8x/Gb/sSdPLr4oW/lAf4A27a5NAF0z/eYntskEGuCGWh?= =?us-ascii?Q?BIIpyfJUvVmsPTw2FFGq78pxUHginHa1jNrDdK2Towo/Q9Mk0rKWT32LEzyC?= =?us-ascii?Q?KmVGpmQHqn2XDZKbhX+7p/red5XpONHtsE9CCorsVTPm2gny3fG2ivviIG9F?= =?us-ascii?Q?tKsAqA6BXwfcOrmqQY2/4FAwRVlbPzzRP0DdhrGl3CLfqHIUhWaXWWiLHAYu?= =?us-ascii?Q?pU1xWhTFS8Xmjf2cwKsBY9zIQNLiHtH2BgxEYpQAX3zyUX904I4Mw4PL5ZTD?= =?us-ascii?Q?GhLEASOE8BgA8pg+cmZ9DM7oDCDWYC2digPcQYg5Oq/HHyEKJNlnyTGOTtx/?= =?us-ascii?Q?Gwt8NGZnkx6jxghUoluhaqE7Rn7DnxSAI3gfXjgFhcuY/pijqbxuaKSJ+Mlf?= =?us-ascii?Q?77f97vnGAAaSpHH2gP6TpuCeTf8JCBjFdgi2FYrOhc4ogvdkj1jqq0huOuxl?= =?us-ascii?Q?3tcA1sw4dEMeZneG0h+dEZqY+aXEUeBNlJORtjuWeHyCoKSi8f/NTNpCUt48?= =?us-ascii?Q?G5ty5oBarYl4sV+pgmSNoCQs+Repm4e+6ZajQzqegunZIWB/NVOLfdYZlLRC?= =?us-ascii?Q?jc5SkfvcmuMnQp82bI1NI+dATbsgF3wwjFkPK7HdpolQ/zKyEGZcMbyFLbq8?= =?us-ascii?Q?B57iKiEydc+6U7ccugsVPx8vaQykptPl2GvtytT18DqYr+IfGwnwxfAj3Ytd?= =?us-ascii?Q?FX5g8LHsw0fNY2wBcC0hae4/xPzDldqPtwdWICWsghXB2uZ3KdilzCws4Etl?= =?us-ascii?Q?kn+Y9XvhTBfs8LgakPI0LiAEN9YddobmiGcooau8I/siBIEuRVso4PEYGJ6+?= =?us-ascii?Q?s+NuGRkPsnfhdd3FYM5KBVlru+fsn0c2jGWEaVxczW2Smsp6k0mcv/kYLW9L?= =?us-ascii?Q?abto3O0BF/UuPaJ+aVKyJfn1On++3HZmOx4kh+i3sp2YTncD2ahLoixsfj8i?= =?us-ascii?Q?HL+/dNr/Zxgif6wYww8=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cb8d3ac-92c2-4fb1-7e29-08dadc568cda X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2022 15:35:51.4305 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sLGnjICtISZUsgwj1I/uW1cG+4XyAyV6xJOwI6vdMWDPY9sC7VuLqIV6llBzxT1K X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7598 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB4488D41CE4CA64C212A51700ADE29MN2PR12MB4488namp_" --_000_MN2PR12MB4488D41CE4CA64C212A51700ADE29MN2PR12MB4488namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Konstantin, Do you have a fix for the cyclic redundancy issue when building OptionROMs?= If not, can you help me reproduce it? I'd hate to revert d372ab as it fixed dependency issues we frequently ran i= nto during parallel builds. Thanks, Jake ________________________________ From: Konstantin Aladyshev Sent: Monday, December 12, 2022 8:09 AM To: devel@edk2.groups.io Cc: bob.c.feng@intel.com ; gaoliming@byosoft.com.cn <= gaoliming@byosoft.com.cn>; yuwei.chen@intel.com ; Jak= e Garver ; Konstantin Aladyshev Subject: [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-File template" External email: Use caution opening links or attachments Revert commit d372ab585a2cdc5348af5f701c56c631235fe698. EdkII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID =3D <...> PCI_DEVICE_ID =3D <...> PCI_CLASS_CODE =3D <...> PCI_REVISION =3D <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Revert d372ab585a2cdc5348af5f701c56c631235fe698 until the issue is resolved. --- BaseTools/Conf/build_rule.template | 2 -- 1 file changed, 2 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..32053f6353 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,8 +342,6 @@ $(OUTPUT_DIR)(+)$(MODULE_NAME).efi - $(DEBUG_DIR)(+)$(MODULE_NAME).efi - $(OUTPUT_DIR)(+)$(MODULE_NAME).map "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS) -- 2.34.1 --_000_MN2PR12MB4488D41CE4CA64C212A51700ADE29MN2PR12MB4488namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi, Konstantin,

Do you have a fix for the = cyclic redundancy issue when building OptionROMs?  If not, can you help me reproduce it?

I'd hate to= revert d372ab as it fixed dependency issues we frequently ran into during parallel builds.

Thanks,
Jake
From: Konstantin Aladyshev = <aladyshev22@gmail.com>
Sent: Monday, December 12, 2022 8:09 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: bob.c.feng@intel.com <bob.c.feng@intel.com>; gaoliming@byo= soft.com.cn <gaoliming@byosoft.com.cn>; yuwei.chen@intel.com <yuwe= i.chen@intel.com>; Jake Garver <jake@nvidia.com>; Konstantin Alady= shev <aladyshev22@gmail.com>
Subject: [PATCH] Revert "BaseTools/Conf: Fix Dynamic-Library-Fi= le template"
 
External email: Use caution opening links or attac= hments


Revert commit d372ab585a2cdc5348af5f701c56c631235fe698.

EdkII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
  ...
  PCI_VENDOR_ID         &= nbsp;        =3D <...>
  PCI_DEVICE_ID         &= nbsp;        =3D <...>
  PCI_CLASS_CODE         =         =3D <...>
  PCI_REVISION         &n= bsp;         =3D <...>
```
Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698
it is no longer possible.
The build system fails with the error:
```
Cyclic dependency detected while generating rule for
"<...>/DEBUG/<...>.efi" file
```
Revert d372ab585a2cdc5348af5f701c56c631235fe698 until the issue
is resolved.
---
 BaseTools/Conf/build_rule.template | 2 --
 1 file changed, 2 deletions(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template
index af4819de92..32053f6353 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -342,8 +342,6 @@


     <OutputFile>

         $(OUTPUT_DIR)(+)$(MODULE_N= AME).efi

-        $(DEBUG_DIR)(+)$(MODULE_NAME).e= fi

-        $(OUTPUT_DIR)(+)$(MODULE_NAME).= map



     <Command.MSFT, Command.INTEL, Command.CLANGPDB&= gt;

         "$(GENFW)" -e $(= MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS)

--
2.34.1

--_000_MN2PR12MB4488D41CE4CA64C212A51700ADE29MN2PR12MB4488namp_--