From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.82481.1670957276232826043 for ; Tue, 13 Dec 2022 10:47:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=kX3fFc1O; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.236.41, mailfrom: jake@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/4znCTapsozr19TW8DnmkKtgKSxVsMnIvuNseXyjYCeeu894jN8aBhegSfGGepR4t/HBDfq+m+waa83+8OlUs2yrbho6u6N5+u8XBu2ypQrMhpqewPfM905+njT5sho+GByurPBKPmAVFWBTg/pDajrTvEEPuSumzh2zk6R9cCqrBp9h8z9BgufXBqwe8XcYTm4FrEr0aDAvPNkzOaya2lz9KWZS+3wCMDL08Co5wMm3V3DdJ6olWaeVkPR/6RX315MHGlt1KYE0IE6l+0QU4oI7jOMAPpvi9w479abg7NgjDyseww0+SEDr4RXFLRl0smzxjhyCp1G/AKNVZGbWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=URH2UuKxEJ1eYfF1gDVymNCVcC45PYKuOzgfBfiW07s=; b=JePKx4mimiEG7wvkJYaMHTBLory/Plh8g1A5bLB4qy0YInCpqDu+w9mdNew73NmJS10kiSzon4CH7edJL+yahAUSvoWQ0Jh4gO6st7383nDDFVX9hbuSTKlnUZ26srizDFEQJq5Hh+MYtltnRcQwfjucze+T0TAIDJcNNrgSlUTmEXwG0yx8Yf+NpeXbzA+ynERHobGiRiioUft9kImk0fgyG+pnuz2st3CpmyB3Kc2t8BKmg+V6V//FgM7ioHHIeEQjk63ymfLkYqhNbv8C1QtMJiFxu7iIM2T5hOtPqWwYBlf6rS3ttFYYoWCGm3f8QTJIItsw9jwpy7xdBJvVNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=URH2UuKxEJ1eYfF1gDVymNCVcC45PYKuOzgfBfiW07s=; b=kX3fFc1OjvOH2sBjw2wnaSLCgE/Ht5iF7/fG5dEU4hCWnZygTV452J32QKvP/zJYQlNyDjMMH7yS3wq2FBEZPCV7HwYXST3djCDf7wJMep6y3euKXZvPht1+2GTnQvS24CJxnbuzkvQgTC8k3LMOIWxublUo4egq44ayLb5ZXI5lf8Keu51xWe+ub4atbVv7OXBZy1zN2rFG3HDHJMX/S3vIlykbD8aa1IDqnEnnmfjGimpIs4hcjPeP21rMBP0REi8bmLO8+OHp7Hr6Z+K2tUtkvpU4gNOwMXfqmIJmdwUwvPb5nA3lDg7zDt6Rj9sR9USsGoWwnlxxshNYm6BtxQ== Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by CY8PR12MB8313.namprd12.prod.outlook.com (2603:10b6:930:7d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec 2022 18:47:53 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::38e0:383a:5f56:1f06%5]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 18:47:52 +0000 From: "Jake Garver" To: Konstantin Aladyshev , "devel@edk2.groups.io" CC: "bob.c.feng@intel.com" , "gaoliming@byosoft.com.cn" , "yuwei.chen@intel.com" Subject: Re: [PATCH] Fix cyclic dependency error on OptionROM build Thread-Topic: [PATCH] Fix cyclic dependency error on OptionROM build Thread-Index: AQHZDw8WfdUDkkLLZkiK2Lh2xNi7zK5sKH75 Date: Tue, 13 Dec 2022 18:47:52 +0000 Message-ID: References: <20221212130924.8156-1-aladyshev22@gmail.com> <20221213162222.590-1-aladyshev22@gmail.com> In-Reply-To: <20221213162222.590-1-aladyshev22@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB4488:EE_|CY8PR12MB8313:EE_ x-ms-office365-filtering-correlation-id: 7e99f183-b958-4697-3414-08dadd3a8a8f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mbK/PYc7itliUTHWQnFJVsogaMgM9rK/L4CdtJTb0SHYH/rnVBOazFoTJ1lIHVKaJz09WHVeOCwJgqci+9TTJ3sGMt4yinXCb/KPGIBVdJyPfSljh7hDLpXtUUypGSHBsG97QevTllEge85pFGIVi1rh3D2SQdba4+sI5lkArC+/MkBx2HVFZnjDtGd+e9b25kQ5ruPHLvd7p/R4J2kTCSMnUmOeHWT2Nu17fK0N7YRoz0bnN5jVAmbVlZvRQt8PEwFPmWNh8JBe8NPm3q5+lLP2kt39nr85uhGM5E/Gb+e+gF43Tbcw64yckbdPqZNEizrpXhzmHkJp6v6HFTXqYPwcHPLROrQzNO1oCA0UA2NU4elww83SOYTZQlgAA3Wb9c2ig+DJ2iNFuorOM0I8nRWFz6k4MI8lzsiNeBR0cUG4k9gq7+z7hRPpCBZZuiM3s/85eH7OWwxp634l6cbVJPcFFYl2z8Cr0TEVcR6MOH5li3CAmQAc7ODBCqxE31EBhAxPdppbOdYTqCs9VbUs3StRD+Rh7KUKJVbE64ltBo4PcOGe0xO/7Hc/Wu4xcMoFmhdAUmmHnsWsKdCjW9ZuiUzG6lZvRi4nQkgWywCtIWI/AFVRWoThzDxH540ChLoI8OTl7iT3SGxquAZlv3Mznix+q0Dxe4Vg6pei+JUuyVqyzeoQ14NBQW7n20B0uYShMVd6+8RhCRkLiTIorsmw2Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4488.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199015)(38070700005)(33656002)(478600001)(122000001)(41300700001)(55016003)(66946007)(71200400001)(2906002)(38100700002)(5660300002)(86362001)(53546011)(66476007)(19627405001)(54906003)(110136005)(316002)(8676002)(76116006)(66556008)(64756008)(66446008)(7696005)(4326008)(9686003)(186003)(52536014)(6506007)(8936002)(26005)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c6vJhBfiBlcqx9k0rhcp69qbSXgm4eDuxmzCjiYv3n/bFUMsjU0dqDWt3sn5?= =?us-ascii?Q?j31C//0xITMq01d0yVDtx2ZvEY/pYFLiRwb8GiVvK/BVQxN+bPxLpmtwEVdI?= =?us-ascii?Q?5G8iKvph678qGCpwhzcoIaVwfU/EOgcqAt55YqbFyrTgveoMNkaBa9NTk1C6?= =?us-ascii?Q?YCpA5SgmY8SKrXEoCku5Dkqx7X290fq6EFMaizaYB8dqC4dfqTSq6AopbN42?= =?us-ascii?Q?5sWL5GqPmsN1G3DwixULx3lbSuvROIKv+9m5UTC/KnPN9SZMzf0uViASuD6t?= =?us-ascii?Q?wUOiX4C2aOhpJMl4ELp+GnRZ592WI3rrAUyFj0rABFlw58rSxmaPsfZtiiyF?= =?us-ascii?Q?ZGLdTM/JGQzKZLXYRFs/jWSOFlbTA2j7eY++MfWeDOea1UsXbC04hm0hkSbb?= =?us-ascii?Q?ZAaQxqnhGCMkof1eeQ4viPZfqADof49jbUmLO0LW17kty4Ef4IpgYMgT36x0?= =?us-ascii?Q?5zgxAcB5Xfe6XL7zzUC57AR0yAKV7gT+YlP3Dn5c4ytIDWEjp/cxlQ9NVTXg?= =?us-ascii?Q?TUSjT0+Dk8Ls2U27BOGK43iY7GD8xj/ifKC6kw4B+7xK4H78I9+7BDSybd1L?= =?us-ascii?Q?MCUZRmsDg56uk8+TETQNA285z+M9/2wZMwWJcbdmxwJHbSMelZZFdFqT/YY8?= =?us-ascii?Q?c41asLFZdJzvh2gnLINJekflzoGPW8rta/XeGTmK8wTkoQ32D2zVWpHtZF5z?= =?us-ascii?Q?8bVmGHfFcGuzkpXPA/THGgyVoEj7YK6Mz/S/mzz5l/+14CIxLlq6teOvT4km?= =?us-ascii?Q?ghKaPdaGpInvtmC5KCjEtnSZm2L0fOwWQ7tK+IE1L3tsCb/NV2qibdy9sZna?= =?us-ascii?Q?op6uvMcorw0bkfSo8Fvw4vI8Rt97mBIVKLlmx5yWFEDErN2yP+qEEpVcim73?= =?us-ascii?Q?CmGswjVPzeyV6lRczCsf+Fk3N6uuMR0u52iawT9uxyeFIaH4+xsgMm/Ppj1J?= =?us-ascii?Q?4ChpFJJIX+hojZ800xf4sApTbZ00W8VBMhWUcJrjgwE8UJxn++xX/xvI8JSK?= =?us-ascii?Q?eODriysdJAA9W4Ejwe7AGRHDi5yFtoALjUjm4AJMasXM1QriWTJ8yV/sv6CR?= =?us-ascii?Q?8+8/n+7G2tgpruGo95zrfjhPaDfCcu/EktBaPWFSXlqb8HJi/C+zUBHPEt9Y?= =?us-ascii?Q?DAcaB0AAdZ4AEWe/cfuPC1Vo3QqiJ3JRRVeu3ZH2RMF7jg7ZEjSuUPRq9kvR?= =?us-ascii?Q?Tio35YQZzJYTO2u85mVIlwOAMAhXW1D0PhJHs+JQneutqCuPFq1k78H5el/d?= =?us-ascii?Q?uSc4//WTsYDmCjyZNjE8/nBrPoXxxEhcOCpwEfd/3efa68fu0FE8wc+Xisos?= =?us-ascii?Q?9ZxveKQhQoDzAZ5XJ1K2ByBjcUY0hgE+gfCyg/tlmPTA1XNOGNA+yqpJFxqz?= =?us-ascii?Q?hhe+wLgHZLzWFU9dxLeyBM7rAqriXd/Tz3m30rad3poHCp7wMjkrfLPK5AuH?= =?us-ascii?Q?x3NUVphGHae0FN7DHZYLwWsobZym7RQglxevX/tUuoAQLPdqgTHr9uTyfItz?= =?us-ascii?Q?78T0ogbrmd/2fNKQ8KJxwXiK3pIkIWgqYCCpgeXE1U6S3/m9dAG0ksFGzwPQ?= =?us-ascii?Q?ujmeeu3yBu4ujv47nZ8=3D?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e99f183-b958-4697-3414-08dadd3a8a8f X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2022 18:47:52.8516 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b+MNhCrRhByuKX10h9cBszmPXF+RNW4/xdiAQeIBznTltsCkDrRgZrtGgw0YJqIJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8313 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB4488EDFA866B66468BBAB73AADE39MN2PR12MB4488namp_" --_000_MN2PR12MB4488EDFA866B66468BBAB73AADE39MN2PR12MB4488namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, Konstantin, I approve this version. Thanks, Jake ________________________________ From: Konstantin Aladyshev Sent: Tuesday, December 13, 2022 11:22 AM To: devel@edk2.groups.io Cc: bob.c.feng@intel.com ; gaoliming@byosoft.com.cn <= gaoliming@byosoft.com.cn>; yuwei.chen@intel.com ; Jak= e Garver ; Konstantin Aladyshev Subject: [PATCH] Fix cyclic dependency error on OptionROM build External email: Use caution opening links or attachments EDKII build system supports OptionROM generation if particular PCI_* defines are present in the module INF file: ``` [Defines] ... PCI_VENDOR_ID =3D <...> PCI_DEVICE_ID =3D <...> PCI_CLASS_CODE =3D <...> PCI_REVISION =3D <...> ``` Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698 ("BaseTools/Conf: Fix Dynamic-Library-File template") it is no longer possible. The build system fails with the error: ``` Cyclic dependency detected while generating rule for "<...>/DEBUG/<...>.efi" file ``` Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output files to fix the cyclic dependency. --- BaseTools/Conf/build_rule.template | 1 - 1 file changed, 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template index af4819de92..21ccd864fa 100755 --- a/BaseTools/Conf/build_rule.template +++ b/BaseTools/Conf/build_rule.template @@ -342,7 +342,6 @@ $(OUTPUT_DIR)(+)$(MODULE_NAME).efi - $(DEBUG_DIR)(+)$(MODULE_NAME).efi $(OUTPUT_DIR)(+)$(MODULE_NAME).map -- 2.34.1 --_000_MN2PR12MB4488EDFA866B66468BBAB73AADE39MN2PR12MB4488namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thanks, Konstantin,

I approve this version.

Thanks,
Jake
From: Konstantin Aladyshev = <aladyshev22@gmail.com>
Sent: Tuesday, December 13, 2022 11:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: bob.c.feng@intel.com <bob.c.feng@intel.com>; gaoliming@byo= soft.com.cn <gaoliming@byosoft.com.cn>; yuwei.chen@intel.com <yuwe= i.chen@intel.com>; Jake Garver <jake@nvidia.com>; Konstantin Alady= shev <aladyshev22@gmail.com>
Subject: [PATCH] Fix cyclic dependency error on OptionROM build
 
External email: Use caution opening links or attac= hments


EDKII build system supports OptionROM generation if particular PCI_*
defines are present in the module INF file:
```
[Defines]
  ...
  PCI_VENDOR_ID         &= nbsp;        =3D <...>
  PCI_DEVICE_ID         &= nbsp;        =3D <...>
  PCI_CLASS_CODE         =         =3D <...>
  PCI_REVISION         &n= bsp;         =3D <...>
```
Although after the commit d372ab585a2cdc5348af5f701c56c631235fe698
("BaseTools/Conf: Fix Dynamic-Library-File template") it is no lo= nger
possible.
The build system fails with the error:
```
Cyclic dependency detected while generating rule for
"<...>/DEBUG/<...>.efi" file
```
Remove "$(DEBUG_DIR)(+)$(MODULE_NAME).efi" from the 'dll' output = files
to fix the cyclic dependency.
---
 BaseTools/Conf/build_rule.template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule= .template
index af4819de92..21ccd864fa 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -342,7 +342,6 @@


     <OutputFile>

         $(OUTPUT_DIR)(+)$(MODULE_N= AME).efi

-        $(DEBUG_DIR)(+)$(MODULE_NAME).e= fi

         $(OUTPUT_DIR)(+)$(MODULE_N= AME).map



     <Command.MSFT, Command.INTEL, Command.CLANGPDB&= gt;

--
2.34.1

--_000_MN2PR12MB4488EDFA866B66468BBAB73AADE39MN2PR12MB4488namp_--