From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 893D974003A for ; Wed, 6 Sep 2023 03:03:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GKrd8tAWkOmV+H2y5I+z+HYCyJqsDhOcyZpovtYQyek=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1693969384; v=1; b=e3EvWI8o7RKxwv4FCiqvP/t//KcZWZ/tJsewMsXUDTm0N8ydiJHkzqPn5AjDJJFFLFn12rfF hzN52EYMagyBOVWThWL3U7R7m2e+u1THUHeqlk7xOgKuY6T/UoA9+cVTEfQdQt7EIsmoXjG8k2O ZJRM4aSa9S5ThFij4Dfivj64= X-Received: by 127.0.0.2 with SMTP id SdyqYY7687511xByvxuQUEHI; Tue, 05 Sep 2023 20:03:04 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.559.1693969383537183148 for ; Tue, 05 Sep 2023 20:03:03 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10824"; a="357264932" X-IronPort-AV: E=Sophos;i="6.02,230,1688454000"; d="scan'208";a="357264932" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2023 20:03:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10824"; a="915096494" X-IronPort-AV: E=Sophos;i="6.02,230,1688454000"; d="scan'208";a="915096494" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Sep 2023 20:03:01 -0700 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 5 Sep 2023 20:03:00 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 5 Sep 2023 20:03:00 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 5 Sep 2023 20:02:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTSAML4SPwaGP5vZnyysG3PZQcoYJhPcXmkrDugyZ1EoO7MUQqHokGV2545jZK7LgSUQ+DB+z/4rGxfrkowzfWiFFpUW5sz9hDn2lfgrqzRo9eSDLQhRUhvICr+3ie+kuYi+duJpBa9JXILzR2jDCT3S+Vme0cqJvOzOsHKcHoSVNAiKVcEj1k4jo/PzaeKt7n8n8ccm0b+fI1fI1whEXQcqDUaAtMO0R7RjVTv7LTTojyBV3bvU3vf4CGXh9gRxBTldCrLkOc1uwu1fG/SR1u4kLAMBJU9PuVB8xi2NTjFKwLqj01jZcqI9pKdvc6WofPfKBS0Xd1KCO7BoCFfIeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vd/W6rt7wqJBJFfnlDuIgtADZaUaN7Q9VueE7KO3Abs=; b=OiaR/c2uJMzs/YvVyS6E6bFLy6SOcZEqYttVV/szXOwAoTYSIkY5LoMMXPLrqln2yOW19CcBx8nF9njSzf3woyobu1yYEDxSMnVZssGlKQnhk2JV9VXWYTpRod0om2fi50AdHrv1Yv316m4pProev5lzzPV5oE+Xh+LaMJpYx651Sm0QHsSv4eUmHUkhSq+6qeHB3DPpU7WX2z0XjtiyiL+IWnZNxdcEXxGuxo5W59W0bTD+MGlXCKKShUnCFJkrGeNWIrhBHS5USwq0R74ie0nFmMeYCKOEpTWvIdJhEVxXXHLeMSA5S8vh6kA7hIGzV4qTcbNCTNdJqRyn+3XETw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8242.namprd11.prod.outlook.com (2603:10b6:208:474::11) by CH0PR11MB5315.namprd11.prod.outlook.com (2603:10b6:610:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Wed, 6 Sep 2023 03:02:52 +0000 X-Received: from MN6PR11MB8242.namprd11.prod.outlook.com ([fe80::669d:e74:3693:7622]) by MN6PR11MB8242.namprd11.prod.outlook.com ([fe80::669d:e74:3693:7622%7]) with mapi id 15.20.6745.030; Wed, 6 Sep 2023 03:02:52 +0000 From: "Dandan Bi" To: "Wang, Yin" , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" , "Gerd Hoffmann" , Sunil V L , "Warkentin, Andrei" , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable Thread-Topic: [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable Thread-Index: AQHZ3K1O5AGJx8KKkEi29JCdXfNx6LANI7Hg Date: Wed, 6 Sep 2023 03:02:52 +0000 Message-ID: References: <20230901082117.1618901-1-yin.wang@intel.com> In-Reply-To: <20230901082117.1618901-1-yin.wang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8242:EE_|CH0PR11MB5315:EE_ x-ms-office365-filtering-correlation-id: ffdbc68f-df9b-4dd9-e778-08dbae85c2e9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 4Wo9vqoTnU/YAT6cfnZE7sm6FGaLTXT5QMlxTwmYBvfRCKgX/FEMP4PTWnH/j69uu6GbksA7tdX96JXrH3u5aaeyqU0BV1rF753UbB2KhU8A5//4/BJuf3G4BHRH9QBJBB1skD2r9Vqem3uq89uQwiIVK5RMRb0nB7tKTxIsWD0y/33CoWW2tDdwjo6cdj8IMBsSy+UcVYyVcKFXRyb2mLa+6QntNNk5LwfWrlY7rArnXBiEBW+y6GCLw77Q6bcG6r9Ch9rgS6Yx9CN8SVnt6lEj7PIA6ZrhD67Uz7aItAEY1aRxl6yyQicIu9CGeA99hCSSGuj3R1qXmeA0lt7QyENhVKrbHzRGwgXnKzXPIwZcl97N2hJ5B5rwhbCepFXCEWs6BzIzMtP9Fm0ABBHd9I49kj5Uk/GKRljuS3rI0ih/wu0gYMktJi8a2gNQC8VBYtSIpS/gRRYVe28pjQyLCu6jXAKypv9gTFFNuQiIFlF9ZG3cJr3WXmcAjjVHBtztIRlF7HAifRuuqgXVCcqorJi0Y6fjgrGYUIx1Z23SL03CEezTAPdHthNkme4LxECYbqNVGnoE9+5n/R1H1PZ6tU+o9WgYaaTUk6MV7Pn41p7KO2CkNwsXQfRTwGfMBBAS x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d9YOJCJANSwMfIPjHOlCtntzHxDSkpQsXssOs1HcUy0A8mnyOs9zw8DqY4+d?= =?us-ascii?Q?Ha6gGh1zlq/yCgLNzOuSbLptzKhyM9HIeLy7VqPSGyY1RhDwWj4ZyiOpJWOw?= =?us-ascii?Q?ZhDrCAmavjZY3QACzPS1qVIoeA3WiyomJCCAxcME2ogYU+rqpouEoVxj2ATT?= =?us-ascii?Q?lXp5gRXU3qMKzvkk8NWGohwdlLZQMCUlHSf7VMW5M+xO/tKjeDyAUYZgVINa?= =?us-ascii?Q?JRughBbX8gQl3PEtA5sJdI1SD7H00wERESE+c/DR5WSFVyZPhlvdr5cnahT7?= =?us-ascii?Q?G27bXNVfk/xUhddugO+KB4RpYTsapiqi5+EWgiZE/jeVMXRuont2yGLvb1kU?= =?us-ascii?Q?UVCO7WhXFydRmUuZW7kGbyVSXERV3dfK+Q8JOpw+RL86mJ0w2O+dCczCLl9N?= =?us-ascii?Q?rf+9lYm+1VluDwhHJagKw9ra0qiaWRvoDMzPPB4qr4mPbbuDqvAEH7yr3xsR?= =?us-ascii?Q?o2y/JQwhHLtMOG5CeyBTjzIEHD8Tn+Knhtmha+RneqwUu1pe6NfPL4r4CksL?= =?us-ascii?Q?gHDEg5XnE1ihdcNlkCJZp+VVrdEMXjD70ha1eCuW69GSmWyuBeiKpCMygMmq?= =?us-ascii?Q?OMKMAarRk4gVIlfgX6RjofomRxhfnD8U6MxGXTRK6cwM80FZDuqR5bCPmtfo?= =?us-ascii?Q?rtjStbMFBlDd+dcvQAtIQ9qjgDGXlHbEKvBbwMIrmCD4jl2Un49LavGZzszv?= =?us-ascii?Q?3xTlOeAFsDz9Q55D6RANAYPrWwSoXxxOTPH88P4q6dBKOgXC/7r0hfWRYu/U?= =?us-ascii?Q?JNbNjTo6krirWkmsluiv35FwpOfxAxKj4X+RU61vA9KAtx719Fmm1hjSW9nx?= =?us-ascii?Q?gunl5G3U9Sw+x/+vqmekSXlbLzO6ZBAJ0MGiu2frRXVQMooGIv0ibmYQEVpH?= =?us-ascii?Q?7zU29K0/vy0wsnBV8s24KPzb8B/ZayOAfF6J3a9hfs3xL1KVLyAtGlBSzp6I?= =?us-ascii?Q?tYZSxtctI6vnvpH7AozoDacxA71l0deig22lljISzwaBN+/uQADOYNVTGc+l?= =?us-ascii?Q?mgcVuHNAADLGVjtuGODQHgJNdeHPi5qxb8rXegCxgAqo79jQa64MqHb8kszn?= =?us-ascii?Q?VxE8dSwcc27FMOini1z29XtSMuIniNlvivePeW8wJoFKLMb6sTIN9vVGz6y2?= =?us-ascii?Q?ef9Wf3hZb5SNTtqhTQkV52gah5k7VeXiTg2AX+cvujsQ5gjXaPmQBRqnWjNc?= =?us-ascii?Q?75ObIHqDT3AIqsldBKccWjbudCNeaalN0tul6pmEJByIkX5ueq2tvUOmcL+d?= =?us-ascii?Q?IgKNfBcNBXTDjYVuyypL1sOfDExCqrUMDqza6TL1EjsUKjVQh+6SYfAu/wt1?= =?us-ascii?Q?ZjUpW3ylsiuZDPCJlnXFsOGl23xmEc4sQpCW4nSJGBxJv/WfqD7yNcqKF2IJ?= =?us-ascii?Q?iDTQ968T88ijwu5v8U1xH0qH+Y3gixfDtNoR37gVAm67JYlNOkQWeoDEWFho?= =?us-ascii?Q?Tm7LO4zU++sfloo7BG88uVl/w6gF9I03kuonmZWfa689wprIJ7SkVt4TakhT?= =?us-ascii?Q?FX3orWBPEkqdeZZ2e1hiNqkbSVTrSHlW7Sdeb9jbXkhyVyS6A+7RKbobAyev?= =?us-ascii?Q?JrrbOV0kR9ZlXXWoNx3E9/1pttV27iIYNBmkY/cK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8242.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffdbc68f-df9b-4dd9-e778-08dbae85c2e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2023 03:02:52.6655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NbZ4TeCar6zJBRvVa0sUrQmJbRbqrMUzQkPhvKsdGRyrLNIpbu91hHyUPoWaHggUebMmLizFMCCbUsE0yPay2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5315 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dandan.bi@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YAwDfbLxKNdH6RvGSAoGqv2Px7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=e3EvWI8o; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: Wang, Yin =20 Sent: Friday, September 1, 2023 4:21 PM To: devel@edk2.groups.io Cc: Wang, Yin ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Gerd Hoffmann ; Sunil V L ; Warkentin, Andrei ; Bi, Dandan ; Dong, Eric Subject: [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variab= le The Hii form is named "MainFormState" while the EFI variable is named "Pla= tformConfig". This discrepancy in names causes the following SCT cases to fail on RiscVVirtQemu: ExtractConfigConformance ExtractConfigFunction ExtractConfig_Func Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Sunil V L Cc: Andrei Warkentin Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Yin Wang Acked-by: Gerd Hoffmann Acked-by: Sunil V L --- v5: Re-organize commit message v4: Update commit message about version history - aefcc918: Enhance ExtractConfig() to match UEFI specification, adding check of whether " matches the GUID and name" - 16acacf2: Fix Hii form name mismatch in ExtractConfig() - This patch: Add one more fix for Hii form name mismatch v3: Gerd comments on v2 that caused issues may related to RISC-V specific c= onfig. To address this separately, the patch was restored to v1, and detail= s were added to the commit message. v2: Add two more changes which caused other two SCT Hii cases to fail. v1: Initial version --- OvmfPkg/PlatformDxe/Platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.= c index cd3bfd554c..c32439683d 100644 --- a/OvmfPkg/PlatformDxe/Platform.c +++ b/OvmfPkg/PlatformDxe/Platform.c @@ -279,7 +279,7 @@ ExtractConfig ( // ConfigRequestHdr =3D HiiConstructConfigHdr ( = &gOvmfPlatformConfigGuid,- mVariableName,+ = mHiiFormName, mImageHandle = ); if (ConfigRequestHdr =3D=3D NULL) {--=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108299): https://edk2.groups.io/g/devel/message/108299 Mute This Topic: https://groups.io/mt/101090614/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-