From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 86009AC096E for ; Fri, 10 May 2024 03:18:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XH9yNueAf0RV73inMOPO67r46+F6G7IoxfC9x8zgCbg=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715311091; v=1; b=OMA0lHA3FdeREgHpHqOAinOAoTmOymwE2AvfM8fYOLpkYTr7rLDrHGV6JhAVnYk4ZMx6JlPr zCpXCYQ8BGawDSchY5+nsBZiuRUuyjOylo2IHLlL+SgiuC0KUm+EPXi3A3SDJaOYm0V2p9vXWYw QZLT75WQ5G38aRqBHTMcGTFD+q9xKjJNyzVy2Or1Ev4Nd3bq+n8HcSIZd0cmN8T/VltDJ4OJK/q pQndhNXshDLUXs901TVcFnbnVRP7TVEPYjf/38pGCIM98KdP3mJllSutrhYrvWKM75kOJ2qfcxH rNtbTw8W3BtASVdESPjEXtIMWQvaRVvIzssqPa4hJFXMQ== X-Received: by 127.0.0.2 with SMTP id 9oReYY7687511x2uS2bM0GKQ; Thu, 09 May 2024 20:18:11 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web11.4498.1715311090278200835 for ; Thu, 09 May 2024 20:18:10 -0700 X-CSE-ConnectionGUID: wQSt5AH9QfSUHh4Vcn9gYA== X-CSE-MsgGUID: OFJgZ/JWShqq15pfKBTkfQ== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="28782428" X-IronPort-AV: E=Sophos;i="6.08,149,1712646000"; d="scan'208,217";a="28782428" X-Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 20:18:10 -0700 X-CSE-ConnectionGUID: grEmJGdISha0YTenV/UOdQ== X-CSE-MsgGUID: LukKe64FQCq2rQjLSQm9xQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,149,1712646000"; d="scan'208,217";a="33984621" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 May 2024 20:18:11 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 9 May 2024 20:18:09 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 9 May 2024 20:18:09 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 9 May 2024 20:18:09 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ2PR11MB7648.namprd11.prod.outlook.com (2603:10b6:a03:4d3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Fri, 10 May 2024 03:18:07 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.046; Fri, 10 May 2024 03:18:06 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Borzeszkowski, Alan" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver in early DXE Thread-Topic: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver in early DXE Thread-Index: AQHaoIAZsIMOkNnYAUGapUdq5gpuvrGMrfjegACnCYCAAnms/w== Date: Fri, 10 May 2024 03:18:06 +0000 Message-ID: References: <28921.1715174647070019432@groups.io> In-Reply-To: <28921.1715174647070019432@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ2PR11MB7648:EE_ x-ms-office365-filtering-correlation-id: f664d86c-38cc-495c-d5e8-08dc709fcfcc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?J3beut2NkFwShnuY7CjcfTGD/WOFSMs3aq09ihx5MT8eQIQN1SzZjzQg9VTT?= =?us-ascii?Q?IyFVJ0PEwM9sHVSpZPc0Nx9nwtayNuimB29Enhlf3FeHGNWr0cfKXdMGueGR?= =?us-ascii?Q?s03DQtBC90FhVTn6xx6X9QWv05ra6nI+DPZihkbc4UqRGNIOWV2H3+X7bNfP?= =?us-ascii?Q?bKe/NqTBezRgnxWEpQ2V1eTr97NFIwDw9dTh30Mhr7r85jcPvkQaOfRXgUS4?= =?us-ascii?Q?hCxCciCuO9SzqQZvWVo0X4z8viKZkIFDhq99SZY5w7letI2Gjo0oG4jD9kEo?= =?us-ascii?Q?w/U95ylruR33JZtNdwSREzlTc85jlf/cqFF2SU3ndpoTz8eojjDpr/BCw04A?= =?us-ascii?Q?IW0A3FWSti2jZYJ94S8c6MKTK46V9s6PEvjjlyx7P4UAIPnVMpB3SOR9BUMM?= =?us-ascii?Q?B16gA+CIXgPFurrNRVc5fW2nTiTbLU6QHY4TeGy6qXKwkED/fyagm0hGLNk7?= =?us-ascii?Q?75k4HEeCXd2xFOvOZmJjUTr/i3LNfMT0cN/zehCMLpTakzyyhdMjn5fCRSCl?= =?us-ascii?Q?ZhPGxXsV1QkwTYNMBy7Iz1Cx2EOJQbHwNPOH8IyQavQeXq2TVjMHnbtodIPv?= =?us-ascii?Q?iDaaqVYsC3caFEoRQHQmZUSbqKNDtTHFKUhpEii28ZzoUe7cXFLhSTCIx8f6?= =?us-ascii?Q?JLe9W9bvNS3PfxDd33kx6HJ5GW+jqGNl2VHgPtYfBUgqYwHH3Qaiw+r89ns3?= =?us-ascii?Q?lwD57fVnZcxK/OPDLVhhvevD50d8cadPPReypTewl4gn4gPYa2EhxOAfp54N?= =?us-ascii?Q?Xa7bolbu9MEojDPcUMpuJSCt7KSQiDWzAtzYwhikeijEN5f3GChJ0H0L3APq?= =?us-ascii?Q?VA433YjGni4MbfNbWaWxuwkpcM/BxVsh7ZMf8FT9cIjQMB1bleiasTWWymrR?= =?us-ascii?Q?Zl5i4pqJ+6ko2GKekXxlBWtEH0COsiclWwU8vitK11HRC9FrHc8tk0YgGFcI?= =?us-ascii?Q?LgDJmByFzpOGmq7NrXWYxQI/+NNBw2RMTdMpw9EWmicywUhKT7f3yZuRXTwr?= =?us-ascii?Q?IEYPChSGdOdtH+qmOqdn7azSEGDFoYWn9yY21y5Hxqg2h2SKZH5rm1Am1mx3?= =?us-ascii?Q?AN5C6M8S5XIgDclEWWne3h4Jbx7UZDsQx4HG3gCHBcnDUVDPxzNEFc5xSL5Z?= =?us-ascii?Q?ADrwbQ80fKJnnXUjm4+jH9oxKXCBY9KIzhpVPJvEDzbOT+bUGHxuR6w0aIim?= =?us-ascii?Q?1mYvuI+OEJ8+ABAIC9pimf1xjMBJE1wtWpJ9T48h5mPdziRwvryYPDBZaoPD?= =?us-ascii?Q?8/gHRCU/xxl4m9zw3G2pSLCw0KdovFsxCa43h/mig8bI2giX7v3oLOs+vMUK?= =?us-ascii?Q?6Qg=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qeQ7NdGAVK+q58qtW9pT+jypdL2qCMd31Iv2kIxFlr74i+wJ/xTTGxd0kD6n?= =?us-ascii?Q?rKmQ3RAHI4liEUP5tYkAdD6ZqemkP9n8ITNgOpsra0kOMj9vN757lW7fhp3b?= =?us-ascii?Q?Fnvgg3nnbRhRYUKwMh72uyRX5vwtKL9okfaDcQduCXPnuC9aDglsH4wjZZAB?= =?us-ascii?Q?2H9Q5C2DrGrJeJrr2jYHOP5AwIbNyjA4FunFra/aOnxALgnOSsTLiVPNX5hg?= =?us-ascii?Q?r2fcExZGjG487fvocfqydMqbCLFcmoghBDF0/8r7CwtB/kGLb6NfgGkejovB?= =?us-ascii?Q?G2gQ+8UtJo87ApXkIsKcXlu2Itbbx3RFhBuBvn1i3NEd72J4RigrlgBYAH4U?= =?us-ascii?Q?bAp8SMNn4/l1Za2Vwz7xsbxLxzGJHwzrH+F6zwu4eTAgGMWPAn4g5Zrw/YjW?= =?us-ascii?Q?qSCLf+uzf2M/bCHpExt4uKcmFy40ppW7nW5jm8zDFLE4ElOWAlPYuK24gSey?= =?us-ascii?Q?1lsaQ6YljCmqFbzbL1XGsw9UhLPtnwcMrgKZNPPLxH5lzOOD5cFgbyOqwVqM?= =?us-ascii?Q?aYNihTyZNVYTaWUr2bAoHynjWSRo2dskW3Z3V8aiDtOJ+cFTEHTI/emTzdVZ?= =?us-ascii?Q?3yzj8UO33cwowDE2BL1ggaY92U/EfrRBjmL/MnXSaOJjUzCooGsfkf+eddn3?= =?us-ascii?Q?3uf8bjSlHbeXpCHcbtSnJTGKzDQMkgVsAnxF3ATIN3Mia2b8n612M0R4aTkQ?= =?us-ascii?Q?Spd31loipkY1eFw+0E93lI1xrKWWajb5tr8sMvivcsuYuvtsvpC0PvRdTtAK?= =?us-ascii?Q?nfk8hq3Vd1Ua1tgRwwK33Qbnr0d8EanE1OG7Gg88ba2mmyTfHfeTZXK+JMg9?= =?us-ascii?Q?ZNOeqq6xlW11NmYhTsxS2O0OzoAcaj980rGwUZdlfghWLiNnBgmEeQCFbPLU?= =?us-ascii?Q?xEhi7lCgm8KT41/nzTsw2ky8BtEvyfXhKm/+Yo9pjrOBSUZmD7uHPeB03iMX?= =?us-ascii?Q?QcQGEx1Vg8BkQvb1kn7Y/CmCrGydM+cPqIl4ueWkiVSxMht1PQ3Qot62jmVq?= =?us-ascii?Q?q4+Nr2G/30QO65SbPabMUA157rMAq3VWQrIsh3Ud9zZGXDZXML3VMRQqkZyk?= =?us-ascii?Q?sRwdEkFfW8+nGJdEWpjvDosnsmHtjsJ2QT9Z/I1KuWLN4lOHJH+yn5qjbE5G?= =?us-ascii?Q?EqMb+Jw7h0gwYon2qX0uSLcMbCJgTaLdUHTptcFvwtNHAem1cm868wpgL3y9?= =?us-ascii?Q?EqRwoC9rMirvDlVJN6xF+BfPT6MYtkRRrhBgXUH1HLlMUqCdME71hbCE573y?= =?us-ascii?Q?ume+XLhs8ukvYW10MMMxpI7+FE0UbcpGBWgv3E+d3qISCMl2s7l63a3LugAi?= =?us-ascii?Q?A+9eQjhXxe1SRLuIKCt7twLe9sybcY/U942fugjzrdiw21fU4NtzscETmiPK?= =?us-ascii?Q?MR82CYlEkFZW+byovmTid8r8MyQZfc5uHSwjkp1J40ZqCwd8IvCHZ5EWD0+0?= =?us-ascii?Q?atLw8Xaf/e57j/CatN2RtCb2JjMMNuIYYNSVQDryzzDYKf626wA9kEoYnJvo?= =?us-ascii?Q?WfvAmcn8bz5o4SZSG++DenTFbeGCglzCELxAdBq5r+iH4eA0hGdv+G8qW1bv?= =?us-ascii?Q?f1WFGp/SLseH3hNFyDw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f664d86c-38cc-495c-d5e8-08dc709fcfcc X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2024 03:18:06.7601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xpE/727ntJ5qtGiPYbqiOq596wtFf+nKyL5E05Bxik+Jm9v01ONs90ASX7YdiNfHx8TvUDSsPzPOiso0lO6AMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7648 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 09 May 2024 20:18:10 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JjRdS62wA3m1dmaSWpX4KWJIx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244060A85D19343D3C2D7038CE72MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=OMA0lHA3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244060A85D19343D3C2D7038CE72MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike did not recommend the approach used by the patch. Your patch exposes a new pattern that's anti-driver-model, IMO. If you want to avoid code duplication, solve that problem in a way that doe= s not introduce such a pattern. Please be aware that any one piece of code introduced in edk2, could be clo= ned to multiple similar pieces of code. So we need to be very careful. Thanks, Ray ________________________________ From: devel@edk2.groups.io on behalf of Borzeszkowsk= i, Alan Sent: Wednesday, May 8, 2024 21:24 To: Ni, Ray ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver in e= arly DXE We have considered that; however, we aim to avoid maintaining our own imple= mentation of functions that communicate with UART. Please see discussion over previous approach: https://edk2.groups.io/g/devel/topic/104469297#115731 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118788): https://edk2.groups.io/g/devel/message/118788 Mute This Topic: https://groups.io/mt/105959587/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244060A85D19343D3C2D7038CE72MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Mike did not recommend the approach used by the patch.

Your patch exposes a new pattern that's anti-driver-model, IMO.

If you want to avoid code duplication, solve that problem in a way that doe= s not introduce such a pattern.
Please be aware that any one piece of code introduced in edk2, could be clo= ned to multiple similar pieces of code. So we need to be very careful.


Thanks,
Ray
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Borzeszkowski, Alan <alan.borz= eszkowski@intel.com>
Sent: Wednesday, May 8, 2024 21:24
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io <devel= @edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driv= er in early DXE
 

We have considered that; however, we aim to avoid maintaining our own im= plementation of functions that communicate with UART.

Please see discussion over previous approach:

https://edk2.groups.io/g/devel/topic/104469297#115731

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118788) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244060A85D19343D3C2D7038CE72MN6PR11MB8244namp_--