From: "Ni, Ray" <ray.ni@intel.com>
To: "Tan, Dun" <dun.tan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <gaoliming@byosoft.com.cn>,
"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck
Date: Fri, 31 Mar 2023 07:08:46 +0000 [thread overview]
Message-ID: <MN6PR11MB8244066530213074D53B2A6D8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230328024302.2085-7-dun.tan@intel.com>
Mike,
What's your comment for this patch?
PageTableLib is in UefiCpuPkg. DxeIpl requires PageTableLib for Ia32 and X64 versions.
I prefer that we can move the pkg dependency rule discussion as a separate topic and only review the
code logic in this patch series.
Do you think that we can loosen the dependency for the DxeIpl because it's really arch specific?
Thanks,
Ray
> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Tuesday, March 28, 2023 10:43 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck
>
> Add UefiCpuPkg/UefiCpuPkg.dec in MdeModulePkg.ci.yaml to pass
> DependencyCheck since DxeIpl in MdeModulePkg needs to consume
> CpuPageTableLib in UefiCpuPkg.
>
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.ci.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
> index f69989087b..d2616f4cdc 100644
> --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> @@ -2,7 +2,7 @@
> # CI configuration for MdeModulePkg
> #
> # Copyright (c) Microsoft Corporation
> -# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2020 - 2023, Intel Corporation. All rights reserved.<BR>
> # (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> ##
> @@ -51,7 +51,8 @@
> "MdePkg/MdePkg.dec",
> "MdeModulePkg/MdeModulePkg.dec",
> "StandaloneMmPkg/StandaloneMmPkg.dec",
> - "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an abstraction
> + "ArmPkg/ArmPkg.dec", # this should be fixed by promoting an abstraction
> + "UefiCpuPkg/UefiCpuPkg.dec"
> ],
> # For host based unit tests
> "AcceptableDependencies-HOST_APPLICATION":[
> --
> 2.31.1.windows.1
next prev parent reply other threads:[~2023-03-31 7:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 2:42 [PATCH 0/9] Create page table by CpuPageTableLib in DxeIpl duntan
2023-03-28 2:42 ` [PATCH 1/9] ArmVirtPkg: Add CpuPageTableLib required by DxeIpl in DSC duntan
2023-03-28 6:53 ` Gerd Hoffmann
2023-03-28 11:30 ` duntan
2023-03-28 2:42 ` [PATCH 2/9] EmulatorPkg: " duntan
2023-03-28 2:42 ` [PATCH 3/9] IntelFsp2Pkg: " duntan
2023-03-28 2:56 ` Chiu, Chasel
2023-03-28 2:42 ` [PATCH 4/9] MdeModulePkg: " duntan
2023-03-28 2:42 ` [PATCH 5/9] OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file duntan
2023-03-28 2:42 ` [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck duntan
2023-03-31 7:08 ` Ni, Ray [this message]
2023-03-28 2:43 ` [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib duntan
2023-03-31 7:01 ` Ni, Ray
2023-03-31 7:09 ` duntan
2023-03-28 2:43 ` [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX duntan
2023-03-31 7:02 ` Ni, Ray
2023-03-28 2:43 ` [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO duntan
2023-03-31 7:05 ` Ni, Ray
2023-03-31 7:10 ` duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244066530213074D53B2A6D8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox