From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4E8A0D800FD for ; Thu, 7 Dec 2023 01:26:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=q3qwYCLgTGrRplniKvbHx4SYDIAFqlBtuKw8luG/saw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701912404; v=1; b=ju9dKbnHNZTIPWdwdbdXW+sZxOXR9xAYTLFk4ygf4LIIsLQbjY1Lt5GSgYMBQaEfyti6OnSr eXYjyNoUXt1R73BpNHK9VcoQFR5T4kS1PqMkdUeT/8/8T43zN5hqQ4w+lE2lVYp2bKZhpwssXAf Q24uS5gQaF70B0G7jIHAoB3s= X-Received: by 127.0.0.2 with SMTP id 979fYY7687511xjbNJ1fSVLQ; Wed, 06 Dec 2023 17:26:44 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.73251.1701912402938313427 for ; Wed, 06 Dec 2023 17:26:43 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="391326349" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="391326349" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 17:26:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10916"; a="771521334" X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="scan'208";a="771521334" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Dec 2023 17:26:42 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 17:26:41 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Dec 2023 17:26:41 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Dec 2023 17:26:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=duMG2ECGFXrKJ9cayojSftdSj+EeOgao+12VZyCfRHyk/kUC7N/ei7LX1twQ0dGXGqekVhIHAKSwIM2P1uNJj0i42MtIX1kwBAbsoLDQ4VuYQQUEjENJig9WdNREyY4j6vo9Hc2icrsOoyLXTQft+acSKRaE8c/ir5XFS+2Ydfa25+l0/cxLo8PpvTVoF/q1BS57QCXtgb56EeUEtfvOLXQZ104V6QmDGtDjyy+w4CEznguY9EiYDugBV8x/yu3yPfl/CaXhuL3Hw1VWbp3WV5+TJ0b5dU/7nqHjqWiWo5Ab7S9NFGtZWz6/KefjYJEZb3ZS4DLrVf6NrfLuGDw9xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j0hKblbVuNp146NSR1EFsckiaemCEqtCEdq/JBHel1c=; b=H40qXiq64acxXWn/j+whqCscgTxjG8fAhtdMgBCkmrMPwQBrXKdY5V9WjtZgiDBEbMsnQKC9U2w4S/IMz4snyCeKz6rpm74uveUBfaUhicYMcICgG/DnzyT2DZhplTRlntqj/Jtd3tt/21My1CcmyVBuv2vTTOi6p1/InPbU7z7r88PwFMp6DLUNoN4TKYuFUpp6gt0c/V3k/rbNia7G42wT58P3CpikoGigcXSpSe3drATmm+9C5xY2PWYap2FXCdtVq2K/8tMj/kMqfimr2suAzH1G6VIskuRBH7jVJhqJMcL7JUnY362NVdB/oIdOEM/YY9jJFyfdmqRGhUMYBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ0PR11MB5168.namprd11.prod.outlook.com (2603:10b6:a03:2dc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Thu, 7 Dec 2023 01:26:38 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7046.034; Thu, 7 Dec 2023 01:26:38 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH 3/6] UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe Thread-Topic: [PATCH 3/6] UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe Thread-Index: AQHaJz7RGa6jjpG2MkGGLZfxXJAGj7Cb/d5wgAD2uBCAABVuEA== Date: Thu, 7 Dec 2023 01:26:38 +0000 Message-ID: References: <20231205054900.926-1-dun.tan@intel.com> <20231205054900.926-4-dun.tan@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ0PR11MB5168:EE_ x-ms-office365-filtering-correlation-id: 79f62564-6714-473b-0599-08dbf6c38f5b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Z8xy9N9megKh1g3Qp7t4faEj2rIbPH2gTRC3Ubu8HSlMvo3BdpbKVmj/pGoSCUZnfcSx55/Xsmz97kMshYWZqx4w/5USNM9Pwr8XIn7dhTiNEzvpWuX7+dWQd70ODrPq0/4SI16+wmShk6rN/46/WPVz2pmxBf/AgUItutGVczTbwY9Jn6QhWCUl0S3qfopUAgr/08j/AQGPQ7/nvRgpsnvzNJZUfVas1jSicrzFYWAU6hho3VhcwGHqVRH0QxPjgjoJNz2XEcJ0aIn0JNd9LZ6FHFMNjAgliCpfdYBpB6d+elL6nlrk4XWh3y+0DOsAdVwfdd1X6BvVOiwEwK5idrB5fibUpA8XlV8XnMd3BfmPleewNHpCZGdj0S0QxIwgO/yeeFIaO7L2eGTn1aAwIpBGvsHqpujVear03Rn1milUgLvGQIGdX5X7fhr/rF7197R0aMCDJY+HdwKgnQ97RIltcZtYeIi8s9opoKgJE/zPMGEeTDCWZSpGOBVrgWJvDd1OdLia+t0Ry+kCtV5neWMdvA+Ibe/uTBsTdwp1B5xFj47sR+V5wn7IjkP4HFdwSdoM6969PXaPI6kwNXNjZ91llQ4UiUnrdo/wvDyTLPVLInWcme4ie+Hfrb9SuIdz x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GraBbSH+18TW+AeXSw9WtCQ1VHv747Y29aYKPO1OK7Y6OXa1lZTr2WqxQTXn?= =?us-ascii?Q?/dwilMrJXtfl1C67TD+3IXc9IVsSC++hzDyYpE2UeOTrxbkow5ZhDhxPvE43?= =?us-ascii?Q?ZZdJNbCavzaDHHkXUARHwiuPlwG0o07fjU95H+xVp2QWo3to74mGDnlXIZ0f?= =?us-ascii?Q?UQzN+8lxcLeCfx9p17677dYr06Cpu8OZpdJQ/w2/xqa8nISwrHlpS05aZlUw?= =?us-ascii?Q?hWUVnREM+oblE3VZmU7jY9iyb/FG+qY1aF9Y7xafc45ptIYoEcunZZOHLYkt?= =?us-ascii?Q?GfF7yX+xrGAXVV0nSNRkokNRn66D/jmaPd5ji2jxX1/lnufgS41mhRCSlNPS?= =?us-ascii?Q?TmZHKqqhF1X5zyL0B16dRTWEyFGTDWWov8m1Sk9lj20+BFHm6LU/B7lnZ8XG?= =?us-ascii?Q?CKlsQJQa2xLneSI1MwM+BHdK1d0bhoERe1A9KJyKIRWxLXUFkwvU94g8CpKX?= =?us-ascii?Q?jWOA8xhE6eAw87+hudEgrqkfeEQ7ycNbenatMsdhyI7QK5FvJMluFAhVwqtT?= =?us-ascii?Q?YVTuwBhZiOtqRqfqDOxTHG2QEtMELrXLCRCH+lxCJQwBA90GxV/oyMpXHfbR?= =?us-ascii?Q?EnOV6f2jHgzMSbZyNXTp63mIfX5sDW52gHbmPnECSVoEDk2Mot/pZd3OaTQ2?= =?us-ascii?Q?RkNjeZVV2MHgHcO9ZSZjYZFXQOJF/fKIODyrJxNfr5Rkq8N8J2dC/rcRxORE?= =?us-ascii?Q?rSu2NhoKpfCMABuBOitDO7oHxUkFpoi6G689pXNC5S3qiS7qUOxM4DlJ0RlY?= =?us-ascii?Q?VRMmtnYlwmHz0HyXpiR3u8RSUTeVvqMFACQPSNGxvohESnLsnstmABqQeSHX?= =?us-ascii?Q?0hT8GvxVMb9Ri62ARRJrNzA3HiTt+J5StRyDyq1KqZsXXRIzKrWauZ5XdFMd?= =?us-ascii?Q?QhIy4XNsQvoMvzBvmIe7Hi1skC7ZQnIJ2egT5Oyu+Qvm2VIyau/MfF5lG1OO?= =?us-ascii?Q?+YzboFg+W8kFnoPcQzae37BFbIcu0W7w0hMmFr/9HhK6InFrd5trLb3V7Rfw?= =?us-ascii?Q?gUfrwuK6ImC+0JJXca3uMlggdcIScAKpuB2Az67t1+CpJ5sDBBdfiRwD8wj2?= =?us-ascii?Q?JSCWd06/a5NJnTji1Q3E5kdNLORmhbkmc8QtbQ8Ufr5diepk3yBAgBr10new?= =?us-ascii?Q?si2QUF0cg8dzIcgJ+0yGUxNdFrV28P/xd1z1bzlIgQCw84osrsxVU0//wqzg?= =?us-ascii?Q?ogfV1EJThkelT+w356QpJnNp/ajEC5CpaZX13YDUWOmNBfP09LAHGeJGsFpI?= =?us-ascii?Q?qw4dq0OZ4f/W2z2r/ZAvIkHmBJZ0xNXTmlUM3PMRItJNqOaRuo0N8b1h86Ll?= =?us-ascii?Q?a3VelX1zENMQyKQUGH9a8u2OtjGuNVbwAIsMrhG59qYY1Ub5OVt/cDmKN6k1?= =?us-ascii?Q?CNSJEBrMt4UdaKG6IeUcwJPv1ROL3wJo54cBiwW81lcVK1vx6Hs5+PZ2ZvBi?= =?us-ascii?Q?PgvGSoiySXLF27Pz6zystq/+UmDlyIwI2dirZOgoSg4tfjjdSLbp8pZ6CnIZ?= =?us-ascii?Q?hzksanIi1EjyWcBufbdtWJht+sSS9quEdG++O1subqbobBfSKa7gU9pZWP1n?= =?us-ascii?Q?CZwAgR8II7JwWZSSk8Q=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79f62564-6714-473b-0599-08dbf6c38f5b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 01:26:38.7059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: txXmYiXagxPlLEqn8SIz9hEU1HvePJFXROeJdWPbhaZBuaJ7S8fLJhFty0ZrqOiS6RuXOgfS9AacyWSz4nRaTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5168 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: F7IfMmgz9FJVlsVeoWMHR8gzx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ju9dKbnH; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") > -----Original Message----- > From: Tan, Dun > Sent: Thursday, December 7, 2023 8:23 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: RE: [PATCH 3/6] UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe >=20 > Will change the code based on comments 1-9. >=20 > About comments 10, "10. The depex change means that CpuSmm driver could > run before CpuMp driver runs. Have you verified if CpuSmm can start well > even removing CpuMp DXE driver?" >=20 > Yes, I verified it in OvmfIa32X64 boot. CpuSmm can start well even removi= ng > CpuMp DXE driver. Great! > (also removed some checking for gEfiCpuArchProtocolGuid) I assume the checking for CpuArch protocol is from other modules. >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, December 6, 2023 5:55 PM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: RE: [PATCH 3/6] UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe >=20 > 1. The function name can be "GetMpInformation()" without mentioning > "FromMpInfo2Hob". >=20 > > + EFI_HOB_GUID_TYPE *GuidHob; > > + EFI_HOB_GUID_TYPE *FirstMpInfor2Hob; >=20 > 2. "FirstMpInfo2Hob". Please remove "r". >=20 > >+ FirstMpInfor2Hob =3D GetFirstGuidHob (&gMpInformationHobGuid2); >=20 > 3. Please update comments to explain "FirstMpInfo2Hob" is to speed up the > 2nd while-loop without needing to look for MpInfo2Hob from beginning. >=20 > > + > > + ASSERT (CpuCount <=3D PcdGet32 (PcdCpuMaxLogicalProcessorNumber)); > > + *NumberOfCpus =3D CpuCount; >=20 > 4. There is no "return" before "*NumberOfCpus" assignment. So, why not > remove "CpuCount" and directly udpates "*NumberOfCpus" in the > while-loop? >=20 > > + > > + MpInfomation2Buffer =3D AllocatePool (sizeof > > (MP_INFORMATION2_HOB_DATA *) * HobCount); >=20 > 5. MpInfomation2Buffer -> MpInfo2Hobs >=20 >=20 > 6. Can you move "PrevProcessorIndex" assignment just above the "for" loop= ? >=20 > > + for (Index =3D 0; Index < HobCount; Index++) { > 7. Index -> HobIndex >=20 > > + CopyMem ( > > + ProcessorInfo + PrevProcessorIndex + ProcessorIndex, >=20 > 8. &ProcessorInfo[PrevProcessorIndex + ProcessorIndex] >=20 > > + > > + *ProcessorInfoPointer =3D ProcessorInfo; >=20 > 9. If you let the function just return ProcessorInfo and NULL when failur= e > happens, will it simplify the code? >=20 > > > > +[Depex] > > + TRUE > > -[Depex] > > - gEfiMpServiceProtocolGuid >=20 > 10. The depex change means that CpuSmm driver could run before CpuMp > driver runs. Have you verified if CpuSmm can start well even removing Cpu= Mp > DXE driver? -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112150): https://edk2.groups.io/g/devel/message/112150 Mute This Topic: https://groups.io/mt/102987139/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-