From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.3458.1685957922671662933 for ; Mon, 05 Jun 2023 02:38:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Rhm+XaeL; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685957922; x=1717493922; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=e3Z9EIxEylLzzj7n0BUwvb+MbyASfcYXMdTEHuTA6+E=; b=Rhm+XaeLGBds+KmYPg/E2f4Y09pvaPf6TWWx49AG5jg++fXG+G8I/b/g iHkkhyuT9H5Mklb2xzRco69m+VozWeETGmbSbytOajtT4U8kOeVoaaKVo bwSz2r8ZSfJPm/pn0qHALZiZOr1SrOyYdEAYt3h6ogYP96djtsAqIRZUi Rfg9SfdQLgt8rcp5UIf2YesZdOGE+RIXZfe9IyXbHJPurYoHh9zhMKaS6 x3gT9WvJdlfKUgOBu1wrj/cUVc8gkOjgCG7WmrvMJDdIc15f9Y172dXGP BKktMPXlCrDQFr9tIqkqjJvZuBS+9s779veoYnOwordgFGVFVgDeEDPR+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="419871362" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="419871362" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 02:38:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10731"; a="659017296" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="659017296" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 05 Jun 2023 02:38:42 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 5 Jun 2023 02:38:41 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 5 Jun 2023 02:38:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Jun 2023 02:38:41 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 5 Jun 2023 02:38:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fb9HnYKnbFbcKq2m6zV8l0P6pnwte7/F8q3WmFIZgT16FcIsFcMZ37b7/U7nC4NLsOBMi3bNcuetoElKr0PSJCs4OK28HeIXPRy8BS9ISiSe5jYY9D1H/cmhDUd133HsQ9JrbQGQ6rdSD/PWUl/72FP2dG2tYLXOOpvf9PyLDadwwlvxBlX9wHjE/+lpA8hCsZ+/+gdUKKnHJbe+J+8bZnIqIbLDvjD4Mxj9oVzj9B4I/d8uklIMrzg2nNOpOjWBAn7FCVx7MuyJh/Yr9NzaOsyi+AfDJw+cCw1ImoH8DfYYZZmSAT50XCSzCP05VvTBAVS+7HQeR6PJAX9JIkTEJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5t+LEOiHmsabvfHdZYiNby+8snFiR8W1KeUBT/fdMZk=; b=ROwQaOTULkLh1rooSogepz0U5kfStqoIm9q7k5tNdgzYJgzSLKg9WMnMdiEHniFJYfwS3APEnTBPNarmCKMTxSdjcBA6vCzuIkfh/kgu++XNqfRHRiSjSkh02p5sckHqZhAcDOnmBcXVF70v1iH7qPvDmdgPOzs4pe7hPIPNWX8Bngw0AceHs8VWJ35FmmFIkPe0VVwCFM/Bm4vjsDjbdvxCff2bZgz5L/w2i0CD+FUDGLJyEGcTpqp3xOA4C4gGtOC+iMMY3RgGAsJZK4zaHdfU70gNv738J0Y7e+DPNycFrWSRVyUR3ppDTVoP3lpRM8aVr/G/P7HfQM7au5UP7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CY5PR11MB6367.namprd11.prod.outlook.com (2603:10b6:930:39::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.31; Mon, 5 Jun 2023 09:38:37 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%3]) with mapi id 15.20.6455.027; Mon, 5 Jun 2023 09:38:37 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "abner.chang@amd.com" , "Attar, AbdulLateef (Abdul Lateef)" CC: "Grimes, Paul" , "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Topic: [edk2-devel] [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Index: AQHZjT+zAe5wpQQ0xUOmr5oyOWB3zq9nZSiAgAAB54CAFKAhcA== Date: Mon, 5 Jun 2023 09:38:37 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=478c6dbc-e316-401d-a0df-7b5093ac5fd4;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-23T06:25:39Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CY5PR11MB6367:EE_ x-ms-office365-filtering-correlation-id: 2b1a2090-24f4-4c0e-739d-08db65a8a3ac x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GbIqj01oJf9VCLuCHVmtIzwuNLlxbnIuL1roM0DGamAxOo7PCWtR8wiv1Kvs/2znUhSEHrMBKt3ua/8dlAtod2Zi8HqZ9idxKb2NYZZxas3CyasSYNMjREjBK74v8ITfQEUdvtPnuNE7sQrmgXv6Ensh/wdmQEoo1SxBZbnixkMeznxtnynVfSZHfTzzQY4cxnaulw2X13UReaF48qMogqr6hiiCe5aMirjpby2FLrPSFStV6mHr6Zkx3uQvffsf7qXPtU+4adRPi0PDQs8odeE4Q7u0xBz2VhcFZpHNtyOIXG1BNQ72kyImUo20r3EY4pq5T1XQGYhBol0r2SnoYY0xn9U2O8VnmH0ok6AtrDofmOqDW4AiB3WQnNRwHU2+leACZBrs7UCbbc/OH2Rg2LFIu7luybKUjid9MMvhUo5PPzdBLUTSmmM0xWYSLgCiZGIkZT3wPkKoc+MLid0gO60/1qHrmER0K1VHht/XL0ga27Dt4vyZqtcIqKW2qoo3Z84HO+NpoOXxBML7Y7xcGqposiiw8q3JxgU/M31Os7rNqyvXD+u94Wbo9lTfnfmyjdy9S1QnI3siPYJynaJS/AvD4k6OPZ4rIYuzy5mdqURpa8rM8vccDMuEUjAHYhdZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(376002)(136003)(366004)(39860400002)(346002)(396003)(84040400005)(451199021)(107886003)(6506007)(26005)(53546011)(9686003)(966005)(83380400001)(33656002)(122000001)(86362001)(38070700005)(38100700002)(82960400001)(186003)(55016003)(110136005)(5660300002)(52536014)(19627235002)(54906003)(2906002)(30864003)(478600001)(316002)(41300700001)(8936002)(4326008)(64756008)(66946007)(66446008)(66556008)(66476007)(76116006)(8676002)(71200400001)(66899021)(7696005)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Kb9xp2Ggd3kqzOPk8njth7NxlFnAHlOSFTkMDUblgngN2gzPhOvCZX3TFQET?= =?us-ascii?Q?/NMtO3Y0m8C5yjr07gaE72KVJjsLV07Cew62Sr0oAW3LEXKTZuYpirlW41QV?= =?us-ascii?Q?Iay0p/YwzEf2TftRdKHJcxSbXPNskbZRXlWS+w0Asc3UBnVa04/ntDuAGqn3?= =?us-ascii?Q?7T74WG2kKcLa2ER18+P2N87ITYU72w3cwSFN8fwvhC7Bv+GjLIwvCPDQNaTR?= =?us-ascii?Q?o7MZwI14eOkRJwNUBGaXddAqtbv6mnnt2E5782fdwqqO5yrmuu+iuIG+hs56?= =?us-ascii?Q?kDRAnGPxn/zwuToT25PgY/46Oj1gdomUHh/Urx0kgq+LDm4tO8ON/+/WY8ws?= =?us-ascii?Q?Q6fvxlnCXkHY9choYt8RA2g6JQx8M5P+G+wPI++iHgQGf5lqQvJtpySB5LQz?= =?us-ascii?Q?2CEby9OXjIl2cmlReyPLfdw0N8mXkUfbDB6MTxThcQ1j6AQxjcobGN80wL6F?= =?us-ascii?Q?p4j7QP/0qTKkI6bMm/CLOGiQN7PvkmVKDeZH7RVA6DZ5+aDfCI7F4L79pu/c?= =?us-ascii?Q?r0iRcURY6KktdR/mjKBNaZ1ub9AwFhvGEOfS6I4JyUwIvDCqXHFVWxIZK1mD?= =?us-ascii?Q?OXUbChtYwFyiR7AfC/+0H18kMQjQ1Ohw2/rZNTTZBhpks4tUmSrxT9mZP/U4?= =?us-ascii?Q?a1G5khhV3TeYfc2hKESeR56Lj0nleP+RPj4wCRAegZjEjrwLfS2aLO+4FLaA?= =?us-ascii?Q?50TLSTqKOmwCEv0PIGLkBvKLX2gKAQt6Q9fLnCrKckgIM/aPDGxfth0y+G7j?= =?us-ascii?Q?J+2/PF8wWn0pxaM7dHyNHr9MRh5sKrO7o9M/3yfD1stnpa/xynGWBUQct7cQ?= =?us-ascii?Q?XmfexuNPCRQ5jtOAwF/iYDQemERZp60nqGHxWZYTOW7t9YAf11HSM2RXmdmM?= =?us-ascii?Q?ytqKVE3YY4TjOTm3sLQItmcpnN6IIKgYqROFueuoFAdkL66KRNj/PAGlup9b?= =?us-ascii?Q?CkUwTCz/6pvH4psbc7IEMYgLHGkAhkDxbw8XKU3LzvVTrP5E1zTqFyCDCwu4?= =?us-ascii?Q?Kt4WOTNdObUg7JHI8173fYwGgMm0W9DPVsIm3z0kD6zkkWO8KgxQrX4qKLjv?= =?us-ascii?Q?SwATuwPXU0Jcoqms08l1SqOBAYSnOIMBb6AGKRJAS7mLlMe/7iH4jB5D+qjU?= =?us-ascii?Q?g701vx/sQMk1KfbwtFQCGlGEAN9NdvzOw0w/C/cROKn1V7qyEutfixRxFtfB?= =?us-ascii?Q?uWXoEc9SvGOXpOMJ/ppYyZNmlacowQtHlIBQRAebX62IbFbjNN3gCc2VWWa8?= =?us-ascii?Q?UV7ABzpGnzP/rexNhx+FOxAbpv+veDBrww9NiYi/gHTvN+GhXcvrKZLGioCk?= =?us-ascii?Q?rcHieR2RzWHTHRhiqxFTQAZmbVLjD0ugGs+6ULJfcFvUWEckzf1JCzrS6AMj?= =?us-ascii?Q?AuXhDgz07eSBDoaqOKokoBCFfYGEjPEB/G9sNzx88NaiZVevOgZqHUyoaDHw?= =?us-ascii?Q?Jw2VxVI9JK3RB1NkvGNQ8F9y0ubD/JtXUwxcltEjg6Vfey/BzJepm5nL2MYv?= =?us-ascii?Q?thngVt1v8+ESAlWZHXumSkxwIsmKywWXOTd8Daj77adMeuIFndc+v5Mq5qjK?= =?us-ascii?Q?d85r7NDGoaCdc9XoqQE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b1a2090-24f4-4c0e-739d-08db65a8a3ac X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2023 09:38:37.7681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BTXPhQ+C+2ID+oCLc92ZlbW39E/QJYzq2quAm2XEXKF6Lv8T9xjpAJa+dVAUX43YFMFjHHRjVGXB+W/53yglfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6367 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I spent some time to verify if the IntelMmSaveStateLib behaves the same as = the default implementation in CpuSmm driver. The result looks good with following embedded test code in BSPHandler(): for (Cpu =3D 0; Cpu < mMaxNumberOfCpus; Cpu++) { DEBUG ((DEBUG_INFO, "Testing SMRAM Read CPU[%d]...", Cpu)); for (Register =3D EFI_MM_SAVE_STATE_REGISTER_GDTBASE; Register <=3D E= FI_MM_SAVE_STATE_REGISTER_PROCESSOR_ID; Register++) { DEBUG ((DEBUG_INFO, " Register(%d)...\n", Register)); switch (Register) { case EFI_MM_SAVE_STATE_REGISTER_IO: Width =3D sizeof (IoInfo); break; case EFI_MM_SAVE_STATE_REGISTER_LMA: Width =3D 1; break; default: Width =3D 8; break; } Status =3D MmSaveStateReadRegister (Cpu, Register, Width, &IoInfo)= ; Status2 =3D ReadSaveStateRegister (Cpu, Register, Width, &IoInfo2); ASSERT (Status =3D=3D Status2); if (!EFI_ERROR (Status)) { ASSERT (CompareMem (&IoInfo, &IoInfo2, Width) =3D=3D 0); } else { if (Status =3D=3D EFI_INVALID_PARAMETER) { Status =3D MmSaveStateReadRegister (Cpu, Register, sizeof (UIN= T32), &IoInfo); Status2 =3D ReadSaveStateRegister (Cpu, Register, sizeof (UINT3= 2), &IoInfo2); ASSERT (Status =3D=3D Status2); ASSERT (Status =3D=3D EFI_SUCCESS); ASSERT (CompareMem (&IoInfo, &IoInfo2, sizeof (UINT32)) =3D=3D = 0); } } } } But, one comment: EFI_SMM_SAVE_STATE_REGISTER_PROCESSOR_ID is not handled b= y MmSaveStateLib. It's handled by CpuSmm driver. I am ok with that. Can you please update the MmSaveStateLib header file to = explicitly mention that? I am afraid I may forget this without clear function header comments. Others look good to me. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, Abn= er > via groups.io > Sent: Tuesday, May 23, 2023 2:36 PM > To: Ni, Ray ; Attar, AbdulLateef (Abdul Lateef) > ; devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Grimes= , > Paul ; Dong, Eric ; Kumar, Rahu= l > R ; Gerd Hoffmann ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ard > Biesheuvel ; Yao, Jiewen ; > Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib >=20 > [AMD Official Use Only - General] >=20 > Let's talk to Liming to see if we have chance to make this included in 20= 2305 as > the review process of this patch set looks to me close to finish. >=20 > Thanks > Abner >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Tuesday, May 23, 2023 2:30 PM > > To: Chang, Abner ; Attar, AbdulLateef (Abdul > > Lateef) ; devel@edk2.groups.io > > Cc: Attar, AbdulLateef (Abdul Lateef) ; Grim= es, > > Paul ; Dong, Eric ; Kumar, > > Rahul R ; Gerd Hoffmann ; > > Kinney, Michael D ; Gao, Liming > > ; Liu, Zhiguang ; Ard > > Biesheuvel ; Yao, Jiewen > > ; Justen, Jordan L > > Subject: RE: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and > > MmSaveStateLib > > > > [AMD Official Use Only - General] > > > > Caution: This message originated from an External Source. Use proper ca= ution > > when opening attachments, clicking links, or responding. > > > > > > Abner, > > Sure. I will review the new patch set. > > > > But I am afraid this patch set cannot be included in 202305 stable rele= ase > > because the edk2 repo > > has been locked for quite a while for 202305 release and is about to un= locked. > > > > Thanks, > > Ray > > > > > -----Original Message----- > > > From: Chang, Abner > > > Sent: Tuesday, May 23, 2023 2:28 PM > > > To: Attar, AbdulLateef (Abdul Lateef) ; > > > devel@edk2.groups.io; Ni, Ray > > > Cc: Attar, AbdulLateef (Abdul Lateef) ; > > Grimes, > > > Paul ; Dong, Eric ; Kumar, > > Rahul > > > R ; Gerd Hoffmann ; > > Kinney, > > > Michael D ; Gao, Liming > > > ; Liu, Zhiguang ; A= rd > > > Biesheuvel ; Yao, Jiewen > > ; > > > Justen, Jordan L > > > Subject: RE: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and > > MmSaveStateLib > > > > > > [AMD Official Use Only - General] > > > > > > Hi @Ray Ni, > > > We are almost there... We need your help to review this patch set as = we > > need > > > this library to be part of 202305 stable release. > > > > > > Thanks > > > Abner > > > > > > > > > > > > > -----Original Message----- > > > > From: Abdul Lateef Attar > > > > Sent: Friday, May 12, 2023 8:32 PM > > > > To: devel@edk2.groups.io > > > > Cc: Attar, AbdulLateef (Abdul Lateef) ; > > Grimes, > > > > Paul ; Chang, Abner ; > > Eric > > > > Dong ; Ray Ni ; Rahul Kumar > > > > ; Gerd Hoffmann ; > > Michael D > > > > Kinney ; Liming Gao > > > > ; Zhiguang Liu ; = Ard > > > > Biesheuvel ; Jiewen Yao > > > > ; Jordan Justen > > > > Subject: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and > > > > MmSaveStateLib > > > > > > > > Backward-compatibility changes: > > > > This patch series removes the SmmCpuFeaturesReadSaveStateRegister > > > > and SmmCpuFeaturesWriteSaveStateRegister interface/function. > > > > SmmReadSaveState() and SmmWriteSaveState() now directly invokes > > > > MmSaveStateLib > > > > routines to save/restore registers. > > > > > > > > PR: https://github.com/tianocore/edk2/pull/4392 > > > > > > > > V13: Delta changes > > > > Address review comments from Ray Ni > > > > Changed the BASE _NAME of AmdSmmCpuFeaturesLib. > > > > Removed EFIAPI from local function. > > > > Removed CpuIndex parameter from MmSaveStateGetRegisterLma > > > > Modifed MmSaveStateGetRegisterIndex () to accept RegOffset > > > > as second parameter. > > > > Removed FILE_GUID library instance for intel implemention from > > > > UefiCpuPkg.dsc. > > > > > > > > V12: > > > > Addressed review comments from Michael. > > > > Added LibraryClasses to .inf file. > > > > removed duplicate MACRO definations. > > > > Moved related MACRO defination to respective file. > > > > V11: Delta changes > > > > Drop the OVMF implementation of MmSaveStateLib > > > > V10: Delta changes: > > > > Addressed review comments from Abner. > > > > V9: Delta changes: > > > > Addressed review comments. > > > > Rename to MmSaveStateLib. > > > > Also rename SMM_ defines to MM_. > > > > Implemented OVMF MmSaveStateLib. > > > > Removes SmmCpuFeaturesReadSaveStateRegister and > > > > SmmCpuFeaturesWriteSaveStateRegister > > > > function interface. > > > > V8 delta changes: > > > > Addressed review comments from Abner, > > > > Fix the whitespace error. > > > > Seperate the Ovmf changes to another patch > > > > V7 delta changes: > > > > Adds SmmSmramSaveStateLib for Intel processor. > > > > Integrate SmmSmramSaveStateLib library. > > > > V6 delta changes: > > > > Addressed review comments for Ray NI. > > > > removed unnecessary EFIAPI. > > > > V5 delta changes: > > > > rebase to master branch. > > > > updated Reviewed-by > > > > V4 delta changes: > > > > rebase to master branch. > > > > added reviewed-by. > > > > V3 delta changes: > > > > Addressed review comments from Abner chang. > > > > Re-arranged patch order. > > > > > > > > Cc: Paul Grimes > > > > Cc: Abner Chang > > > > Cc: Eric Dong > > > > Cc: Ray Ni > > > > Cc: Rahul Kumar > > > > Cc: Gerd Hoffmann > > > > Cc: Michael D Kinney > > > > Cc: Liming Gao > > > > Cc: Zhiguang Liu > > > > Cc: Ard Biesheuvel > > > > Cc: Jiewen Yao > > > > Cc: Jordan Justen > > > > Cc: Abdul Lateef Attar > > > > > > > > Abdul Lateef Attar (8): > > > > MdePkg: Adds AMD SMRAM save state map > > > > UefiCpuPkg: Adds MmSaveStateLib library class > > > > UefiCpuPkg: Implements MmSaveStateLib library instance > > > > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > > > > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > > > > UefiCpuPkg: Implements MmSaveStateLib for Intel > > > > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > > > > OvmfPkg: Uses MmSaveStateLib library > > > > > > > > UefiCpuPkg/UefiCpuPkg.dec | 4 + > > > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > > > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > > > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > > > UefiCpuPkg/UefiCpuPkg.dsc | 13 + > > > > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 34 + > > > > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 34 + > > > > .../AmdSmmCpuFeaturesLib.inf | 38 + > > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > > > > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++ > > > > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 70 ++ > > > > .../Include/Library/SmmCpuFeaturesLib.h | 52 -- > > > > .../Library/MmSaveStateLib/MmSaveState.h | 94 +++ > > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +- > > > > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 --------------= ---- > > > > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++ > > > > .../Library/MmSaveStateLib/IntelMmSaveState.c | 410 ++++++++++ > > > > .../MmSaveStateLib/MmSaveStateCommon.c | 132 +++ > > > > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 +++++++++ > > > > .../IntelSmmCpuFeaturesLib.c | 70 ++ > > > > .../SmmCpuFeaturesLibCommon.c | 128 --- > > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +- > > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------- > > > > MdePkg/MdePkg.ci.yaml | 4 +- > > > > 24 files changed, 1806 insertions(+), 1508 deletions(-) > > > > create mode 100644 > > > > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf > > > > create mode 100644 > > > > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf > > > > create mode 100644 > > > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf > > > > create mode 100644 > > MdePkg/Include/Register/Amd/SmramSaveStateMap.h > > > > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h > > > > create mode 100644 > > UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h > > > > create mode 100644 > > > > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > > > > create mode 100644 > > > > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c > > > > create mode 100644 > > > > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c > > > > create mode 100644 > > > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c > > > > > > > > -- > > > > 2.25.1 >=20 >=20 >=20 >=20 >=20