From: "Ni, Ray" <ray.ni@intel.com>
To: "Tan, Dun" <dun.tan@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>,
"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX
Date: Fri, 31 Mar 2023 07:02:53 +0000 [thread overview]
Message-ID: <MN6PR11MB82440DFDC04AE7BDCA3029BD8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230328024302.2085-9-dun.tan@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Tuesday, March 28, 2023 10:43 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>
> Subject: [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX
>
> In IA32 code, remove the duplicated code to enable NX.
> In the previous patch, IA32 code also uses the new
> CreateIdentityMappingPageTables() to create PAE page table.
> This function calls EnableExecuteDisableBit if needed.
>
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> ---
> MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c
> b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c
> index e0e2601637..4b97e4ea80 100644
> --- a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c
> +++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c
> @@ -322,9 +322,6 @@ HandOffToDxeCore (
> BuildPageTablesIa32Pae = ToBuildPageTable ();
> if (BuildPageTablesIa32Pae) {
> PageTables = CreateIdentityMappingPageTables (TRUE, BaseOfStack, STACK_SIZE, 0, 0);
> - if (IsEnableNonExecNeeded ()) {
> - EnableExecuteDisableBit ();
> - }
> }
>
> //
> --
> 2.31.1.windows.1
next prev parent reply other threads:[~2023-03-31 7:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 2:42 [PATCH 0/9] Create page table by CpuPageTableLib in DxeIpl duntan
2023-03-28 2:42 ` [PATCH 1/9] ArmVirtPkg: Add CpuPageTableLib required by DxeIpl in DSC duntan
2023-03-28 6:53 ` Gerd Hoffmann
2023-03-28 11:30 ` duntan
2023-03-28 2:42 ` [PATCH 2/9] EmulatorPkg: " duntan
2023-03-28 2:42 ` [PATCH 3/9] IntelFsp2Pkg: " duntan
2023-03-28 2:56 ` Chiu, Chasel
2023-03-28 2:42 ` [PATCH 4/9] MdeModulePkg: " duntan
2023-03-28 2:42 ` [PATCH 5/9] OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file duntan
2023-03-28 2:42 ` [PATCH 6/9] MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck duntan
2023-03-31 7:08 ` Ni, Ray
2023-03-28 2:43 ` [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib duntan
2023-03-31 7:01 ` Ni, Ray
2023-03-31 7:09 ` duntan
2023-03-28 2:43 ` [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX duntan
2023-03-31 7:02 ` Ni, Ray [this message]
2023-03-28 2:43 ` [PATCH 9/9] MdeModulePkg/DxeIpl: Refinement to the code to set PageTable as RO duntan
2023-03-31 7:05 ` Ni, Ray
2023-03-31 7:10 ` duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB82440DFDC04AE7BDCA3029BD8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox