From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.48858.1680246178146704330 for ; Fri, 31 Mar 2023 00:02:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C3GauGGl; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680246178; x=1711782178; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ISZKgpHEPt8ZNMoKMFKFyE2WKgVbvDXPkI8bqoi9MeM=; b=C3GauGGlKfSi2Jpbl2yDZQVpzIJ2hTVJ2DSxTHxBfnRBSGTzkAe4a6TC 9kTjNZlra814yix+VzE5EzdYEq6SePnZFO/4Ab3MfUh3n0fHQMZ98RIs5 lnWktF5YNcsTrtL3RyGh6dojomYA5Z3OpU0y/DA2P3iTNM5Tlfly6zDu1 qUGjCBOLBk0LpefxaOYWHbu/KHimyN3YQHYslGnCu2PRt7GdCYS8jS1mC K3PERw3Iq78165p8ZqmQ0CAqtA7PIZukMHdwUQf+SIprrceomMZY9C5/U Fgacxvjt+ZlDKtekS5QqKRAUPaFDGv0J6PN7mfThjCmygSC4NQemji69Z A==; X-IronPort-AV: E=McAfee;i="6600,9927,10665"; a="427656887" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="427656887" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 00:02:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10665"; a="687549216" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="687549216" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 31 Mar 2023 00:02:57 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 31 Mar 2023 00:02:57 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 31 Mar 2023 00:02:56 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 31 Mar 2023 00:02:56 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 31 Mar 2023 00:02:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ez7NdP/JreOaTmyqINsS7nMrl/wlTW/ZpPziwTGqMowImRsLOWERKQgYjR9vRXOIFUz52bGWbc4bu2xFLiShbNCVpYjpAvt3CM79U8FVl1FyXeoVRW1EPK1RymGgPYW2XTtfWH/Z0Jz+BiVjXQxRoP3kzp4qUdChMNtTjSQok30ZD6fwbnqdSUHy6REuCvQjKpnNIAAv2QYuisJD4+8DZEecEXm87zudXc/PGBocBqHv43TkfNjgczaP/I/x+vw0AvJ/U1X05YML9dxI4QsS699dbvc+Vq8DRdu1TP5wlQFAoNig1nDkQ+v7q6pp22fuooAPjYvEQKndOObQ7qWaww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sz5pRL8vFr4P3w8uTJTuuAz32ES9rwZkREm9tluR2q8=; b=CC+7bIjX1g5qhXU1HzyUM71c8XwC6cqSUPdYD452KT4gwLghD/Qq0jaPsEBF7SBaPAwZmDVCzEimGEOMpu5f5xfX6pQ8mB+H5e/AnX8e3D0RY4+vhyXxRRgdPItgdHqzB3UjcHDGa9EAeWI20NBpNCCnDxCzjNd8yT5Y1RhnIlszUQs1eVhpr2iERn4MeXjZU+y1MC2ci6zk1FoXct1OvAZzaQdKCCNdYZ/FaRtD7Sc0XtF/ylDErIeoQMRvQe2WKewfSpjxP4KtRO7bOvvj5LEWJKW09t+9uve6BnepdargWbYaF51+bTXyRB1LgoUJhVDfBiwudSilPY8nFU9edg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ0PR11MB5769.namprd11.prod.outlook.com (2603:10b6:a03:420::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 31 Mar 2023 07:02:54 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%8]) with mapi id 15.20.6222.035; Fri, 31 Mar 2023 07:02:54 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Wang, Jian J" Subject: Re: [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX Thread-Topic: [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enable NX Thread-Index: AQHZYR82L8o2CVYyHEeZtidpI7c7nq8Ue1Pg Date: Fri, 31 Mar 2023 07:02:53 +0000 Message-ID: References: <20230328024302.2085-1-dun.tan@intel.com> <20230328024302.2085-9-dun.tan@intel.com> In-Reply-To: <20230328024302.2085-9-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ0PR11MB5769:EE_ x-ms-office365-filtering-correlation-id: 0e3ecdd6-1a8d-4dc9-8f58-08db31b5f313 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i259+hMRILGhAoFOnVwLDDdKwUGEfHTt0sZN8GJNe4VyVZTFP8HNs866T5vK+qdEvZkJBxRp9Fe/CBksUJakcLG2wEiMtg9J/m8u4TDp2BA/NIiFX7XhFu8pTjKlCbkrh1PZyiI8iWeShg2QukyN6KwYBF/DTxL8rnvWUwE7keHxXpoA2HQvo1fWjjWdF2PBIJgSQ3yyYqwIlDy7IKjhlhnTQqAAZukWQMaZeiThu5Es8OVBMiCqFXslyAkNrbf7zlg1sd7TBklvR1MdEVkC0AyY9F9gfkn4RtmjWw5msdFERTJbKWA/s0Mwm6HhWkEwq6ycO/yhvj78JqGcxlctjNRCi3sreiw6VjswIthR6RSOg+pz+j1Nv8OV1/z06u06n8rQ+YDyjzxsE5Afm8ZjA/bPZzQ2fyIYyU4Qu3BxrHV245DYkkxmZefI7YBybVDYwvWcGLvchQSrJc2hQSAlKNi5kiZf4rBB4/V/eEK7sP/IWn4mlyjA1x5mdjLDkZhEnF4jiVH/RC18Ks1yUWw/BccWI3ozql/a7bkwly9v41WG1rNqY+XgZ79EyzHZsWUI+uLZfM30AEzEWwfjrWQtPYAOtlZ5+0Y4PtOtHpSRa/DF3Ry0mWz+nmqFOUXIVPUN x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199021)(82960400001)(4326008)(19627235002)(122000001)(52536014)(8676002)(8936002)(186003)(76116006)(66476007)(478600001)(53546011)(66946007)(66556008)(66446008)(55016003)(110136005)(7696005)(54906003)(38070700005)(64756008)(71200400001)(9686003)(2906002)(83380400001)(316002)(33656002)(41300700001)(38100700002)(5660300002)(107886003)(6506007)(86362001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c8LpLUIM7KUokFPYYaf/l07EErooneZfD8g3vRzkpV5jJx8ILzaw5l7DzM8d?= =?us-ascii?Q?GCOTryFsp5j8BWuUFqQ3RMdMoCfcIAPUe1DJRGplLixxL9HutJ54MD4dcQst?= =?us-ascii?Q?tbBFf5aTvukta5y09gwAs+WdKhoQ/M8amtd5wa49+2T+cpZio18QbnlXlUrV?= =?us-ascii?Q?v5Zx2nQy265WQ6ZBMWxblkCR9gFPEoaisGovuvSPQUGbEW54J4OmQ7/tgSut?= =?us-ascii?Q?uW1flseGr+wPjZ8t54cxeunvLpMALC8KQF0tEGjenMAplazxcIedyI8omhr7?= =?us-ascii?Q?8M19c00n7YvoEQdN01fEt2J/aY7IK7FtVs5cTpMnMDQWtfCiAmEr/vTL3gnh?= =?us-ascii?Q?4m1MtgYaHR7a/R/sSRq6PgxDucLBF2lRdSpnQ0l5NQ+taJ6voYb31QebiTUV?= =?us-ascii?Q?e1ZS0+qW5oYuFKpsMVZUPufdAVDczD5jbk3b1e5YI2HWmOsZ5D/byRJyV2s4?= =?us-ascii?Q?iNiMyaTV75FevEZex3Fob/J69MRZyUb9tUxRQlkiFaNa1eUZyKVepVmtDiNg?= =?us-ascii?Q?SKocZeTTl+IzANAtB0VvaasXDY9wC3JZQdkbWtMRDSasBuTNlYVqlLUJsfUS?= =?us-ascii?Q?xCuF2GColBhQ1ept/ZqmNZlnzOWFDs24tOqqsU6I47DwuyZyArll+ciC+k1H?= =?us-ascii?Q?FsUcdDmsxkXQFFKi+s33QH9Xm2RVHwl+q1HJJoVjbPHJvx+zED3kSz7xC8Dr?= =?us-ascii?Q?SugYnjWRnsdKSv8050KIARJILsGp87Els53txu+d2DUWPUJUR2BH6v4xOqaz?= =?us-ascii?Q?WiOoD9zRhe1UGo3VJm9c7OLjzuQzta6ArKpvWnQskSZNllu5NGNXZL9Mt8BR?= =?us-ascii?Q?JIsETCOzqgTV1zvR9qaV5qCpOlQUY4Srlb2FvAXeEEruZh7PmsMr1bq2UX5L?= =?us-ascii?Q?9KzSQbwTYu5RiaeaH3a+9hHb1smm7p9dwRjHktDPjf1+Oi4xrvvkHCeD9W8a?= =?us-ascii?Q?U2kCxm8ZpmmVZ/cqIsL9EHBBuKdgdOau428+qWHXzqE3/u7ZK6QtpqeyxM5j?= =?us-ascii?Q?GRCzKi1M/464St9mpTZqnln/tAALzHuFBpDXn2m4Urf8IUGdZRIXaRAEzxpp?= =?us-ascii?Q?azvmfKefsP+ATB41KruVZk/NAdtbQG1QGP7H4Ll48meSwKSs2KsHbOl+4xkL?= =?us-ascii?Q?fzq2WTup/gY6H+amHAdAJBGAHGqHDGaAFJJy6+DkQ53jJOorfB/IK19nMjKw?= =?us-ascii?Q?YNTuxfB7OYjcxTUCqqAIHcku0cUuzV4sb7IMCeV/ltFQikboTsJAgr8CXP00?= =?us-ascii?Q?uO6jx2wmF/QpGiEN65NNRfCfAsIra3Jj638Vz0QPp28pxJXTZLi24Oy6FQDP?= =?us-ascii?Q?WFDZzZ0u074sq+YzMhkzyawOTUdw1UoeMblJ8Edkq47nr1w3a+TLjKaH93Oe?= =?us-ascii?Q?gkb8hMow7bv80rlPiQwcwujBOI6DecMQC0d3HH7vJX0bqRacNNG/OA4U/m9h?= =?us-ascii?Q?vHJZd18OiInbw5H+QQ6qNBV/i82RDQ2bngOJj4l3pJsovWDBSNqEXGDFTW3L?= =?us-ascii?Q?yCaTah+HRwyHH4a7fhupe2SABsaptUa7kfETZhrsH8IfqV/0gWNOoWhPqxzg?= =?us-ascii?Q?ryHDp1yU/480uu3itfk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e3ecdd6-1a8d-4dc9-8f58-08db31b5f313 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2023 07:02:53.9501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JfhAAAGsqwrN+pDurRmlwabm4J8l8C1smmyK3BaiViiFMOIAGofuOgnjQ219352U8tsVEPchAS1S0Ej3BtQa7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5769 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Dun > Sent: Tuesday, March 28, 2023 10:43 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; Ni, Ray ; Wang, Jian > J > Subject: [PATCH 8/9] MdeModulePkg/DxeIpl: Remove duplicated code to enabl= e NX >=20 > In IA32 code, remove the duplicated code to enable NX. > In the previous patch, IA32 code also uses the new > CreateIdentityMappingPageTables() to create PAE page table. > This function calls EnableExecuteDisableBit if needed. >=20 > Signed-off-by: Dun Tan > Cc: Dandan Bi > Cc: Liming Gao > Cc: Ray Ni > Cc: Jian J Wang > --- > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c > b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c > index e0e2601637..4b97e4ea80 100644 > --- a/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c > +++ b/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c > @@ -322,9 +322,6 @@ HandOffToDxeCore ( > BuildPageTablesIa32Pae =3D ToBuildPageTable (); > if (BuildPageTablesIa32Pae) { > PageTables =3D CreateIdentityMappingPageTables (TRUE, BaseOfStack,= STACK_SIZE, 0, 0); > - if (IsEnableNonExecNeeded ()) { > - EnableExecuteDisableBit (); > - } > } >=20 > // > -- > 2.31.1.windows.1