From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7CFDB7803D9 for ; Wed, 15 May 2024 08:36:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YGCKJyuRoooRcStvFQeLVW7OtT1YkrJQH5d4ag/jmOI=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715762176; v=1; b=POCr8pQd4WDXkopgg/NvBSQIYDXmS9OY8wyETL/hW9u0Q7fOz5KYEOHso4AL+RbfInIf1Pl7 LHBP8/j/KHow3GrTvPJyWuHGunGj6cF0sVQaigTJThV2Md77fPaG8CtdnH20uhMHisUXpWovF55 88ufMG2VD0cZ5Q9v4DxVkQ0wVh6NikBov84AggWVZXLrUfTPUANgPKEvTWZH2ASG7O1C9cpFsg0 EG0/EGli78JFkAGtPr+ZbYgSjK2hGO7i+KvEJh0sqouoRZphiMW09J8tqdJd0PYAZ5tIXb/1qeh w+fw+JHZrzvMyON435q559CKMEC/WLXcYuYRVCrsvM53A== X-Received: by 127.0.0.2 with SMTP id ahBuYY7687511xNJXchvOYWh; Wed, 15 May 2024 01:36:16 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web10.9810.1715762171901643493 for ; Wed, 15 May 2024 01:36:14 -0700 X-CSE-ConnectionGUID: +erphgY4RT6na7xtUGiTpg== X-CSE-MsgGUID: 34kF/KKvSMW1/V3pZZ84xA== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="34307261" X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208,217";a="34307261" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 01:36:11 -0700 X-CSE-ConnectionGUID: gOmj2S6ASo6JUcLy4sYQ4g== X-CSE-MsgGUID: PGJJHFbpQmGnw6US+rPGUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208,217";a="30981741" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 May 2024 01:36:10 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 15 May 2024 01:36:10 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 15 May 2024 01:36:10 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 01:36:09 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW6PR11MB8391.namprd11.prod.outlook.com (2603:10b6:303:243::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.26; Wed, 15 May 2024 08:36:02 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.052; Wed, 15 May 2024 08:36:02 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "wangyang@bosc.ac.cn" CC: "sunilvl@ventanamicro.com" , "git@danielschaefer.me" , Ran Wang , Leif Lindholm , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] XiangshanSeriesPkg:Add Support for Xilinx RC(PCIE) Driver Thread-Topic: [edk2-devel] [PATCH] XiangshanSeriesPkg:Add Support for Xilinx RC(PCIE) Driver Thread-Index: AQHapptRJ0rtVKBr+EOszndZKunOSLGX9TMt Date: Wed, 15 May 2024 08:36:02 +0000 Message-ID: References: <17C6FF8EBB82206B.20815@groups.io> <29ca357a.eb.18f7b3255cd.Coremail.wangyang@bosc.ac.cn> In-Reply-To: <29ca357a.eb.18f7b3255cd.Coremail.wangyang@bosc.ac.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW6PR11MB8391:EE_ x-ms-office365-filtering-correlation-id: 3fb8f1be-bed2-4f94-9af7-08dc74ba0de2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?53qj6pS/aowKMliAfYwuLzSAxEznC79+LTef/uNylezxMboP0vBbYRrtS0?= =?iso-8859-1?Q?3/41rRPFOWOHHOVcgRhJna9GLybAdc3zzgcOL81ozlxzXprNUk6N4sOaO7?= =?iso-8859-1?Q?KZ8v/XhqhjQUtIsmSXdwdu3jHukIrDzFsEYYnUA3jW0soC/JGx9K6Moe4n?= =?iso-8859-1?Q?bL7msfVEEbnPFOT1Qq5dq4gcUoTVN2Z5BUl5TheCgTo0sMMm7c0sPHfc8w?= =?iso-8859-1?Q?vsCPbMiWWH7kpvWP+KwgUChGX0PvxcmkBl1O8w0mfrple2i3nxElwgSJ4y?= =?iso-8859-1?Q?dqpdhJIRzKu4p1/Dnu9Q+F/5VuDeFhw0FmgZ9rRx5+f9aosJxJ7rsCbpdL?= =?iso-8859-1?Q?w/Xqq+eX89zWx+ZMWZhM3LHEaDkMdUCLgABGWtc3/3HBtX0SmR9SkCiJo9?= =?iso-8859-1?Q?BcaGeEFbNFWoKqdXcgwtgJ2ch32ViYz8MCAau6nu8xxZ3EI5+m6dB4jm4Y?= =?iso-8859-1?Q?CY4mq685Xm3V864vLM+DuJflhUz4W7EyNMOD3FFGv814qfcbdM9eBPQne1?= =?iso-8859-1?Q?XeBA3SK8pW2ginLAc+2DhCEUr8G6S1afsxe09Qlb1sxSOiIOaSZuDm9lPm?= =?iso-8859-1?Q?kXC2a6UjvJRwLGHtznsG1Xlz4Ba/81GRkenkL6JNbyqBZndEVB29YORIoj?= =?iso-8859-1?Q?5+o9B6ow4owD3vEGyKisB8p5y4axLa8KEihZn/coPK+ubsMrL+V68jXAVu?= =?iso-8859-1?Q?6xC/FdlcTe19G6N+Tm6J6M89vrU1jmlEsuNtJ9deXHZYGBHxNBo7rMgb61?= =?iso-8859-1?Q?Kgc9CDGM6DB6p8qa7II3aWnEkvyXGBq8WC6o9QJuMUduWodatNW/s5wIpF?= =?iso-8859-1?Q?bXDBvCm5+QSa78Riz6e21b++AqtMPN+yUG6dyjZ0kBF2Km0EqUkLNIpHMj?= =?iso-8859-1?Q?kJu4J0eqw4aM0XqbN6LMyezjGbYWbBGC1tecY6J0hwEjBuyfgB7DVqnsAf?= =?iso-8859-1?Q?aNxQER68ugPGQXO1yV7A+P92MK/Y/8JOxeizbQ6QzPIP3sTU08cd+yuaB7?= =?iso-8859-1?Q?Qv6OEsDiTwLHQGLMi8g2vv9OEqad1LcZiDJx/StRowNBdnmTbbUUB242Ut?= =?iso-8859-1?Q?UI/LlvIkNbvrA+/fe3zradVa7BxbRG3OmuGsiMQc3cgKXidVhakntUo+UW?= =?iso-8859-1?Q?2t8yV70mpuyV1RkiAm/B9GC4LMaMImD+Wl9loKA4ftfFSz42BLYNvr7yhn?= =?iso-8859-1?Q?we3GbIfES1CWimxIWTgxobaeMI971cSCgPyvc4oLNCAEXTdRzBCmmZYDt9?= =?iso-8859-1?Q?1qewgK3p+PBw6VhN0uhucgmLwvbRIyKE49i8gdifnGAmdyUoQX6a64UT9g?= =?iso-8859-1?Q?sxkmMMDPFLqkV8G6auDQOO81AnIYFHvVSr/j3R/nBWdU/JyzmaJmSsyMwC?= =?iso-8859-1?Q?0OOJxFt5Flm8uZvCxmcYKhhEh8bIQ1BQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?VluknRhpEBp+3omw8U6mzd0292MfgYyW6TuUIaV47yZcZvuonmqopXEnMl?= =?iso-8859-1?Q?MBvcRZ1EcwD90u9Yzkbpbrwv/xikF2C164n02ocmMjMrVbXe4f/Iv9Oqde?= =?iso-8859-1?Q?OqUsOWJPOPtMYD3kAJAIZ60HNmIZF0YP/S5OFCkC5lCBuCJSa5O/ek9k13?= =?iso-8859-1?Q?FA9zMi7sm8LjSBnxKaf0X4SlQi3wIs8W4O5K3ep5e9AUkPONLK0HyNWevd?= =?iso-8859-1?Q?dp+kEdwhEFwN9tg1ShARmu6uVW6oBwlIwYycrXknPU594T/Mkv2E0URKAY?= =?iso-8859-1?Q?cdNfn9mci5wdH92bQlfywomlfwZ0C6bbSoF4PJ/m1LRrrY2p/EzgJwalK4?= =?iso-8859-1?Q?FwVwZW9ok1xF1c4s+IvJcdB5WPilTY8QpuZ2SlivGJGIQAlKWLaSoTpaz2?= =?iso-8859-1?Q?eXXOgg8KRTbGi85J3y3DxtdUIc+w0PYkHjwpeP8OFu2r2wjngtnaOZOoWV?= =?iso-8859-1?Q?zwwNdF/GZ55NjU+fTmPL6JcKAqF8Z6Q4XDQv0R640G/rY4UUl7KyBz8zsZ?= =?iso-8859-1?Q?Pz+UHGqmyyY029N+g2L0dMhYqXVJMTOXdIvjWSf+UT2vPoAMzJl80c2/iv?= =?iso-8859-1?Q?kquMpyyj23TFORwoQDVsRvnw4bN6Fp9/MeEg/g5PmSN07/2tF5kdom9KOc?= =?iso-8859-1?Q?yb55Js78IQRf7NSK5RFZUXGSiogNUUp9bpHhGm6PmA0KGKgu4b+9NpCCoh?= =?iso-8859-1?Q?9HatpzkFvmmQ4es6xWbV51iDThQFl00d0fK/cbDkMkW8DyaFFLLmqklmd3?= =?iso-8859-1?Q?2gOUwpFSHWwX+0mz4BaxpVOH2yXsZJbMLkHb5q8bLl9QmXC8tUc17mdJd7?= =?iso-8859-1?Q?cvUjWSyhydtrQTsDurOCZlJlEQ9R/nT7iljHrbyH3YBHJuLcj2bQOjCqlh?= =?iso-8859-1?Q?rcXdBD1Y4p81Uor9PWFHgNkyZ0lANwwi5WvPNGXW7LvbOHfkSKyPqENAZr?= =?iso-8859-1?Q?3DoNEFYdMZP/IagyYPePJWd1AIsGpxcCGbYWei6n0sFwt+LrAtI2+nBZC3?= =?iso-8859-1?Q?Xf2dKy0KQ798sXTUF3TBIz8jrYNMdIL22HxHhCgx+ICoRzgDH7CaQ92BUd?= =?iso-8859-1?Q?LHC4Fk4d8HDdOaAg4HN5jkO2XI99hwxWLylERlcRg+kdnIsvDU7p58HoET?= =?iso-8859-1?Q?g5d9wMcGxVw+FvsKH5VQR2ebxaKezN+DkIbFrYmzIOf4zCTvgnLajuamsL?= =?iso-8859-1?Q?Oc7IDS6SN6queHI9l9bT8iLi69VgvLatvXqmQQ9grfeEcmEMB1T9DUki2z?= =?iso-8859-1?Q?zDQEnJh/RX+zPSC+AEX6lZ9fYTi5abFfHAm2d+blGkjMcrvoes//eCy+yO?= =?iso-8859-1?Q?oaAPB8POhTASHFdkxY7JeHaSeVaQ3ijwm7GfM6vHIJzZlQVbSBk07rfEBV?= =?iso-8859-1?Q?dQ9KRghXcdI0ZlIMmGNoLxxXHuizQxwOxwhgOGGfY7bqtypY+cYrSC3PtS?= =?iso-8859-1?Q?+WlRxXjuhkrulsVGcKwepskgyM9QVuC6MyvwfaM9QP5cftUTKJSqNpxfjQ?= =?iso-8859-1?Q?moeAXlG7nudzAK0hpZhzV8YvbZOiGNjXLyafpCawaQvldgf6mFR7oCtB8o?= =?iso-8859-1?Q?eVBFvfheOdnt4T3mmnf4xx5PqAQ7clNsjjhyl3+DrG6qFMWTfxt0Y1PhIV?= =?iso-8859-1?Q?9RzgAR4PlXCDk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fb8f1be-bed2-4f94-9af7-08dc74ba0de2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 08:36:02.4848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +P4CePOY0l/pl95A9XwQKDvbg3FYFIfTgDFx7RC8rehzfk64ER3iUIqKyPohPmAe44QxdMMmTckyyf83sXxfqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8391 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 May 2024 01:36:14 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9443JK2EhccbRYUVA0EU79S8x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82440E0207F3CDBDE7778E218CEC2MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=POCr8pQd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82440E0207F3CDBDE7778E218CEC2MN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable 1. The patch is too big. Can you split it to multiple smaller patches? > +STATIC > +UINT64 > +PciSegmentLibGetConfigBase ( > + IN UINT64 Address > + ) > +{ > + UINT8 Bus; > + UINT8 Device; > + UINT8 Function; > + > + EXTRACT_PCIE_ADDRESS (Address, Bus, Device, Function); > + if ((Bus =3D=3D 1) || (Bus =3D=3D 2) || (Bus =3D=3D 3) || (Bus =3D=3D = 4)) { > + return PCI_SEG_CONFIG_BASE; > + } > + > + return PCI_SEG_CONFIG_BASE; 1. Both paths return the same PCI_SEG_CONFIG_BASE. Then why do you check the B= us number? -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118913): https://edk2.groups.io/g/devel/message/118913 Mute This Topic: https://groups.io/mt/105572700/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82440E0207F3CDBDE7778E218CEC2MN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
  1. The= patch is too big. Can you split it to multiple smaller patches?

> +STATIC
> +UINT64
> +PciSegmentLibGetConfigBase (
> +  IN  UINT64      Address
> +  )
> +{
> +  UINT8 Bus;
> +  UINT8 Device;
> +  UINT8 Function;
> +
> +  EXTRACT_PCIE_ADDRESS (Address, Bus, Device, Function);
> +  if ((Bus =3D=3D 1) || (Bus =3D=3D 2) || (Bus =3D=3D 3) || (Bus= =3D=3D 4)) {
> +    return PCI_SEG_CONFIG_BASE;
> +  }
> +
> +  return PCI_SEG_CONFIG_BASE;

  1. Both paths return the same PCI_SEG_CONFIG_BASE. Then why do you check the B= us number?

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118913) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82440E0207F3CDBDE7778E218CEC2MN6PR11MB8244namp_--