From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B98F178003C for ; Mon, 13 May 2024 02:25:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hI/KVnpmeHUho8FJrNcnEXUMqIAmnGVhgsu1h3lxTko=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715567142; v=1; b=gVz85j/EPd9sMUPFyHwfcG0rApQdQMdR1dU503ezEM8Y2h9MSbdYnKmeHVVshjYmlaFBSAKt 2NutwuwnhLshdkxPuJNM1PBOYOYoCaimDEmSKtUJ6IPkblJkFqVDsjMemiZEeSyiaHpUA9NaE2f S94ylXBjKmiJBYmc7h8a++lfjEQtlK6LtkWtCS8VNjUgCAPFy6IvUUwj85xO8Jn16MrlChXWmsn Tfpuf2LwSAKJAUoF7nTE1ZAlK89s/nfoDnPN+Gdw0R1lZvpCtUct/Kq1mqbjTldFxeQo513yMhc 2Wma9OWTSWM6QmurR0mKxFZ3EYTgfRDYZ6uS50D9mlFIQ== X-Received: by 127.0.0.2 with SMTP id weMiYY7687511xGJ9UnPJvCs; Sun, 12 May 2024 19:25:42 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web11.51327.1715567141538791543 for ; Sun, 12 May 2024 19:25:41 -0700 X-CSE-ConnectionGUID: hrsBKVKeSKu/BTaR5buwcA== X-CSE-MsgGUID: FxZ/HbFfTxydN0+0GRsGGQ== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="22155314" X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="22155314" X-Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2024 19:25:41 -0700 X-CSE-ConnectionGUID: VI1Nnz5ET825hHGs2Nm9bg== X-CSE-MsgGUID: IZ+vYqUUR8WdhADQsAfhTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="30270576" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 May 2024 19:25:41 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:25:40 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:25:40 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 12 May 2024 19:25:40 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 12 May 2024 19:25:40 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ2PR11MB8537.namprd11.prod.outlook.com (2603:10b6:a03:56f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 02:25:37 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.052; Mon, 13 May 2024 02:25:37 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting Thread-Topic: [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting Thread-Index: AQHaosIleKbrnnpm6EK0eMhJfoBDJ7GUdBSe Date: Mon, 13 May 2024 02:25:37 +0000 Message-ID: References: <20240510100827.1903-1-dun.tan@intel.com> <20240510100827.1903-13-dun.tan@intel.com> In-Reply-To: <20240510100827.1903-13-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ2PR11MB8537:EE_ x-ms-office365-filtering-correlation-id: dadc6ae7-56c3-4dd5-11a2-08dc72f3f9ec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?I6ebRVCMwp2cEJNPE8OTC5MlWkvVGDG5YUyms9W2DGOcL/7kSJG2G+JL25mZ?= =?us-ascii?Q?ph5Nj7bFGj+HOysjPS7h1u8MNa4IDDHsCZXxLoWqbGF3i4hv+358q2WF8s5o?= =?us-ascii?Q?hrA7tcudFthPKlDn8GSYSXgIHvlxRrHZpf4eGa+JSEsx8mF90RTj2pd9obB9?= =?us-ascii?Q?rUXZMieZrxK2KPeqVQTSAZDMlk57MFu4DZR0EpuTAgwBbqWaVO8udKjQaEIL?= =?us-ascii?Q?l/kL09hZbTBWY+4app0rsKnojB+aKd750hwGH6VdqulE/K2CnuQg5ZBjXc73?= =?us-ascii?Q?gzxXIHE4P/mvRlzefVvhS28x2sUSxWEbXeOnN4lWT/uRH+cs3l/JA3BEXdIO?= =?us-ascii?Q?MSRk7aegCsx3KwWUuTTej8kh0ZK1mr9Jb1FGuHLZkGsOgC+XdLDTYFMIl/ms?= =?us-ascii?Q?hs3f+wf1W3SeK0WduBmUJgX0rLK3XFn4FSmRyOJ9qxYh6hzVN116dku3pG/V?= =?us-ascii?Q?dd9SuR12fbuITr6IPoJzc4XRmTZkzh/jSVSD5zuxGkAAnqKroarXfCbGCmMW?= =?us-ascii?Q?ldumTKthjBQLnIHwJnztSIvkwY4+hIBuGPq6iWyunZj/pb6skjo19Ds+YTL3?= =?us-ascii?Q?ddfROjD+dHiwXIzgfygSa/tRJzKA/weK38lW9z9xo4LXXoW5rx0czaXsnIB6?= =?us-ascii?Q?ISrQs8wl4RSIcB7D58+CMoQMs2gKzwShhTPZZ1tL4N2RsjF0+nAKZUFkXj1t?= =?us-ascii?Q?HzgPJNPfFdt5VABr4ZrCU6lwQHG0V0f8PWyONTjeOTQQ05D002jXIBY9EJnD?= =?us-ascii?Q?MUk7Smza9cFpp6g7x0scsK8VmvK9Cl0kxPlH40mf357wSGil2LyR/iRYlbjo?= =?us-ascii?Q?YdC2Fpm4qEZjdWy18sSTajyai0MfEsdgF9PSys3l0QyY7MBpk5wOrF+9/JsO?= =?us-ascii?Q?FuMpWzXDeQBh6fHhJrTh6air8e5rijMKB7XbXKs6QQOPtusPpx2kQoWKFURl?= =?us-ascii?Q?16Ae2LA/EUGowhT4+65zHBET5M372R7jSeeDLJT8vCVmVH/d/xxO3d6c79pB?= =?us-ascii?Q?W9yJTD66uWSulGRHbzYJHm1CHc/NPNYbaJ2O8ybKmC8xl1EGvJgfge7wQlQh?= =?us-ascii?Q?qt3HBNEJUw4esX1cTOGirnqbxad2YSGOZhCzBmUpu4DlY2XX1nuiDPeOBd4d?= =?us-ascii?Q?WfdJwDXu9ddyiGDCvbtRmZy2yZIOJgjSl4zU8ojyOnzRP2P8Mm98NvZKBVcY?= =?us-ascii?Q?3YTFp9HMOaCOrXflkn9gwSk0JvGHzm9nahUW+ZTb7r/UrBQRFww7x2M8WVJv?= =?us-ascii?Q?m3Zu8AFg/lWtcYp9/yiDao9URtYNwf+BlDKDkr0+tT9rrRCZ99zXhKPsUOvc?= =?us-ascii?Q?HkC3954+ARliMOJBiG9hWjLC5Q47W9N7wh8SR9ZxbSh3yw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hGeCMbT3T5hZuV8yU8qc0UkREDeAat+5BEyhE82J7B4xvhpaVaTH/T6j/kX9?= =?us-ascii?Q?9EwbBRXz4k8FT6MRFN/RxNOORE1vAlYWvaM3ZBGkoTx70YIwrcoY9iqT5DgH?= =?us-ascii?Q?Xg3uZlKFFOS/qZbksNI3BeYF7F2CuCKTsdhSj1t6+2KRCPdV9U9/BsBSrr3P?= =?us-ascii?Q?6ZH243gocjdadzL1grpJhgL4zHwRfNuQkzg1Zus4PKmOQotrSfJLnQQnv65Z?= =?us-ascii?Q?WqOGXV2ov0QIwLni8hT+33oszjOaQoF4gLT5hMKJqHbe+nHp6kZXg1qll0Hr?= =?us-ascii?Q?oZWJD9UYvxciYHPDZmo6DkX7fb2gYXACEwxGKGRri5eVmmiJYA8sogBXpUXR?= =?us-ascii?Q?JbYeefa45atjFljc6yWoDxPRCFHgBCwM/cpEsFfnpgopyhzMA7NHX8CJPWhw?= =?us-ascii?Q?gp7t/u8l8tcXxy4cA4uHYqeHAc1jj3qwx4CifXAxHMBblrSdvMXhXHqLTm45?= =?us-ascii?Q?E/q+4OZ/O12cMTm1Fz2N8XMCrkrcIyEhxBA033dQU5h3lPVP2KGjMjNol9m4?= =?us-ascii?Q?3b/53QUFJe6ljBgORoEo+KOCwcdz6Fo3PC7uk8l3kODupZYk7IeftVz4G55j?= =?us-ascii?Q?b7Zsq2mweGvZkAUMZxX1hz0IxzsZkrzhLArRMsRMzYTwhYTJjBTqgh0ZDDyv?= =?us-ascii?Q?OvOXzp1PLwQrR1/rHXFXB8Kcj53yjD+qbMXkHRVln9sArTSEmdQjx+QiKDRE?= =?us-ascii?Q?tjSbMzgc9nj3hdQeUgqZciTfJBXxJHZ5UZsShWg8oAm0vbuejA7bXkvvCdCr?= =?us-ascii?Q?NV87M+jcZeaM0PECsuOswhXE7zFPsk/4cBqu02kDxmv4d6wthatcZAXRrC9K?= =?us-ascii?Q?sxbOXqOU3Mi58CdNNSdLXHkLFj25jd3VNvZEeEZBzzMrSD+IaPuVPP2oH/eS?= =?us-ascii?Q?aJLJsj/YSlLMuhVfIHEGF1vRsYdpYotemSYrmt06Gdvk0D762PSe6gMH44C1?= =?us-ascii?Q?WX+5t354H1a7KAEDeeH1g7ELQ6FP4oVz+uLNbo4wXirkS2gM9P5FxzqcjfCt?= =?us-ascii?Q?NzxP6iKw49UmHqSBNFVBo0YrKmpQV04icfDehONH5cuPyp5g4JGrK+WVyArB?= =?us-ascii?Q?JYi/BZOY+1sziheV8MP3JfrxVXfIWysQoD8zZPuF/52I4RuU5MPPT72FLube?= =?us-ascii?Q?1/KwD8spmX1935D7ygVwIrL5EfyUwSNv0GGGSMQ1hw0pi5aK7y7JJqwYZohD?= =?us-ascii?Q?zrSNZNBes/kIQvGPWoEqWWOd4MTK2kk3ZfxXAFVLYmQblwb7ett1ioOj2pwe?= =?us-ascii?Q?IGQlewCQ/CUJOdj/TX5KGl3dFuk7U5JiVBb0L0BcrIwidMx/twAURPAJ26wJ?= =?us-ascii?Q?4LyzOcosnP6lUEjZVzjQmsUu5czr1OAGEp4G+so66ckjp9KBvIPX9UUUNcDe?= =?us-ascii?Q?UbwJAaYVEQ5CI1S1k8ZCtYglGQnnU/dsNiGl6n/zxoriGPirccvCg3npjZLR?= =?us-ascii?Q?n4gfUbeoNc4VcPt01Mjs9xF9DbSmQSK+j1Ru8g1/uDdwy9X6AkRqEkFeVZEe?= =?us-ascii?Q?hNLvRKgw7be7WFIa1nW9A5oH6b99Ng7vMwW9Gx84+RsnsRxSCS3YzbOKBAsr?= =?us-ascii?Q?07/1EAAERrDmjjsv5Oo=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dadc6ae7-56c3-4dd5-11a2-08dc72f3f9ec X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 02:25:37.4985 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z03PdfkvINor+bKNBphivpoIfkPhu1tuVQ/8JftvfxwkvJd4CgzVZ7GRSPFTPWuHiNIy7RVKx574dX1srNYLwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8537 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 12 May 2024 19:25:41 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8mPQrLFlCD50Hi3IxuzR7HmQx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82441268ACE80F8E6E99E7428CE22MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="gVz85j/E"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82441268ACE80F8E6E99E7428CE22MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Tan, Dun Sent: Friday, May 10, 2024 18:08 To: devel@edk2.groups.io Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Ra= hul R ; Gerd Hoffmann ; Wu, Jia= xin Subject: [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting Remove code to load mtrr setting in CpuS3.c. In previous commits, before transferring to CpuS3.c, MTRR setting has been loaded in S3RestoreConfig2() for all CPU. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/= CpuS3.c index d67fb49890..7ac6b62676 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c @@ -91,36 +91,6 @@ UINT8 mApHltLoopCodeTemplate[] =3D { 0xEB, 0xFC // jmp $-2 }; -/** - Sync up the MTRR values for all processors. - - @param MtrrTable Table holding fixed/variable MTRR values to be loaded. -**/ -VOID -EFIAPI -LoadMtrrData ( - EFI_PHYSICAL_ADDRESS MtrrTable - ) - -/*++ - -Routine Description: - - Sync up the MTRR values for all processors. - -Arguments: - -Returns: - None - ---*/ -{ - MTRR_SETTINGS *MtrrSettings; - - MtrrSettings =3D (MTRR_SETTINGS *)(UINTN)MtrrTable; - MtrrSetAllMtrrs (MtrrSettings); -} - /** Increment semaphore by 1. @@ -554,8 +524,6 @@ InitializeCpuBeforeRebase ( IN BOOLEAN IsBsp ) { - LoadMtrrData (mAcpiCpuData.MtrrTable); - SetRegister (TRUE); ProgramVirtualWireMode (); -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118843): https://edk2.groups.io/g/devel/message/118843 Mute This Topic: https://groups.io/mt/106018137/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82441268ACE80F8E6E99E7428CE22MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
From: Tan, Dun <dun.tan@= intel.com>
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat= .com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Hoffmann <= ;kraxel@redhat.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [PATCH 12/18] UefiCpuPkg: Remove code to load mtrr setting<= /font>
 
Remove code to load mtrr setting in CpuS3.c.
In previous commits, before transferring to
CpuS3.c, MTRR setting has been loaded in
S3RestoreConfig2() for all CPU.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
---
 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 32 ------------------------------= --
 1 file changed, 32 deletions(-)

diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/= CpuS3.c
index d67fb49890..7ac6b62676 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
@@ -91,36 +91,6 @@ UINT8  mApHltLoopCodeTemplate[] =3D {
   0xEB, 0xFC        &nbs= p;     // jmp $-2
 };
 
-/**
-  Sync up the MTRR values for all processors.
-
-  @param MtrrTable  Table holding fixed/variable MTRR values to = be loaded.
-**/
-VOID
-EFIAPI
-LoadMtrrData (
-  EFI_PHYSICAL_ADDRESS  MtrrTable
-  )
-
-/*++
-
-Routine Description:
-
-  Sync up the MTRR values for all processors.
-
-Arguments:
-
-Returns:
-    None
-
---*/
-{
-  MTRR_SETTINGS  *MtrrSettings;
-
-  MtrrSettings =3D (MTRR_SETTINGS *)(UINTN)MtrrTable;
-  MtrrSetAllMtrrs (MtrrSettings);
-}
-
 /**
   Increment semaphore by 1.
 
@@ -554,8 +524,6 @@ InitializeCpuBeforeRebase (
   IN BOOLEAN  IsBsp
   )
 {
-  LoadMtrrData (mAcpiCpuData.MtrrTable);
-
   SetRegister (TRUE);
 
   ProgramVirtualWireMode ();
--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118843) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82441268ACE80F8E6E99E7428CE22MN6PR11MB8244namp_--