From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5672178003C for ; Wed, 21 Feb 2024 05:46:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vSnVcThwWOfzq3meRPwg3OrTNmOFDWYTPxYUn4J1/ms=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708494368; v=1; b=DaCbYFR5XcSnlVSKVz1QY2yJNwvubLMViG3mV+T0+Llk/Ega69yWvRW+nu7tI35fc2VimQHr bBvV3rEWeH26M9Lrb47J0R7QBQeWCd+xEHlbeodACQ8pgXN7O82yGa5oL/EBGMxea8g+cvgftZw T48QgcQWCQGgIEF9AEaXbt24= X-Received: by 127.0.0.2 with SMTP id QY7rYY7687511x7hQpcAGsrO; Tue, 20 Feb 2024 21:46:08 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web11.6889.1708494368014990412 for ; Tue, 20 Feb 2024 21:46:08 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10990"; a="2749862" X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="2749862" X-Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2024 21:46:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,174,1705392000"; d="scan'208";a="28173237" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Feb 2024 21:46:06 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 20 Feb 2024 21:46:05 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 20 Feb 2024 21:46:05 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 20 Feb 2024 21:46:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NG6d6uNLZDCXPWGrEn1uVAWstapfEhJWWcBTpvr8F5Z3lI2SLn7T/z0rZ1fEuJ0O5VmrtTW2oqxW1B4qLSYWP1W30r+TemPBB/YNuHvkbtYm2Ck6ozJExWcyanZeaXeABRYoNT3qLPDVcNoyltXcQu/OTYul63dVknbiMXr85ktNJRViqnuzK6eum/zAflCAkook6a7ST34VTZmE8RoBL7/fPJXG1I+1g1ygNR0OsO9BuIf/P9dUOcnYvXMxG/fVm6RIgSbMw6zNmtS6yE8ntbWFSxe4M96WC26MyNv6avnzVly/DXm3WuwPTRrjgHerVfuVd8dwxhuRBh298CXrJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e6q7G5YEJfK9KU16ynU9gCqtpMDlmMhLt6KmgyyPRGg=; b=UoVelEVwGPWqZgTIuXtqNVAZUnfmZFQrYy63U3NOhbITYHWmMOMCBXyGDGYna82ehQU0qk+q2VwEGV7Bw9S0wErjA+Lq59DiT+dvzXGLMaJb4S2CqrcTY7ADe6uRg1roa9xUMCoCNdrm+lru99EBRPjdpBiNOA953rluJ4m95wll7sFnVWqA5LdWjOsLtE1RMvHDk1T2F3PKeqQGCOxwO0GolLqXjVtGBJAjfzX/adg38C0NeEgeuUobpep3arkeE9jPqwk8Xd1EN8AzHHVbcrIjr4uV54hwPL3tDJOGZjUDgITfaxXrS5TWdGDMICUzIlWz/laNxIq0DM/aW7ACYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH7PR11MB6554.namprd11.prod.outlook.com (2603:10b6:510:1a8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Wed, 21 Feb 2024 05:46:02 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf%7]) with mapi id 15.20.7292.036; Wed, 21 Feb 2024 05:46:02 +0000 From: "Ni, Ray" To: "Zhou, Jianfeng" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN Thread-Topic: [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN Thread-Index: AQHaZGTHR72z1UMozUaqmjNvOWPF7LEUSXIw Date: Wed, 21 Feb 2024 05:46:02 +0000 Message-ID: References: <20240221012441.27406-1-jianfeng.zhou@intel.com> In-Reply-To: <20240221012441.27406-1-jianfeng.zhou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH7PR11MB6554:EE_ x-ms-office365-filtering-correlation-id: 12b8232f-933b-40d3-3cbd-08dc32a06394 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: i78XTcEArNzVZRpcPJ35JWGFnTAY8kE1F6F5vtE85grVD0H1TgQlKzKI3HIN73IphS5jrqoAg26tUI6nPjsrBwl3/CPavtmK5M/NHnJ2RmVFhMDwyESYPYUh96mBPcwjNPC9BZtZdnEiD+c2gmz2ff5CSaQhxi3SxyDxr7i8/INgyT80O7FHp+HgnyHs6BGkN9oOTSv3/swNUj495kAdmZcJdwGGoHe80u/oZd9Rnfb3UydK/FOZrZ0/oCAH6pAR6eSL6FsvvmvgzBFyrtrTVP/PBZOOumDda8RN6OmlW16sU1AuDsyD0Xn1x2/b1sFhcj1bc+Sy8YRDfQiSPeakocE5c0fCfkTwpiEkSUvMySQlf/bnchg3i/Q7YtzUQQOuaeKq2uUoJ6ZZDHhJLMI/lfUc2GN7ubVtpDHzruIJfDSi9BRPYIg/ICghp8cpFHnLTkkQrUXVCcqG1yXTAc4gxO8dfPwZq+MCvtLDsuNpFNfK+OCWI+mbxCf3/tPiyklsOWIyeOlFjyd/jmdUxQuxKL5UZ/yXkBI3OMEIpOpXBYGkAtYxacfbtbGR4hEPZtnUIKBMmeI6b/sP+1/QA1w11PQA3VteicQVm3av3TpmlUuNfBQSJNz+10ba+uy56AKE x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+SEgGfzVZXrE72PB3JqCJEuZiE6PYtZZr9A+b7BfdF2Tp7lm9sy37u4v56pX?= =?us-ascii?Q?4zVAm39Oi/y+Fi79S2k+CtrwyEKw3BD6aqadtb442siR8lIoqwW7P9rmFL0T?= =?us-ascii?Q?ybVep3KI2KuoOO9/PzqBhXtIR+ix7+acUVhBjGffsNIDfqbNRARDIoIK1s4N?= =?us-ascii?Q?NPbdjsZWU5dUKaemLdbHUs3Ra6jx7c4OuLtZF28V7M6+qVg/xdQzsAKMZY57?= =?us-ascii?Q?dYXyNd5iWrx1t61esbMLf1uBVZAWBXzi1l2XQa7nxT6yNvy9OIGB5+UE5d/7?= =?us-ascii?Q?RgAn/0+KJ4lGRJGnhe/U1i44YGxAQwXPkKYePlKC73ONWo71HCsSYWud1Dq/?= =?us-ascii?Q?I8ii84WhIx+T2rGNXrdHj/8lEPniKpaMpYmC18bfRaSo03uux0nyhwQ+rphW?= =?us-ascii?Q?a6kCcdoIpmFSmN9180SDgE3k/XVP2jMULfUFe6jx2dZTB289FaTZIIGV6O+K?= =?us-ascii?Q?iXsbfwrUp2p05qvezyYGh/4zSFon40Hn/rz6BUXCbY7wOBBWKkwEj874irxq?= =?us-ascii?Q?omwvftTH2GYJ027twKqtV2EaCRYpVSa1TJwEG3OQH9O57rcNI7+POM5kGT3H?= =?us-ascii?Q?e5UuF4sAnSbMkgmfrodmSawayUViZpqImcSTu+q5+dVo/n7h3Q1YRjD7LrcL?= =?us-ascii?Q?hSUu95n7G0d83xNzzLTgDpPzfdHGDYJfQAxmzmb7O5T0Zf8HB11IaKPeIlpy?= =?us-ascii?Q?2CqvwGaKDhNuX74L310cg7z0ne7fpOQLbX2RKvojFwptRTWFOmOO9qkFqrXt?= =?us-ascii?Q?deWtQIRXNIRlpFXip4JRf+GZ4wvPY0+eXwpQQaAkFxwDunMCU63K3AayBQIu?= =?us-ascii?Q?zXVhEdAOu1Pc4kcYd2IYpDXHxSROqJ9KV6p2FWNpHlfVc1u9rJdoUcDNxvNw?= =?us-ascii?Q?Ko2iy4Duce3XJTIrkBuV0habbXrN81wwv9QCUT8j3uqJwyVRnOgv6fOIrtTd?= =?us-ascii?Q?zfd7qlev58blCQapcZb8naY19ht1wVI6UTSedOMzkHcOqSpeGz066MkxSmXP?= =?us-ascii?Q?gxjap7zbv7ShKbX0nqFMizYBm0Ms+7ZMGkVBV9B9iSRHyNDq0EHnIv67JmI6?= =?us-ascii?Q?CVx6u9vPnQ6+4SNpKSZ9qRuFSFUR2mvUDBwdlL3G4JLJn6EzCoNTCzdCdmPx?= =?us-ascii?Q?ifylM8eoL3QET5gjaAZX290AK6aIFnRpMeKVyrCt7tQlRut4uiS9FzxZITRq?= =?us-ascii?Q?hXGT5L969C1hCPogBov575yHKVTkdIEunfFANt/g4fM/tYp2mSR5WQwzCmnD?= =?us-ascii?Q?gjphUim6AeeuDwYZkK0nHyg/4kdzD9cS5Jr3BqmUZbbMNs2UVCCRXigftD+I?= =?us-ascii?Q?8BlW0mSuIh5ZZzGS3w9tddre8fBsT35eMTuKjMGDtu9Ykzyf7PEThFrvygCM?= =?us-ascii?Q?S4emYYC3KL+KoZITdaSFWiKAhxe1YrOcxMi1EsmbZJP66k4GF1UzLpSLJ2jO?= =?us-ascii?Q?sly2Apm1OdyGn0UwMSXr0qupzpF3DmL9iZ/rq8XCS2MLcVKKEbAky63UqgW8?= =?us-ascii?Q?l8ydP/Wkevw0KKhvdTJJhznPB2J3IvkqdN/QgXggvDSSVWFhTdG7l2pg5f9G?= =?us-ascii?Q?2otCUm4dp4jQa4iMmkQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12b8232f-933b-40d3-3cbd-08dc32a06394 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 05:46:02.6058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KugU/N/KNhe9q8zRPyeg9/0I4wQ4wsts/ARNd7eK00E0IDVZeziESQ+nS8uOcrO9OJ3qbaCJmP6dNifZQENj/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6554 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Pu5rSytMyzLLl3sW3ss477K3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DaCbYFR5; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Zhou, Jianfeng > Sent: Wednesday, February 21, 2024 9:25 AM > To: devel@edk2.groups.io > Cc: Zhou, Jianfeng ; Ni, Ray ; > Laszlo Ersek ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: [PATCH] UefiCpuPkg: Fix IN OUT parameters marked as IN >=20 > Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as > IN. > "IN" replaced with "IN OUT" in the following interfaces: >=20 > PageTableLibSetPte4K(): Pte4K > PageTableLibSetPleB(): PleB > PageTableLibSetPle(): Ple > PageTableLibSetPnle(): Pnle >=20 > Signed-off-by: Zhou Jianfeng > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > .../Library/CpuPageTableLib/CpuPageTableMap.c | 32 +++++++++---------- > 1 file changed, 16 insertions(+), 16 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index ae4caf8dfe..2ea40666cc 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -20,10 +20,10 @@ > **/ >=20 > VOID >=20 > PageTableLibSetPte4K ( >=20 > - IN IA32_PTE_4K *Pte4K, >=20 > - IN UINT64 Offset, >=20 > - IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > - IN IA32_MAP_ATTRIBUTE *Mask >=20 > + IN OUT IA32_PTE_4K *Pte4K, >=20 > + IN UINT64 Offset, >=20 > + IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > + IN IA32_MAP_ATTRIBUTE *Mask >=20 > ) >=20 > { >=20 > IA32_PTE_4K LocalPte4K; >=20 > @@ -94,10 +94,10 @@ PageTableLibSetPte4K ( > **/ >=20 > VOID >=20 > PageTableLibSetPleB ( >=20 > - IN IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB, >=20 > - IN UINT64 Offset, >=20 > - IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > - IN IA32_MAP_ATTRIBUTE *Mask >=20 > + IN OUT IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE *PleB, >=20 > + IN UINT64 Offset, >=20 > + IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > + IN IA32_MAP_ATTRIBUTE *Mask >=20 > ) >=20 > { >=20 > IA32_PAGE_LEAF_ENTRY_BIG_PAGESIZE LocalPleB; >=20 > @@ -171,11 +171,11 @@ PageTableLibSetPleB ( > **/ >=20 > VOID >=20 > PageTableLibSetPle ( >=20 > - IN UINTN Level, >=20 > - IN IA32_PAGING_ENTRY *Ple, >=20 > - IN UINT64 Offset, >=20 > - IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > - IN IA32_MAP_ATTRIBUTE *Mask >=20 > + IN UINTN Level, >=20 > + IN OUT IA32_PAGING_ENTRY *Ple, >=20 > + IN UINT64 Offset, >=20 > + IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > + IN IA32_MAP_ATTRIBUTE *Mask >=20 > ) >=20 > { >=20 > if (Level =3D=3D 1) { >=20 > @@ -195,9 +195,9 @@ PageTableLibSetPle ( > **/ >=20 > VOID >=20 > PageTableLibSetPnle ( >=20 > - IN IA32_PAGE_NON_LEAF_ENTRY *Pnle, >=20 > - IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > - IN IA32_MAP_ATTRIBUTE *Mask >=20 > + IN OUT IA32_PAGE_NON_LEAF_ENTRY *Pnle, >=20 > + IN IA32_MAP_ATTRIBUTE *Attribute, >=20 > + IN IA32_MAP_ATTRIBUTE *Mask >=20 > ) >=20 > { >=20 > IA32_PAGE_NON_LEAF_ENTRY LocalPnle; >=20 > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115711): https://edk2.groups.io/g/devel/message/115711 Mute This Topic: https://groups.io/mt/104483605/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-