From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4EB6CAC085F for ; Mon, 13 May 2024 02:07:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9mF0AU2zsaKh2Rk+yLi4v9Pt7PThKrxSA/7W+GK+hRo=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715566035; v=1; b=juwzDwkluT7oCZ3m7ekdlJIEXuI+U2B1CadzxoGqMX4hEEBYpmSSnRmvx19GJGF68XZkK02M 1NtN8KvzVE6e4qzvhR4iQiNvxShjJfL72Ce++KOls9LWidIb70pJJfX5B2AHbUxEZjglVzt2ozI yncPEE4P4aeCzVaFyGPPUDRCYCDtOaNxZEJQ92i2Ga36+Mt9XazwlAIjjklgG+4jS6BRBgrk5kf TAXIZsf3RkPCz2gWEdnnA6Ql+Gk/1k2euGYJwaz8abZE42f+CyGnA933j05+Fh1zg4zYFz5QAaE EzdhdeDRM7OGVtjhifuZ/YuTilny3F+4Mr5YQ/EYTp2pA== X-Received: by 127.0.0.2 with SMTP id thRUYY7687511xfZhRPgos62; Sun, 12 May 2024 19:07:15 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web10.50832.1715566034280971352 for ; Sun, 12 May 2024 19:07:14 -0700 X-CSE-ConnectionGUID: 2QfMj9YiSMmJlx5Intq/QA== X-CSE-MsgGUID: TAVQqekaRB6SKdmUDabVEQ== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="11640660" X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="11640660" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2024 19:07:14 -0700 X-CSE-ConnectionGUID: 2EmgzOaKTrmGHTve1MHsEA== X-CSE-MsgGUID: meg6yIjtRkSquhf2A3fWDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="67675932" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 May 2024 19:07:14 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:07:13 -0700 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:07:12 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 12 May 2024 19:07:12 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 12 May 2024 19:07:12 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MN2PR11MB4584.namprd11.prod.outlook.com (2603:10b6:208:264::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 02:07:10 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.052; Mon, 13 May 2024 02:07:10 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Kumar, Rahul R" , Gerd Hoffmann , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH 06/18] UefiCpuPkg: Remove the duplicated mpservice locate Thread-Topic: [PATCH 06/18] UefiCpuPkg: Remove the duplicated mpservice locate Thread-Index: AQHaosIbBLjcSUjUHkKlFepGk/F2l7GUbT+f Date: Mon, 13 May 2024 02:07:10 +0000 Message-ID: References: <20240510100827.1903-1-dun.tan@intel.com> <20240510100827.1903-7-dun.tan@intel.com> In-Reply-To: <20240510100827.1903-7-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MN2PR11MB4584:EE_ x-ms-office365-filtering-correlation-id: 7967db1d-982e-4606-bd97-08dc72f1664c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?emG742Q0jS93jPjmK7/COd0TX4bKz4QDESqxJ93yuz4QzysPFQHTdbd5NS?= =?iso-8859-1?Q?QbZBRGl6+wXtH5RWPill4S4v7KWrSO0GZkvyV0KjeiCF551ug4uvc42Prn?= =?iso-8859-1?Q?piEcyfWDGwblJs6J47JiYXPE813R+JDPLhYi8nA2rNo1TpUIFqG1/4DSTb?= =?iso-8859-1?Q?MB4doI/IMMvOAGlMdxstAumoBqBFmnt+jb/YTh+s8FKbzEoXKLDLcWVGUr?= =?iso-8859-1?Q?X3msWwQw7ILUkj0pwp5WjHrCQdDjnId2fysxsC6LTWISULEzzE66j3G9Py?= =?iso-8859-1?Q?L6XvlGDeMeEcbNtpjB0hwvwCGkSTYuSWdaDraq64SFvLJ4q8LXB0FeHvoX?= =?iso-8859-1?Q?n3K8QUVXHmpOK63NYk2q4ene5MG9yjtlrsAslxaGYek3R30y3MK/VCExeA?= =?iso-8859-1?Q?xzAA0wxf3k34n+BgYujnSFkGuY57sR2dhpCVvmtANz+zkN4Fs8+HeTSFSs?= =?iso-8859-1?Q?nphlBLC5V0+lvsiBN/blSTWyYGFNyCQbRcFJiMZPsaYcc6bmA0N4CF6xj8?= =?iso-8859-1?Q?wGyp00vkrcSq6lzwzGNbRw+t2l+wTw1u8WO2glsyodF5NPIQAUATVWUDyp?= =?iso-8859-1?Q?DC4zRJKlwEY0c4XJiTCrMl2O7a+aCmdoMX7z78rBCB145+mqToLNM4Y2b6?= =?iso-8859-1?Q?IGDy72UsIOW1WgNTwEshlPmX5++yxEKZcQDl7MHSL1NsfZNOqvrskMRxMP?= =?iso-8859-1?Q?7jEnj2wwUwRyFkOhwEIy7x54PGDGUM59+cIVl8xF3/euXJUcuUCznwNfd6?= =?iso-8859-1?Q?dK970pdmDrqCTx40JtctHggidD69aTIA/gDFTA1UEINPlNWS54VCtb3/+j?= =?iso-8859-1?Q?Q9VHZZkYXpxhZbIIcLVsf7tp1L1i7a3oi9dpV5epzEVxEMvLYN0fVm5bNA?= =?iso-8859-1?Q?eW7FAy3cWpkULwpHjGp1k2AK4JvkAMEIpAO6Ktg+j40HlOcr/gElD9nqP+?= =?iso-8859-1?Q?j44F5Cm/+Q05zS4Hva0Zi+CMQj6q1lqwk4RB4g0ora3iIzEVLj1sCPone5?= =?iso-8859-1?Q?e6dckAv5zDIR9xnZK7j+CawyD4v1yHZQq1j1RCkhOLtRHY2RoRwk5AEEec?= =?iso-8859-1?Q?xa/loxpSrC0rZmYe/lYaDVe2i3mIGYmspRUQS9UJRZjhNB9de4yOKU9FYO?= =?iso-8859-1?Q?RHodG6IQE9lOpLrEWaOsDC0Y6izGER9amacL7Bi41Qsswz1u0czyUg+v15?= =?iso-8859-1?Q?W0hqVuwANPjDm9U73Z5BkkvbVdkdUADvkaa4q+jt+QN58dqAW67sOXDJGi?= =?iso-8859-1?Q?ZzBnGlPgybAJUdMcaSUduvh8yraH6Omef/39h6M1SRbavyLxDJ1VxjwwVm?= =?iso-8859-1?Q?pOuz++3KHCzN3Pi797T6t7BYP6J4qZE0B3VpPUZ/Db0HH1GOMnnJcGFkgQ?= =?iso-8859-1?Q?PeAhtxFxKOwbF22WphtHXnzBZ0BAt7Sw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?jslhDYqI6tYiTd46qT0uHiRWVsQL3yQ6vx95+3JCX/+5wFsPRro2WpAwqN?= =?iso-8859-1?Q?L0jlJ1eIyxvdJOe8268Bjx7hPlHV7xtpdSEpOqzxodhj0nK3fSO0B24HZN?= =?iso-8859-1?Q?eiQAM70fcNO2G7bc0PoOm4vrENM1yxoepAlDs1+4sFgMimymSG58uhn6PM?= =?iso-8859-1?Q?ktBNNhH9EmLzvKZZNn+aFgHSdgIFTnNIkLv9JK6wX708tsu6C98d5o+LOv?= =?iso-8859-1?Q?uukOCocIt8icJPA5VkBxZsYFZIsVBWrOLwfRIaBzzwp/r0Sd4MMsVCVft8?= =?iso-8859-1?Q?glATi6kk+kQfBVaahIqiG+l9kQo/fSP7xfLJKBvD6usBUn0IydE+DjuM6v?= =?iso-8859-1?Q?h2gFTLWwTwe4ASv0oypNjtvwyF8j+vIVLM0qEapFrmoC0PZad213rJ9ZGw?= =?iso-8859-1?Q?6ureWrvbEwAog37nQGBAwrmVammZLuQN/faXeHIuNdMapaIpq9662NOJDe?= =?iso-8859-1?Q?y4R6W6pPUXIkTeHZiE6LMUKN/Jq0ti3ZQ+qzxK/DWdOPZp0tYnbHb6vw67?= =?iso-8859-1?Q?gTFWT/SwyOnVfPiB8zQ1pqlv4vBmRL2cP7a/ZTBDsMK7dgV610OJYrnZQl?= =?iso-8859-1?Q?1nmVGFbZuF5714JbO8SiajzOkrDn9UXQ1W7dkDuejMdBN79+43NBmnxL8B?= =?iso-8859-1?Q?lWB7r8+9Xndesfw5VyON78YrHXsvdNwP2AQJO2SCkDq/vEIRoMyN5lGKWv?= =?iso-8859-1?Q?EOJx8H1fI4CI5KPgNCorkcCCF8M1CM/doX0grkU4wkny7bmb82uSRD+/y6?= =?iso-8859-1?Q?OB2elSbMgn571rceRD30pdDFnBypMrHC1MJ6ME3SnuiJlskbEonWVWy3E4?= =?iso-8859-1?Q?zUeyFyB7RnV/Z+uc6cFlCB+FFeB1qH0R+cj51XcH+R+SvPjZdFpGN+SV0+?= =?iso-8859-1?Q?pt9oI36iqCeLlg1FxFzw+x3AKFKrUxxFcBp2jk0ys5uoS0m1gJHA+ygjLW?= =?iso-8859-1?Q?Jk4FhRJCWhOjjdLQWTNAoB5dSHd1UMcZ5DMtWg7WxVY/c5siV42o+D770r?= =?iso-8859-1?Q?fYqzi6kVT4GBAk2yTQXL8+9bNr9T/XQiEpmr8L76hb+kZd+CoFcXvjsHwZ?= =?iso-8859-1?Q?/pOaHbBocSrjcKwNDamiP2ltABT2TdqIuaZkUm+IklEaQUCsdRPW2tT8fH?= =?iso-8859-1?Q?x30WSa9KGPwLET3j1HsfkYazZQuB4k84Vj5OHFknUVr+7tvc1csU5FNUDe?= =?iso-8859-1?Q?bshwNjyHLbKqP+RxXJHU4veT6yMW+7xB1MiQSG9oUuQw7IUysl1eJiJl5m?= =?iso-8859-1?Q?ekMrG44FDIX9VXTaIa3Sweg0h+dLEekrvVPZNTISSHiL7hadypcskG/z6E?= =?iso-8859-1?Q?bZGv43HBmYTvWi7ouWTLfKjXTJu7NxkDB8qZD4rSpCtGWL2g8UN4TqS+gH?= =?iso-8859-1?Q?wyLVBu/tfcieO7W9N53to21gI3gv2jEvICGXX8jWCOHWH4zRBeidWVFM48?= =?iso-8859-1?Q?6twjNB4a9VJaU90LtmPeNoJP8TaoADTO9zUsaTDGU3MAwvFIMB11L2aVha?= =?iso-8859-1?Q?HF/7+Fdee0wy/xNAdSddW4fAn97dHB/8KoppO7ysjzclKiQCbAw9h2M/aN?= =?iso-8859-1?Q?9mtDrq86ovAKdgpnukUP+KgWZn+XdyzB17sxrtSHrUglFFc8OJC3C4FgFn?= =?iso-8859-1?Q?zBlhawLxWOukE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7967db1d-982e-4606-bd97-08dc72f1664c X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 02:07:10.8170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iAkqxaVkXr4iy2wW7rSO8qHr6CYI84G0N8bIFjXG5UW2BDd8oIXBK3SZ+gR8f4dzybW+HBpfDXC9cX18ufeKzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4584 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 12 May 2024 19:07:14 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UdeuvwXTotQmlaNU9Pe8Hy5Jx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244161E5E376FC1F174E7518CE22MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=juwzDwkl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244161E5E376FC1F174E7518CE22MN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c b/UefiCpuPkg= /Universal/Acpi/S3Resume2Pei/S3Resume.c index 3e85eab28f..a8e9c92a93 100644 --- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c +++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c @@ -1139,7 +1139,6 @@ S3RestoreConfig2 ( SmmS3ResumeState->ReturnContext1 =3D (EFI_PHYSICAL_ADDRESS)(UINTN)= AcpiS3Context; SmmS3ResumeState->ReturnContext2 =3D (EFI_PHYSICAL_ADDRESS)(UINTN)= EfiBootScriptExecutorVariable; SmmS3ResumeState->ReturnStackPointer =3D (EFI_PHYSICAL_ADDRESS)STACK_A= LIGN_DOWN (&Status); - SmmS3ResumeState->MpService2Ppi =3D 0; [Ray] MpService2Ppi will be random value with this patch. Would it cause an= y functionality issue (e.g.: CpuS3.c incorrectly invokes StartupAllCPUs() from the random MpService2Ppi) if only patches 1~6= are applied? Maybe you can add a ZeroMem (SmmS3ResumeState, sizeof (*SmmS3ResumeState)) = so the file does not need any change even after you remove the MpService2Ppi field. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118833): https://edk2.groups.io/g/devel/message/118833 Mute This Topic: https://groups.io/mt/106018127/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244161E5E376FC1F174E7518CE22MN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c b/UefiCpuPkg= /Universal/Acpi/S3Resume2Pei/S3Resume.c
index 3e85eab28f..a8e9c92a93 100644
--- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
+++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c
@@ -1139,7 +1139,6 @@ S3RestoreConfig2 (
     SmmS3ResumeState->ReturnContext1  &nb= sp;  =3D (EFI_PHYSICAL_ADDRESS)(UINTN)AcpiS3Context;
     SmmS3ResumeState->ReturnContext2  &nb= sp;  =3D (EFI_PHYSICAL_ADDRESS)(UINTN)EfiBootScriptExecutorVariable;      SmmS3ResumeState->ReturnStackPointer =3D (EFI_P= HYSICAL_ADDRESS)STACK_ALIGN_DOWN (&Status);
-    SmmS3ResumeState->MpService2Ppi   &nb= sp;  =3D 0;

[Ray] MpService2Ppi will be random value with this patch. Would it cause an= y functionality issue (e.g.: CpuS3.c incorrectly
invokes StartupAllCPUs() from the random MpService2Ppi) if only patches 1~6= are applied?

Maybe you can add a ZeroMem (SmmS3ResumeState, sizeof (*SmmS3ResumeState)) = so the file does not need
any change even after you remove the MpService2Ppi field.
 
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118833) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244161E5E376FC1F174E7518CE22MN6PR11MB8244namp_--