From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 87DCB740034 for ; Fri, 21 Jul 2023 03:52:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pugr5FuC8JyOnnlVqPR+Dkhg4sZmMdMkhKGqD6v4X3M=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ld-processed:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Tr ansport-CrossTenantHeadersStamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1689911544; v=1; b=WNsc2DRgXW36XtiFboSHJvtCSzslz3Mj/dodnUnONFg++SJgtra3tW1yukE5WtRgkQjtJ1R2 5+d9Jqrj5/TI7JNF7d30EthHoC47vaozj71qh8awBhD6wq0y4aRkQwZqypZxORxPy2gmCPpl5E0 n7tsAlEsxzqyec5eDWFiyZ9Q= X-Received: by 127.0.0.2 with SMTP id QCOvYY7687511xkquDBR39ge; Thu, 20 Jul 2023 20:52:24 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.38.1689911542616381479 for ; Thu, 20 Jul 2023 20:52:23 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="364396082" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="364396082" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2023 20:52:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10777"; a="814794299" X-IronPort-AV: E=Sophos;i="6.01,220,1684825200"; d="scan'208";a="814794299" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 20 Jul 2023 20:52:23 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 20:52:23 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 20:52:22 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 20 Jul 2023 20:52:22 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 20 Jul 2023 20:52:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A2Ms7gGW5m9RqNqCdshlgCJoYUjbAo9feru02uEKDqHX1szX3+209NORVpIUQ7l8euioTPY0KLCu2yIxlKan3J+iYIb78gix2+7Y2t/yUYiR2wQuqW/HmRa80yGzZ9KlC5OX5129TR3hR04L3nqajJPegZvCLS8+6EbtORFMGxHTolXZABGqQ8BL1G+6TSvpZfk9D4uQVLvAObrYOrGTVLb1wg2w0Fuii9KWjOoHLDfL8rui7c102OOeAZF2GigHJSRF6AzrBBWtg5duS9AYFVNrVR5lEyr+NVONzMP1tsML+sRzU1TrvqJXTWp4xIZQ4kIN9m9saErj9v8ECm/1XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ws89wioZ5H2ptu7EO2kcgMN7PaIPcAcM4YZbZ5XSNLQ=; b=buA9ZJnUc+0dUX/49hyi998xRxe/VYekJY64Leb3J/NDWR2gxzMKYUeNWA2bot1nhIr934EsYnKuoh+lzJFXoaqB5RXZsIgy1b5VTS5qWYq03xi4v1C6j/ePMAnKCSOsswPC6Mto/ecT9NnN8zCpQtFH0jFNEFjOgVex4BOC54X16qD//oLkcpLIwN+T+tTVW6psnPr9H+LR49g/ZNVlKOxF3TtmaqBp7ztELjYkku35gbcBmkgTZSjtZcdSd7LO8lx5ebD7i1eEz+F4hZXDr6DEcEzuSubLIyvlADXr7/7/ncC8pKts+NCPjRKC3FXoJizmJ9OsvZUYQTh7Ixyjyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS7PR11MB6175.namprd11.prod.outlook.com (2603:10b6:8:99::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Fri, 21 Jul 2023 03:52:17 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6609.025; Fri, 21 Jul 2023 03:52:17 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" Subject: Re: [edk2-devel] [Patch V3 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Topic: [Patch V3 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi Thread-Index: AQHZutjwRe/FRTad5UmBlHMjaMjizK/Dl7mA Date: Fri, 21 Jul 2023 03:52:17 +0000 Message-ID: References: <20230720070736.4562-1-yuanhao.xie@intel.com> <20230720070736.4562-3-yuanhao.xie@intel.com> In-Reply-To: <20230720070736.4562-3-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS7PR11MB6175:EE_ x-ms-office365-filtering-correlation-id: e42899df-c87a-4e52-04e9-08db899de0d9 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: qdgkN0kKl2V4sg1nL0lDlSMt/ZeckS5rbg+jGZm46kRIsl/kzM/oh9U8n/0QYB8OK3T7ABguiqtF9NUOjtmt++BXp9ajQg7PU0S1N1iNJx4reqzHzO2XcVGo1qeU68UJsVsLOmYVb4h2lLZiB4Dv7Tno7SnyIh4iwCmJbEqtNbHFvgAGz6m1oDTR/HL3KIY8/ckE7COO3vKJRXQPLJY0hNWFsOlXWuR6h16hMDStimdBfNzjVXmSwqEOm2faLQ1J7yhdgqIK5w6foBnC6DhvAIdasU3ba2W0Kz1RXOoK3KFXO3Pi+lKvxL76s/EHBUh/Mxmmp425nyqLUq9PiXrEJRSPtw9IkexVuHlMN8jctLwKDkbcKHneEwbS728pMLOixZLtl3NpYb9OliQy2QvFZwVFF/JxKZ3FKxjhw529MzzqLawYiokYpnRZ4DwhxpceSRJuO68liM9KzmNMzIaVUnPeni0dkh0w5AjO+4mVNFCcAWRjfXaxEaIbV1n2XHAjVN2GfNyBApfcUy2r/lL3ayo1sLN4qIy+GrRIyicLUZS+dl1w3pi8ik6Uh3eYB1a5gLXRHy0WIuY91HKo0z3CgWwyV956emijmJFXddLF4++ue9uMyz9twCH9A4QIls5Vbmk2G/vhCEEjmNTrwHetrA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZlbmziEDfD/1/u3jkrR7ThQjv0NFQWn3yacL4EMdu+h7AR0BMRvynU+e6Vb3?= =?us-ascii?Q?htJlwiIv4wxSOPW7su/0EYWg5PnD2obEouff5tThof4Kr3O5yStsIsJXlXrs?= =?us-ascii?Q?5QPvSVIvjJcqUUZXtMITl+B1vl6JB5B9oH7E88AvxeC2Sh2NqHLtD8bpFr3U?= =?us-ascii?Q?vxY+j+t+m2v30rN39I5y1uemhQW1p7Z+5XcSuIMLv8q20iOeY8pCcLW4xNV6?= =?us-ascii?Q?nDsnvni2xUL2vkslcSr6mShTyZfseTyFtFw0ersGJWKVYkfUPENJE2Gr/I7V?= =?us-ascii?Q?GDm5OYWBzoqEVZcHyUx2o+gvJyA+/v8jN75bnJfT3GMaGrObomC9/7Pteoc0?= =?us-ascii?Q?1mkjm0yKtWMwwmeXhEx/1t634btWcmCVXcgU04DQJNpq7HTAzSoyhm3inDzq?= =?us-ascii?Q?wGphsbSOL/X1OGYgehnuJZXyq7VZ07jAfLc26q6GNymwekD8X0LSld960BP/?= =?us-ascii?Q?HFUpxGMDpHC7TpGCHZVp2LhlMrV0L/f/f8n/OzVH1zIuDnY4qy878mPeW2YA?= =?us-ascii?Q?6AnVIcwR5lJLr9x5ZVzqrKfrxR4ba2r6yt8Kyk39cmnoT1yd+zM13ZT6tasU?= =?us-ascii?Q?8Vm7atucQ+zLaXa4lPX7PgOlyzFp+6BBFvsOAs9wqAPpG+r3SHJI1Amk4VED?= =?us-ascii?Q?tcgDxpbTBA7af8kfR1gdIoU1u4gs9cnkSrP01ZilH6WnwPi/IDjRdVNpvgQ6?= =?us-ascii?Q?rEQ7ihZdv2tH6pt1bW44zyivm3sWNGr558pVOv9HpHnDrqGlB54wJc8Juwz3?= =?us-ascii?Q?7Rl578+k5yjnxhJ4Q/HkT1uPtv+6cpjmYpIkAGuQbm3DX8vM3wMda55aigh+?= =?us-ascii?Q?wkOACg3IO6cddL1n666xZ9Zx/4QXRQ3qmF6ylypLJyq1uVxvGrOaYqeBDnMV?= =?us-ascii?Q?JncFFyGZYl/NpYNUkHKScx71/kwKbDNF3VjdWKuM+O1ExR1SLBB2l5A22e94?= =?us-ascii?Q?x40fOqlgL0LQFdBSWhmP55CHU4/TJkeeGNuXKearUMvgZEdelNbgsD1gEhrq?= =?us-ascii?Q?47HGZmcvxybCA4YOWOagKTP/cMjTK48wX+sKLKmhG6xyWImHPaTEDr/NDzhn?= =?us-ascii?Q?9NLmNyKWKO15JaK2NMPdjIAtFbWp61bBzesj6cQJHxYeAp6U4JnNe253oq6P?= =?us-ascii?Q?Zp6WgOl6s2PUKL5E4ga62JnHXgHqzvRaMKzk86pKnKuqqTvNFV6woA40tCm6?= =?us-ascii?Q?lkcpgvnnyd5ERjTRipGIMQeYIBXqmVakzxSW/TzhoYO9ezQM+cv1V/UspGfL?= =?us-ascii?Q?5F7c3ENoWX988i8l4n9VqfdZ4D95QwEc19gYQK3jfNJHE/0LXqBtSgWtb6U3?= =?us-ascii?Q?RW57M/V1CaM23wBC6J+Nl8mCbQhrT9YkEX2P6diYj5BWBx7UOkQ7/9LxAspB?= =?us-ascii?Q?83Ur1r9/ryYTyhdsSiPesFim1meiVE1vAi4Bk63EkbyMCIcnlpqZdDhrhidk?= =?us-ascii?Q?Ow+W/17Bmrkxjxf1msPY/4rrBIAoJDzNsbnyrxO6EALkBrhXuy85QFCULa5c?= =?us-ascii?Q?5r7I2t0yWQKNDk9tswdpDz1j2FGTqC0XfsKieUvwl/NL8CkCGzpopeO7m+a6?= =?us-ascii?Q?XGlDHhjzB4ArCu4mnIA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e42899df-c87a-4e52-04e9-08db899de0d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2023 03:52:17.7737 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8QZsILXJIFhImWeICJ3LFl+xk+EzBCOhh1XSIv1pQp2q1G4ji6UOCT9VVyPkJZBp6RZhPzveGfoyLGEXMER/9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6175 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: glO8xxbL6k40os7EbOCowtMXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WNsc2DRg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Ray Ni > -----Original Message----- > From: Xie, Yuanhao > Sent: Thursday, July 20, 2023 3:08 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Rhodes, S= ean > ; Lu, James ; Guo, Gua > ; Xie, Yuanhao > Subject: [Patch V3 2/4] UefiCpuPkg: Add PcdFirstTimeWakeUpAPsBySipi >=20 > Add PcdFirstTimeWakeUpAPsBySipi to check if it is in the OVMF environment > and necessary to wake up APs by INIT-SIPI-SIPI. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: Sean Rhodes > Cc: James Lu > Cc: Gua Guo > Signed-off-by: Yuanhao Xie > --- > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + > UefiCpuPkg/UefiCpuPkg.dec | 11 +++++++++++ > 3 files changed, 13 insertions(+) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > index 7d45d3ad4d..55e46d4a1f 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > @@ -81,6 +81,7 @@ > gUefiCpuPkgTokenSpaceGuid.PcdCpuApStatusCheckIntervalInMicroSeconds #= # > CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures #= # > CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase #= # > SOMETIMES_CONSUMES > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi #= # > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard #= # > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase #= # CONSUMES > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr #= # > CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > index 83e9028d0f..bc3d716aa9 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > @@ -66,6 +66,7 @@ > gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate ## > SOMETIMES_CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaBase ## > SOMETIMES_CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures ## > CONSUMES > + gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi ## > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase ## CO= NSUMES > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr ## > CONSUMES >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec > index e7726a605c..cef0cbd43b 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -214,6 +214,17 @@ > # @Prompt Configure the SEV-ES work area base >=20 > gUefiCpuPkgTokenSpaceGuid.PcdSevEsWorkAreaSize|0x0|UINT32|0x30002006 >=20 > + ## INIT is now triggered before BIOS by ucode/hardware. In the OVMF > + # environment, QEMU lacks a simulation for the INIT process. > + # To address this, PcdFirstTimeWakeUpAPsBySipi is to indicate > + # whether to broadcast INIT-SIPI-SIPI or SIPI. > + # > + # TRUE - Broadcast SIPI in the OVMF environment. > + # FALSE - Broadcast INIT-SIPI-SIPI. > + # > + # @Prompt Ovmf environement Check. > + > gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|TRUE|BOOLEAN|0 > x30002007 > + > [PcdsFixedAtBuild, PcdsPatchableInModule] > ## This value is the CPU Local APIC base address, which aligns the add= ress on a > 4-KByte boundary. > # @Prompt Configure base address of CPU Local APIC > -- > 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107118): https://edk2.groups.io/g/devel/message/107118 Mute This Topic: https://groups.io/mt/100251416/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-