From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E6C18740032 for ; Tue, 9 Apr 2024 02:06:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2pTdq626rgUuCRoyi+YIzZ7N8U5b+W9rjpogWbekI9c=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1712628392; v=1; b=WWEh3ZjEWIRf5FZSfFxfyYq8WocdkojwijXJwmubZZmm7IvljaVLdNEaKfX/FOocv3AAYHq7 fcJ01UlNiMqqvkez+YSKXqJz+veGbVRa4saM0NNXzr07gxHW0rjWOcKbP2+q6JV7gUTmVAubzy/ DezyKbvwt+zD+4GkohCb9B2F9jbRSDSX0OtUuw0NGa2l2kRyp7aUt+a90vC5ah0SuTqNzR4DxCl 4kaRxYZ4uY1FRnieZ7pqYQfL4bky37hRGR022WjGMfydpBWTapyhZ91W7AMUD7gEhgXxX4iL0z/ QYYyL2KKFWjHvo4HUvVq5RvMXtF7IDfxQV0okGIUJacCg== X-Received: by 127.0.0.2 with SMTP id KlSIYY7687511xCA0GvruJto; Mon, 08 Apr 2024 19:06:32 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web10.126243.1712628391600451726 for ; Mon, 08 Apr 2024 19:06:31 -0700 X-CSE-ConnectionGUID: I/W8mJoWSPSws36bNzoz+g== X-CSE-MsgGUID: kIURYMifSQGX/oLrdqrMeQ== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="33334904" X-IronPort-AV: E=Sophos;i="6.07,188,1708416000"; d="scan'208,217";a="33334904" X-Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 19:06:31 -0700 X-CSE-ConnectionGUID: w6JVqtOeROmiqwozqnAdPw== X-CSE-MsgGUID: QFJ7g29aS4KUhPKDHaMHDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,188,1708416000"; d="scan'208,217";a="24562275" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Apr 2024 19:06:30 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 19:06:30 -0700 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 19:06:29 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 19:06:29 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 19:06:28 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB8749.namprd11.prod.outlook.com (2603:10b6:610:1c9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7430.46; Tue, 9 Apr 2024 02:06:21 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817%5]) with mapi id 15.20.7409.031; Tue, 9 Apr 2024 02:06:20 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , Gerd Hoffmann , "lichao@loongson.cn" CC: "Kumar, Rahul R" , Sami Mujawar , Sunil V L , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Thread-Topic: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Thread-Index: AQHaeqKOwBdqqtDKIUqwU86L2eCtHLFDts8AgAQOACOABjb/hIARUVf0 Date: Tue, 9 Apr 2024 02:06:20 +0000 Message-ID: References: <20240320084152.268323-1-lichao@loongson.cn> <17BFE34457098413.21233@groups.io> <17C02C7EE39BF604.20354@groups.io> <9972bb2c-0790-4879-89f3-946574f0d802@loongson.cn> In-Reply-To: <9972bb2c-0790-4879-89f3-946574f0d802@loongson.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB8749:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SeEgliLGdNcIrxdKkQ5Mi9/RGXEqXw/yAptrsEthgJ0TUkQstcsnO7ANLgBJAkdBcptNIDGl+hVpbqNyvCAgUakYemA036q/GLfK/X1k3wvLkp4G6V2kTyvt4vRbkjyvjBCFXPury8vAHV+bgU9SGFjdUOut9qqbiBcwqsB6UJNZgAu2XGTKSLM0G8vxhl+th0oQcWtvTQPWDYIA06JRngtl5FZSb5qKvz60l4DBGxjbEBVEmdwDbWtlPkj4fQsBG9NbP3hXQRpe4Go3pBz4q9wqjqH0CK7GnYZGps7A1kEkeaAxEAn5t31CgMM4d/DMhjRDhYJcU30YqksAzyofCEy+W5Rl5G9ako00Qc2Az+p/4j+jeLh/KrMge4Q1p+BMrj7FOo4RWnIwst1lKw+tq3OuAlHtGoz6EnYm3ZLvlRAiXrPd/Scvmi/RvHo1pJOsSKZo60V0WaS2781XUU138Xz2Khp5JNX7T/eIHZiILmmGQYk93OylrjZskA0K+Sq9iy409saJSXzzRq2vXaz4wfFBTWGxmhDfWK6t1CbSkXNnuTmsF1UK6LwxlsrCPjMWgIxLCAgqzpGYqgasJ94TNuV/hofc+ceCwReKyqzvwO1g3sjPqHUfWCaKNpORELnZ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?uutigowyI6KcqxSm0+VFwZdobVtbvvC+EgCTdOuPMcgF6wy4WbnflJQmle?= =?iso-8859-1?Q?s3udO5c02YNJNpuBW7obi1gZXur9Ab4KzP/jsNEjN/1GGLv8xWALtMg4hX?= =?iso-8859-1?Q?kvgAAAGwMX+bUIFm083aEYSgywlviXI0oOdOCedN810fYtkFSGuu140MUB?= =?iso-8859-1?Q?7FXQ1hGR1WTmsjf3RxJIJoLbccw4rm+toTHOSbL0ecj5FGIG6epZd5IVHH?= =?iso-8859-1?Q?5hlxndsDYt4Ns4l/4It5omx3h23aAjkCOlg5meo1G2zMEC0gH0RZh+hNyN?= =?iso-8859-1?Q?vQIfdp0H3ohYmV9VPU7epO3SEtlwg8fppXxeyJmhobLcVCCPrm2lUF1G4a?= =?iso-8859-1?Q?GYBYaOG0Sa3Bpeq5qlNpOztyYRa1Sqm1IC9hn4WMat9ihU2nViZMax5/Hq?= =?iso-8859-1?Q?uM1ONpnpi0IvWMP321quUe+HS+1kj2sGXBDWIzoXqSwCDApzCXbSPKCBU3?= =?iso-8859-1?Q?8tP0gUz0I7wzYZdjJwFz8kSTl69KLGMjHWHWeMUs/X08OqTGSvLLcYyxjW?= =?iso-8859-1?Q?7J8U9JqThw6zmleEMFwyRnOXBWaFshiZFZYUx0C3VPe+AudpXpxJ6yRIOC?= =?iso-8859-1?Q?SbvI178qRdE6NCEyVxU9jmQEQ5okNE7yedG1BN6z/Yb9fIpKTB3z5F1PuQ?= =?iso-8859-1?Q?eKDFNTHIJ7Hkxf1FHD4F5nPD15PJFlhT8BWI+TnvlV734SaA6KGfkUFdVC?= =?iso-8859-1?Q?hQjcn97U9S1oFBPfxvfLqs+haorZuotGMstl9TZ9z7juEY4XWnx9KqXmWX?= =?iso-8859-1?Q?O6QrFYPl9t2/HpwOwU9gqDFYAQZGZLbpWSvIiQEHMMMjKpuJ3sv+9ilr8q?= =?iso-8859-1?Q?PJE3lWhclTu3y5pNIaxlv1XoclX2IO+cqVDOfeba0svTHoCWT+2xagi3Z0?= =?iso-8859-1?Q?QvASekr1XWU2yhlfnZ4xvKEo9OoULCfbpCj9ca+0FAbQhRbN5z72AhS1P2?= =?iso-8859-1?Q?T+2JNoopDxrPMdygX8azJ5drZci5QMvBNKTfTSn8NFJuyJbzC8zA8LmRRE?= =?iso-8859-1?Q?XLBTiLtL4SlUSUQfp+SsN9kEjDNO+js/rWCmjHQoPljOTY5RM0uN/ZbEwB?= =?iso-8859-1?Q?hR0dHOyqG/g94ScqtAlEgDljZ+SzVYA1vVFdpua/twIph90CvIElxdJyLo?= =?iso-8859-1?Q?dn+2Yl/lMO3kmc1hel+vY3VKVgRtEynTPYgJnfO1ESyn/yJeIZ33Wi++52?= =?iso-8859-1?Q?BYSJR+54OsBD8+ayVCmy0OsFuXF7GBzPGhKcpOCnNst7mopvONpEzLJx6H?= =?iso-8859-1?Q?soIpRNvFcj9YgyQYeViYVk+tIqsDr0iiawNJGKmZX3lKMDnu3W6N9jZ1Te?= =?iso-8859-1?Q?+JccDP0tTz9+JFwRM2I9hJQf/NARHW8DxDmU9tHvN6T120IPYfkDc85HsI?= =?iso-8859-1?Q?bxlSqIobTaPYzqOgtubS3PHhYel/nRq74uPNlM8IWtlM5v6DVSOCWbwrv8?= =?iso-8859-1?Q?nfbYxSTj19+/lWnXjmDodB22p7lX4GZlSshHkSvUeps9G8du2ceSsJqpCB?= =?iso-8859-1?Q?bzGfPtHr3QVVmd/8FOGIEJvJw+iP0hhBCoO+05g7mHs1M3TlgitJULYvXo?= =?iso-8859-1?Q?A+YzH8SQ+XqcrTpNr7r/t9yHkrA2kMiEI3DsV0d6xz0FamepnuvtYCXv+1?= =?iso-8859-1?Q?jPuDBXuX3vRQg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 108761b0-c3ba-4b2b-d9ca-08dc5839a618 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2024 02:06:20.2259 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b9Xw3y5BPZmpxrIz3VDXuLzGwNVIrn5VSejXRLnUW7ANgE3tEJRzkgyJyp3x2v9OH9TtCKmRxcrWzbzli+WvSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8749 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 08 Apr 2024 19:06:31 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TjZB8tmREb3mjg4VbDWhJ8Tfx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82441980A1C7A43657ED01A98C072MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=WWEh3ZjE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82441980A1C7A43657ED01A98C072MN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Chao, Sorry I missed your mail. If ConfigureMemoryManagementUnit() is called in PEI, can you move the logic= to a LoongArch specific PEIM? My concern is we may need more review on the= lib API ConfigureMemoryManagementUnit() if we position it as a library. If we move the logic in a PEIM and the implementation becomes a PEIM intern= al logic, we can lower the quality expectation of the function prototype as= no other module is able to call it. Thanks, Ray For patches 10, 11: Can the lib be avoided if the logic is implemented in C= puDxe driver? This library is will be called in the PEI stage, so I can't move it under t= he CpuDxe. This library is the low-level libary of CpuMmuLib, which will consume CpuMm= uLIb to configure the MMU. This way is suggested by Laszlo, who saied if CpuMmuLib can not content the= configure API(high-level libary is the basecal libaray, it should not incl= ude the configure API), we can split it into two, where the hight-livel is = CpuMmuLib, and the low-level is CpuMmuInitLib. For patch 12(UefiCpuPkg: Add multiprocessor library for LoongArch64): Revie= wed-by: Ray Ni For patch 13: Please make accordingly changes when you address comments for= patch 8. OK. Thanks, Ray ________________________________ From: Gerd Hoffmann Sent: Friday, March 22, 2024 20:39 To: Chao Li Cc: devel@edk2.groups.io ; Ni, Ray ; Kumar, Rahul R ; Sami Mujawar ; = Sunil V L ; Bibo= Mao ; Dongyan Qian Subject: Re: [PATCH v2 00/13] Part 2 patch set to add LoongArch support int= o UefiCpuPkg On Wed, Mar 20, 2024 at 04:41:52PM +0800, Chao Li wrote: > This patch set adjusted some order in UefiCpuPig alphabetically, added > LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of > the first patch series v8 submitted at > https://edk2.groups.io/g/devel/message/114526. > > And also separated from https://edk2.groups.io/g/devel/message/116583. > > This series only contents the changes for UefiCpuPkg. > > Patch1-Patch4: Reorder some INF files located in UefiCpuPkg > alphabetically. > > Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuDxe > for LoongArch, and added some PCD and header files requested by the > above libraries and drivers. > > Modfied modules: UefiCpuPkg > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4726 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4734 > > PR: https://github.com/tianocore/edk2/pull/5483 > > V1 -> V2: > 1. Removed PcdCpuMmuIsEnabled. > 2. Removed API GetMemoryRegionAttributes API as it is no longer needed. > 3. Patch3, added two empty line in DXE and PEI INF files. > 4. Patch5, added the Status check in GetTimeInnanoSecond function. > 5. Separated into two series, this is series one, and the second one is > OvmfPkg. While I can't comment on the loongarch architecture details the code and the integration into build system looks overall sane to me. Series: Acked-by: Gerd Hoffmann take care, Gerd -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117516): https://edk2.groups.io/g/devel/message/117516 Mute This Topic: https://groups.io/mt/105041080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82441980A1C7A43657ED01A98C072MN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Chao,
Sorry I missed your mail.

If ConfigureMemoryManagementUnit() is ca= lled in PEI, can you move the logic to a LoongArch specific PEIM? My concern is we may need more review on the= lib API ConfigureMemoryManagementUnit() if we position it as a library.

If = we move the logic in a PEIM and the implementation becomes a PEIM internal = logic, we can lower the quality expectation of the function prototype as no other module is able to call it.


Thanks,
Ray


For patches 10, 11: Can the lib be avoided if the logic is implemented in C= puDxe driver?

This library is will be c= alled in the PEI stage, so I can't move it under the CpuDxe.

This library is the low-l= evel libary of CpuMmuLib, which will consume CpuMmuLIb to configure the MMU= .

This way is suggested by = Laszlo, who saied if CpuMmuLib can not content the configure API(high-level= libary is the basecal libaray, it should not include the configure API), w= e can split it into two, where the hight-livel is CpuMmuLib, and the low-level is CpuMmuInitLib.


For patch 12(UefiCpuPkg: Add multiprocessor library for LoongArch64): Revie= wed-by: Ray Ni <ray.ni@intel.com>
For patch 13: Please make accordingly changes when you address comments for= patch 8.
OK.

Thanks,
Ray
From: Gerd Hoffmann <kraxel@redhat.com>
Sent: Friday, March 22, 2024 20:39
To: Chao Li <lichao@loongson.cn>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Sami Mujawar <sami.mujawar@arm.com>; Sunil V L <sunilvl@ventanamicro.com>; Bibo Mao <maobibo@loongson.cn>; Dongyan Qian <qiandongyan@loongson.cn>
Subject: Re: [PATCH v2 00/13] Part 2 patch set to add LoongArch= support into UefiCpuPkg
 
On Wed, Mar 20, 2024 at 04:41:52PM +0800, C= hao Li wrote:
> This patch set adjusted some order in UefiCpuPig alphabetically, added=
> LoongArch libraries and drivers into UefiCpuPkg, it is a continuation = of
> the first patch series v8 submitted at
> https://edk2.groups.io/g/devel/message/114526.
>
> And also separated from https://edk2.groups.io/g/devel/message/116583.
>
> This series only contents the changes for UefiCpuPkg.
>
> Patch1-Patch4: Reorder some INF files located in UefiCpuPkg
> alphabetically.
>
> Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuD= xe
> for LoongArch, and added some PCD and header files requested by the > above libraries and drivers.
>
> Modfied modules: UefiCpuPkg
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4726
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4734
>
>
> V1 -> V2:
> 1. Removed PcdCpuMmuIsEnabled.
> 2. Removed API GetMemoryRegionAttributes API as it is no longer needed= .
> 3. Patch3, added two empty line in DXE and PEI INF files.
> 4. Patch5, added the Status check in GetTimeInnanoSecond function.
> 5. Separated into two series, this is series one, and the second one i= s
> OvmfPkg.

While I can't comment on the loongarch architecture details the code
and the integration into build system looks overall sane to me.

Series:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117516) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82441980A1C7A43657ED01A98C072MN6PR11MB8244namp_--