From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C2FA9D8024B for ; Fri, 28 Jul 2023 06:28:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YyZhCU5oMZ8uiMXJwxRQwpqwqj0mRs7xrlTgkWzIlzo=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690525691; v=1; b=FKfuNGRAU2Dk4EIUS/fdwoIkiUho9vrBcZwmX7MpfamIOpfESfm52uJtrcE/eCqJ8ceTXmpb 5Q5zeNaR48nOaNjYqdWIaMqy7bEY/fvv0en6asFZSmdk6NW8X09xP3sv1ZWJfFzf0BwiPPmWpbm 3gS8PAwrnvyr7IijJndP4TKo= X-Received: by 127.0.0.2 with SMTP id QePSYY7687511xyb1eUgbEtJ; Thu, 27 Jul 2023 23:28:11 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.26952.1690525690809804801 for ; Thu, 27 Jul 2023 23:28:10 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="454881689" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="454881689" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 23:28:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="901098759" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="901098759" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 27 Jul 2023 23:28:10 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 27 Jul 2023 23:28:09 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 27 Jul 2023 23:28:09 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 27 Jul 2023 23:28:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eV0M272sA9/FQkZkolPAmjElH8/T6GB+gqXipsATzFfH24WrKOZalKEgkl5w/9O7neFHwVd8f5oIcYWv2xtFaShZVUhu/jlihoegu4Q+3LFShYbNAf9GKFhqRtYC7EQr7PcQzVvbWroodO6/aXm65dtWuUeSQiXhoQqC93xb/oJOSNum9X4jAC4d+AMR315hsz5jCFM2TUB/We6PCzYjvY/M216eh7K+kr4eDTrdG7OJ4jUGWkyPJvBKaLOmTfNEmbXXPaMUnSRUQXnzP7+F6BmeOP/Nx8FVZnujo4ybpfMg29vELxWguLg9v1eI3fvaJGubMYhwaqxgY6lIETqSPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HF5kKpG99QtKJ7nFEdJ55uWw8he/O8BlT41ryTCjoIY=; b=HuFFR8XIU2UrTrPyhZ6UDrA6lS3VGD8qBoybq7JOUtHenKroaRZfhaCGX98I2eSgJ3ATCAW6CQ3tAbiYPhXQJ/irO07vSfUiiPNiBdXfsyQAOR/xRV1TdCeb1TgkHXgqTLNaY0MUS4vtcPWKeTmIpxZZPKv87OOeTgDFMl2ef8o0Uy/f/hy3szz5BsKBWziAttQWXIyskwoLE9XP/lCCBKbW7rIxJvmmjyHiX0tiMauwg78YbiXq2qQM6jOFqN47yJ8oyI6mAEC3AhiHTaIiQHeBmX06s9EIbYGluLt8CK8MuInsoh4wNxMycH0nfI68NxZe5jRY5F5FV/qvEbvuJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ1PR11MB6300.namprd11.prod.outlook.com (2603:10b6:a03:455::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Fri, 28 Jul 2023 06:28:02 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6631.026; Fri, 28 Jul 2023 06:28:02 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode combo Thread-Topic: [PATCH 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution mode combo Thread-Index: AQHZwDEBGEe5yBcfr0mWlaAzxfsUJa/OuNeQ Date: Fri, 28 Jul 2023 06:28:02 +0000 Message-ID: References: <20230727022040.1910-1-dun.tan@intel.com> <20230727022040.1910-4-dun.tan@intel.com> In-Reply-To: <20230727022040.1910-4-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ1PR11MB6300:EE_ x-ms-office365-filtering-correlation-id: 6d0adbf2-4867-4f2a-ee6f-08db8f33cb76 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ZOSLssxmd5OV3Zu6I67OCqmZ7z6tOs5HnfiemCZQwL/BeghwJhQqRBbmLcYa0OZTDIv5vsPkuzUnBD1HRt4OIiM3ONb4B5wP8yRYDDzx9Zy95y9oXzIISxqZSbHJ8bIeenqyGKZnnZQvclZkwBGBKU/4LPMbf3Uv425pwTsz2N+tZNqp9ly7aYbLzw7XGkAgxopters5IaOvTY75pKwKpqcIifcKFAC5LoIA5/bFypALtvhXQ0DGXjdY8ExDAsR/ft8JkzjJpa3lJk/ioCS9gdNih3/1ax7vh9AVv5abN70DBHxByG5wrvAs0iqgGbKCKYktlJNd7EigrwGlDQC35rkI0pyQiUQig/4sf9P97uoec3jbSoK1RA8R+qsEjNEDhrI1WSzbBBqf6j1Pk4RQ6Um5kLRmVlW2kPw8yxYh9Xkf86tRRaSAEzi7Put3mVin8eb/1z5WveZ09SbC7Tp/lLwxkTq4a/m0pFU7kWXTUo5j4deG8pZCJTQbhxHjXeU9G1aGQDipElaswuQcOyJiBFDC46uvWOQQ91+DTNPu6cpztIqEiG72IWGS0ZsglAp/shVQZ/gRXc2EK8yn6ueBwYt69FW5t3pFgqORmBusSD/DiqvH+vYwmPb1JunLd/bn x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jlwCvkU9fYELh/WVzr6hHFc59z8IfPOvqvSowWgPx//xlsFXVErmThkKL0Rf?= =?us-ascii?Q?w7sn20DYQwfYFppqhFBjJZRgO2BZW9AguxOz5GC7fqABYizN4OXnqf+aAtvP?= =?us-ascii?Q?swFN1yHrJV1YZRkXBOt49OcnWVIzIZTGZIJWM2K6ebDGww6ET2Z/BKDCpbb/?= =?us-ascii?Q?dTbAU6ro81o5pM7czmSjx77JLc6wrUdJ75FnYWLOmNTUrQKKOe0A/decsmkc?= =?us-ascii?Q?u5atKclYCXmMZVy2AaxDplkp/IMgNs2rKprKv+5vCs3+3WrZXRytZEajzW14?= =?us-ascii?Q?p/K5Xt/3pxtVuunFRYAkym+f++CRUyZptHmIJPhNFgUeAXg3ZUW1NBENab8d?= =?us-ascii?Q?okJrpeBEev8msHPQfqPXd/Ypj2cxLB6kHJWqRX0/w599xOy4/qovvqER6mvR?= =?us-ascii?Q?DVovsoFAA2WuADSvlzTOIkHgOEpJS3WnNe7aJa7iQ/B/wZEABTcZwNMmGfVk?= =?us-ascii?Q?HESnB6sq4tUIBsQR/859+we8KicFoGymvb62ELskI07THvY3K/pI3dQXUtsB?= =?us-ascii?Q?hfTeDBUtZR8dSIssYTpVZaD+i20n/GrVCqXjXn8ioyi1p0eY+s8BtXWQafxy?= =?us-ascii?Q?2XUp5zZPt0hgnGcZMzT9Wcy24efkd88SkseHMZzrL4NRNRaU8OkTUQS0j2WG?= =?us-ascii?Q?+Bf7kPEgIHzDsweWKHqQJ+QHZxTRBLVdIZaMPxdwScf1oI+5aeAWyhhnMynk?= =?us-ascii?Q?WL+Kyr5b6HedWIPFw3eJAOquLP5HJie/97C02egvoc/KbGVKlV9Ngytrhd2m?= =?us-ascii?Q?WjVyW4/AhSmcvuvm87SdISo/D2ENa7HNyLLugKgMGHZQjNnPkTJa/7ot7lF6?= =?us-ascii?Q?3MiWHYK3LfNtKl8fBDXPhkXRVcs2TfCuwdCJ2CzEv/NxUN28m0SvTEMp9k3X?= =?us-ascii?Q?VbZQoukA+qa5VUEJ44xVYEABsIiyPe1mKedEDKEOI29eHzBWea3PDdxC8p1d?= =?us-ascii?Q?DKTmtFA7wdNDebPqhZ2EqszKB6lYoaFTsF1u+E13z2x8GFWDLJ5JgWkNpDvo?= =?us-ascii?Q?eYS9So4PjW+/qiQL6SXbU1/j5ogGOlzVVoyGXrkC7poqHigZXJunkBmfXw0N?= =?us-ascii?Q?y/NVYkbSrM07TQzr8z7Z8vGaNTvkEldfF8VbjGVYra0ZBGvylo20aB+nSvKy?= =?us-ascii?Q?155TD7Duj5tOfl0QvyQ5pNgOem1bvv1iXtcigj61J2+y+MWUzDWQTthEfcaI?= =?us-ascii?Q?mrL+y/vQKxHynAQCjmqAaTLF79D6s0gTtMRPiYNv1v/kASy+F4mVEAIiHEJn?= =?us-ascii?Q?jOcvGQUkFfoR4iUcUTfi80pEzh4O/Jf9R/0GLxLa3MGqMKm599PDCXdrRQwS?= =?us-ascii?Q?8Pqc3WVbc1l08mqLM8WbgiBPdEMp8BEq6lbAb279kFXyfzWhkEiIrq8+V5TJ?= =?us-ascii?Q?i+qVpZCHMUBk8dD00zYWxUERZj3ukzKg50hqhWaAtD0EJzsS2yIDK++HPeTd?= =?us-ascii?Q?/PU2L53lUu0/P1kw3jLIiJrH5XxQ7Euj9YG+ctAv0a4wYwbWyIGrAG1Q1vTa?= =?us-ascii?Q?obTczikuRUVsypCdtzVTQ+WP7T3cD1sZJbwQKu/erK14xpAsn2N3MRzKurns?= =?us-ascii?Q?UegdRErpjejyxfJrGL0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d0adbf2-4867-4f2a-ee6f-08db8f33cb76 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 06:28:02.2178 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F5eRhyqbww75xEVdTafNSnlh3QaV64kSfUqQqeru72M5YCobr03ZmYIzoT4qRh0RploATGC4R6Dqbh+q2w8xWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6300 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4LJ4low8db4dslXUvHFm1uvqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FKfuNGRA; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Dun > Sent: Thursday, July 27, 2023 10:21 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, = Rahul > R > Subject: [PATCH 3/5] UefiCpuPkg/S3Resume2Pei: assert for invalid excution= mode > combo >=20 > Add assert for invalid excution mode combination of 64bit PEI + > 32bit DXE. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > --- > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > index 6574849939..34aa901f93 100644 > --- a/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > +++ b/UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c > @@ -1106,6 +1106,13 @@ S3RestoreConfig2 ( > DEBUG ((DEBUG_INFO, "SMM S3 Return Stack Pointer =3D %x\n", > SmmS3ResumeState->ReturnStackPointer)); > DEBUG ((DEBUG_INFO, "SMM S3 Smst =3D %x\n", > SmmS3ResumeState->Smst)); >=20 > + // > + // 64bit PEI and 32bit DXE is not a supported combination. > + // > + if (SmmS3ResumeState->Signature =3D=3D SMM_S3_RESUME_SMM_32) { > + ASSERT (sizeof (UINTN) =3D=3D sizeof (UINT32)); > + } > + > // > // Directly do the switch stack when PEI and SMM env run in the same > execution mode. > // > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107338): https://edk2.groups.io/g/devel/message/107338 Mute This Topic: https://groups.io/mt/100383961/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-