From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 26F6394141B for ; Thu, 12 Oct 2023 07:29:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oDnu0PLoq040B+GkrceSWrJsa2lmrAdMS7P0v0KM3aw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1697095770; v=1; b=hF7KRrV0itqaGYhuDfwbQzM0tm1mCFoGPLv5MxpVvNtr9zSj1ny5fL09vPCAwij7DylYshbP ujLlJbk4ipAxidfe2tASQdZydrnNWdGfweeHxDWbhlALtCEd/A+nzCvfmP6LMhGAOQ07ZfkU8L5 Yp0w6FmSLHjKO9VgN1THahXI= X-Received: by 127.0.0.2 with SMTP id dpGPYY7687511xfoxLgMHnr8; Thu, 12 Oct 2023 00:29:30 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.6106.1697095770077833590 for ; Thu, 12 Oct 2023 00:29:30 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="471110254" X-IronPort-AV: E=Sophos;i="6.03,218,1694761200"; d="scan'208,217";a="471110254" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2023 00:29:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="824493027" X-IronPort-AV: E=Sophos;i="6.03,218,1694761200"; d="scan'208,217";a="824493027" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Oct 2023 00:29:29 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 12 Oct 2023 00:29:28 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Thu, 12 Oct 2023 00:29:28 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Thu, 12 Oct 2023 00:29:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R2+SErVRiuCLTDWynDILclvz710tp0G2dvPsrC8nshVQa+Dsa1cHaZuzZX4AhCOpwX+2/VTpViKeHxjU2vcUnJVlAbq6JQpm+mwLvPPdyMG9Fp7jryPNdBh6pUNkCmZ2Cc48unBhG8PDCpha5Ou+bwiVrV7oj0a63sdnyQpv9sYsgs+e5wOMQnQOMddPwiaeK9ADGjNtiS8sohlUXvOaNIPTyQJdkI+V1VLOC4fwYlhJeALyIQyRP9JbITo8hHMvvoraLH3GaOucxrG4RHArNcE788q1IW+dv1pyUj1BhOUu2neG4aOPMC7L2qNh4SEBuhcGCjNv8EHXxsurHKCw7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3csRrq3NnoIn5tYL81Qk4Qw/xKdzPxVQaEENnrGHnsI=; b=KGLh3p7hMmTsQLYOW5BmnamJnCXXifov4JIArVVplx7OCgRjyP5W2uN7dp0DiZWEB9b2r3vYoVVkNNl68Sm/v8gAQ4405WmimatT+Y8MNJHospbh185O9wvUJ7arf3oQQ5TOIkSnmcukVkLRVwB486qrMAcGmN6Mb+8ch6Xh8cs2+jcwmD/lUoNu+Os6E2oOJf2tdJCepKwjqpOezkhafZiwJ5X04BInn1y6geSwKz/OWCUwVumckWIXWrIk4TVoQOHnEqWy5p+i+YC4JY6Xc4CcmQFQ5P4FE9w6UfVFS/ebmJZODwVXCvYIBVf9FCNa8mgEAIHSI0wQqKjAWScxjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ0PR11MB5072.namprd11.prod.outlook.com (2603:10b6:a03:2db::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Thu, 12 Oct 2023 07:29:26 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::a08f:5d:118c:aee1]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::a08f:5d:118c:aee1%4]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 07:29:26 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable. Thread-Topic: [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable. Thread-Index: AQHZ/LMDFsJNMGL/JEGoOgxpjSUSS7BFwiod Date: Thu, 12 Oct 2023 07:29:24 +0000 Message-ID: References: <20231012022225.316-1-yuanhao.xie@intel.com> In-Reply-To: <20231012022225.316-1-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ0PR11MB5072:EE_ x-ms-office365-filtering-correlation-id: 553cfde3-8ed5-4c62-d604-08dbcaf4f5b2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: AiGCLIUMRulA0BUlCc4rX+V2Y7u1o3xgqIe2+QpkAYo7L6aBwqgw929VAcPkp4pnxY9X0ZXH7PYH0MJgfr0Nc9miebCxh1/Xy3MSExFHGEsfDI8cEziAQIVZ4f6ZsmwIrDrnL+d5H54MCP9PKPUHVhsUw0LfrGW/Lj7N7KIN3AYbaQ4EV/rtwdKkAo4lTOt2QaPLibMpqccN9+QX81gIe1at95Qr6q5sAGXdmde0pQtXYKML0aAuiHem8TaobZCLaOayeY66CUNwLuygJ+sLAdpt/fuKovYBTYS5jSY2oVC22U1UlH64yYJMnIyJhxZVDs+GjvHLDCisacYJWGrvxpfe25a2WFvhdfh4nEUQJ2vHR3s4f7ms8i8tzy4MOD8MInHFkzUkJP58p15cMyrf3Bwzfx8OOHoWrAGdR0oIsHgY/epTWV19cth3Po8GMNukCuGgcliqeuo8poJBwvi+CtLl0RQ6au6VYQ1dUUpi1qyReIDfrqZq/hDR3SCfc65rfyhhvIneDrP1G1SYC+g7VPU3G9Aw7g1gopWmdMSjYwXlz54m1Za9WpywMEK9ArtJBiQS3I7r0lgtR08DVTwsy5zPQ1HQqbxe5FEcxtXilFmxk/byrvmTRC4csVKFqHmZ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4mkgm1uJApGV+4/EEyUataB9mzBSdr19aO62qGdBa43D1P00N4H/ftOswGqT?= =?us-ascii?Q?LOIb8KxQOnGFyIXL+H64ehavORZbDfMtuIHeRVN0GqO1zdhfi+/RY402w0o0?= =?us-ascii?Q?c/sqw6W2hYFQ+J57ZxKPXyJcsFW2u7LV5x0qDdjdqnDIC4EEHIgsSVlP/ajb?= =?us-ascii?Q?upvYp1tXP0urPJxeeCKf3CvXOtRu0bt1szWAvt8SHWCFyYkzAzV7d20zLYlJ?= =?us-ascii?Q?/AOj9FPLHGHNYIAdkJZwLgEsPkC3wdDtGxsA1mUjw1VL6cQyOD+tRnA/mVJy?= =?us-ascii?Q?O7YAWbHaR9L0JHXWKDm2RAkTG6q2DD7DPfFwX2+yz3D+HPLT67wutlijU6rO?= =?us-ascii?Q?cREadCoco53l6MBlIQWpAcNmwdlzeyxP6HRHy3vw8Fv80jXlY8B+N4Zy7GSK?= =?us-ascii?Q?xHudj15d/FSh5bPCRSx3KrJQA12EWuHt/9Tp2YrWI2FbqIxnRPTJLLcD4qUa?= =?us-ascii?Q?aUM8dKIpCaDtHjzw3p6nGuV9BW7h228BK16RPwbE7rTH2O5iYotYKTbOImtx?= =?us-ascii?Q?94usi2auBpPfKZHB4w80kCr5Dc7foGU1e1qRAfqHdbvEPRdct/NsjOUBMuMu?= =?us-ascii?Q?ud6DJMaMFE7vqNdo4a9FyzBr9jGjAfr7fgcIt+ukxhICqHYwPa0BmdI5UgCM?= =?us-ascii?Q?wOKrhzMxTt1geUYTSw0lAkCYO5d0yjaxfJohwpBu+PLEAC8p6NcXM6B/qyqG?= =?us-ascii?Q?ZinlRAo1COOLN2VRtsi9jgfXi+8pJiHQxGrg0L6iD92K14JrHHyJYD1TUhzN?= =?us-ascii?Q?NmCwr2GEmSAl/85m2mb0YbXLeKMb6qmKE+Fn7z+mAOjJbonYn/2Zl5mA1Nsk?= =?us-ascii?Q?eHHe8SfNecqP5TyCeCiQjjklAni0t/H2zo1V1QUi2cpUxQoGhCh0AWsPiztP?= =?us-ascii?Q?yF+UwEtw4WGDiWX+3k1eNK1NwfeIZApJki6nueLQaXiYWL1C5CWPP0/40KR6?= =?us-ascii?Q?vD/Z/bJax32gByEpgt87OEEow+lrMfw869ewdDbMP65EGHJBIb1CbElWP2U6?= =?us-ascii?Q?U0RoNatmPWMVs8UFjAD8mPYRMWBxpHhDgKRmyD2OtNgZvrR8/IqHuo+leOOE?= =?us-ascii?Q?Fs3RUwIU9ZFtj2llVA9d5ZlOGM3BLZ2EJfC4fve4mH+22XOEYOLhtjC77ek6?= =?us-ascii?Q?ci1m54LnB+Vw2uVOFMc7fDZM1GNVquP9ulj3v9yk4Vqc46BD/RmnQ82i6f1e?= =?us-ascii?Q?7E/the9lhCRHwGMlVGIH2NtWwlWZgfbysMQfv/hg6JQWUBlvuJCoK/dmtz51?= =?us-ascii?Q?KYgXUvVqPn9Gwx7dsQUUxVL9ucY9yrjCn9tca98XcYTeicps66gUNbe/CVE/?= =?us-ascii?Q?rB5Kt7EAGfyeK7F4bYu6oaYxFmRZa11fLLeJ+67xWIL4fbEMDxdXc8kw/HXc?= =?us-ascii?Q?NPlzjD0pdGC/VdT5APIgZ74EbRIHGJ0WpPcvyGlirL5zsGfTNJn+1eb9/UKJ?= =?us-ascii?Q?VR7a07EQD/g9GSxudLzo0Dyx3+FguPNWP6AcmCLvAtpMq6TO3l9WN4hu+4sw?= =?us-ascii?Q?g5A3klrhlyR3YM/qH78Ss1gQ8iPLuybyATqmB8XDiA9ZgQxfFguI2Xx5mwSP?= =?us-ascii?Q?CdqP41SY/4xeWi+Zk2k=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 553cfde3-8ed5-4c62-d604-08dbcaf4f5b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2023 07:29:24.5660 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WM2PPgpfbGbc50kieqpCmWRiPhSECKowTofNzWxqEBBVFpvLv1grswKZFVL1izKcypopqgu2reS4S4dYN1+HNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5072 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: B2iTxHPMRgjvOgdsz4Y23MFNx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82441ECFB15F2E95C9E8F2758CD3AMN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hF7KRrV0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82441ECFB15F2E95C9E8F2758CD3AMN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Xie, Yuanhao Sent: Thursday, October 12, 2023 10:22 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Xie, Yuanhao ; Dong,= Eric ; Kumar, Rahul R ; Gerd= Hoffmann Subject: [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable. This change does not introduce any functional modifications. Remove the unused mValidMtrrAddressMask and mValidMtrrBitsMask. Reviewed-by: Ray Ni Signed-off-by: Yuanhao Xie Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Ray Ni --- UefiCpuPkg/CpuDxe/CpuDxe.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c index c5ac624f9e..bf03978710 100644 --- a/UefiCpuPkg/CpuDxe/CpuDxe.c +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c @@ -15,15 +15,13 @@ // // Global Variables // -BOOLEAN InterruptState =3D FALSE; -EFI_HANDLE mCpuHandle =3D NULL; -BOOLEAN mIsFlushingGCD; -BOOLEAN mIsAllocatingPageTable =3D FALSE; -UINT64 mValidMtrrAddressMask; -UINT64 mValidMtrrBitsMask; -UINT64 mTimerPeriod =3D 0; -UINT32 mCpuTargetCState =3D 0; -EFI_CPU_ARCH_PROTOCOL gCpu =3D { +BOOLEAN InterruptState =3D FALSE; +EFI_HANDLE mCpuHandle =3D NULL; +BOOLEAN mIsFlushingGCD; +BOOLEAN mIsAllocatingPageTable =3D FALSE; +UINT64 mTimerPeriod =3D 0; + +EFI_CPU_ARCH_PROTOCOL gCpu =3D { CpuFlushCpuDataCache, CpuEnableInterrupt, CpuDisableInterrupt, -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109538): https://edk2.groups.io/g/devel/message/109538 Mute This Topic: https://groups.io/mt/101911140/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82441ECFB15F2E95C9E8F2758CD3AMN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
From: Xie, Yuanhao <yuan= hao.xie@intel.com>
Sent: Thursday, October 12, 2023 10:22 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Xie, Yuanhao <yuanhao.xie@i= ntel.com>; Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <ra= hul.r.kumar@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
Subject: [Patch V3] UefiCpuPkg/CpuDxe: Eliminate the unused variable= .
 
This change does not introduce any functional modi= fications.

Remove the unused mValidMtrrAddressMask and mValidMtrrBitsMask.

Reviewed-by: Ray Ni <ray.ni@intel.com>
Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Ray Ni <ray.ni@intel.com>
---
 UefiCpuPkg/CpuDxe/CpuDxe.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
index c5ac624f9e..bf03978710 100644
--- a/UefiCpuPkg/CpuDxe/CpuDxe.c
+++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
@@ -15,15 +15,13 @@
 //
 // Global Variables
 //
-BOOLEAN           &= nbsp;    InterruptState =3D FALSE;
-EFI_HANDLE          &nbs= p;  mCpuHandle     =3D NULL;
-BOOLEAN           &= nbsp;    mIsFlushingGCD;
-BOOLEAN           &= nbsp;    mIsAllocatingPageTable =3D FALSE;
-UINT64           &n= bsp;     mValidMtrrAddressMask;
-UINT64           &n= bsp;     mValidMtrrBitsMask;
-UINT64           &n= bsp;     mTimerPeriod     =3D 0; -UINT32           &n= bsp;     mCpuTargetCState =3D 0;
-EFI_CPU_ARCH_PROTOCOL  gCpu       =       =3D {
+BOOLEAN     InterruptState =3D FALSE;
+EFI_HANDLE  mCpuHandle     =3D NULL;
+BOOLEAN     mIsFlushingGCD;
+BOOLEAN     mIsAllocatingPageTable =3D FALSE;
+UINT64      mTimerPeriod    &= nbsp;      =3D 0;
+
+EFI_CPU_ARCH_PROTOCOL  gCpu =3D {
   CpuFlushCpuDataCache,
   CpuEnableInterrupt,
   CpuDisableInterrupt,
--
2.36.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109538) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82441ECFB15F2E95C9E8F2758CD3AMN6PR11MB8244namp_--