From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.101770.1679666393071923675 for ; Fri, 24 Mar 2023 06:59:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Gogmcv0a; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679666393; x=1711202393; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=I7sRra+RLRyivBbLy/BS2OaZl/z3eKgZVlWOrrknKMY=; b=Gogmcv0aypYHf4Jexzi8BjrUpj4jVW1Ehl/c6rgmEnXlq7Iw5tLL1nJw JD8MTagwQXCjeCgUSeevVAdxtKJzzR6VbOC+J/psCv796fQZjNHIEVq6T x8zbtqPcNu0r+pxwSuDBg6JCKybwqKHqrgQb2+k2Kk9tzflENUIMNL2TI s/IrJx6fv1Iwt72oodX8WzwNLUetU0aOVuB5cJa9oyuTNUgDFhlNgKEjy k/rGpxr8jG/Xyy5dRlX4e7HOYp9Oyadv/Fwv5y8ok06YwOt3+e6CuZyWn XbKcGpou0vtLKnHYMYxREV8wH7l4UNVEzWgAZln9yk4ELVoqCZYzVq0IU w==; X-IronPort-AV: E=McAfee;i="6600,9927,10659"; a="404700162" X-IronPort-AV: E=Sophos;i="5.98,288,1673942400"; d="scan'208";a="404700162" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2023 06:59:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10659"; a="928664327" X-IronPort-AV: E=Sophos;i="5.98,288,1673942400"; d="scan'208";a="928664327" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 24 Mar 2023 06:59:52 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 24 Mar 2023 06:59:51 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 24 Mar 2023 06:59:51 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 24 Mar 2023 06:59:51 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 24 Mar 2023 06:59:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOwfeclNRnVC2PUk7W/GYyPFSM/frpdRl8kNV1C18jOEtHPb/AsEWrymaxCloClqhkmL4IaHmyqJW345oSJc9kzDr7oaDBkJ+UqMuleykWe2DCdyn+Ev/KPOa6oIBfYlK+KtdH7ynSMLIxG7f/JumHs8JwLsHC3gIxEUdwNBaAD+bdSMtH9kb6b6bP9rKdCkBDNRYWD4t3fu1UvdOggvTA7N3vbMrPxA4OtnyXCbCJEf2Cdi/FAUQieU54iBDZl7r75RKdpBzyrhrSztVisC3BvmulJ5F8c5ekwpVpVffMUPpZUIRrdE3L+h1j5D0UvBdQ3hCVrH3/30DBbNH3tpaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HLCXGoUDb+Z1BMHhfbKSJEYiti0lavrdvIWw7xgV3sQ=; b=P1SKpr2hFvEtxW6LYYllL1ytAnCs+Qn8vdbdg3l90suTa650U9Cs+6oIDY9hSQ5nCd6S0ejL/cvkmll5wk8IuwiQ3MCPwO/IwPSJEbww/oLsgbg6uTFJFE+Z0Q6l6onNnzFDfES5WPHQxaV9zmDgGpnAh3RiDNGA1VNET0OmpPS4wKK2mbrU888KNonkCZQ3rq+o6R9NVDUrz+QuhIDAwIx1p8w4iM/vxL1KA5nF0GtPn3wRvpxLhaaA2ymuSbJw2Uv+F1ED7l9RfT6BJaEvJeeflWnlKBvU4fbWELoln+H+Mzvzy62XwJ3sP1gglDV8De3WQNYeLF0ISvRqMIxzSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7263.namprd11.prod.outlook.com (2603:10b6:8:13f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Fri, 24 Mar 2023 13:59:49 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Fri, 24 Mar 2023 13:59:48 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Dong, Eric" , Oliver Steffen , "Kumar, Rahul R" , Pawel Polawski , Laszlo Ersek Subject: Re: [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string Thread-Topic: [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string Thread-Index: AQHZXlZ4C4DhTkjqSkaylV/0L6Ed8K8J9DSA Date: Fri, 24 Mar 2023 13:59:48 +0000 Message-ID: References: <20230324134157.118321-1-kraxel@redhat.com> In-Reply-To: <20230324134157.118321-1-kraxel@redhat.com> Accept-Language: en-US X-Mentions: michael.d.kinney@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7263:EE_ x-ms-office365-filtering-correlation-id: 4a872055-50f1-401d-99f9-08db2c7007cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g7PCXW7rSjdQZ/EiwtBBlDQkIUF3a0dXM/gP1NJtI9jrFrZBOruNcWy8V7ueSQSJsDpfBuHiAf/lMGULhOSJC4ZCdeKZ/06FZgzrEvb4F1V5HiLDgbq7rBcRSmOMrn+Yrh+ZRWIc7FwlrZOuoI4tdNkUHGDAYyXETZxY+6DstMfI5EX0MEMaVL+2A7Q3sUaOodrh0PH42aMyENKiCJTqz7GPfjRiT9LFmjD9gCx+A+brQUM5e/243fyXbeHcVjltFjZUq1RZ9EyCToH+3AtspFAj6niyv8x6NKUSDZ37821I7Ru2q+1IPBT3vFuYnMdO8OyVr2Vbcfso5vbx2QFwpAlqp0sl88wOHV2+gekiAmlhY6jX3H0SdXWGoYtwyd+xgZAo9gViBiQfNe7ZwlQNgTbD2ZU35BEnKtZMEBmigvbMuGOfcBO4He0i9wzcW5IGn4uAFfy/gw65sAqqgdJmxdkgrUxiFlQ4peB2pomi8JPUmoarj3bIaxdc0iOZfur4aCevRDbWreD3N7nLSBKO7S+qtTpozxlP+al9NLMtatSGLZOFbbeTshGOZcCxLga6fZzIuyx9ywSc3+gGD9Lw44uz7dOtMPbvvoUmP1h3hiNpFqcg9B/T4H1nRBB+m2SRUQCix8iVTSZpdC5F2AuCxulW1sQR6QBE1mHujq+kuo7mi7N9OX3+gydmOpSB2GwZfaSNEC5MjoizBKwnpWlnQg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199018)(33656002)(38100700002)(8936002)(4326008)(8676002)(86362001)(76116006)(66446008)(66946007)(64756008)(52536014)(66556008)(41300700001)(66476007)(110136005)(71200400001)(316002)(6636002)(54906003)(7696005)(478600001)(2906002)(5660300002)(82960400001)(26005)(38070700005)(55016003)(9686003)(122000001)(53546011)(6506007)(186003)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rQcJyQjMTEHZwvcjlXJ7Rl9xV2idHylq9uxgc8tZpVIFHDCpZ/fGbvD4eoG1?= =?us-ascii?Q?arEUO5AzcasV2dUqT4RV1mFFR5zDwWjJvMEz0u7wvlPTU2pOvJ3p0SnSOqRl?= =?us-ascii?Q?pHLWlGQtc+QXEEJohkOxM6lgJNVkLo76vI5XRZ7rxI7pp3kOgRwF6bmgyeqH?= =?us-ascii?Q?2+4E+68PteBAMEBn1p/6gNltJYMNoa8PX1UZNLL60v8Ln5C7g/TAvTAwNbRa?= =?us-ascii?Q?oOGPNLDpeWgHL9C0/sa8sz2XpXXgWszZP1aM81fOIstmxbepAgu2rDy+c5P4?= =?us-ascii?Q?uX4VSda0BDnwL0PGViDiYJqp4AdKUy0VhJI0I5JNyYsBwqX40mnDSuXSaUYZ?= =?us-ascii?Q?AChoFQuyFniJS49N4inH8srokCH8arRsYfCp/R+Qvvusz5D4VJHToAx3DJYv?= =?us-ascii?Q?UUM129Jl+Bs0Kb9v54T4ZDQx8EGOXkSYtkxYhiImcNlIHuqmbOnPVz2gjh9k?= =?us-ascii?Q?4NJkIN1Mn+c1SImq+CbiQxmA48ziIUYbOwmwKtADNiIehjqiwDEF/zZ5r3El?= =?us-ascii?Q?V4m4PuDFJuVOVk3Qi68FmJeKjKlC+wLFWqfW4oMEkV4mIaBVpvBOKQ/sJIhG?= =?us-ascii?Q?4vSmQYxqJPRtkM8BZAxRcNbQN9msIw7wYdef/7RQWHzNYULW577Bem0XsUBb?= =?us-ascii?Q?6DzieuPLWl8myTR9uFYthu4yOX6mTpAOKNJ/g32pG4fOC2Co/g9FcVNtF19L?= =?us-ascii?Q?J30oys3QKafCHhJ5zSeqFQ0K0HhJWJZnb/ppjw6efU/mGYGojgr2Hj5JhrQ3?= =?us-ascii?Q?F7owP5t6Kw2nQgAhnMmWL01AxDf5HTnMhvobiHrbmeE26rejNtrMqktGGjNH?= =?us-ascii?Q?S1YO0sjKOHp8JwcrBMnKXPiayRuL6Yp/jjHLCTjrVm7IyLu1T3uOtFlVy++H?= =?us-ascii?Q?JkbuPVriJUx/81yCwCp4ZARZb6whA+iqAJkft1+6c2IWOG65avblO3wd4QUv?= =?us-ascii?Q?wP92iO8WnbtP4tjKaUMtY9y8IG//zm3GKxwftLEf3cShBb4NhG2fXjQQTSfy?= =?us-ascii?Q?NcssffukV7agQoQzXgWqYj9O49Ppwc5EUpSmlLpdTQtinYQQALEcVpr/+BcI?= =?us-ascii?Q?l3xlK9Jo6fD8eN5HbGinH1TCeoxNz9IApZu7WdrWxhIEeTN87nowf0Uw7fP3?= =?us-ascii?Q?CD0O7plgjhE6lMKRJLR3XlOs4H5+ddKfdFCrk7VXM0YiV55VmltpQI7leE4r?= =?us-ascii?Q?DPg4CobFjWHMpeFnEwUB88A5JT+B3y1PGii/5YVvPjeJz5ofWB6dwTvhrr20?= =?us-ascii?Q?S0N3Ats6KVgQTwvUiQhj75T38derdp0v6XJ28t1ZsvYAmOzfE8jHDBV181K6?= =?us-ascii?Q?Vo2wDFOf8by2wFZmcAcaUkz37rPnHsT0F87U//wgiB58dz6U3eOmVhel16r6?= =?us-ascii?Q?fUqfFZEJL6fpTUy3Sp978mioWzb0cPB06CZyyAEY3C0NZyxZDGAH5SFbc+H9?= =?us-ascii?Q?vt693XIRGWLtcAR3tEJwh1+/130dCK96WyAfriEs9gC5DdiaOgr3qLcaD+3S?= =?us-ascii?Q?NTDZaLSlw3WOrzOF4/Q1GxhNn5Odf/tN5VP/z9h4yoOQIU3M4ovvPQr0G7B3?= =?us-ascii?Q?/uPQpBlfy6gNhz2Q+Gs=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a872055-50f1-401d-99f9-08db2c7007cf X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2023 13:59:48.1749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LQO9N4u5znOJ3DbGz1FPQnxFSSq9F7pDocoXoHfrxCjXiNAqHppyOVSINrmsowIq+3qP7RB9JVYh6cL2ud5P0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7263 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, "%d" tells "int" type value is in the stack. This actually works in both 32bit and 64bit case assuming the BufferPages i= s less than MAX_UINT32. But if using "%Lu", it tells that "uint_64" type value is in the stack. This precisely describes the stack content in 64bit mode. But it may print random value in the stack as high-32 bit in 32bit mode. @Kinney, Michael D, any comments? Thanks, Ray > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, March 24, 2023 9:42 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gerd Hoffmann ; > Oliver Steffen ; Kumar, Rahul R > ; Ni, Ray ; Pawel Polawski > ; Laszlo Ersek > Subject: [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: fix format string >=20 > BufferPages is UINTN, so we need "%Lu" when printing it. >=20 > Fixes: 4f441d024bee ("UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling") > Reported-by: Laszlo Ersek > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index cf69161caa4b..08663b1b1ab4 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -880,7 +880,7 @@ PiCpuSmmEntry ( > BufferPages =3D EFI_SIZE_TO_PAGES (SIZE_32KB + TileSize * > (mMaxNumberOfCpus - 1)); > Buffer =3D AllocateAlignedCodePages (BufferPages, SIZE_4KB); > if (Buffer =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "Failed to allocate %d pages.\n", BufferPages= )); > + DEBUG ((DEBUG_ERROR, "Failed to allocate %Lu pages.\n", > BufferPages)); > CpuDeadLoop (); > return EFI_OUT_OF_RESOURCES; > } > -- > 2.39.2