From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.70776.1679574592733291003 for ; Thu, 23 Mar 2023 05:29:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=c8eaq5RN; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679574592; x=1711110592; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CgBCYteJkonTUDIqXa2DsFY+DUpR9rXMFIr1uJsXw34=; b=c8eaq5RNrl3O6+MIDhHU/R4SSLqnvDkXsf/HeZQ6lqm9/7S2rYq1bgML paMQLf7lGKLhRKwhtHM74aftytuzaoRJbRBjiFitXfmhxRWhTZP+CA0Xd U8MVYUjMDvvCERqAL2Aig07CBA7MRC8ntYDkInLuIogVCIsyh/byWInQ4 /MQhXogNh3FAzu1Pf2p0qhyhyUI55ne2qjLvto2VZlDRKirH3k7T/tGid GaMrrFw+Xj1bCsIV6pJP3LVQvhIgc4OXM9cAeRO18fFJmXlJI5qSgMoo3 d2u9EOweQr2NQLnD0tneK1NBoC+pTNm0hg3MwT5GUbMnHUOcMmVgRD2mf A==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="341010338" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="341010338" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 05:29:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856464771" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="856464771" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 23 Mar 2023 05:29:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 23 Mar 2023 05:29:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 23 Mar 2023 05:29:47 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 23 Mar 2023 05:29:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a9fnqr45i8Agto2ykFhj9FqKkld+mTuJNMiEQccy10CE02mG7CH3fVNAT/OmjrgQpGqpaZUPFjWx3UnDN0fwxbWV7EnMFx+MHUKVi4NJ1nW2izKjbKyUSSIACdmB0BdgA8i1Es3etM+vYQDZYtvyIcHGX9sWNxTBULoyzh/XmLeNRzliCrHn5GeBFDwE/FUZbfGU3MPlujZpBKAkchYkYlPDBiP3WG9yNrirAYAOFZjgsWuz9JwR9LVeyBEO8XPBZBy/VjD4ztzx34epR8vORbSWMlIz+J87N0GXodgGb7GYhkfDM7vutFP57Zsm+VRlWEy0tO+FI4WgbRf0Ho3tSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KVugXYmRZU6xL/bQkLxgN324yu5zPyybpDsuzU/TM4w=; b=TKSfegJO0XYvt/V+CmCRkyS88I4+iIdt+PdbzRBQ+AVYinyAdMQlQX2XCEgmoWMwxBm/TI9BPBIeuYzQqf1yOWxOGl3a0eHQ7l/tsy/CLamLlzX0l+YeFKLBHR71KDOieg1oGuAo/w8B+YAjpb5UpU0vRT4MO8RAVLiT1RuXDqpKyPDjqKDyt8As47Lxavb802xyyyMzMNuYsdcYGj1g4b8SmuFgFDaoK7C0/YScad5HhXda6lpWi/aqK5X0Flux6rxUF8Xgo+WtoptW3krhbECgPPT7Mly9AOF02PcWGl9w+WZWlrS4f6A8U8FxkypryWxRor6yZ+RMzxvJ5tmS1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by IA0PR11MB7839.namprd11.prod.outlook.com (2603:10b6:208:408::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Thu, 23 Mar 2023 12:29:45 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Thu, 23 Mar 2023 12:29:45 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize bit(Bit7) for non-leaf Thread-Topic: [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize bit(Bit7) for non-leaf Thread-Index: AQHZXVriEEuzu9rajUODRC5qBRTdHK8IS59w Date: Thu, 23 Mar 2023 12:29:45 +0000 Message-ID: References: <20230323074057.549-1-dun.tan@intel.com> <20230323074057.549-6-dun.tan@intel.com> In-Reply-To: <20230323074057.549-6-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|IA0PR11MB7839:EE_ x-ms-office365-filtering-correlation-id: 74845907-8583-490f-b913-08db2b9a4948 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i6f7qbvzdFyQ/Y6BMed6UTmBm7+rinf4WCF7qla4sPy3RfLOUWIXHjmbyYoxQQWiVt49/uUIaAmHO/845tw56ZT0bW5442GbFWvFoNTEmbgZ5zUY6zwbYUOXyX7Gybqa+2QBgdlz7Q9q1j9cfNB54qnWi3+FgHaVeaOUN0Z8tJJrV+OTlzUQtbhr+QTAXplOwCgESv+RwiyBwA3ohbUvaSJDnFUd6jHirp5NR2nYd53AsuKZEbDhzb297eFOoBxtlapcXc4peD4gtoBuUKEK5KIeLsURhM+2qzGolqNbSunPLsIn9WI4IsAd+mRuX+pULb6Q6yF8UAoQ2mst3R5UL8dl3HE3lumcTv3J8yeqEOl4A07kS/7P+C6MTs0rGGZvHCwbrUDwzSxWXtvl1WDUPodi9mOC+ODU+siZ/cjDi3EbTZPaPe+ILkJ4/FfdXi4OKrvVbu5NrApzDXUOVS8od09MBTHjUh54fQ8ZtWkCPAwRD0NB0kwCByXt/pyRpO0SK5rKbw5vTPp7EnpMknDEsxSRSvu4s48Q9r5wiGRZiaQ7CxxO3hRdiypv93ReDaKa81VLtI1tV4thxxQm0ljhSvEycm/adc0QrUEASNBqLkbwHcdvYR2WhYv1S86dQYUXZFiL59lMmMZjMuL7T4FInvyWDNV+ZsJM4IfG+VK+Mf7QBEfpaF1NLoJdZDNwcEfAs2lmXdlFJGBIJ52dhoVhHw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(346002)(39860400002)(396003)(136003)(451199018)(86362001)(33656002)(82960400001)(38070700005)(122000001)(38100700002)(2906002)(41300700001)(66476007)(8676002)(4326008)(66556008)(64756008)(5660300002)(52536014)(66446008)(8936002)(55016003)(66946007)(186003)(53546011)(9686003)(83380400001)(6506007)(54906003)(478600001)(76116006)(110136005)(316002)(26005)(7696005)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?282hWayqnUBX/uvYwDuq0s2L9oLUhuSbQqbdTx4eIBkZfsZQfiKL3giwBlDj?= =?us-ascii?Q?56KoITXTGNFX7Tdm3OcpHkMO5wc2nl3N+XwGlsuuSRCxNlvUhNRXd0BTEpcG?= =?us-ascii?Q?uys+kySeMCcyxA5GLfuHBrFHbnGIOvDyXA0jhuzZZ+xMkAK6avcTsixMvP3S?= =?us-ascii?Q?fAgzPlgaheR41uKYGoXoyg4x94uGrjKJ+SGhcfS85Fjvlv/1FdhMBkGDCx/w?= =?us-ascii?Q?jDdKWCKumab4mwI65+DJ9NZogE/UhZ6mK5vHCSTESbnEBAyREiLQ9p0ctbJS?= =?us-ascii?Q?NBs0Mlsf94PwkFnl4AYGkMQhilN6mYmiRFNsl/+BsH0cuGbkCxDgJo+p5pl0?= =?us-ascii?Q?GWjAgwR7plswHhSxqe9zzidc2WZkDRclEtmCnrQIWjmiTN3A6b8ACY9DZpXa?= =?us-ascii?Q?FD3iyhwYZrEiDP3Vhn9oaKVBFidpm+EqM9UYWJZvPyyhf8pUItPaug1MhbwN?= =?us-ascii?Q?5Id2xZmYr60xBgRgaKk+GgpGpOF1b8kWeCwWzWX06jfFRMkvvDa4venDRF28?= =?us-ascii?Q?bz6RAJtEs2NoPMp5tMfDzMBaSKRaRR1ABBcSCiyVJPhDTTycxqIHgFFMXJnW?= =?us-ascii?Q?4IDrv/iWWrPKSrk8n0vVXBRVie74YpbU1rQYLacNCJ/hfdW3ogCTUJDJSeSk?= =?us-ascii?Q?Gi8++PineEvZiFNB2IhBXV8lWVlsPy0Fd2fVC3NvBWDXeIjGh94A0j7vaqsQ?= =?us-ascii?Q?OaPpowljHfZx4I6YrHwe1+Rh4LRTjdcAHKfcljMlVs/jRtSRWNZNO6ZUmwF6?= =?us-ascii?Q?99Qbihxy2zYpzNdZz7oJ78sZDNDKIFrabTeABLAcinYxPI1XtyiSNl8tX0u4?= =?us-ascii?Q?xzBy6jCNiOlq/AaaYdiyd0tdX4Dm1C7tXDl9qBdLMy+grOse1H/c9Rrt5lX4?= =?us-ascii?Q?HOI7lTbKmoo2VyLHVAn7zvrSIOuCWpTukFZYtEbmitaP06gp2FahXyJoRD+0?= =?us-ascii?Q?43XQvegwjXEZsR7VxCtOu5niRDrT7biaWqKg4aMCwngQqt0S2xHLUExKa+TD?= =?us-ascii?Q?PyOhqW53hYaazGcnzwIZX6oYFxjzgJ0/w78m/LbOrnQ8OZqul/nRZ/HOgsGs?= =?us-ascii?Q?redvZjRnPXlkfpFXNM6f6igTkzzoUZEpLItRHRUOtqLENjTWQ8X9c2YZaoww?= =?us-ascii?Q?qm+V8wu3yZMIlRq0gt5MtZBfmv0eIeYj9pkW/B9J2cFTaGrT2LSZaJnwDpqD?= =?us-ascii?Q?QJTXSa/CvChY3O6MaM8nm/SnMo+ws59maXmEF/U/qf1p737hEx4QXJLUwslG?= =?us-ascii?Q?Hpugj5bfAJlSsBwbZpm31aCEst6VHNRAGOFTPu0ji3BwfnGjHQsxqN6By0wp?= =?us-ascii?Q?tmvhfsowrprWzHMFq3ZKqggdUhITQc7iIwa/Xwwcfzg+wKzKYgzVUZm93Kf3?= =?us-ascii?Q?emS6ars67lxGnZ1hiDTpxcuzWYu0bHdYJK/360GgL57CZNu6ovruslWdXvFX?= =?us-ascii?Q?Y3G0AKO3ImFOQMMYVivJCjx4NOyfWYPJqQIUD2OeBNqtx93bPhxfJALR0NFI?= =?us-ascii?Q?aCnUq6hgBlrRPeITeHDjLsLtZbRnrrONrvHmT2/GPCyMhkkx549THN4+3/vH?= =?us-ascii?Q?foOMtoZQ4R31vV2Fug3RHyNF6uEF2IToe3dbQwke?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74845907-8583-490f-b913-08db2b9a4948 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2023 12:29:45.7205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /JsiKoPDsKp6Lnos4+KUFW7ks6E16B5W/Zs6KYseSl4o+sgRoOuMQnqHEClyxl16gh29hgzOEVGfLy4snxcIiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7839 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 05/21] UefiCpuPkg/CpuPageTableLib:Clear PageSize > bit(Bit7) for non-leaf >=20 > Clear PageSize bit(Bit7) for non-leaf entry in PageTableLibSetPnle. > This function is used to set non-leaf entry attributes so it should > make sure that the PageSize bit of the entry should be 0. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index ad68792ca8..cf0cfeca77 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -202,7 +202,8 @@ PageTableLibSetPnle ( > Pnle->Bits.Nx =3D Attribute->Bits.Nx; > } >=20 > - Pnle->Bits.Accessed =3D 0; > + Pnle->Bits.Accessed =3D 0; > + Pnle->Bits.MustBeZero =3D 0; >=20 > // > // Set the attributes (WT, CD, A) to 0. > -- > 2.31.1.windows.1