From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1614.1678860126772676121 for ; Tue, 14 Mar 2023 23:02:06 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ejvCT3rL; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678860126; x=1710396126; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LAVjACxhfOOCqbFW+3Zf3X0HQZB/t3goGjRn04e6Ryo=; b=ejvCT3rLy6bgLJIDbVL8MYX6rXZYtkVl2V7KVjuLTBVXMYPo/O6NBbkj L7PBvV1tWhD5NDvCjndCO8vcsbuhrhDxmuSSNV8mZbMksFQrH260y/VVJ 5b21VSE7bsZnxPKyhokZ3y2cSwYL3bGbx3OlsbRj18GwM+y89wNoKcOKZ gAmfaQRxt2ZyArz/qYOuIABlqkge2Vq2irZtqvukYf9E8DwZEhKwHHW5F 879qhTxVsbZcSfbNxR6rHaX7iu2ISyoRMLT/OEk1zjL0SEMykQXHr+ZyM zdylWql9487JoWWoZYRtzFdiNCTgpnosJXRx90UK9cyNCfet2M86EM9nm g==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="317273723" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="317273723" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 23:01:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="743568352" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="743568352" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 14 Mar 2023 23:01:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 23:01:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 14 Mar 2023 23:01:58 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 14 Mar 2023 23:01:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iPkgBVFxpCyWJyVXGStULcDIPRUqbPI5BcC1Frvmn8fzDU3wyQUqY+Q9MkrzhhKyEAp1I5aBk9odc6430it6aYABS9ZDoi+tfcbt/zimcMapyGpZcBRZmt/w8tMXF0pc1jgXP100FvGsv1CijTgalKFqFJnLh50nk7IoplVRv49TYNCEBgRUAQNBgtgLP+eq78a0Sp6uaVKxrqiklYgejrlvlPMwdyl1PYY93rNwEokYdbE0Qs0epY4x2Rqo9Lqd/YAZrQf6ELve1fduaNTTAbxI+MsXZ03jLBCt7fZsCZS2mM+h6BEEyoaqFRl8rT9DjhXCpWRZtiIyfJqI+dgrBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fElQVQQI1/pZypn4sdXXEZ5mu+zTRadhqJF4sdvo//c=; b=aI0CCVNL/dY6IFi94HVZRH+sVHMgKhw2j7OSbVruBzUdwtgzpxkOkdfz+p1l9GD3BOrF/dn9N4SERDWVXjmT7iUz3xBNW65zLmHZwiBhpcgGYsjPkvirC0XftEH2s3xUUaiFwy9+Lg4bAL5aXcX5Zm5Z7S19veiyymRXEdL5AU9dQZzAFkTXPLktwd9X72KiAe8jn8eQvX82MDX3SQ0U4wC8OX17+ni56I1BdB9YawtkCtpPVgZ0+7PP2L8f0SnQOf3EURcEiwlIRxXFQ8o29tlz2RjeKCUGrv0r42WiAMEBbWg30uPzNT0uzXRiU6nOm8bfmSwRoHGwUSpSIQOLeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA2PR11MB4971.namprd11.prod.outlook.com (2603:10b6:806:118::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17; Wed, 15 Mar 2023 06:01:56 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.024; Wed, 15 Mar 2023 06:01:56 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 09/14] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter. Thread-Topic: [Patch V2 09/14] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter. Thread-Index: AQHZUaYQLaZoSJ4V8ka/grwfssN7HK77YYig Date: Wed, 15 Mar 2023 06:01:56 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-10-dun.tan@intel.com> In-Reply-To: <20230308100758.669-10-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA2PR11MB4971:EE_ x-ms-office365-filtering-correlation-id: 8e67d9e7-c0ca-4cac-4d0f-08db251ac871 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gEs3f0r/V+L6SxJyTHqAWsNs6+ggrO2hQtot9Wur4p6hoXHlh2xqYphzIk7t8uqra846Juh7xlTVL5K3q7dU4ZF211spgIHfEg0UikKV3K3Pn0Qy7YGGRfjeJ76xeEDolzbkjkCFP9RqAFKJ03I9ooi891/cckBCfrcmhQxlDgbsz81avVdaBI1SFjy6OeyTgFzOoEpoar2K/E4fAld1eBu5ytfdSlSQ911Syt9zz4L/YKxu6ejM8RXFq+bZPbeQDUiOxqqOASkmQ3iV7imfQGJo4XjLkAG/ZtyzGRDMVa/KRov8TNCBFefMPst6aTrh52xpob1XXaZ8Q1I14kyCL3+SRZIjoGAZKhE1mK3ODqujUR5O69dy5kXEkJJLkofuCPTCrrVRjPpCKIh0DY5Fw9dsYMCEb1JakRtZrDtciNlz3MDe7VH3FVaVFYYlEchdS1senlixNaxH0RE++q7T8I+FfyJbncDCkYYuIL5l6OxSNKEP/UqJVn6OatKtDHwzTIFGx1Gi9RqDYMECeCvKXrDRIgBgw9bx9Ff6liLS3gQI9nRM/f6cS191kay8BrgJBhGembVBAelvYZBbLlA+sS2zq3k0mkM90QnMi4q+2V/9riY66pdaZ1Zg9XIqEXQWbWtP6RS3v9A8yd4WIrwQDwz2wsQlpHFmnqoynG6rtsmFJMfS1rfQKKE/B4Ev32CrC99cQ2k1MnOn3hclxJVBSQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199018)(55016003)(26005)(9686003)(33656002)(316002)(110136005)(54906003)(478600001)(38100700002)(8676002)(38070700005)(8936002)(5660300002)(82960400001)(122000001)(4744005)(64756008)(66946007)(66556008)(52536014)(66476007)(76116006)(4326008)(66446008)(2906002)(41300700001)(6506007)(186003)(86362001)(7696005)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?APkU3kC1Ame0xi1vuXtpqmIG9jiLO0Kpy0ccDff0rrw8cj9No+PplJWKSrc6?= =?us-ascii?Q?im0bpJe47AWx4t0oJQ0bR1f8yYIpp+7MBcgVtIbYiciAvp5SppW/kqzuzRvP?= =?us-ascii?Q?imtBm7DKi9cM4qQhGaAw3qZyPlgR8deG4VRdZT2NoqpfthqVoDK37I2MxeWn?= =?us-ascii?Q?9YhIgVwLjvflGjSBpxt8q9/4McpI66VsCVAQv3mgmzNDOXygnARcN9yUiAeX?= =?us-ascii?Q?KqW5Q0K2JU3BgzT85tiGd7WrPPTKxCkspusKgQ51jCr8wE/z9M8YoMYFECLe?= =?us-ascii?Q?wJ5GJwlJKvQjXKRb/bVFpnFsM/8BmLugbZUMZdTxk+IhLZIzeQiXCmtJmqHK?= =?us-ascii?Q?vTp17+zeaTtbfpnE8KulVaOFmjjicByG/U9i0p8sYEzH9CxUf1YujfqCTW4n?= =?us-ascii?Q?NqaBDGqbnVRqYa42qkZTaE8sS+yRPxFs72CniEevhrZcnYa9p9f+VmatwAak?= =?us-ascii?Q?1GXKh0UC+EYSi9cmhvTybkUeqgmseuk1aZ/Uz7Jr7Nob4uHoD4YLVwOkFQYI?= =?us-ascii?Q?zWXr8vO4kzlqO6+DwekmyG3VVIbkSMnIpKVqru5bTcRMCbYFgnRiUQTGK3TU?= =?us-ascii?Q?Ot6ZjATeosuVGR0Rqsnsy7WQ63WAI8dEclS+dqQ5seNNKpQFk4iV3U4+LGSx?= =?us-ascii?Q?0KR0fii6eZB95Jq/L8kDt+U3s4w+vrDrpopbDuxcfNftLRsA+zFeGy4rEDrX?= =?us-ascii?Q?RwKMf71rLrmjsqA3Lze2JNTjm4HwuJYIyaSlIqXJvksqorslNqTHhDGwZplE?= =?us-ascii?Q?JZdQhlNpdrP78y4Juuz9prSQk0BdIjuuDvivMXM8i4K/iTXKzILsMxqLQWWf?= =?us-ascii?Q?3UnsbulLjdXUE62IXJNytTVqXBU5Lu/gNXKGXe95hDxIo5lYsG80/cv1ma8d?= =?us-ascii?Q?S7CJaCRHkpxLghk+X1xolZ+CjZvaFxPRi8y4ONi4I68LeD1RY9CIExhwHzA5?= =?us-ascii?Q?eKexGTT6VoCLsVhD1AEJ5hpegLyANNQPs1j6FMDW6gWFm128snPOe6dWck0I?= =?us-ascii?Q?0yOB9xiiPwOfXIT9fpozkM6jtWjvKeduAtOEsZrUHD4WTLVZgddHWbvzPgTA?= =?us-ascii?Q?pZfOzvQwntELheMVzM7TJod144LnaagIoUGsU8VlePzvhGxe1EL0bGoeNnQE?= =?us-ascii?Q?xmHUS7b9/WJXpzNq76L7dWFqsJZ/eDpyaWnFvG1Pz02QZsCdexEOFXBZ+s5T?= =?us-ascii?Q?XqeqInW4Tylrprqu5Phq6bNraQpF1PebIyuhtLB56Ipu/zIzqNqvXJh6CUOZ?= =?us-ascii?Q?4wWvSIbgpwCaNuJ3SvwFBVqKpy12GDpjQRAFefEFR781FK8ecpe+tPTfGtNW?= =?us-ascii?Q?M2m+B1mbMeMWOOFpJxeJF9OUlhPmKWb+FeocTXkLI3e2SMucXb4taVLT8tK3?= =?us-ascii?Q?y+SnGyTC7zzI9DF28P3cNZxWP8UJSHjQ4tDzEoIf7t24X/y9tQEXDcZT9yxt?= =?us-ascii?Q?Nt1isW0GXujaqfsdBIkbbHEdQFFjPviuo9ECMFor/QmpgdlMkxuB5twwOgJb?= =?us-ascii?Q?z4XU/WBlBPlrF6jv9GHYo3Lw8eA4gMuaV0uNvnOwWRgVnkpuUflpt/d2Jw1P?= =?us-ascii?Q?rzyEsVmDFMU/ANJHg9kRPQqabhE7eGyWencar89f?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e67d9e7-c0ca-4cac-4d0f-08db251ac871 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 06:01:56.4834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bRNBfi/Jc+vYDObt9y2bymVAvxUY7t0DO7tvjDOCcSC2nV0adbp8MgR08jZBPW0PFZR1qhiBKw70Ykyvk1x9Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4971 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + IA32_PAGING_ENTRY ParentPagingEntryContent; 1. how about "OriginalParentPagingEntry"? > + IA32_PAGING_ENTRY PrevLeafPagingEntryContent; 2. how about "OriginalCurrentPagingEntry"? >=20 > + // > + // Check if ParentPagingEntry entry is modified. > + // 3. Can you add more comments to explain why checking parent entry content i= s enough? > + if (ParentPagingEntryContent.Uint64 !=3D ParentPagingEntry->Uint64) { > + if (IsModified !=3D NULL) { 4. Can you always pass a non-NULL IsModified to MapInLevel()? 5. By the way, it's good that this patch doesn't enhance test case to test = IsModified return value.