From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4DC7A94154E for ; Mon, 28 Aug 2023 08:13:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2oAxMvU49abpkjTXGcqIFmL3rofcC5dhlLlKRw7c9TQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1693210391; v=1; b=wMydjQJQVqhVV5cVIC0u//Vb/z9hbK4RuRRBBK7v69IUADwvHT8JJkPHk+qs7reHRGu2NfiK RXvxE2SvDTBRm0pgdhXOe6SsXVOylug1nj3pCQVo+VPQrR3au7htim5TewY0Pzm+g0vJE07nM97 T5CYsame+ZDsQKphhm6Iy1XU= X-Received: by 127.0.0.2 with SMTP id V07YYY7687511xzLaMmmOcTM; Mon, 28 Aug 2023 01:13:11 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.8973.1693210391252108983 for ; Mon, 28 Aug 2023 01:13:11 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="355372560" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208,217";a="355372560" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 01:13:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10815"; a="803620981" X-IronPort-AV: E=Sophos;i="6.02,207,1688454000"; d="scan'208,217";a="803620981" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga008.fm.intel.com with ESMTP; 28 Aug 2023 01:13:05 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 28 Aug 2023 01:13:05 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 28 Aug 2023 01:13:04 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 28 Aug 2023 01:13:04 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 28 Aug 2023 01:13:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5QkK4wc6NHxOWdnAz+MBEjrp3IxwOlb7r8Cb34WK4mFIQRQFMnkprGdd3qHb5st8EOh/z8hvqpM3CpFxrophdOdhkgHUXwWEHGhyCJ4tCg61wnhxcpDOJCxyXa6fk/dUhjhiexlt/exCuiMyeZ03dTv/J9D+E4zpWrJw3stmWlQuYxh4Idp3MXQqZ72BJTDlJOn8dXhwW8NSLmdDHO2ChXI3bscDoFh9AXZ41GdjJnJ7RoaeQRDRNUOAnD2PSeTwYf2XD/nt0oNxjPIZbqVsQ44PVGChUng0TDQg8PSsXO3H+vfS2Ozl9LlMCpmf6fMhcie7oqS+hqCX+Omz1MsKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lpl1Zk91yOwUZlSYZjXEmKVyv8aIwCY6LwCuRgWmR7s=; b=bvvQrr/a591bL00uHbY6jzZVqnecES2N2vkqpDbnfeU0yy0WJCtJeQ2/+2b2zfV+3pSvRlYekAVvLTMusasnpLdfQYDp7xuvSq81zXxbMJGPVV0yst/KSs8YRSyUoDpY/uEo5aSMuA684ICWSY2MeJdLqXjKBBm+kMTZdCVZGkFYjyLHq//sZVi8tkdFkIvKQUbFWO3AvwVjuH3WSgMrf7oS75tdUF+KRb1NKXf2sHCXcB+Ro0Vn/bP0ovqxGKdRHE+nTQNcU7FpAwlHKH5dbyV1tFK1FZYU89nCjzwO2MG6CJOIJBTzo0koGt5ZyoykB6ffUSqxipQ1uylElMwCiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL1PR11MB5416.namprd11.prod.outlook.com (2603:10b6:208:319::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.34; Mon, 28 Aug 2023 08:13:02 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6699.034; Mon, 28 Aug 2023 08:13:01 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCorePerformanceLib:fix smm perf issue Thread-Topic: [PATCH] MdeModulePkg/DxeCorePerformanceLib:fix smm perf issue Thread-Index: AQHZ1mcRxcRLFh2X00K7FZkJoetxk6//YQr5 Date: Mon, 28 Aug 2023 08:13:01 +0000 Message-ID: References: <20230824084215.876-1-dun.tan@intel.com> In-Reply-To: <20230824084215.876-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL1PR11MB5416:EE_ x-ms-office365-filtering-correlation-id: e3a17e7b-0b18-4edc-f0fe-08dba79e991d x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: s+QsG5ZfZ07pSTpdyZ+vOoqNPiyFr+hrVy0iQpwj0EltgJ2D4Gm9zhrVg8ec+Aj2RHMrgKimj9V6T2gltCZuYRq/dyYKM4+6ehBjGSYI4QwZHd7d2ZA81YbJgDnmBG6cd3lO0uPCMtyifZ6TDQI06+a2Sb5M8jvSGe3zRJNd1GDQMkYe9rlYMFCoR1ksC5DkNiDpY1zuzYZgjgA6a6uBreJDoa7nogMyylt4/lKv26XX3hNV3/24dQfkBiRBbUu3JFuz/EofUlgwY2WIxIhEjRmToIAmCiRl8++OvMEUhmWoEWH2dkAgfBGm3EIkAbYz8i46gH86dTA0x8WFY3gdFn3P0uBkCWBhpcoqqxf2AmXKYtWuwhU9n9Djf+n81DOhJSRmJIa+DT2i/vSLxOEZtf+oprr3XUE+X1gVaePwfsYiGIpV4iv4kufD95oLfD7eU3rUrJvTWyVBsTzU6h+n/FTCKb9nqaN4LtFfUUV0ifxccCe1CIJbG1MhrNhcSRQx7RTEhXAeChztYM/tyRRtTWwLnt8Qnt9szbLWGrn+vzowPFk55xbl/iZ/5nskbXkseGrOy6GsNIiCh/x7JDo8tNihjf0QQ/wL7g4hsQsJqIv9U76UZ0X1VvN0GyTe41kO x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SkUdsuY68fEL4ODaW9EJONRCTIYBgeV8zSrvxGcm26EhM49Uce9HCgL7n0?= =?iso-8859-1?Q?a+odHLS+Fi5uHTCqTrbtOETdeEIRZqKkVF+B1jcqTiusV8mAP4iZlw0xnJ?= =?iso-8859-1?Q?qPHsRJ/rGdgvk37Zi76QAqFmNyWdYs9irLz/1JhumEIcR7yGomvM6xYlwQ?= =?iso-8859-1?Q?yWG6GfLztcM/o018t+PATPs5bXhvACDEDREGSF/ADw1NhH0EryF+FA5Q3T?= =?iso-8859-1?Q?8i/oeMXwACoPruWOqp550+8s+FEwuAhlRqlsVLyRwwR1UvPxUhpYC/TBF4?= =?iso-8859-1?Q?vg/3NLu2uDaolP2gVAxEYFNdIr2jY44EDaa5hBJxfWcqdHeYYni6S6rKK2?= =?iso-8859-1?Q?lMY6hlpztNmrQjPmYLPXEB2EwAsqiYjoJ55f2PCsa389tGPrarWeljC49m?= =?iso-8859-1?Q?QvjHN9gMNjFBAK2W/o/Fvvg35sAHos6kUEBtZTE18kGtMlw3g9aEByp5C9?= =?iso-8859-1?Q?9gxclVnSVyZvI8Z/SL8/0CGnjMbCNvfETrSDAm+YPJ2iL7LK0IlJ4ocg94?= =?iso-8859-1?Q?glYZ8iqqi+RM9zI656Cn3B8j9Cqnd0ImSFRaeSF3oGPbjznfQ2iebgOGdP?= =?iso-8859-1?Q?Ipo8huKSz8JGPtDQZKND/TvdQRaFTBXWIcJRFGitW1Pb5GsZYii6/+l+Ak?= =?iso-8859-1?Q?PV/eLT8ZJ6hzMEfJbTFCSxt048nHZSiGKEzduhiVwhOVPu7GswG6s/4jOO?= =?iso-8859-1?Q?P4F9+lA+HI1acFD72gHNN6vaJQhn9sYKDkZwT0DOqBIVuALjTQLx58Fokg?= =?iso-8859-1?Q?lVbWz0elI3IcNHcZnkjZcny07gGQ9O4br/zNWcuFHdeASkn4GHUxfMUFEj?= =?iso-8859-1?Q?TxTuJix5eFgR4MOH7MH07mjCM4tY0Q8pIrfmFheTJZOZlRCsiGCC8hsSYm?= =?iso-8859-1?Q?UNLYqZvbAI21b1l6c2AMOgtvV4GWue+2rdXspx1mHQohxtT62goGwse3zf?= =?iso-8859-1?Q?wv20kpkmRubU38sCS0J/vMU0goMFnH+OrMhIQ9IJtodUtaqgMdF37Eg8+Q?= =?iso-8859-1?Q?xbvwFWZlnHFrXsh1cFL/r/4gCPIN/eMlPj1pzhLRdJQImrK9R7q3CDPQR4?= =?iso-8859-1?Q?K3KuTDykXpcrCji9Wl/3nzDDY8ivc7JvqBN1l74LBgeWrkFKxstQ/S66sr?= =?iso-8859-1?Q?K7WY+uE0lvgmPRmisssZaERfu6wBKOadnmW1vDpeKpevsxp0swYA+Htvkz?= =?iso-8859-1?Q?I3+YvvYnbqcZRDjxTw7ML4OqiThlO+kv3h2JUDC022zhILt54nLJZcQ2wJ?= =?iso-8859-1?Q?n2vi0dxLdDmsDOlElzT2f613TzA8TXPR0UwInuZrczfq1Wl4Fk7WI9h8nj?= =?iso-8859-1?Q?YT+TeI8MNLOEdfKuiuCuAUHMmNz68u1yWpEBegy909kfUst/c5QOzl7O4P?= =?iso-8859-1?Q?WArQvBmg253Ln9kpz7jvZ/3IClwXJBWeaT5K/0ClMc3lzuevSzbmhx50lP?= =?iso-8859-1?Q?uNloJv7olPwX6/lR1FAlBI11W/oDqtIW4lxjSbQn34ljd/H2WEfUrMvD5v?= =?iso-8859-1?Q?zh3YOubVqvtcN6hRqe668yhYWJDqOE2TenoWFRahYH97zXsXsNZDE7qRqP?= =?iso-8859-1?Q?50yCzW510fxdsTKsurhkgtEu5S4gqWU0YHj8cu4VWSOagKWtk1yC5BPa4V?= =?iso-8859-1?Q?zWWUnjU3zUCH4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3a17e7b-0b18-4edc-f0fe-08dba79e991d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2023 08:13:01.8133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aBUKDo/1eZtoVgGfjRFTpxktk6rNXY5Op7ZjQPKLRL/LOOOziTprpZZy+L54BIWUFEng5cDUrnvsB2y6E8xBhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5416 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YXVqE8svarvey9XFoDNxRu8Fx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB824428969BD70F67692041928CE0AMN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wMydjQJQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB824428969BD70F67692041928CE0AMN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable 2 comments as follows, starting with "[ray" @@ -73,6 +73,7 @@ UINT8 *mPerformancePointer =3D NULL; UINT8 *mBootRecordBuffer =3D NULL; BOOLEAN mLockInsertRecord =3D FALSE; CHAR8 *mDevicePathString =3D NULL; +UINTN mBootRecordOffset =3D 0; [ray.1] How about mSmmBootRecordOffset? EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText =3D NULL; @@ -236,6 +237,7 @@ InternalGetSmmPerfData ( VOID *SmmBootRecordData; UINTN SmmBootRecordDataSize; UINTN ReservedMemSize; + UINTN CurrentRecordOffset; [ray.2] How about "SmmBootRecordDataRetrieved"? -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108051): https://edk2.groups.io/g/devel/message/108051 Mute This Topic: https://groups.io/mt/100931879/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB824428969BD70F67692041928CE0AMN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
2 comments as follows, starting with "[ray"

@@ -73,6 +73,7 @@ UINT8  =   *mPerformancePointer  =3D NULL;
 UINT8    *mBootRecordBuffer    =3D NULL= ;
 BOOLEAN  mLockInsertRecord     =3D FALSE;  CHAR8    *mDevicePathString    =3D NULL= ;
+UINTN    mBootRecordOffset     =3D 0;

[ray.1] How about mSmmBootRecordOff= set?
 
 EFI_DEVICE_PATH_TO_TEXT_PROTOCOL  *mDevicePathToText =3D NULL;  
@@ -236,6 +237,7 @@ InternalGetSmmPerfData (
   VOID         &nbs= p;            &= nbsp;           &nbs= p;  *SmmBootRecordData;
   UINTN         &nb= sp;            =             &nb= sp; SmmBootRecordDataSize;
   UINTN         &nb= sp;            =             &nb= sp; ReservedMemSize;
+  UINTN          &n= bsp;            = ;             C= urrentRecordOffset;

[ray.2] How about "SmmBootRecordDataRetrieved"?
 
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#108051) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB824428969BD70F67692041928CE0AMN6PR11MB8244namp_--