From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A133D9411EC for ; Fri, 27 Oct 2023 05:49:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2PU7twXnDhqUf8r+kbEBfJYIl0+smOU44mw8UlIWqPI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1698385745; v=1; b=xNvHx86WU9GmEesoY//BgQBz9LWbdv7RqxNGrcFGQrI8gP1JzjvwETTcSLg6LNRjHLp6jx2u Kkv58LfRT2/sBhS3GlNoAGvbnE8TMxZ3zBQG4G9MFGyAXQPH/loqJGYQoXJ+ttIaDLIJd6e1BkO GozwiwVbi/OC66MraC1u0ajo= X-Received: by 127.0.0.2 with SMTP id URY5YY7687511xGz4mYOxjOQ; Thu, 26 Oct 2023 22:49:05 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.977.1698385744678048033 for ; Thu, 26 Oct 2023 22:49:04 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="372763115" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208,217";a="372763115" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 22:49:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="883089131" X-IronPort-AV: E=Sophos;i="6.03,255,1694761200"; d="scan'208,217";a="883089131" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Oct 2023 22:49:04 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 22:49:03 -0700 X-Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 26 Oct 2023 22:49:03 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 26 Oct 2023 22:49:03 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 26 Oct 2023 22:49:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JDVHHDRlx2QV44J+CC6WLPJiPz9jR8LO+CwYj2fxaAlrCQfwEPacUADdnDuUHrVbeMymQ/06t1cXuGCfpPFhfIrvSnxIbk4zYUY5lGESXyDs4gSof4uHthan4ur5LrKrRRBuBKyhdGVqwEmh0Bt8kRTI1xqONTCIeJt7S9JnpmuVoyzYLi68E+PSM2t6lHVKqZomqAhtNIoymfPlOEK+QXx71lBRAN3uD2BLo5AP5BkxrZvlkNuJIfKTtQ8yVeyz15J0yfGtMVdbDpg5uieZIlaWBTr2BIaP0nkDNFLutqL5iH5l++Wra016W7uNvJlrVKcX+RLWBNBqH1EGOnZ7pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q9zIbQxvhZ8g7p+759EcMVEZykN6kBScIfq+VPLkZj8=; b=e+f0PpzEG/B2KgS+qs6pGnjcThMljkQc/IKrGjZGbkivgdp1J8CWJ+t0CcIAxHkiSnkVzqicDVwtJle9Psuqv3v0jvxbecbDnEyfP2os38C5NVepb3wJrR6PHdzPg1hv/NuzVH6kZe1Oak39a9v59XPdKSX8qaYp1sVvtVw8vxfdNkOEfuzCFqTEA+9X9VIpNRSCOzMreOOJ70sBs5S3b7VohzYLKNine97TxUKoTLgwXqWitpzGTKgTDXYnYS0uNaARDMCsbfKc1FFWp8iXk3B7GF4nxcaOw8pxKSi6yDcSwjTCyhQSHMH1zUEezJJVZp5H5zYFo+1TpDRcLHgzBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL1PR11MB5448.namprd11.prod.outlook.com (2603:10b6:208:319::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.24; Fri, 27 Oct 2023 05:49:01 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.6933.019; Fri, 27 Oct 2023 05:49:01 +0000 From: "Ni, Ray" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inner fv. Thread-Topic: [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inner fv. Thread-Index: AQHaCHDdMzDRNfy5M06p/2fdlt4FC7BdIUeJ Date: Fri, 27 Oct 2023 05:49:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL1PR11MB5448:EE_ x-ms-office365-filtering-correlation-id: 12d9cc27-4922-4177-da63-08dbd6b06b92 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: /IuUhXMfDX5QGTUjby3vy6XgVH8WrWZv5C7aAgF2/bBKxJKjH0jma2RxTiUMW7N8Pk+I8XFJcKV+dP1ldAPe6nINnZPBs6iKFyhbBr+Ha+zS9F58Ln0i7pHSsCd+fiSzZBiDUcPsHXy5PqL7v7hUvK6B+jz3za1+VRGrISpmWRSsNanVBeY6GxxaPIQls8CXOqITnaBMcS3sv5LXKZ5+3CLXQzk8VRImVKCOqiNlY+i/ohT3+qh/BSF8txYhbPLi/hPgjWe6tHFMyDp19NCFZR+PmmzIpu+x+Rfqb8NvL/oGaNEmtROBHKLdUYJVu7Ay62gLZrDD/0XaO2hVWmkFgVo/D1+UaZY8sSjiqErMbZpz6iPNf8OlD70rQFK2z9z5v8uOBJ9vK8FaSEPGLM54zJRSr0kzyfBMrWWkppqXZkHskkOs5D2W2nwLbwuzUU6iM6kDIf6dz4U6+ZjFda+yb4qVgJO4Ni1Q6OhGnbX0jWaeHUN/hkmgCOSIY5rReotmSfvetm/9fHq4xzBTm3BES8uBGkUJdz0n4NH91Wsg0CKTHDN7eMxce4MfzFALu7FcF0Ne5Jg4kklrrtStwuyym6W/W/2wwT+V8j2Dt1XKEM6QYslzBF5UF3nP20eMlxiNWurPJ6F6na5HDInvVBNBYQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Aw51OPKM6KKwmbH4FxJIJAHGJmkCmlpkWaxv5jIXsEiiuvHeG3ZKfhC56BEa?= =?us-ascii?Q?xxH+dBQaxMflrnCnRf8L3koQ2vcypA0aJW6EoI9mn9qpjWgt2pYJw65HVYXN?= =?us-ascii?Q?xKJDPiiQU//o5fvX3m7nkMr7Cozk+/fEYR/7SWPQTsiwOvxHT5EChOS+bNzx?= =?us-ascii?Q?S1OuVM/fvf+CcVViojO7WOWQBenalegcXvcA6Yl/i4ZWKOnIqS2g7I+KdanJ?= =?us-ascii?Q?EOKC4P2q6JpCttkj21x2mOVJXHIFjzRNX7XOAkWymWuSJEXoS3cvJKzhNXOk?= =?us-ascii?Q?7F/SC25q/lRj0ERi/Ck3XUnprqZ8uakaXMEEqn6EFClS2pdwVAkR5jaKyBul?= =?us-ascii?Q?yguP/uF2VXEls63qlsZygP3wG/VFmCRWh8l/J1V3KlUKldP2y2ZObFyw1/PS?= =?us-ascii?Q?b7qdKdgxo8pKZTDyFIwqxMRifco602hbsQ7zckplBNQvSPpWDPsEvg6/7GHU?= =?us-ascii?Q?HX7cwhWOQTRJ84b0MJKYKaiVgyOyiBiDJwNmhxO7jdFvmpuqqvKF1m/WwJhP?= =?us-ascii?Q?tlm0uMVotiNe3IS7ck8jCPsmiU9Nan7NQIV4ECZzRFSnTI6VaVSNiZiQkxs5?= =?us-ascii?Q?+2Jprym4qlsXLyFUHZ0G8Z2e0JUIpo02YvIKKO76daSxO9RMcsnp/jsHrSye?= =?us-ascii?Q?f8Lj/1/hlMK9LtNwRX+wWdG87zfCI8KEyYtRyTTLpNdblKftPXxULBuGd9fD?= =?us-ascii?Q?Fjb0lJmJVW0oBicqR8sz02BpeDgI6iC1kFcJDC0CTDZldBS7C5jmOM15aDug?= =?us-ascii?Q?1feQ16JrHI6Tg0KvyIlnkfIkeYRo+RLINtsJhc7yGWjiQpjTeAmLQMyYBPZx?= =?us-ascii?Q?C4cjIRAu1kTXkI0CimjGuu125PccrWYX70730LjeyjzMbctU9F+rQrNpWV54?= =?us-ascii?Q?BmcRaGxe0v2mq+7u9QM7QWgREkQx4Z9ElBIx/cH9w8E1tXH/52Zqa2zLcxkF?= =?us-ascii?Q?TC4UdI6PBkjNnYh9G/spZlxMmAKkqhWnvtJhI0dG/K3AgtPIFdbVCAEQiIGI?= =?us-ascii?Q?2iXCVOMHRT+eK5j6B22DXLzVQjv4jXgyhOgkw+pqAbeADkHbUAx7cfS4/gGB?= =?us-ascii?Q?1/QcvIUs9CuI6gHfE9bU2N2eUxzPrSNK8fdkiEQn0opTPFFByWnCEjthuCfm?= =?us-ascii?Q?zqu+HrlvqRJ3VExXeiMsJOzSoh9Ys1kjjkGflEbufy6NqU8fYJ4jNIpy7XUo?= =?us-ascii?Q?s2kErv8WXjmccG3E1OOoaNoRzu0eOVQRWvQYVVfbOnUSvvC98sZFPRIBlYdx?= =?us-ascii?Q?rBQZozkcBEBryk9Gka0B7+f10R8z34KS6XFbjNme8F2t2Ea1/dxFbT/vpzBi?= =?us-ascii?Q?hnRoYfo7zGRMRO+gpnSzAzEs/i4hNKj7qM84Grd52JJnUo+IGOorqtZU//fY?= =?us-ascii?Q?v/3wMAOJvW9Tl5HsF9Tfzt3Bk2PfiuTEZkg3FJ96hOhPWhGnLzHGGFR5Ser+?= =?us-ascii?Q?osZgzGUBHbQVOt8mIA/4pKTC3XFUcKDLTv3qDACI9lqY8VrQsJskAqfG2FUJ?= =?us-ascii?Q?DG2J+YHA02HDTAvxx5JVXlgGqQM0gktT7mghAU2SDMqt7+PDUMT4nIW18Sgw?= =?us-ascii?Q?gCYAojuDhQLDAKetmkE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12d9cc27-4922-4177-da63-08dbd6b06b92 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 05:49:01.0029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6kRt7c/nvLuU1AeHwdxTz1AKC5JgOezC/sMMzlzZhwwZg1N0qv1cslyK416TSl3G1wmM7STOX7L2Iki04DrkWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5448 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7utOFuWtZZsUpUPAwtDBpihvx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB824428BD28B1BD44736C057F8CDCAMN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=xNvHx86W; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB824428BD28B1BD44736C057F8CDCAMN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Wei, Thanks for fixing the 3 issues. Can you kindly separate the one patch to at least 2 patches? One patch is to fix minor issues. The other is to add support of nested uncompressed FV. Thanks, Ray ________________________________ From: Xu, Wei6 Sent: Friday, October 27, 2023 8:59 AM To: devel@edk2.groups.io Cc: Xu, Wei6 ; Laszlo Ersek ; Ard Bie= sheuvel ; Sami Mujawar ; N= i, Ray Subject: [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompressed inne= r fv. V1: This patch is to fix the issue that StandaloneMmCore fails to detect uncomp= ressed inner FV. PR: https://github.com/tianocore/edk2/pull/4943 V2: Based on V1, fix some other issues 1. Add Missing object size checks before casting pointers to header types a. InnerFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)SectionData; This is introduced in V1, add the size check on SectionDataSize agains= t EFI_FIRMWARE_VOLUME_HEADER b. Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); Use FfsFindSection instead of FfsFindSectionData to avoid pointer cast= ing. 2. Fix potential memory leak issue that ScratchBuffer is not freed when pag= e allocation for DstBuffer fails. PR: https://github.com/tianocore/edk2/pull/4965 Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Ray Ni Wei6 Xu (1): StandaloneMmPkg: Fix some issues in function MmCoreFfsFindMmDriver. StandaloneMmPkg/Core/FwVol.c | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-) -- 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110189): https://edk2.groups.io/g/devel/message/110189 Mute This Topic: https://groups.io/mt/102212657/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB824428BD28B1BD44736C057F8CDCAMN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Wei,
Thanks for fixing the 3 issues.
Can you kindly separate the one patch to at least 2 patches?
One patch is to fix minor issues.
The other is to add support of nested uncompressed FV.

Thanks,
Ray
From: Xu, Wei6 <wei6.xu@= intel.com>
Sent: Friday, October 27, 2023 8:59 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Xu, Wei6 <wei6.xu@intel.com>; Laszlo Ersek <lersek@redh= at.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar = <sami.mujawar@arm.com>; Ni, Ray <ray.ni@intel.com>
Subject: [PATCH v2 0/1] StandaloneMmCore finds drivers in uncompress= ed inner fv.
 
V1:
This patch is to fix the issue that StandaloneMmCore fails to detect uncomp= ressed inner FV.
PR: https://github.= com/tianocore/edk2/pull/4943

V2:
Based on V1, fix some other issues
1. Add Missing object size checks before casting pointers to header types   a. InnerFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)SectionData;
     This is introduced in V1, add the size check on Se= ctionDataSize against EFI_FIRMWARE_VOLUME_HEADER
  b. Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
     Use FfsFindSection instead of FfsFindSectionData t= o avoid pointer casting.
2. Fix potential memory leak issue that ScratchBuffer is not freed when pag= e allocation for DstBuffer fails.
PR: https://github.= com/tianocore/edk2/pull/4965

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Ray Ni <ray.ni@intel.com>

Wei6 Xu (1):
  StandaloneMmPkg: Fix some issues in function MmCoreFfsFindMmDriver.<= br>
 StandaloneMmPkg/Core/FwVol.c | 34 ++++++++++++++++++++++++++--------<= br>  1 file changed, 26 insertions(+), 8 deletions(-)

--
2.29.2.windows.2

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#110189) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB824428BD28B1BD44736C057F8CDCAMN6PR11MB8244namp_--