From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C669E9414AA for ; Wed, 10 Jan 2024 09:09:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=u1eDQ3/xyGnzdKqU6IG9Z0UlfPvUZvwQHlCj3plZQ54=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704877744; v=1; b=lELx3SDLNwogjkZR4FHH1ir1vxzOp9PIqe679WgqnibTEnD1MPEIYBQY4gxxgQRbGlIwkVA3 OJ0yhEpKmcLMCOWddxKccyFRqj0S+TYrlM3lUDotQNzMWScclFPh9Ys6WsegPeEw2i0vmZ6lDrd OCJdzOy2s05utpc0CqSNbY7o= X-Received: by 127.0.0.2 with SMTP id pokqYY7687511xwPqut7EJKI; Wed, 10 Jan 2024 01:09:04 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.8017.1704877743848530382 for ; Wed, 10 Jan 2024 01:09:04 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="462746936" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="462746936" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2024 01:09:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="30516844" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Jan 2024 01:09:03 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Jan 2024 01:09:02 -0800 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Jan 2024 01:09:02 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Jan 2024 01:09:02 -0800 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Jan 2024 01:09:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TqWllDgKILfJztNLjzn6sYPvpT30ZUWsQ6DsECOdFrkLBqM3ZZt6YbP6G6yJnD0mS1mYH8N3XgiBo5SVx2Scs0alnt9b6JmSEfuapTMiBlWgU0Bxpc3GHpXmiLa7c/I39L77zh1qycc0vx3+wVj/EuxCZLdxJwfIXRc9NWr7nppLWvuPNzrLfMNIvzEvA2Ya7HqKnMLbFZBzzkiAcWuVtuSxQnJBPsTxex47kMwnIEq4Btygay09dhSTc9fk4YFHrH45t5NZmQJhTtwfy2HljXLDDfLUqbHRR7Fj1Bq/PXOKH6DuKrtKAfsFuUgig+HSsY6DJFvyPX4hb3hHYPQc1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fKK+ZrM6wAiZNQ5zdv/Jc/SUjew2NBA9wbFV2GL60C4=; b=ksf0LsdKffo0QeWfEHbiIpTZ4P7nisQgFCZpGE4En3IIr+HwmDNSdMEtUCymcWqRHw8p43BBhT7d9Nw7ams6KhBwLSb4o5qIibwSMyjXyKX7zs3F8UvDnD5PRMDAF3gUWxX3FyJ4tRM8ImsxScHWh4sKlFTeifT4GR+NDo9eJIfnJrB9Qf2eu2r6do/rX9IskqDIpGJwWujqH1oeQml586tWw/puyvk15sn2+f3hueBlx/zYJpKQwx8XO42FQf/60JkibVjlyAQ7ZWtnXgW7DYN/6CJMMh2rAEFmOKDduTfUh3RePmMdCnb51bj+wx0FITDes6gHggGfJoFV3RCbsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ0PR11MB5038.namprd11.prod.outlook.com (2603:10b6:a03:2d8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 09:08:59 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::3fea:ca2b:2ef7:e3d4]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::3fea:ca2b:2ef7:e3d4%4]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 09:08:59 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent Thread-Topic: [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent Thread-Index: AQHaQ4f4Y1ztKCJL6U2bSp/KutHMOLDSwiyQ Date: Wed, 10 Jan 2024 09:08:59 +0000 Message-ID: References: <20240110054318.997-1-zhiguang.liu@intel.com> In-Reply-To: <20240110054318.997-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ0PR11MB5038:EE_ x-ms-office365-filtering-correlation-id: b9b0057e-e87f-4664-ba6c-08dc11bbc7f2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: +hjfAbj+n52BiS02z5h7KO33yUk0B0xYY2LzJyYCYrulVItCOErw43FxeZyucJFlHJnRZmKUgXUb+EfIro/6SXrpgNz9b2eMrrfTgtk25SKjxDSEt50a+trAuWSAegLwkwU/5xCmIHXlw7VIDNTCwxihjhY1yxe+HLBzDIyUMMg6bSSuAeTSL3cNLD6KLrUCcUWeYyRSyVKXZrjoZcGcGduJ4yo/BKXjdoakBrO455Gc1Dea6J0z1yYi6gWd1a40Rskzxv8r8cTS6MTZwj1cK5SDqE1PzX345Eb0H6uZs/DifkwLVTBcPlZdASPz7dtPaQyQn0KVBtabl6/cIXlCOOMLR2h3RrudgqDqRkuR6FrVAvQP4WTotwzQC8DUSGp7XnNd9XxuKu+QQWzFblr3Z6uMMHROdzECk/VGxzdfpq16nIdatA8lDTlOrN87nf8Qn8u9YlJtwb8V/owZOhtwnsSmCssIZ7tzE9nL/aPDL/eH3IDbnlLKEus7CBe0dzP+E0DXQZ8EmW60M/x5NilH2JqKIsKn8JjQl/frNjx+hoH1JK8EvztVl3CZBbnPwUEbBUOS6rvf5SLZEiXx5GihW3MOCYxi44+GDZyS9n5u8Ss= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9V43+s3aoBcnnVxu/eZgkHfWR6R070duPcgCsNP/lKbAKsJ9Txmqpi0VMLQ+?= =?us-ascii?Q?uBtT2j2VNOZbsLvMM9n1NYJY0ZkKZq7j4fQjjz0ozAHT704CpkoFpPopAgPk?= =?us-ascii?Q?SFofIXRvLlGHQxXnTpNSudL1ED56KpmdUkFtFSfm+NJUrPSQHGbuNq4ubi3q?= =?us-ascii?Q?jsH27K7WROfLMuRl8CpoH47eRfE5Svz7L7RGswwMmVP2qKnzoF9FBSf3by9N?= =?us-ascii?Q?SWY3dTcThykOB7loI0XZq+qS26M9VjIICcgqgqTrxPp7MZTtP6pbVMiTl+aW?= =?us-ascii?Q?qxvpXvN0gPEuOPDKnaE8jNOicuwauATo29UClymJ4Or8Rm+N2bn9PNKwkbKm?= =?us-ascii?Q?Y+7aCw4ulLRLox7MOxtL8zXY9X2jJu3qT3fIiZljv2/wmy+/VzVqai/0bLNb?= =?us-ascii?Q?HkXSCAa252+cwIi8s/4TmZuupyZIXeSi0w0XylPhM25X1VxBE0NsME0KrfuO?= =?us-ascii?Q?AmvhiMLAWL/UYJbh4T/s5C6NuFvZ9bm7Ra1nAVAzdW5HveGO98XaNRKXyBox?= =?us-ascii?Q?iEb0b0jDlhHA46M7xmEr/9408r4mwwgjwuyhwFa8x7PHmpJUQuJwEcXbcymZ?= =?us-ascii?Q?opa+4v9sRUbUuVYYohOHOFpdcSE5IiZBx0471ZcyT5eIffKeFUznPJ8keCKO?= =?us-ascii?Q?ABDggO0/ewpafeNkBLkXEx4hcQ3C8c8LvnlS0pb8KbhOcTPDOKQafJl+bmaO?= =?us-ascii?Q?ypGBOVolzicau6gW6401Fnb2et5d//M+ojpDCaaEfJ66LHmhhIe4e0LIkFKg?= =?us-ascii?Q?sE4gJv/HjjvV7aYOlABIln8OAGhaMlfDyzbC9x7CfVHf+FQoV8GNydNwPTwq?= =?us-ascii?Q?+ij2CAcUOUO04fxYOsXBSEnuyLLD1cgYDzstK2M4Yl+rvjci8ka61jQRy6v+?= =?us-ascii?Q?q0Gb98dgLCNJ1QGWKRYt2ibbxb8rRykBtLOwFBNnNZzuC2C177QS8QLtmwd+?= =?us-ascii?Q?rNyy4sP9WxtW8ZeDU1IBvLmQWZ9sEJAdOrzBa+dHfs/WmPZrGTI2PM6mIFX5?= =?us-ascii?Q?Kt9RzOfT1w8WN0kMkAU5GgVQsoxpRXkIlwi45EMtkjWpVGqXXxnVx7PMdC8V?= =?us-ascii?Q?dY3rIh44ZCPtKyPZyczr4QFxi/NFMjT5ogAXW1aVH+JnB0iHqwIa/4HOdpfU?= =?us-ascii?Q?nVGGPe6ytkEcK0P45qnrWXJTLivzoQJVwgRTEZVSfBjd0QG44gHQTk0jHUfE?= =?us-ascii?Q?oc+JMI4qmSHkU5kUDqvNELITHKwTW2ssqlUhjPM+64RTdvJjP3oqfgu0I+WJ?= =?us-ascii?Q?+9ACj24GZ/Gl9m1XU+kdGncOBRBtbxQAUYjj99cB4jCDHNDX6FSgIAG1Okkf?= =?us-ascii?Q?2pOfITs/VxVKb1u5rdbkBoogBSFKUiAfR/a/guS+lyAvstXnR0iwzbKmpZGf?= =?us-ascii?Q?a86avh5KLHC3ZWBZKImwDbwJRSvaMMphkxxKOMP/TmclQNxDFqRbX421In8D?= =?us-ascii?Q?TK3Uy7EmcCrLJ1gBpR/vDp/XJL3k0qN9GkbLecJNz3isx9JWsoDW5idqtUxc?= =?us-ascii?Q?MdeP16ZDlOpYBC7LMEgQSsqPedtSPDREQZh+8Iv4h4eQghgpWyJd7EtPfTYq?= =?us-ascii?Q?f6lQ5wiYMXQtG7Z4jBA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9b0057e-e87f-4664-ba6c-08dc11bbc7f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 09:08:59.0733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uxdPwbEKBm4FlryLkWJ4vSOfGnXkKm86VvDEhDFpzX2qMCUAe90w4+MBZ3pj08J8Wq8hlsAMobgLta8wLEQuQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5038 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hAj8pfGjCc4kxzjUfQ8cDutex7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lELx3SDL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Liu, Zhiguang > Sent: Wednesday, January 10, 2024 1:43 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Ni, Ray ; L= aszlo > Ersek ; Kumar, Rahul R ; Gerd > Hoffmann > Subject: [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in > ConvertMemoryPageToNotPresent >=20 > After ConvertMemoryPageToNotPresent, there is always a flush TLB > function. So, to improve performance, there is no need to write CR3 > inside ConvertMemoryPageToNotPresent >=20 > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Zhiguang Liu > --- > UefiCpuPkg/CpuMpPei/CpuPaging.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/UefiCpuPkg/CpuMpPei/CpuPaging.c > b/UefiCpuPkg/CpuMpPei/CpuPaging.c > index 15c7015fb8..c6894458f7 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuPaging.c > +++ b/UefiCpuPkg/CpuMpPei/CpuPaging.c > @@ -167,7 +167,6 @@ ConvertMemoryPageToNotPresent ( > } >=20 > ASSERT_EFI_ERROR (Status); > - AsmWriteCr3 (PageTable); > return Status; > } >=20 > -- > 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113520): https://edk2.groups.io/g/devel/message/113520 Mute This Topic: https://groups.io/mt/103636435/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-