From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 74133740040 for ; Wed, 6 Dec 2023 09:24:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xsNRC4CbR/BgtVvpZllPO0/gXPSZSjXVOXqF3cWHaus=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701854658; v=1; b=bXAdZfJ61czGCYoO0iz+JL5UPts+pX/ksihuDmstLN3E58oGiRv8bMSo2UiQKdSLBEyDXknL t7gdePUDuHB520Q2DGfGcybDG1fbfKaoE5XE8I+LC3I/yGxqkjTv+1xWYy1sr6fQ7NdxlDEXZP7 0aUFTGb5lBiI1NUk11oAsTmo= X-Received: by 127.0.0.2 with SMTP id xjK4YY7687511xKiK3rkwrkG; Wed, 06 Dec 2023 01:24:18 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.27745.1701854657166943051 for ; Wed, 06 Dec 2023 01:24:17 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="393761979" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="393761979" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 01:24:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="19268686" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Dec 2023 01:24:17 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 01:24:16 -0800 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 01:24:15 -0800 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Dec 2023 01:24:15 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Dec 2023 01:24:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EDThNVxZqeoGzTBSHkdbnhOqeWzLvfVykXSHmdUR881UyfQA0ZK63IKNNulEZz/y4E3yXkPZFMSjv75gOvLwSc8hJjYfpA83UvitjSEOd8znILel3EjSVdfnpCq5628KkpcX64M01HM79RORoMCghG6fEpdKJLQKSlhx/NZ1MX1UM64AD/WZIf8iqoYllTCur1ReMXIcajNgBzSEpnNUtr01p5atDlvc9HC8yEElsQry0++X7MylcJMFI3C+aYWNRO93LMhpnx1YYpSMiGvbai7n2smJWoNgRjgYXEO29xtyUlPJ37s+jo1WWzQf4qmST/iRdn0P1K2tAe7m1EFUJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rxcO5cDU0rtemIjM5KOHxt8kZKuQliAWx2Y4EjXup1A=; b=Y+ouBYCSC2OuxFIUgOdd6PddZJyQovd5awaxBssl0vMDQXo99OAr71p/Q+IJasZFpQqwzIF3TAFzcjuKdUu0yLNyZhpDlpUAOwCjVy34/E6IX7+FDZn1COPIOyXZ2AfGsq6liOHDHUG6RDrxAYhjJhqYkEKlwp6GUWQTzlNV8IhqjdJtHDf7JmMy/bxej3zY9UUVvV56rR70IRpmIAuydp4Wv+DVxnhLPT/QWxrZ7AZa/haTG4DgdtBCJj/2TCX2b6NurrQ3UfBmXBRBLqohLVzmYTfakKB88a2FoeKI7M/up3hGUoIRTrJ7toWCHfsbrr/C3S3y899YZDMpLBKGHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA0PR11MB4670.namprd11.prod.outlook.com (2603:10b6:806:9a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Wed, 6 Dec 2023 09:24:13 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7046.034; Wed, 6 Dec 2023 09:24:13 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH 2/6] UefiCpuPkg: Build MpInfo2HOB in CpuMpPei Thread-Topic: [PATCH 2/6] UefiCpuPkg: Build MpInfo2HOB in CpuMpPei Thread-Index: AQHaJz7RNc+0rX0Tk0aZw04YP0tuzLCb+bQA Date: Wed, 6 Dec 2023 09:24:12 +0000 Message-ID: References: <20231205054900.926-1-dun.tan@intel.com> <20231205054900.926-3-dun.tan@intel.com> In-Reply-To: <20231205054900.926-3-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA0PR11MB4670:EE_ x-ms-office365-filtering-correlation-id: 9e7caf58-0e50-4cb0-3725-08dbf63d1c3b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: cEsbf310JWkv8jhRxora28GQ0d65F0ZzsM5wuxB20ZC5P47Se+Zkl6C22FQwFj87rSS3asnXEgcYUYjUsMYT7v1SWZKxDZTunryb3jIZz9O9iu6W5AUBWkdoSybVkRURrkOv82e4rU8K9oNg9OPKGgLOjUg+URIbDHEVSfsEPjoSWElCSrjZQ6R7MgeUHcyXX3LrCceZKB26PRNglEGOm5ktNhdcDUf5Tt/+RoBI2rAp6Nkb3KJx+JoRSsn4ixTkkgpvVgL4P2aAtLKnQ/9o4lA+3rhWU6GvBiMdTAjtJtI66D+8KbWsAbBOoH6kOi/RIj9lY6TiKzoylzqab5PEhKiCjcv/8MjPFcicNNSOOoGOYc05NFUTA2S9osdedMfCf7eEENxfTud40nRNXAvdWpn5qN1WUu/DBzEigz0RFHa64vvyn3DztfT/y2kNWICmfCp0xx5JDw6CH/TC3xSPGfgmSi27vhJSbbdQp192beJhu0gHTqOec7B0o888TDTY36GOtyTvbEoJKpRm3K0rRkAD8zwGyu9mr9iue0Kn8uiYS16NG0waqxXAmW1a78tBslf78kLtk4URzW7N9b+iQTLwvFQHawnZvBcOLaPO0J9214o/D272UZK5HuYXnfyw x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J4ykq+DWADH7gQfYPVAzvisC/guKFJ1fj72gButNEZ/56HXxDqZETOVymScl?= =?us-ascii?Q?Ze4dqAV+TtLMV3DiQMatHxWv7+XI3CReWf1J3xgZkbY2L4HOmcsMmyGBMaEF?= =?us-ascii?Q?DZV88pWgJKmEZe/6yyvZD4SslDNXWIm4Uw/afklcQNSiLgC/oimDjG0SQGM7?= =?us-ascii?Q?lZ+IVKHgy4HyiTcUhddQNewc5PIjQWlaiW+PY590wEGCYL2glbkX56yKXiSq?= =?us-ascii?Q?B0MH+8avVEclYYwvX+LLRYbtHlBSwzFGOZVZLSnIPDvqaBYI4gpXqEVoQEFc?= =?us-ascii?Q?vKIbF9OkgESakWnVame2osi81sjG/4WYJ+p21iKfFCsC6koxlO68WtAan1Dx?= =?us-ascii?Q?gb29virc17w6MmShxVfybM3/2WrXWSEl4tWOEMCQv209r7BbOqrwxgHlA2OS?= =?us-ascii?Q?Nwdt7ZmI6YU/vblwXTPWw4TD5ZJ1ionkCOASl9GmUS566Qbfzw+VWyEIle7O?= =?us-ascii?Q?PndFMIENv5EwhkkS9mt0H2ShD/uiCz2nGC6OXbGqqbzfFp3o/pq0CXruVW+W?= =?us-ascii?Q?j2KBvGui7z4F50ADmTgTJNv4/s7Kn+BpEe61LZ9LcwFEqaXN6giWIfOYFbjY?= =?us-ascii?Q?Z0VrWsEw63c2aAQs90QpIC6WNvKRZA4PYxqPikdT/Bm/Qh8hnT1Ehl5OPJnm?= =?us-ascii?Q?WXis4Y8DlOPgwMf256hD5mdVkRDOMlVd6bWA1e0distEWnyjEloit6uSS435?= =?us-ascii?Q?bTo6C00DpV47k2LdCdGbt9z4L3xM/RmNHz/UVc12ATC8uPledkdjiGCjK8BY?= =?us-ascii?Q?iDEcgbOmusAr7I83MuYbXrQJz0txhf4/hXzkPTM3R9YyqB0vxAu/aMzOA6dU?= =?us-ascii?Q?uVAGRFvqS5HYcEoyFilaj+i61+l0pMdeBEOLRJbDhOEAxmZ7kNbWfTNy+WMi?= =?us-ascii?Q?oI7AE6cCYlL+yfL2SvLlox4jeBV73a7b821N1ZoXUxu+YPGWJVUJzvwQ5nIY?= =?us-ascii?Q?CKJNGHHamyANxyDcFo7fPsHThIfYLzM5ynMY/8CW5az8ZzUzqF2ZV3A0bSW+?= =?us-ascii?Q?LOIRXbCRVNINoqEcuO6joECHDV+L2SBgcPoweTAP2T3DbaJFPezdIYlubzh/?= =?us-ascii?Q?VxudVslKbTsPgOH0abVvzDV2MI9qnwd5fC8uhWCDLbH4O/BK37JUQdDLfOSj?= =?us-ascii?Q?ZtJ6EQ9gFsHHmbA4tG1/nVbKQ4URX9y3wDJHkJeZi8Mj6ZFHboBEh6XkTUsN?= =?us-ascii?Q?5wxweJVAQlK0TrBmY4JpGxlsLJ2+NfjAq4aDMkrQjQ4MzdGJqki1wTz1zoR8?= =?us-ascii?Q?Rd+9+p8oB3Axhr4JXF0nnIjSBqSN5KN3ApG9belV+tsqoQ5YhcPQzxG9yJHo?= =?us-ascii?Q?OnYbEYsk+AclXW8f15Tx5mG9EnRAgBZ7deb57Cu29t747Dfo8E66KOttXyq8?= =?us-ascii?Q?vaQ+0O+plZp/oB0G4ctZQYiUcoVdP65mS802E1m4sqLwjz945Iso1TKo7ZDP?= =?us-ascii?Q?ZmDWn5IA5GQLCmQL+pR4zinVjrG21I+wWuQnLizSnchpb3uAJzoAj6t6OjX+?= =?us-ascii?Q?q8QNaS5+tTRaxGRt9GGHGKzrfuqrN9x8Dc1XxvA5YvoPcTE40WgXKj2GEgfF?= =?us-ascii?Q?KKFdOhAVnScBJNt5Gqs=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e7caf58-0e50-4cb0-3725-08dbf63d1c3b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2023 09:24:12.9942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jwnVI8CPoqreEWBdaKOwMEOsySsq+XngHmY3fKYQvDbOiP9nmSzcdu6r6kZEeON3ap0k+gsNrGRmSYstd840hA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4670 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4zQSzSqJTPC6p8VlB4a4mzlux7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bXAdZfJ6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") 4 minor comments: > + DEBUG ((DEBUG_INFO, "BuildMpInformationHob\n")); 1. DEBUG ("Creating MpInformation2 HOB...\n") > + > + for (Index =3D 0; Index < NumberOfProcessorsInHob; Index++) { > + MpInformation2Entry =3D GET_MP_INFORMATION_ENTRY > (MpInformation2HobData, Index); 2. Since EntrySize equals to sizeof (MP_INFORMATION2_ENTRY), is it ok to ju= st use MpInformation2HobData->Entry[Index]? 3. Do you think "Entry[0]" is more proper than "MpInformation[0]"? > + DEBUG (( > + DEBUG_INFO, > + "ProcessorIndex =3D %x, ProcessorId =3D %lx, StatusFlag =3D %x\n= ", > + Index + ProcessorIndex, > + MpInformation2Entry->ProcessorInfo.ProcessorId, > + MpInformation2Entry->ProcessorInfo.StatusFlag > + )); 4. How about the debug messages are as follows: Processor[0000]: ProcessorId =3D 0x00000000, StatusFlag =3D 0= x00000001\n Location =3D Package:0 Core:0 Thread:0\n Location2 =3D Package:0 Die:0 Tile:0 Module:0 C= ore:0 Thread:0\n If a number has "0x" prefix, it uses hex format, otherwise it uses dec form= at. The debug message should clearly tell what format the number follows. Extra 2 spaces in Location/Location2 are to tell that these are extra info = for the processor #0. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112102): https://edk2.groups.io/g/devel/message/112102 Mute This Topic: https://groups.io/mt/102987138/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-