From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.1923.1678843527323974019 for ; Tue, 14 Mar 2023 18:25:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=mWbHlzns; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678843527; x=1710379527; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=g2bGh3pF8VXXLX9W51TkL9pwS/Zlybp0ri0qK6apukI=; b=mWbHlznsn2iFpGdC8pbk3cUCRpVJr0ao65DcFmwcq7ZIF8sSSgOpBdGC 30/yg9mGMxMOfc7a+rVSboixPnpZFDcByvYz01SvYAu720s4wX8xlprE5 Pt9T+CNgCHuFvFDc8BF5jV0EDY1ElmOeIlGqfCM7f6orzg9/mvsoCu69s Y+NOoNDwI8NZtE3wIKSkXFPdUutWNQH4qNtt3o+/TFKuNrP6FDhTuYaUd N3gI3Cd1JxCRZI2q4o5NSo7/vAeWiDQcW1F7Xu5Xm/8cM30lKhcAbBHpW zTzytwXlUJf1KW7yhozYRq6iDTM9B5VheHneGGhxtMzy0nIoOz+J3Y3Lb w==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="400165931" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="400165931" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 18:23:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="853409810" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="853409810" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 14 Mar 2023 18:23:54 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 18:23:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 18:23:53 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 14 Mar 2023 18:23:53 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 14 Mar 2023 18:23:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6gqOqYO/zYCvdm9aIDSjuOnkFs6PgObHmjUyqwSg0oiJIaQxwgfYAxZecROvUWCpuuQBw3W0mWbZHPj2t+82CGHiZZw3/PKHuj2hN1QSKeNJfQ10wskWkp4uYPeayprSj1S90Y5T8YyodIj136mrpnImsP161+RhoP25Ho9gKoT2rj45Qhr+RfOyZ7v4s8oGZm4z70jHzrwPT9juoWK82nBJ7bpXqdXxPZRG9WBczQyrCEe2oUP/2AJ+9NbDLqVdfm9Nsf3tzk5vAvVk1Oem5JkiCMCNt+7KjsovpnXQhCjYPByNGNG3lkpxl0spRuFP5vjg8Zd5lenuw0I7pMjrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ub5bLtfEWiQOG/lGeeoJ7qhZ1Mmn5BPHESxXxUe3y2o=; b=ZnMlDLIIZ60ff7awjcXsWa/tsY8RttT3FsmUxCDA/aujhRtLeA/1p6vciBJhgolvrvQwtD24rgBvzDG9Yi5hJkN1S4F5B+j7B2EQivNCZMd2phoPHQhFJ5L48rtr9U117ZbEngKRjZxvhkWHbjuJ85enbZBOV65FFk42KxQCSSg9veTQFQZF/5ZaC6WPMRGCKr6Nf7g3lhvDqjPWJbpv5QXoQeKj1HPRjpbgXczrvjeQYmhmMuN4w6ZBNsnBECv8Wdc7Yeuc+mzTMBEz3I/KCwgXv8aWivrDkGwgLuQal4ZrHQNigKZhQP7y1As0Z3dRNhxJTpbL918da72e8rb2jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH8PR11MB7118.namprd11.prod.outlook.com (2603:10b6:510:216::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Wed, 15 Mar 2023 01:23:51 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.024; Wed, 15 Mar 2023 01:23:51 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition Thread-Topic: [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition Thread-Index: AQHZUaXz29B2S55VIUW1qsjLO7egQa77FkCw Date: Wed, 15 Mar 2023 01:23:51 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-2-dun.tan@intel.com> In-Reply-To: <20230308100758.669-2-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH8PR11MB7118:EE_ x-ms-office365-filtering-correlation-id: 63776183-359f-4d26-a1b2-08db24f3ef5b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8Ftd1oSmQeGK6Ws5heg+jmodumqDGPczGU+u5I8yt5qSuzYlRl7LeC+1RePaSA0jzFhtjrBCgOH2eOVsWga4qzcBKtGtYwq1d50RlIPgH6s5T+gLm3roVcD5RQ1OUxTIKz9/SOkM04D6lYacVK1AWaU84L9pG3G/mwgYI/+/R//oiy83ZWb2kvBgoLznzI/CdiTBes1cp+NFf9t5z5g0258t7fup43AfKhcBDcxW0cBLuSdMsgauC2E6W76KxAFgk7UT/7ed311p8EPRJvsYetRVQseqkGZYptSwYaOM/oSAyUakPUHUYDjw6TWOi1ODxTCkBZfW87ozsBKhy26gpZRSzz0hg6jpQaWObNnCCK2VlDayS1KR3QkGMqrDR8mpijuQB8DVKGj93rApQc/NQxsLcJfnfhTH7SumMdFrqI0wwt/YMkRuqyrm9N6kIgozBwH8k7otuPBsNV3uRUThnEsqCIk5OU4KqHGJkNMHQrhRsTdJfmwT2RYJ+jasL7q3cwHpLVnx4cjBjTPKwJ7iLy2lRSHiqFBSi0DRAMCPhc8rj78ryt8C9DxweaCvzmIonj1111ETVf5C0YXldoE6VZyJUmA7sceaCJfIRcflNWLZ3b9R1x4yxjyrikNsEfyGXlEWjIXTo1eZPUUkDs+AlC0X4IvJMg5ZWiWBHZrUEpUzB05xhoSjCr/Q3pxAPs4X0IRZ1FZk6JIN2UGGC97wLA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199018)(5660300002)(8676002)(33656002)(83380400001)(110136005)(478600001)(7696005)(53546011)(6506007)(71200400001)(26005)(66946007)(186003)(9686003)(38070700005)(4326008)(41300700001)(66556008)(66476007)(66446008)(55016003)(52536014)(64756008)(8936002)(316002)(86362001)(76116006)(38100700002)(54906003)(122000001)(82960400001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mx17uqbfYUevVeIV6X1/Ymq2BIyYo1KzqIyHd9OfvzOiTYTcaGGcjsZXMPKf?= =?us-ascii?Q?QVjy73CP2abXfWmvOXzixWQECI2EOJy7v93HmzyOWrOO22GxqEwtx1BCbr2E?= =?us-ascii?Q?adDYeIZantzUopQ+Yk3ldWxEVO7eMAwlx5wh4Um6DWr5fCeB6K1dNSL3rYA8?= =?us-ascii?Q?RiDMjtRSJlmatAkt1EadsIZoOsUipgCyl1mm7Tu93FnOdYFOQSxPRfn/KGYU?= =?us-ascii?Q?brQXOwlthkd6WAPRu4GAQ3i8PvYf9/E0572+Q7V25UniovdG74SBzhNFoc24?= =?us-ascii?Q?OhTHoqiUlhID3VlzLxbRjits3Cl2ZBlW/qdBa2WA8f3YkYE9qHzId3FQwO79?= =?us-ascii?Q?3PgTH7BwkE8ym6FDlq41PHeem6Baf8P7+yH8OUtBSOE17Qwfk2+7/N19HKLz?= =?us-ascii?Q?IfXan3/33L50VxxiZu2nkpYaBgz/QI0llEN7Q6l8BkOskNcL2v6f7X9rk2WI?= =?us-ascii?Q?djRLkyk800vVBvkQjfNSrggk/5dCRK8l/aqQDjVUsUc6HUu+Vei8zKT/vth0?= =?us-ascii?Q?Qy1CYnSFbYJixF5XumP1Epbs4Enfmy4mCQDVo+XUC45xIrXeGNiOlS9LMUZU?= =?us-ascii?Q?f8Nsaw+SzcVgYSSOaPpj3RuaB2tXt0mwzI8cyEWH87G78oawOXDAiesQnH+v?= =?us-ascii?Q?6ceJsX8c3brKYhLM0CuRuvKlUYXv63rgc4HKqLfKL0OyDf7sg1asUhKdvVoJ?= =?us-ascii?Q?ZCB1I6Rq30zMd7R+k/9FTyMN+eertRcsisR5l/lxbWQcJo5KKuvqzBVXPSLG?= =?us-ascii?Q?Qun7PFr6iPwGK6jGru3oiVSj4pLp6yQFYnvKTk0HLzOVw5PmSO8EHozf4VfC?= =?us-ascii?Q?oTbeaUZXQyafD8JdUQxHwiR+3zS/5bPjRf3mTj5jOYnR89uuhP7oRKlmoXZY?= =?us-ascii?Q?XONrpD7slzFPjliflvV/mWuLuVWwphBSWEe6se1kK3TQl4c6/0ubuHAD+Nr3?= =?us-ascii?Q?cSdTVc60QeNrHxjFhDjzwDlT9vohyMVXUV/pZunzmJkY/UjwxKdO+bLP/rDQ?= =?us-ascii?Q?8Pz3vwTprshbY68c4uhaCYQrM8ccemwyFA0FWz1qN5Bhpzj3JbYk2CSXcUdc?= =?us-ascii?Q?N98j1SvbmcM7RxJsNpBkryOmGamNlXYZq5OvQkKlG3ze2zm0QjkZyqKln0gQ?= =?us-ascii?Q?Wu4aWoDQJYOQbw6fOEU4pEjds89kPBW5lWXbE+k8VPpmxl1F+lMfbltiZtLI?= =?us-ascii?Q?sRP86mWI1ftDMcpOma5oW5V/Ih3fNcVif21C+8p0w1FEzDl1sSqnMl5shEzB?= =?us-ascii?Q?WCIo8H0YeShMIEETymhFdWsmzGnJ8MbyL8H+l6f2PCvqmJWI0guyA4LthMsj?= =?us-ascii?Q?WpLvrr8CDH/Iyls/RuGfproboN5lKIHPbz/AePkDVWg/K1pTb1dQatlzuUhj?= =?us-ascii?Q?cYYW6box0Fjk70bfpDUhcGYridXxJzohC87zAVGNTvROBe74WShVj0kZjZ3H?= =?us-ascii?Q?oypqFZhlq/G28UgRaNCnCoK27ubqC3xBt6wcuViHPKObQyGm078cRVLCDTIF?= =?us-ascii?Q?K/ZIssPg0REFv7JbvKBLEMRB0Za0FomXWZ7iuvYKps5mK8XrU9LWqHOErUPY?= =?us-ascii?Q?LriJNn3NF0+Y53wJUu6okVglyGmed/2v9X1EtO20?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63776183-359f-4d26-a1b2-08db24f3ef5b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 01:23:51.3844 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: byxUzfPPCUfH/6efJyEWOiopNj8dUdUn/rlLWT96Rwa+DA7tI72e9mOLGPQkL77SXAjI49pm6axR+oge5zOlZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7118 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable You can carry my Reviewed-by in next version if you add the copy right year= change. > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded > 'if' condition >=20 > Remove unneeded 'if' condition in CpuPageTableLib code. > The deleted code is in the code branch for present non-leaf parent > entry. So the 'if' check for (ParentPagingEntry->Pnle.Bits.Present > =3D=3D 0) is always FALSE. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 9 --------- > 1 file changed, 9 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index 37713ec659..47027917d9 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -375,15 +375,6 @@ PageTableLibMapInLevel ( > // we need to change PDPTE[0].ReadWrite =3D 1 and let all= PDE[0- > 255].ReadWrite =3D 0 in this step. > // when PDPTE[0].Nx =3D 1 but caller wants to map [0-2MB] as N= x =3D 0 > (PDT[0].Nx =3D 0) > // we need to change PDPTE[0].Nx =3D 0 and let all PDE[0-= 255].Nx =3D 1 in > this step. > - if ((ParentPagingEntry->Pnle.Bits.Present =3D=3D 0) && (Mask->Bits.P= resent > =3D=3D 1) && (Attribute->Bits.Present =3D=3D 1)) { > - if (Modify) { > - ParentPagingEntry->Pnle.Bits.Present =3D 1; > - } > - > - ChildAttribute.Bits.Present =3D 0; > - ChildMask.Bits.Present =3D 1; > - } > - > if ((ParentPagingEntry->Pnle.Bits.ReadWrite =3D=3D 0) && (Mask- > >Bits.ReadWrite =3D=3D 1) && (Attribute->Bits.ReadWrite =3D=3D 1)) { > if (Modify) { > ParentPagingEntry->Pnle.Bits.ReadWrite =3D 1; > -- > 2.31.1.windows.1