From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
Sunil V L <sunilvl@ventanamicro.com>
Cc: "Ni, Ray" <ray.ni@intel.com>,
"lichao@loongson.cn" <lichao@loongson.cn>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [edk2-devel] RFC: Folder layout change in UefiCpuPkg
Date: Fri, 12 Jan 2024 09:12:34 +0000 [thread overview]
Message-ID: <MN6PR11MB8244364844C5861F5518DDA38C6F2@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]
Sunil,
I would like to hear your feedback regarding locations of following RiscV64 components in UefiCpuPkg:
* UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/
* UefiCpuPkg/Library/BaseRiscV64CpuTimerLib/
* UefiCpuPkg/CpuDxeRiscV64/
* UefiCpuPkg/CpuTimerDxeRiscV64/
I would like to move them to the following new locations accordingly:
* UefiCpuPkg/Library/CpuExceptionHandlerLib/RiscV64/
* UefiCpuPkg/Library/CpuTimerLib/RiscV64/
* UefiCpuPkg/CpuDxe/RiscV64/
* UefiCpuPkg/CpuTimerDxe/RiscV64/
I want to avoid too many similar drivers in root folder, and too many libraries in Library folder.
Movement of the first 3 ones put the RiscV components under existing folders.
Movement of the last one creates the UefiCpuPkg/CpuTimerDxe folder, that could be potentially shared by other archs as well.
I raised similar comments to Chao Li who is working on LoongArch upstream.
The location movement follows the 2nd pattern defined by edk2 coding standard:
Driver's location could be:
<Feature><Phase>[<CpuArch>[<Vendor>]]
or
<Feature><Phase>[/<CpuArch>[/<Vendor>]]
Library's location could be:
<Phase>[<CpuArch>[<Vendor>]]<LibraryClassName>[<Dependency>]
or
<Phase><LibraryClassName>[<Dependency>]/[<CpuArch>[/<Vendor>]]
Thanks,
Ray
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113700): https://edk2.groups.io/g/devel/message/113700
Mute This Topic: https://groups.io/mt/103679850/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 6888 bytes --]
next reply other threads:[~2024-01-12 9:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 9:12 Ni, Ray [this message]
2024-01-12 9:57 ` [edk2-devel] RFC: Folder layout change in UefiCpuPkg Chao Li
2024-01-12 10:19 ` Sunil V L
2024-01-15 1:13 ` Ni, Ray
2024-01-15 4:44 ` Sunil V L
2024-01-15 5:44 ` Ni, Ray
2024-01-15 6:17 ` Chao Li
2024-01-15 6:46 ` Sunil V L
2024-01-15 8:11 ` Ni, Ray
2024-01-16 0:59 ` Chao Li
[not found] ` <17AAAE0FD29564BB.7072@groups.io>
2024-01-18 8:27 ` Chao Li
2024-01-19 10:17 ` Ni, Ray
2024-01-19 13:47 ` Laszlo Ersek
2024-01-23 3:10 ` Chang, Abner via groups.io
2024-01-23 4:39 ` Chao Li
2024-01-23 5:02 ` Chang, Abner via groups.io
2024-01-15 8:48 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244364844C5861F5518DDA38C6F2@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox