Good to me.

Thanks,

Ray

From: Chao Li <lichao@loongson.cn>
Sent: Friday, December 22, 2023 9:15 AM
To: devel@edk2.groups.io; ardb@kernel.org; Ni, Ray <ray.ni@intel.com>
Cc: Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe

Thanks,
Chao

On 2023/12/21 21:59, Ard Biesheuvel wrote:

On Thu, 21 Dec 2023 at 13:41, Chao Li <lichao@loongson.cn> wrote:

 

...

A given platform will either be able to use port IO, or it will need

to use MMIO translation. So a driver that can do both based on a PCD

is not very useful, it makes more sense to have two different drivers,

and the platform incorporates the one it can use.

Ok, I get it, I think you are more inclined to move the ArmCpuIo2Dxe to a new place and rename it, maybe: CpuMmio2Dxe, while some platforms choose the different CpuIo2 drvier by themselves when building FW, right?

Yes.

Ok, I agree. If there are no issues with Ray, I will adjust this patch in V5. I tund is move it under UefiCpuPkg and name it CpuMmio2Dxe, it will be in the same directory as CpuIo2Dxe, is that OK?

Ray, what do you think of this plan?

 
 
 
 