From: "Ni, Ray" <ray.ni@intel.com>
To: "Guo, Gua" <gua.guo@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Marc Beatove <mbeatove@google.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
"Mathews, John" <john.mathews@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Hob: Integer Overflow in CreateHob()
Date: Fri, 12 Jan 2024 08:56:02 +0000 [thread overview]
Message-ID: <MN6PR11MB824438EEBAFE130EE10478728C6F2@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240112022521.710-3-gua.guo@intel.com>
It's strange to me that ARM's MM env still allows modifying HOBs.
Thanks,
Ray
> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Friday, January 12, 2024 10:25 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Marc Beatove <mbeatove@google.com>;
> Ard Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar
> <sami.mujawar@arm.com>; Ni, Ray <ray.ni@intel.com>; Mathews, John
> <john.mathews@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH v3 2/4] StandaloneMmPkg/Hob: Integer Overflow in
> CreateHob()
>
> From: Gua Guo <gua.guo@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4166
>
> Fix integer overflow in various CreateHob instances.
> Fixes: CVE-2022-36765
>
> The CreateHob() function aligns the requested size to 8
> performing the following operation:
> ```
> HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
> ```
>
> No checks are performed to ensure this value doesn't
> overflow, and could lead to CreateHob() returning a smaller
> HOB than requested, which could lead to OOB HOB accesses.
>
> Reported-by: Marc Beatove <mbeatove@google.com>
> Reviewed-by: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: John Mathew <john.mathews@intel.com>
> Authored-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
> .../Arm/StandaloneMmCoreHobLib.c | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git
> a/StandaloneMmPkg/Library/StandaloneMmCoreHobLib/Arm/StandaloneM
> mCoreHobLib.c
> b/StandaloneMmPkg/Library/StandaloneMmCoreHobLib/Arm/StandaloneM
> mCoreHobLib.c
> index 1550e1babc..59473e28fe 100644
> ---
> a/StandaloneMmPkg/Library/StandaloneMmCoreHobLib/Arm/StandaloneM
> mCoreHobLib.c
> +++
> b/StandaloneMmPkg/Library/StandaloneMmCoreHobLib/Arm/StandaloneM
> mCoreHobLib.c
> @@ -34,6 +34,13 @@ CreateHob (
>
>
> HandOffHob = GetHobList ();
>
>
>
> + //
>
> + // Check Length to avoid data overflow.
>
> + //
>
> + if (HobLength > MAX_UINT16 - 0x7) {
>
> + return NULL;
>
> + }
>
> +
>
> HobLength = (UINT16)((HobLength + 0x7) & (~0x7));
>
>
>
> FreeMemory = HandOffHob->EfiFreeMemoryTop - HandOffHob-
> >EfiFreeMemoryBottom;
>
> @@ -89,6 +96,10 @@ BuildModuleHob (
> );
>
>
>
> Hob = CreateHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, sizeof
> (EFI_HOB_MEMORY_ALLOCATION_MODULE));
>
> + ASSERT (Hob != NULL);
>
> + if (Hob == NULL) {
>
> + return;
>
> + }
>
>
>
> CopyGuid (&(Hob->MemoryAllocationHeader.Name),
> &gEfiHobMemoryAllocModuleGuid);
>
> Hob->MemoryAllocationHeader.MemoryBaseAddress =
> MemoryAllocationModule;
>
> @@ -129,6 +140,9 @@ BuildResourceDescriptorHob (
>
>
> Hob = CreateHob (EFI_HOB_TYPE_RESOURCE_DESCRIPTOR, sizeof
> (EFI_HOB_RESOURCE_DESCRIPTOR));
>
> ASSERT (Hob != NULL);
>
> + if (Hob == NULL) {
>
> + return;
>
> + }
>
>
>
> Hob->ResourceType = ResourceType;
>
> Hob->ResourceAttribute = ResourceAttribute;
>
> @@ -167,6 +181,11 @@ BuildGuidHob (
> ASSERT (DataLength <= (0xffff - sizeof (EFI_HOB_GUID_TYPE)));
>
>
>
> Hob = CreateHob (EFI_HOB_TYPE_GUID_EXTENSION, (UINT16)(sizeof
> (EFI_HOB_GUID_TYPE) + DataLength));
>
> + ASSERT (Hob != NULL);
>
> + if (Hob == NULL) {
>
> + return NULL;
>
> + }
>
> +
>
> CopyGuid (&Hob->Name, Guid);
>
> return Hob + 1;
>
> }
>
> @@ -226,6 +245,10 @@ BuildFvHob (
> EFI_HOB_FIRMWARE_VOLUME *Hob;
>
>
>
> Hob = CreateHob (EFI_HOB_TYPE_FV, sizeof
> (EFI_HOB_FIRMWARE_VOLUME));
>
> + ASSERT (Hob != NULL);
>
> + if (Hob == NULL) {
>
> + return;
>
> + }
>
>
>
> Hob->BaseAddress = BaseAddress;
>
> Hob->Length = Length;
>
> @@ -255,6 +278,10 @@ BuildFv2Hob (
> EFI_HOB_FIRMWARE_VOLUME2 *Hob;
>
>
>
> Hob = CreateHob (EFI_HOB_TYPE_FV2, sizeof
> (EFI_HOB_FIRMWARE_VOLUME2));
>
> + ASSERT (Hob != NULL);
>
> + if (Hob == NULL) {
>
> + return;
>
> + }
>
>
>
> Hob->BaseAddress = BaseAddress;
>
> Hob->Length = Length;
>
> @@ -282,6 +309,10 @@ BuildCpuHob (
> EFI_HOB_CPU *Hob;
>
>
>
> Hob = CreateHob (EFI_HOB_TYPE_CPU, sizeof (EFI_HOB_CPU));
>
> + ASSERT (Hob != NULL);
>
> + if (Hob == NULL) {
>
> + return;
>
> + }
>
>
>
> Hob->SizeOfMemorySpace = SizeOfMemorySpace;
>
> Hob->SizeOfIoSpace = SizeOfIoSpace;
>
> @@ -319,6 +350,10 @@ BuildMemoryAllocationHob (
> );
>
>
>
> Hob = CreateHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, sizeof
> (EFI_HOB_MEMORY_ALLOCATION));
>
> + ASSERT (Hob != NULL);
>
> + if (Hob == NULL) {
>
> + return;
>
> + }
>
>
>
> ZeroMem (&(Hob->AllocDescriptor.Name), sizeof (EFI_GUID));
>
> Hob->AllocDescriptor.MemoryBaseAddress = BaseAddress;
>
> --
> 2.39.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113699): https://edk2.groups.io/g/devel/message/113699
Mute This Topic: https://groups.io/mt/103675962/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-12 8:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 2:25 [edk2-devel] [PATCH v3 0/4] Bz4166: Integer Overflow in CreateHob() Guo, Gua
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 1/4] UefiPayloadPkg/Hob: " Guo, Gua
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Hob: " Guo, Gua
2024-01-12 8:56 ` Ni, Ray [this message]
2024-01-24 12:40 ` Gerd Hoffmann
2024-01-25 1:33 ` Ni, Ray
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 3/4] EmbeddedPkg/Hob: " Guo, Gua
2024-01-12 2:25 ` [edk2-devel] [PATCH v3 4/4] MdeModulePkg/Hob: " Guo, Gua
2024-01-16 14:39 ` 回复: " gaoliming via groups.io
2024-01-19 9:53 ` [edk2-devel] [PATCH v3 0/4] Bz4166: " Sami Mujawar
2024-01-23 14:49 ` Gerd Hoffmann
2024-01-23 15:16 ` Guo, Gua
2024-01-24 12:48 ` Gerd Hoffmann
2024-01-25 8:08 ` Guo, Gua
-- strict thread matches above, loose matches on Subject: below --
2024-01-24 15:35 [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Hob: " Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB824438EEBAFE130EE10478728C6F2@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox