Re: [PATCH 4/5] SimicsOpenBoardPkg: Use another SmmAccess Driver

["Ni, Ray" <ray.ni@intel.com>]

The code change looks good to me.

Can you refine your commit message a bit to explain what the bug is?

Thanks,
Ray

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Tuesday, April 25, 2023 3:03 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH 4/5] SimicsOpenBoardPkg: Use another SmmAccess Driver
> 
> Because of the similiar reason I mentioned in last commit, the
> SmmAccess2Dxe.inf driver should be deleted and the replacement
> will avoid hard-code and use gEfiSmmSmramMemoryGuid Hob to get
> Smm Range information.
> 
> This can fix an exsiting bug, when gSmmBaseHobGuid may allocate buffer
> from smm range, and update gEfiSmmSmramMemoryGuid Hob. Current
> driver will return hard-code smm range and the buffer used
> by gSmmBaseHobGuid is marked as free range by mistake.
> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc     | 2 +-
>  Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf            | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> index fcae343146..64c3af2584 100644
> ---
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> @@ -278,7 +278,7 @@
>  !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE
>    $(PCH_PKG)/SmmControl/RuntimeDxe/SmmControl2Dxe.inf
>    $(PCH_PKG)/Spi/Smm/PchSpiSmm.inf
> -  $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf
> +  IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf
>    IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf
>  !endif
> 
> diff --git a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf
> b/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf
> index fdcb4fb9a7..ca3706578b 100644
> --- a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf
> +++ b/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf
> @@ -8,7 +8,7 @@
>  ##
> 
>  !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE
> -  INF  $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf
> +  INF  IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf
>    INF  UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf
>  !endif
>  INF  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
> --
> 2.31.1.windows.1