From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.79750.1682431079482560585 for ; Tue, 25 Apr 2023 06:58:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HhbDz13J; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682431080; x=1713967080; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9XQ8DzwGgx4x0DDI8OPgF5Nxsjj97A0bnWQo8AHNUJM=; b=HhbDz13J/bOGfmVZkP8/iuSW6m9IHAuCD54HBB9KtuHMgaeHPlnhabhE mef4UTA2JNAWk7uiRFRzJo3DVWDC5DIuwtRIpTWZhP82wVSVvDtW/d7Qr 5r12O4eOkSm3bAS6mJwWiQq/gX/fKvG1NYPZMWwr7SS3oMbKtheWwFdRr KWyVECtVmobMBeHN0fYiHlwQpa6xUFowlxe1cVXZgTAtENVZ7BazV9nDM GZ/uVHakxIRBtEKj/Hs/3JyIAY5aJRbtYYeXJ/YzLKSb2oYYsfT5ZHW6g a5dUKpXBFzhbQlCsiLG9KGTAOrWMPSgcwqNi/o+GoKLK1PcqQNw01UU3S w==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="335671786" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="335671786" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 06:57:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="670896077" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="670896077" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 25 Apr 2023 06:57:37 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 06:57:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 06:57:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 06:57:35 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 06:57:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fjaKE0+i+Bhww/Kirh9tYe0zijNlaeyD1kh1doYhFn7N9i5FdcupgxjCDoQC9vZDxwFGbJAA+Cklnfo3zUo+vFXRnmlWAi8ppB/jFFemWpZlYVQ9MT85UKHugBbhzeV1RkVyHcTquxRmJeYzxeywyhwjjaOXC1gWeY84bzwNsrlNzIkU0LXap2OeS7DimMMoqS9wtAJ3xajm8LjQ/DGqnF8lnegw6N8ZFDaGsbproP9Hr66B5RB/H5hiDymEuI2t24WAKZTfYtwksQwEm2Tcn+p2u5M92kyCQBiakS1Sd9SIvh9C7Asa3eX3RMCEXS8Bxrk6xr7tU7xNGRP34dB8Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B6cz4JXFZ2iMwrq+t6O/Dt1dIXc2V23lTmHuABXKKGk=; b=YmSM7wrDwyTgW5dU62xzqHYXe98lPOcy0HwPQ3dfETNhFsQIE1azAJU6GxyXEoo+/3pShX/nubedBHlqYwOvOwA6XklQqCCTT6J8so6bPoO/JrFeTNYakhVSP6URV0C2q1NrDXt5W56Ye9I7R5bo8ckd8TplU6Jrvwa9JU4fNNMLMBGd1pPP+wlrrTVEKQB+T/MgJlI+Xi/rsYiSAcUr+euqzOvuywQvVkkOtX286K4XDQiiVJulLENHLwx9BwXpQ7MnUtIaHGvTvzJalPUp612u4f1qIbOhMu1O894K7+v9cW4O6fk2dTNuRarwFresh369WejVCEdoRW0VC7uyPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CO1PR11MB5074.namprd11.prod.outlook.com (2603:10b6:303:97::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 13:57:33 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6319.033; Tue, 25 Apr 2023 13:57:33 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [PATCH 4/5] SimicsOpenBoardPkg: Use another SmmAccess Driver Thread-Topic: [PATCH 4/5] SimicsOpenBoardPkg: Use another SmmAccess Driver Thread-Index: AQHZd0QSNaIFe8B6XE+GKGwa6c3mCK88DQ/A Date: Tue, 25 Apr 2023 13:57:32 +0000 Message-ID: References: <20230425070304.2120-1-zhiguang.liu@intel.com> <20230425070304.2120-5-zhiguang.liu@intel.com> In-Reply-To: <20230425070304.2120-5-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CO1PR11MB5074:EE_ x-ms-office365-filtering-correlation-id: b3f11fad-5209-4946-8cd7-08db4595046f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0xU5pAOYh1HR+15dME8efc/LbRgJujqbeHHDU3UC/o3jvywglTa8agjgPNAi0W8dv1MWOqSEBrnfwMWZEJO/zfJBTWKpoKPfFi9fhIJoDWgy5AEf4evoi4LtWGAQ7ZnCY30rJmuAOqGvNbUUOVV7jj7bXx+jjWMJ3TD+/noUZB5lBa4/U11crW8MQKelTJR6TIVMRawuu2qJJ8IhYE4C5L4bC7BsLPAEZwgurPWvU+zBXthQ+wQUnX1H0ZsQE9PIfKrkqkJ1pWcZVQUjOO2DATPtq/vpiE2mVO8HzTpnRL/GjeVTZKOGMaw5e3dHCFahKvo9d+UKEU2oTWX5UVe2zEOYQQCVelKudzpDei5dpt+SFpwA1Am4AHWURZ04b0EsocStqunbEGJU+cC/2DGTa5dkBhP9kPd9GBgtCk67PD509hxzZWXm+O9rU6CjS93L4pUMgLjUgXgn4NyyhZnFBMS/OmMZ5ZxUPRnyWwmSVFp3jjiB4li5fTG1b1Y4gLM/vRVyjGxSUBSq8NI9fZkjoVsTexNI7txmNFa44dZprGkLgQjUnTMosCIvweJ0++k7f6f0tak5YPlSCin6aQduzKHtqIdyDywsRf4mmagxEmwgViS0hA/QXODZYuhdnARY x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(366004)(39860400002)(376002)(136003)(346002)(451199021)(9686003)(107886003)(53546011)(6506007)(26005)(38070700005)(55016003)(83380400001)(186003)(82960400001)(122000001)(38100700002)(66946007)(76116006)(86362001)(478600001)(66556008)(66476007)(66446008)(8676002)(8936002)(64756008)(110136005)(52536014)(5660300002)(71200400001)(7696005)(41300700001)(2906002)(4326008)(33656002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FdkJlAF21dZWfgvFRZ7FbkEktYzHyCmxaO2KgZ5M+ZZ2RzO/YWw+GdQNEK2d?= =?us-ascii?Q?U5AXBpBV4bqyi1iw9frpLpxfckbkB+YfOsXMTdfScuCQ/LlPFBkShcPEP65B?= =?us-ascii?Q?yHKDZMam+mxkSw4z0mfQPdPQmM7unKrTcsbnIRD/dZmh1oZMi7wDDnL7P/nk?= =?us-ascii?Q?6cehVjpFW/zQqVY28wwIjEYdsU68KEMAHwjyvi3aoGpR+tJj0XRurgy8FZlx?= =?us-ascii?Q?o4iVrIYNZlpvIubBPFoAlccNEqasCNhEM/NgOJQ7eZE6QTIH+6PyrW0PGSo2?= =?us-ascii?Q?i4C7AsL13cVve+9BdRma1EISuXLt43NZUFgjBNW9zpyqrEFY/c/Vstw8uVvg?= =?us-ascii?Q?znWyCzsciz6Sj5JS15AAq3UpbFgMv2xnjfaCkclf/3n419+6+nVN7UjZ4qrP?= =?us-ascii?Q?+SlUytOs3fybC0DWXV0t5ctSp4d/LdvQZV2alwqZ4LegR9YGbQiUvDUAgjkW?= =?us-ascii?Q?bwWywng14R7P5hVO3FWDSuMDYcbv4hjk9qciIkkYzIOb7HC4oNmx43QSJCtl?= =?us-ascii?Q?MqSWJ8G5wd0o4r3ToEhul3U3oJsU/eKl5L/yiXDlhfX44HtpI2rtl4h6jDl8?= =?us-ascii?Q?tfwGZkOYKCswPB65+Hcy0hcrY35CX/8nI3X3n2Yw0FRqYCyFKvDJafsuKRoP?= =?us-ascii?Q?e6AsYwH+vowymMceJK+P90VCKbTgQCA7KfGzdYnRZTacPDxypAy0+81YHwqY?= =?us-ascii?Q?PniB4PkKaoH5rHQ5+zxV0JY7ha5omTBImqPS9kOoVaZ2TY3M7WtHq7cLjJ6T?= =?us-ascii?Q?ngB74BpRUzk7W5AeS5rCYtaciwKs367IUZDu7tSnF7d6hCmmyHqtznrCJTOZ?= =?us-ascii?Q?aaIVV5YIpD+tMMax4bm4vZJN0SvlN1pKcnl+SCezozCQ/Fnrb11qnOGyLcR0?= =?us-ascii?Q?B8JnlGpKptnryLIpnJ7E365YPmhdDIGFrugyNxY0veESH1ab5R7m9cZeEdO1?= =?us-ascii?Q?OdSbVOkbmXLR5NwR2mstFLh84tCnANONLnywwpGz9juk/rx9OzImgKS/MHpc?= =?us-ascii?Q?yzZJqPOZdbMGDY9TYq6e/I1pO0ZSaLDVR8tC1YvIo/t2WM54ArRY1DCqy365?= =?us-ascii?Q?z8ZGVlfLQXfuCsixEt22aJCzUeWrQPioAVt8uym3fCORq139i1Tu4Fg6C+uG?= =?us-ascii?Q?6iL3gF/kCN25wW8Mj9l123zoW2ZtEG++W2EifozaDaHorcEuvnA2nFStSClr?= =?us-ascii?Q?XZbHgz/jacyfX/U4VSdzy6UtrVAidCW4SkKiSrWGzrd6ndJnQoYy3+t9xKQI?= =?us-ascii?Q?iNlmFzL5aEG2xw/9xRVk8sCVfxEMzAr2DeYnmmXw0YwZGLX2ucimbuZIS5Iq?= =?us-ascii?Q?XZhlpUXo0peC9iiTtjzcoBxsD4iYpK/47DydeaXc8wBj+I+CtfvHqXOOSWz7?= =?us-ascii?Q?uTNckIu+EixKYLyKLeey9xVssHeDySmr4YZdLvoxQXksQxaQc55Nr+DDqbi2?= =?us-ascii?Q?JJnDgdiyAWaz9aGUtvVXVuhxUdlnqg4ad6n2dBVazxL3pEHHRJqOiq/rnjbE?= =?us-ascii?Q?3LkREJVzFzpWKnw0wfrXzibBtpXTIFTTj2Sd7V8ssXSBM6uh0BDGhqChdunj?= =?us-ascii?Q?L99HrVrqOcZo1Fl02VROSG8Tss24vGgV8oVMEAgm?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3f11fad-5209-4946-8cd7-08db4595046f X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2023 13:57:32.9688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SxA3Kja6doWV4C8pMRtL+SgNhe9s+FNiaGdweBIc2bry6ECmyLbRRz/4AwinsZE4Lz7sxUW5TxQVc+iFysAE2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5074 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The code change looks good to me. Can you refine your commit message a bit to explain what the bug is? Thanks, Ray > -----Original Message----- > From: Liu, Zhiguang > Sent: Tuesday, April 25, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Desimone, Nathaniel L > ; Ni, Ray > Subject: [PATCH 4/5] SimicsOpenBoardPkg: Use another SmmAccess Driver >=20 > Because of the similiar reason I mentioned in last commit, the > SmmAccess2Dxe.inf driver should be deleted and the replacement > will avoid hard-code and use gEfiSmmSmramMemoryGuid Hob to get > Smm Range information. >=20 > This can fix an exsiting bug, when gSmmBaseHobGuid may allocate buffer > from smm range, and update gEfiSmmSmramMemoryGuid Hob. Current > driver will return hard-code smm range and the buffer used > by gSmmBaseHobGuid is marked as free range by mistake. >=20 > Cc: Nate DeSimone > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 2 +- > Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index fcae343146..64c3af2584 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -278,7 +278,7 @@ > !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > $(PCH_PKG)/SmmControl/RuntimeDxe/SmmControl2Dxe.inf > $(PCH_PKG)/Spi/Smm/PchSpiSmm.inf > - $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf > + IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf > IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf > !endif >=20 > diff --git a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf > b/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf > index fdcb4fb9a7..ca3706578b 100644 > --- a/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf > +++ b/Silicon/Intel/SimicsX58SktPkg/SktUefiBootInclude.fdf > @@ -8,7 +8,7 @@ > ## >=20 > !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > - INF $(SKT_PKG)/Smm/Access/SmmAccess2Dxe.inf > + INF IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf > INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > !endif > INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > -- > 2.31.1.windows.1