From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.15729.1680142370792626006 for ; Wed, 29 Mar 2023 19:12:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XvTi6HZG; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680142370; x=1711678370; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=ggbv0qkJbo3gAHXx0dVFduVax+bQvndYjRGCjxz/tPU=; b=XvTi6HZGZb+YMsXC7V1A8wBq69prFdZiVW1sS8t8tVYuhKwMUnhJ5SwC a3yFaUuQHvSbOZ0VT0O3JE3i6fQXtNMS5diil6SS7oAdquxUs1u12F9lD k2M8htaecfRL3Ic5dsRe2PAv1S45NYE4W11w6K/gcaTJe/bH7qkAIVOBL UVif4Uv+1g/PdTzCGz3IiW1hqvw5bCubSw4tI4+FQDmAZCAYHG0OOs1qE /e08E374u46+g13Hh+w4AJaCl0cOHt3/94vIhT16kI1go7fLfLubD3lJ3 P76F52OBPuWElbhSTx471fNMPMVRxsB/6khmT7dPlVRHMUlIdMdyTRT35 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="368826526" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="368826526" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 19:12:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="828128510" X-IronPort-AV: E=Sophos;i="5.98,301,1673942400"; d="scan'208";a="828128510" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 29 Mar 2023 19:12:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 29 Mar 2023 19:12:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 29 Mar 2023 19:12:33 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.45) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 29 Mar 2023 19:12:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eK78zLZ+Z0nxea7iL8HZ9AULYumlbb9k6JPxLXPMNzr0IY/rCe3iHfuADiBkAC5lmr0TKD/9hTMcDatCoM5wdMCuxZUAqXo3p8knfrGUzmgyMmNc/54K6G4hG7IJ5//gKECMNB71fnAMKierLDee0ck30XVwd9bPNeBbBt6tohU1SYxkI5vw5PkC9lLxm1DBju2FE9TUPmiFn9G9kR7VFPRMFcaBlCFUWIdrazIQ7z+/bsf/iov3NCs0KoAEngD19hgZ4D3u/02XrlZVTYLDt+diylxFRUXeyeqPE9+P8H2j/ZGtHU6cgUWIzPIdApPM2Zy6RR7K1RT02mPoZgM5bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vFt5DvhlwIru3CPeFIezIlkymO8YRK4LWUs8dyiA5O8=; b=Sxl1Ve1iD3Eo/sFHJzml5FP2Z2l3R6Ab8j68A8M/iY68FA2xE6rdh2gqlCDURUR5i7YW07K8HmrArkETRNhsvN9S94sz6GkLQ3TUpm9qBvmoknFcPwebUqSIcIANLCD8jFHWNMY6m6yXBzVVrEFJDjV9aSiPGTX3mgqvdL3tgwm90MA1DCMVUkNf8nD+zrTiJJ8+m10c4xzka1fgplnoKGePFIvCQbQUvSEJP2UR7BGKzsObcsgWzY6QF5Jw3Zj2OYfezkUynWwfZh2rJu28agCtXhJRC5o6Dbfai7nz5FJcbOQgBbOOzgsQuYAzrJLReebWQvUulWaWHciR7gE9zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7803.namprd11.prod.outlook.com (2603:10b6:8:f5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.28; Thu, 30 Mar 2023 02:12:31 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%8]) with mapi id 15.20.6222.035; Thu, 30 Mar 2023 02:12:28 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Kinney, Michael D" Subject: Re: [edk2-devel] [Patch 1/1] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: PcdRtcDefaultYear bounds Thread-Topic: [edk2-devel] [Patch 1/1] PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: PcdRtcDefaultYear bounds Thread-Index: AQHZYo8GAqY0L8rZsUaDpmAjQt5ZL68SlQ8A Date: Thu, 30 Mar 2023 02:12:28 +0000 Message-ID: References: <20230329223656.476-1-michael.d.kinney@intel.com> In-Reply-To: <20230329223656.476-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7803:EE_ x-ms-office365-filtering-correlation-id: 9c0e1b7e-6312-4eb4-3cbe-08db30c43607 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a7SsV7q1PlZOh6M6luKg0DJzFy1Ucut6yG3W+BOUFLpMGcMUc/QghEy4pvBKCDn77PfMr5YDNNZ8sYdiX/mNYe8VDb2QtDyW8zFbeZIYQmsE5qnfeZXag1PTF3GTEL2WS3JYQprDgh+aKEupFnoqQOqfr76s+Sii21xfObsawL1htbrfCQ5Y0/LjA7vc+qgOdcXpInjXjHVoCz1mXPWj7qdruNOm30zFC15m6Z4/J3+3u4ZAwSI4IRoz8GEiGvSMJtcCMi9ufp15RDGFkpS3zE6t3+TX2Y5WOHMHzPn2PZaWetMIl4QJLBbqtZI8B3rA79RWfRPR/Yq0xOlM17SjTuLdIxMKv9jjljhGjCxPXhu5fTm2PRN4eSunKIZWG9tjP7ovFR/4EoRciAEA7lE/PCBKVnXnKrhn5kmzEBHuaVPB/urHTdiv5B3jeD/44Szz2N8kRKxdsOym8GuN/hdS52SSnMTcQw7mRYFMLSa1SYGqDfAqBWtrw7ACw1NK3IE0j6R/sTzZGU3VGobIbcTlA5kPp1yevFUkY+tr/kM0Pi5QCv5rf6RR6HZKdUgPEzo1Q9akWnQr/iEpzW7QdDFNRjp1qpWsyhCkS+6qb3Kd6196S0ooNHBXFKZUyxFD9P7W+b9OZybnm+xU9dNn1MuV97AHFIdmM/2xSdLQN0WhRjM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199021)(8936002)(66899021)(2906002)(83380400001)(86362001)(66446008)(38100700002)(52536014)(33656002)(41300700001)(122000001)(5660300002)(82960400001)(966005)(7696005)(71200400001)(478600001)(66556008)(76116006)(64756008)(8676002)(66946007)(66476007)(6506007)(55016003)(186003)(38070700005)(53546011)(26005)(110136005)(316002)(6636002)(9686003)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z8C+aUw67ffizfUzeg6I/rt6jDTKyzrE3KB7LpGy5P51WLDoYFY6mYFnhllV?= =?us-ascii?Q?DIM01QZobU6ec7H1jJUaXQQpSbNSIR4hfPCsawDoHprEMIOcJaCehj9xTZSa?= =?us-ascii?Q?MNY4bKxgB2nFqmv/fLWdNLekJCtxQ8gPFHwDShzkxfBdzfS48c7bu6eio2fD?= =?us-ascii?Q?KGOWBuAV1+jQ89awpl4Vth2tFJksm3Ocmz7EyHyt0Y6qSgfBd2n0cd4IBrwV?= =?us-ascii?Q?4tvSZIxmAfHzRjtBVTAuQTTusMJavZO978sJ698uJnGSK22BE4dZKw0kYPd7?= =?us-ascii?Q?+ox6Rvvc89Ech+iYq/ZmYqRGLWrVfFnYt2VleKu1Oa0HHBUxDPO2hbeK41Jb?= =?us-ascii?Q?ywQ46qGr9688doMNyH9T2YUB9JkESpKgRFRs0EYNjx7CQqXdp/9KKygIiSXh?= =?us-ascii?Q?7EcHdaoaQSnDkpdUAbu6M7j96vztYNfAKXsyak+0qEcwFAisf6xEh0Zyb5+C?= =?us-ascii?Q?XDzfxGbuCSgmgtFKTFTccord0QcN8+0R0YFO1bXaZRD2jpV+rd7geJzNOftt?= =?us-ascii?Q?vNU0r30asCpwMCOZhEOCmawltl2qzJnQX7PBrtjTBo4wAwy0erY8naDoYCQp?= =?us-ascii?Q?Q7Ne5AyEMhgYAU8MwD7w9S7Iu2RNZhQZr0Etcg5xW+cKtG5/xNEwrpq00u34?= =?us-ascii?Q?ebtihhPCwDBBjyaO3ZM/6WCcJVBLkA0K/R15HCqkR+ZVTrH/HTyMph3wcF2h?= =?us-ascii?Q?nS3J7f3I2fGnkuCpdXvMb342FjDJ1Z5cCo54wk8CRn+klgnywryqIZekZYHK?= =?us-ascii?Q?lRpYmsAalMkWOmlxZcvX65nEDmayuwmu51P2GRECO9MyT0f2P08B2rj5nonw?= =?us-ascii?Q?DzrzMaM0SbDiySfvobem4YhU4fmvRDGJf+AaBdWc7t+XuMbjAHPtUlO2QObx?= =?us-ascii?Q?qD6IMY1SWUNO6F+ZxgVsSkjJe9E8A0Y3ljqcaik1R/zPVPkvJ0/ZonMsr4Zo?= =?us-ascii?Q?je8mEmaTW6mAWyMiv04u8YP5RS09aT3lIlBGZ8w4AROfNTVaXsMWNx8jWaNM?= =?us-ascii?Q?tL8nOoIOXQUs6iizTy7PgzRAVtCg6Lx6XBYhDeHZaZbTRUb4FHe+wbvQybWa?= =?us-ascii?Q?w+8FIKregwpATd3QlsSSys6NBPJ6uoFcpiIU4pUEy+sd9ZNSYsGKEBsVAE/I?= =?us-ascii?Q?8fGQmXIyQARmYR4m36jMgY8331SyetlRF+To9v/0SlVef2eG3Og+w2NdlnRr?= =?us-ascii?Q?UlFL31HK3P+iHBhRzpqH2A+WgtJG3dVyRoPYSmvDEpH3C7BE7ZkYerqpJ+7L?= =?us-ascii?Q?mrp/5qbeVdku7QbhR9+yGZKNB4WreRHbfYqohIDdKXyJvRWT8xGA/ULIRi4n?= =?us-ascii?Q?kTD8o64v+mhgHLXPLGYTiOIze8urlQYBgL8lYK8VD9F87nj7h7vl9mH5K5xk?= =?us-ascii?Q?Sjez6oBEP9dU03KJsegPCSNB3hkqtPtj9LnH0f1YxRQe8D8fEsRJtvPOAN6K?= =?us-ascii?Q?0e7+Xi5bEiZToEDvWmgSmBSDN1K5uZR8haJW1m2SvFnZN6QDSDTSqIfm+nXw?= =?us-ascii?Q?1litP4V3CYUqaJv3h1irTe6iImug7gPQu/jM/3LKr5B7gfbdcVpSQ3OLPJ1W?= =?us-ascii?Q?CJu2NhjGgN6arRDLNBI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c0e1b7e-6312-4eb4-3cbe-08db30c43607 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2023 02:12:28.0755 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XKBUJBQ+O7aX+Ek2MYewsN8eopmvt+Dek9zbZiFP7qjxh6MSBI3KjxYvays8r0inq8JPf18r3oO7R9T3+9lZAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7803 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Thursday, March 30, 2023 6:37 AM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [edk2-devel] [Patch 1/1] > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: PcdRtcDefaultYear bounds >=20 > Add bounds checks of PcdRtcDefaultYear to guarantee that the year > is always between PcdMinimalValidYear and PcdMaximalValidYear. > This is required to make the following commit a backwards compatible > change and guarantee and invalid year is never set. >=20 > https://github.com/tianocore/edk2/commit/d55d73152ebf5c793b645d6ec5b > c517d219881cd >=20 > This is required because use of an expression in the DEC file > PCD default value is only used to determine the DEC default values. > If an INF/DSC overrides PcdRtcDefaultYear, then the DEC expression > for PcdMinimalValidYear is not applied again. >=20 > Cc: Ray Ni > Signed-off-by: Michael D Kinney > --- > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > index b059e92f02dc..15759463f2a3 100644 > --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c > @@ -317,7 +317,8 @@ PcRtcInit ( > Time.Hour =3D RTC_INIT_HOUR; > Time.Day =3D RTC_INIT_DAY; > Time.Month =3D RTC_INIT_MONTH; > - Time.Year =3D PcdGet16 (PcdRtcDefaultYear); > + Time.Year =3D MAX (PcdGet16 (PcdRtcDefaultYear), PcdGet16 > (PcdMinimalValidYear)); > + Time.Year =3D MIN (Time.Year, PcdGet16 (PcdMaximalValidYear)); > Time.Nanosecond =3D 0; > Time.TimeZone =3D EFI_UNSPECIFIED_TIMEZONE; > Time.Daylight =3D 0; > @@ -357,7 +358,8 @@ PcRtcInit ( > Time.Hour =3D RTC_INIT_HOUR; > Time.Day =3D RTC_INIT_DAY; > Time.Month =3D RTC_INIT_MONTH; > - Time.Year =3D PcdGet16 (PcdRtcDefaultYear); > + Time.Year =3D MAX (PcdGet16 (PcdRtcDefaultYear), PcdGet16 > (PcdMinimalValidYear)); > + Time.Year =3D MIN (Time.Year, PcdGet16 (PcdMaximalValidYear)); > Time.Nanosecond =3D 0; > Time.TimeZone =3D Global->SavedTimeZone; > Time.Daylight =3D Global->Daylight; > -- > 2.39.1.windows.1 >=20 >=20 >=20 >=20 >=20