From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5BD4A940FD9 for ; Mon, 1 Apr 2024 07:45:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=L263lmxllaKof4MQq1riT36PRtmHoq9P0RSUGRh2xE8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1711957522; v=1; b=UkvTJB3rhRjABnINV4CbUn86Ek7eLn6c3eFu+obb1SHP/uK4x7y7DIiGm4SeoAQ4o2Vrg955 qASuuRnL/wsT1Fdeun+mxbr+uhCLRZ49AH93scTabqiYbTIVtwA0wWkne2d9UrI7ly6ulZVmCpU jdGjyzKsDvis8cEESA42aKWZTf1FWGO29NemPEjAxbhY9e3sm/7GAgjDgKHv97F0MXi/TrJdDIJ 2pyEXIF7HcxYNy2S7evyZcjvYzFKycozfe7GsyXS8aLnRPSsUcHWlEr7kfF9GKhDnB1xSbEN0hQ tSemyhoFKUktFX+PXaxvBM5zNNAqtkcwYj5SyU4FLAUww== X-Received: by 127.0.0.2 with SMTP id FFrHYY7687511xtRvnAMndm6; Mon, 01 Apr 2024 00:45:22 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.32552.1711957522181821722 for ; Mon, 01 Apr 2024 00:45:22 -0700 X-CSE-ConnectionGUID: txv8cOlJQESDooHd4Lf9eg== X-CSE-MsgGUID: ECP65VngS8y1EEnA4o48dA== X-IronPort-AV: E=McAfee;i="6600,9927,11030"; a="10033225" X-IronPort-AV: E=Sophos;i="6.07,171,1708416000"; d="scan'208,217";a="10033225" X-Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2024 00:45:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,171,1708416000"; d="scan'208,217";a="48832976" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Apr 2024 00:45:21 -0700 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 1 Apr 2024 00:45:20 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 1 Apr 2024 00:45:20 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 00:45:20 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS7PR11MB7836.namprd11.prod.outlook.com (2603:10b6:8:e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.24; Mon, 1 Apr 2024 07:45:18 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817%5]) with mapi id 15.20.7409.031; Mon, 1 Apr 2024 07:45:18 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Lou, Yun" , "Chiu, Chasel" , "Desimone, Nathaniel L" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel] [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId Thread-Topic: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable mForceX2ApicId Thread-Index: AQHag/p7Q6HLtVegIkCt3C8DYhGe0bFTCRIG Date: Mon, 1 Apr 2024 07:45:18 +0000 Message-ID: References: <20240401060411.899-1-dun.tan@intel.com> <20240401060411.899-2-dun.tan@intel.com> In-Reply-To: <20240401060411.899-2-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS7PR11MB7836:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Q4ojzwu8K1TVFXCFaLkjq0FgqbK9OPdatTk49b4NghMOGY4/AT3+M2ncTgcEvRiJnTUXxMnNA81eD21sCFxbd8c3OTkvPcpCiEHQzTZpaCyohMOcTAaQFR8I/UQI4hICGp0t0sAQdDVMTaM/gbzJKKOeXxsR6ucBnQHFtiIbxWbqBYosc+U6B15KAtkbJ4pCH+71WPrgXgD3bHT223y+/SR13V9YUBMaefu07NkgWpj8peQEpcsui42/UPKtgx2pS6Nnx+BoBgo9CrRJYjxKXvVwn5D9j5PVShSSnLzq9f0ea8MR60PYf79sDzg4xhFPO5cNDl31NKxH0F2l7OcGSWf1/vvzCekCYi97UCFacEk7HGoS0VxrEE72vEgh3jvluvKL88gGaISZDH18YI7feHtLIbAgeRoSH76Lq+UqXsK3J3EKfWsE/nvMSjcfAMQzMKxO7Dpgb+/nfkrGl5oIZhRhqQeFci1MPmMcfboPKl9R575sDIzWPXe+MeWxR/fwc1X2StqgrtZ3OrvjisiBck2G8Z7GHGCo+dLYXXsPwqB+Ws78RC7JHtFiHQph8yCZo1VwFT6RZ6VrK/DtSqAWRKvH5RIB+/af53InmumDEQj0sIkZ4ipgYqwgNRgFLLXgOv6dNOACnzDi7F3zVtA2GeB9HF9Hrmw5St4kl2513lM= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xGYsQDVxErZBu6mvfbRs1VF4/4gmEO57LddULt4z3tS5zKuEPrPfOiklbGuu?= =?us-ascii?Q?VfNnv92VnlUpXawofGVdVTPMHorAWqGWbPdifCuJ+/NjXEzNHgYmX2ds0NmV?= =?us-ascii?Q?UUHoDwnmshFCnvdRpw2w3AcMFQA3W9Hwy94NfkiCZyq4VVlbmi0vQ50xLM6/?= =?us-ascii?Q?arHYzIM0/YWH61TcVxJwFayM85jSixcyx7ul1yZl9YFx6POLKuenE0qTE9/Q?= =?us-ascii?Q?lImYfvPVwBqSYJWWqDGOwwnSHO0RPXhV7nTT6c6vLGINPrkaNSFHuXhMlhvd?= =?us-ascii?Q?ctTM70Zqljqn5mTpkeDj6UA8b7BepOIgQv6/THRWC/tTq58fxuYJDb9MaRIp?= =?us-ascii?Q?WSd0dxKL37Z2txvw3H4suU211imUbHZeu9lJu8r6kO3wg0SKJBKyKy++E1+Y?= =?us-ascii?Q?pqh9u3PgqhDF/0km81PEYoZzVb77ktjPayKXe55dw9z6ijbdBwQxp6R3flUE?= =?us-ascii?Q?wHd9PmQBNG9J16ftCadyfLJa2/gfSJGPcN1bLWzp8xei/381U7Wskz3DHAFn?= =?us-ascii?Q?hEu5unKPo14HY2k6fiXE0FFEaChTMaTf0UE0nIQAkjSwTe5K6+GytlmAJkDC?= =?us-ascii?Q?kBq7M89o2lBroZHYm/ijn/UJ7Dw0AoCHftHSeezL3ajSFSEmOIAQPVQeChRa?= =?us-ascii?Q?LHoo17LCYwxENc0h/2RvjGxPvaAzfetPZGIkG8x8o3tBOe3orcpLEy7DVXbl?= =?us-ascii?Q?lZhScscLwWohxgqslvt24sHosvUpeFAyxT0WqVRqHT3jXXCjFTiVBWJgQlRE?= =?us-ascii?Q?RF0CJXe9CghXoyz0nd11t2qnNrLstJss/Or5zOtsq48Gd4/H09YiKg5f3yWT?= =?us-ascii?Q?WKb5yYSOVQP0EsjOPmOs9stapfZQfjfs/cGhK+OfRT8hDc7WwxfkxblUidfM?= =?us-ascii?Q?KONp6YB6Ut1B1qznlJ3WyO6tJGNsBcvJ5pxqlTFq8DvVtwwmEbdpMjJzMVG4?= =?us-ascii?Q?+4voVdgtrQ/bwFaCAOI32A5kuWR0hGAY8qBNuEGMB42vwUXIM2iVUhkY2SZc?= =?us-ascii?Q?4iyWRKwEGh2Wdz39IIx33KaQvEgBz2RwvpX+olHHim4hWLGjqMXMudWxs1Df?= =?us-ascii?Q?WW8NEoHYC1n0+TRgRs4lOXVFU/MyCwFVDzZxHoGgREkKbzDFZWmSOHkUxI9J?= =?us-ascii?Q?0hrV27lpxC5FOnoSf1G49s2HIshs0DTIeiC5r0+xLvvbFr+Y3PBJynCEdimr?= =?us-ascii?Q?FHQxz+bSvRqxlZdZmeu4QexPl2967edXttT+ml9psKDuka1ZPeYsgQzFm0wB?= =?us-ascii?Q?go4N9DfMATQmVbtpUAKkgS0RsJGvsm96SLCgRq50Q6n61wzSKJZGSZHY0XNY?= =?us-ascii?Q?WKpKMGs3A93VttuV61KNpzIX/fcdkVJRFJXfiu5OEYJ9i7ELH9XkQhVYweAg?= =?us-ascii?Q?ffPKYT+LrcynrxEKEVV9dCsFmzn9QQNQ5gUGjFXWIMYXD329EtNKdQN68C+1?= =?us-ascii?Q?pgZL5szPhnTe1fKVqRrWEpB5s7xMD5a8lKq9itv7OzYvzktNgxRehIJ6dcob?= =?us-ascii?Q?MilVgVKEfCxLtcrJk03VwuKmr1FE8ZRdn3nbOpZNQuqhnFVoo7B8PRJrXymK?= =?us-ascii?Q?rgD/RFol3zepSoDvNFc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ee7343a-3182-45e6-7ab4-08dc521fad50 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2024 07:45:18.4544 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gHxD0ORt+b4VWKj6bV4pOu8Yz0+RXpAOEs+8hS9sxt24SkXq+4woZrqLWFtz2EBciXnHtl1UUtC8sgwdou1aRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7836 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Apr 2024 00:45:22 -0700 Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sm2F05LFDunVFgpfPJYVil5ax7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82443E722F7FE87A22EC63B18C3F2MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UkvTJB3r; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82443E722F7FE87A22EC63B18C3F2MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Tan, Dun Sent: Monday, April 1, 2024 14:04 To: devel@edk2.groups.io Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel = ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global variable= mForceX2ApicId This global variable mForceX2ApicId is not assigned to any value in code and will be initialized to 0 when the driver is loaded. So remove the global variable and related code that will not be executed. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Jason Lou Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 10 --------= -- 1 file changed, 10 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 2a833ec99c..62a7da290a 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -53,7 +53,6 @@ VOID *mLocalTable[] =3D { EFI_ACPI_TABLE_PROTOCOL *mAcpiTable; UINT32 mNumOfBitShift =3D 6; -BOOLEAN mForceX2ApicId; BOOLEAN mX2ApicEnabled; EFI_MP_SERVICES_PROTOCOL *mMpService; @@ -163,14 +162,6 @@ CreateCpuLocalApicInTable ( CpuIdMapPtr->Thread =3D ProcessorInfoBuffer.Location.Thread; CpuIdMapPtr->Flags =3D ((ProcessorInfoBuffer.StatusFlag & PROCESSO= R_ENABLED_BIT) !=3D 0); CpuIdMapPtr->SocketNum =3D ProcessorInfoBuffer.Location.Package; - - //update processorbitMask - if (CpuIdMapPtr->Flags =3D=3D 1) { - if (mForceX2ApicId) { - CpuIdMapPtr->SocketNum &=3D 0x7; - CpuIdMapPtr->AcpiProcessorUid &=3D 0xFF; //keep lower 8bit due t= o use Proc obj in dsdt - } - } } else { //not enabled CpuIdMapPtr->ApicId =3D (UINT32)-1; CpuIdMapPtr->Thread =3D (UINT32)-1; @@ -1537,7 +1528,6 @@ InstallAcpiPlatform ( } DEBUG ((DEBUG_INFO, "mX2ApicEnabled - 0x%x\n", mX2ApicEnabled)); - DEBUG ((DEBUG_INFO, "mForceX2ApicId - 0x%x\n", mForceX2ApicId)); // support up to 64 threads/socket AsmCpuidEx (CPUID_EXTENDED_TOPOLOGY, 1, &mNumOfBitShift, NULL, NULL, NUL= L); -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117282): https://edk2.groups.io/g/devel/message/117282 Mute This Topic: https://groups.io/mt/105259123/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82443E722F7FE87A22EC63B18C3F2MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>



Thanks,
Ray
From: Tan, Dun <dun.tan@= intel.com>
Sent: Monday, April 1, 2024 14:04
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Lou, Yun <yun.lou@intel.com= >; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <= ;nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.c= n>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the global v= ariable mForceX2ApicId
 
This global variable mForceX2ApicId is not assigne= d
to any value in code and will be initialized to 0 when
the driver is loaded. So remove the global variable
and related code that will not be executed.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jason Lou <yun.lou@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
---
 Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 10 ---= -------
 1 file changed, 10 deletions(-)

diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
index 2a833ec99c..62a7da290a 100644
--- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
+++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
@@ -53,7 +53,6 @@ VOID  *mLocalTable[] =3D {
 EFI_ACPI_TABLE_PROTOCOL     *mAcpiTable;
 
 UINT32          &nb= sp;           mNumOfBitSh= ift =3D 6;
-BOOLEAN           &= nbsp;         mForceX2ApicId;
 BOOLEAN          &n= bsp;          mX2ApicEnabled;<= br>  
 EFI_MP_SERVICES_PROTOCOL    *mMpService;
@@ -163,14 +162,6 @@ CreateCpuLocalApicInTable (
       CpuIdMapPtr->Thread  =3D Proce= ssorInfoBuffer.Location.Thread;
       CpuIdMapPtr->Flags   =3D = ((ProcessorInfoBuffer.StatusFlag & PROCESSOR_ENABLED_BIT) !=3D 0);
       CpuIdMapPtr->SocketNum =3D Processo= rInfoBuffer.Location.Package;
-
-      //update processorbitMask
-      if (CpuIdMapPtr->Flags =3D=3D 1) {
-        if (mForceX2ApicId) {
-          CpuIdMapPtr->Soc= ketNum        &=3D 0x7;
-          CpuIdMapPtr->Acp= iProcessorUid &=3D 0xFF; //keep lower 8bit due to use Proc obj in dsdt<= br> -        }
-      }
     } else {  //not enabled
       CpuIdMapPtr->ApicId  &nbs= p;  =3D (UINT32)-1;
       CpuIdMapPtr->Thread  &nbs= p;  =3D (UINT32)-1;
@@ -1537,7 +1528,6 @@ InstallAcpiPlatform (
   }
 
   DEBUG ((DEBUG_INFO, "mX2ApicEnabled - 0x%x\n", mX2Ap= icEnabled));
-  DEBUG ((DEBUG_INFO, "mForceX2ApicId - 0x%x\n", mForceX2Ap= icId));
 
   // support up to 64 threads/socket
   AsmCpuidEx (CPUID_EXTENDED_TOPOLOGY, 1, &mNumOfBitShift, N= ULL, NULL, NULL);
--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117282) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82443E722F7FE87A22EC63B18C3F2MN6PR11MB8244namp_--