From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.70937.1679575082969703356 for ; Thu, 23 Mar 2023 05:38:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=eG9YCMzg; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679575082; x=1711111082; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hR0hi9rdONfWOMuxpzpxlFW1m2Ss9nP27FXkSKHnrVA=; b=eG9YCMzgN/YSdy5YKD9y4eCEUGxWfvY2BtbhcWQzc0M7aMi9SOmBorX2 CyzR7VZt5R2ynMHGuNEChPVhjPhlys6EL3Ngar3sp0N8lzjrX/YPiLSzE FnyDZDv47GmIb4E8AK7c7pZJLDl2xYJTT2t5hQdhDmUeVknB7qeHvl0FG DDwHcw6FiVg5EfOBjSaaC3PCASknImL89w5RSa8e9EyuIaKkkHgzfvX3u XSD4GEZgMHN664XQhvgEhMxJii4TfmKMjylJkBUMdyf4sPomSwy1EHqea brHg1qajq0KIzLA+u/oaEc1P/7swYplXvPkwJiA7p9gVFJd+dPnHSGYn2 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="338194731" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="338194731" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 05:38:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="825802594" X-IronPort-AV: E=Sophos;i="5.98,283,1673942400"; d="scan'208";a="825802594" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 23 Mar 2023 05:38:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 23 Mar 2023 05:38:02 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 23 Mar 2023 05:38:02 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 23 Mar 2023 05:38:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hr5RPTnprf1FVcwncNvhc890V9PJkOHY13SjtFpSsvsCT/9hA+aSFkn6VJ/lgJUbvOApAOxLU93Ramyj3avk1m6kYIOTBH4kgX8tXaUeCGSHE5z4Qxje8UEUc/u7QQs+Lhp7Ht/vytRM0crZvBPnTd+fE2esEoMLFhTz1H/baz/TMxCIAbxyzrLbV4H4htlX4n9Y5SF8SxEUoN0ZVwd41g+MFJY4/O0uWg7CdLOC6NqWxz29yaSZBQLLF8W0QRf9e+7aiEJ2oaOQzijBzNMlH4oQViWz38jRZIAtMBSS8aB5is6TVesy0bhwkL+ENutFwLVwZCHvkmOzwoRoMP8kDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sA44vTMJwqaOY+z4i5O84+JNA4FrK1fT3pqqLS2bHvY=; b=B9U1n1csMdbFREWKi3qlknqq0NxAGX5pjvGvOBEovELXO41fAhnOHE2Nd7xK1VnHxh1LIvyqVCAf5wRmoggR1xgaI4nLtOx5CR3RgCQhxVZPwyFISHE+JiC8V9UE2bmpZlxri/iAqnjRi2VP6UESLWuXbunHNaejqyNjXMKgAjwR7LhdeJhEXWuBpeExEA196q/5kccp2s1aIZWaqQcXUFJCpKXocjpBCIe/kBw/nUiz2x3+qcRdxK9DuEsEevjLQ2AvLbQ2d0QpeRBEAeDVfppwxqOTyB5FKZDZb26duIgw2tM1CPi6qCLtZ+Z0AJQFtHbFxrKRQDrizzOSk8lqzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW5PR11MB5930.namprd11.prod.outlook.com (2603:10b6:303:1a1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19; Thu, 23 Mar 2023 12:37:59 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Thu, 23 Mar 2023 12:37:59 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize MapMask Thread-Topic: [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize MapMask Thread-Index: AQHZXVrjz8Zpj+S5PkKch8g93qPVTK8ITULw Date: Thu, 23 Mar 2023 12:37:59 +0000 Message-ID: References: <20230323074057.549-1-dun.tan@intel.com> <20230323074057.549-8-dun.tan@intel.com> In-Reply-To: <20230323074057.549-8-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW5PR11MB5930:EE_ x-ms-office365-filtering-correlation-id: e8c5740a-3408-44a9-8f98-08db2b9b6f85 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VC/iBswdCnx1YU9hLWl4LYY9Hue2NK9rtxZmC+D3yBHF8t8u6kAjRPNru7MnJB39VXPCS6xJv1rDk5E9hfkil1YJCVbo9X44GWeE1SsYiZx5W/xML+CTU2vsinMya0qWtPx1/T2ZDhOnfSooUHqboCC5Gj02zJZbDi0aZxNrYbBepc0ok60KmoVC/8JS4DdtCc/EfDtNEqZeT1HphXdDKkAQcfYUK5oT6F1gYvIAMFGCMPQZQQCFzLjf215h+O5K8Vc+of4jIIIPy6CZoZgIP9ntRp03lMhKcKBp/HQJPdSkaqRSxFWt9A4XyY5Hh2vpi+xrwOdf7HDEUy3zoAwB7N4s8YP79LnqM797T2bCr1Cj3sIVhfsay4yCowdb0bYNwhnxNNbYzvsD7zSVGk4jQSVbonVmvsiQhvTWtu1VzDXtgMX13oVLu6W2qfbwhDRwPo5bjrqC4WrWzlYR7Z15udRH4eaKpzQFfCN6Rdn54BoHJoBozDm6VTAZj9vev4IO30/KKlFjYZU5vzX0Tk78tVtRhVYlm28HdqBUjbcJsDxO+LkpzCDI9oS8XaMZV86/XCqirKIPSl87vtCgQ1CRh4yf3wWDXn2UUzMdYSzpc52oT5bbWHQ61Umr7p/s6J1OCFgtcepmWS+C2qD9Dh/66uukPENgoTnCL+ZB07Dcf32xZN1W+sYiAOpHhbPG0FVQC/4lYulBGYlNau8m3RyabA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(346002)(376002)(136003)(39860400002)(396003)(366004)(451199018)(19627235002)(83380400001)(7696005)(316002)(52536014)(9686003)(5660300002)(66476007)(186003)(8936002)(2906002)(41300700001)(26005)(86362001)(71200400001)(64756008)(76116006)(6506007)(66446008)(8676002)(4326008)(55016003)(110136005)(54906003)(478600001)(38070700005)(122000001)(66946007)(66556008)(38100700002)(33656002)(82960400001)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3BLksHYyvSt5RpONU68+BRaCBiOo5VMh29LAlApmBLISZD/x/NA4Bt5xfRCQ?= =?us-ascii?Q?9+j6AsAka5ygGNmeY/czurvWQD51RrPDcQY3ueDowvI88hnjfmGM2/5LZH6M?= =?us-ascii?Q?+iMUEg2Py9M6Ew/nRjRk3opy6EP3TdoXyEojeGK7Mv1DodjLBtAJWB3mfjtd?= =?us-ascii?Q?fnsqWkty9MXs9alijxnbNW7Bb+11m5LS6JBZi7M4mNj7+Vo9WhMDS1boAp1v?= =?us-ascii?Q?pBtEPcbTCLa5hQvGgvf9MWc8jf/NK3159ccadHJZ6qqS8d53fTRfl4BXI4q5?= =?us-ascii?Q?80lyXdhbFbqIYRpK3ZE4e4xJYsnRlhtLcJ8ebM1viQyBCkSqfh9B91OhPydY?= =?us-ascii?Q?oPmnaTlF7coHz0j1AR5L8DpEN4kWlAL+sPTH35tWC9n34hTILT5Hqh8lXfzD?= =?us-ascii?Q?aCBFCBtIXKQNj3zoLrQ93eBmHFr3UpS1e1usGHPhok0AkMwX+yEVk8xASnXC?= =?us-ascii?Q?7UmuzUg5WHAmLj+jfoKAXVoV4D8ydz8pipkb+EB1mqR71+9C857SkY8Q6PBF?= =?us-ascii?Q?H+faSkuVtE7QbQJ4QNjW4z6dmeltA0u2lPUBANZQE9Aw1GCGBBsgN+woiz+k?= =?us-ascii?Q?gc5xjXYIWOLkZ2RpvgVg1UrOrIH64fbxybyZWEWyO35rRA/L3Pis8a23SoZ5?= =?us-ascii?Q?JcF0ytke2u7yx5qx/H7gjxlSS/5Ha9QWfbiI20CpIrN9uzIuLwkDFOKMJ0fo?= =?us-ascii?Q?FbPWI70IjvYvXvAj6jpS/ziPyZl4zgPNEGkS6MLTedKI8hHrT1u8CH5WFJi8?= =?us-ascii?Q?7QASWPcVvTIjyQ9gHnMEG/eDnB1/RYie32Fpl9q3AGvIQfcewyPHy+t+13MT?= =?us-ascii?Q?jGx9/caPZW4Gnb1sMvmDkJ0m8HH6b/mvIvocWoBOTpxdRXCIFCx9qK0dHWwt?= =?us-ascii?Q?fuxUb4ZxE6xxO8GznbiwjfZrecgzq87WR8Ykc0AQ26tKdWWrZR1+SIuV9lNb?= =?us-ascii?Q?bl6V3JAIiDXG42yJSn+HIn+0hEaOF19MW29cdZ8wGzsh8XNidGKi9gAGT0pd?= =?us-ascii?Q?QkRutQ6FRFm+XiyhFpLmjQsfUpNHCtQz/2+r+r0XSpk5ERvzNsUgQ5+kdczl?= =?us-ascii?Q?kD1PERjkazE1XpQUXKZW3WR5a7K0q5tvfhKFkesS+z2fqOesC0PEDHdc3cUP?= =?us-ascii?Q?XV/fBcJLoSIAlyecB588CH4G01EBHMqL5FuPyG5IkLlWCzsmNFtOAxx3FTV1?= =?us-ascii?Q?mr5jfT1gsc66xMyG4ovD6B0IGED+pTV1H4N9MGXKPfn2FKSP4WTqKhL474gD?= =?us-ascii?Q?YjdrKgMXq9xO0RtC/C+0IVpfePerlMcquc1pq0SMEcSyoaLinLa/M+06WDjt?= =?us-ascii?Q?mD2UM3Z6qbBCCc2dEInxJmZiEWnq6Fe7hESHw6yA2rt0o0Wp1fCP14pDjdjH?= =?us-ascii?Q?h8VhBxWTOUFZDYCtnujnsQSzh11BjWI8K/uhQWwh+byDM2pM/cCbli5hAj2V?= =?us-ascii?Q?3jiQDnQaqjGlks0X/ulqkMPeBKhC2xF9gzCy2Xjgr29SCdpzrdsMxFd6+lWH?= =?us-ascii?Q?7rICSS0YY4FKgw3ry+RSchJPjUdhbdHWQfvEIupJyFe4aQDhP3bnYsD0aloO?= =?us-ascii?Q?63/iqm4aefbFT7GM+bnaUoOOAsU7yuhE3UtCF86H?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8c5740a-3408-44a9-8f98-08db2b9b6f85 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2023 12:37:59.3850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jdzj6HVaCornCS1oPuhvb3UZvX+G5+6ZmsUUNUKBOQ5KIlFgnbfTtsadExNo1Ij9fJZ+LaCRx/ro3nXifiNQ/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5930 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Tan, Dun > Sent: Thursday, March 23, 2023 3:41 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V4 07/21] UefiCpuPkg/MpInitLib: Add code to initialize > MapMask >=20 > In function CreatePageTable(), add code to initialize MapMask to > MAX_UINT64. When creating new page table or map non-present range > to present, all attributes should be provided. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c > b/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c > index 7cf91ed9c4..f20068152b 100644 > --- a/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c > +++ b/UefiCpuPkg/Library/MpInitLib/X64/CreatePageTable.c > @@ -36,10 +36,7 @@ CreatePageTable ( > MapAttribute.Uint64 =3D Address; > MapAttribute.Bits.Present =3D 1; > MapAttribute.Bits.ReadWrite =3D 1; > - > - MapMask.Bits.PageTableBaseAddress =3D 1; > - MapMask.Bits.Present =3D 1; > - MapMask.Bits.ReadWrite =3D 1; > + MapMask.Uint64 =3D MAX_UINT64; >=20 > PageTable =3D 0; > PageTableBufferSize =3D 0; > -- > 2.31.1.windows.1