From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 697A9D8024B for ; Mon, 15 Apr 2024 02:15:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FZjgb9C6Nlwki0qIXwOkPgsJC10gtWqDiMRLs7Ue5Z4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1713147325; v=1; b=xU3h8FT3xjMGtfucORW9RH5xO2rETuqUiZ/j+9Y5EYFuF5aMIjhqePAmKETKdyohKbxN3w9Y bMevFNzEH6PLxv7LLh9U3iudbQcQ3qOGYeqhBofyCuVBySOXFm4j7vxbiJyvM9yOJaaXhLmrEXY H4LHpfW+X9FpREXx3RO4AWkFTIEOgw28aYotxK2indv5mruKwv7UAXsrv8M6s0iZ2OhnZrPH8Ed qiMrpEKBexfJsUvByMK3QDCMLpMzz3P0AYL4AEX8KZfb27tfNq2FdCo+UblxtVA4c3mlEMFxolt qwuONQq5cf4WDYK4bQilaI/PhzZnDtvEl+0USoAntcP8g== X-Received: by 127.0.0.2 with SMTP id KgSIYY7687511xWDuKQJOrkQ; Sun, 14 Apr 2024 19:15:25 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web11.11803.1713147324293377407 for ; Sun, 14 Apr 2024 19:15:24 -0700 X-CSE-ConnectionGUID: t5ApdsA7SmazKgQoIg4Gxg== X-CSE-MsgGUID: zGKc71wTSgC8sj5DZAU+Jg== X-IronPort-AV: E=McAfee;i="6600,9927,11044"; a="19943927" X-IronPort-AV: E=Sophos;i="6.07,202,1708416000"; d="scan'208,217";a="19943927" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2024 19:15:24 -0700 X-CSE-ConnectionGUID: 6IfVKsJIRlmi63wXFfLY6Q== X-CSE-MsgGUID: YrFAOqh9Q/uHnxqtvkrQNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,202,1708416000"; d="scan'208,217";a="26187900" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Apr 2024 19:15:24 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 14 Apr 2024 19:15:23 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 14 Apr 2024 19:15:23 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 14 Apr 2024 19:15:22 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ2PR11MB7454.namprd11.prod.outlook.com (2603:10b6:a03:4cc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.29; Mon, 15 Apr 2024 02:15:21 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8774:81a7:c5b7:5c2c]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8774:81a7:c5b7:5c2c%7]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 02:15:20 +0000 From: "Ni, Ray" To: Chao Li , "devel@edk2.groups.io" CC: "Kumar, Rahul R" , Gerd Hoffmann , Sami Mujawar , Sunil V L , Bibo Mao , Dongyan Qian Subject: Re: [edk2-devel] [PATCH v3 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Thread-Topic: [PATCH v3 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Thread-Index: AQHajKvAhWFlE7TqY0OBCyPhNt2zNLFom94L Date: Mon, 15 Apr 2024 02:15:20 +0000 Message-ID: References: <20240412073254.3486364-1-lichao@loongson.cn> In-Reply-To: <20240412073254.3486364-1-lichao@loongson.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ2PR11MB7454:EE_ x-ms-office365-filtering-correlation-id: 439bb916-cab4-49d8-3cc4-08dc5cf1e6cd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Wg3pV6CIT7giOhw+xxsBnfKhRXW664zQwktn56zv3PUD/HEBo92d540ycGIjv4AIoTy6KR5HDqSHNROnsufCA0P+OGGiRIBEx7h2NmTrULWGmtpNTDXgl4F7XEMf5R3t9QdjMImqh5kzOzIsShFs01yLe3U/AA+VJbPhNdBxQnzOrkFxChPEfx7VBhNM9MdzG5tXuzMGRz+cg4naUdfpjikUfm2R3iyvxB8Zv0SqFtb5yiG8me9DSfgkfrHNMaVpTPyghOrMxXWR4VyjOcfbKMIsyFmIB9t87HxDo1CbLEG6bZHvOCcza6o7nRPBjwXqs9GsJ5RG4T0/y2w5N2wbKaWWAgvz439d/op1cHNTVtoZZOkcK8ORxC2Atuy1dGgzfbX7lsZ7KYfL8hmDBMWveeeuSZGQQtiW3UtclbFD/i4YKdYkiUpkDsnhuw9Vxx90aYQ1e+2Q2Mk9jeb6dmtUGJ/YhDWMd/PjjgZ9pJCA2rdxLM0BcaBkX42vfe+IyRnxd7P/Iv+KF7dJOx20t7ZUj1PjOzHWaJqg60eRZqgAf2ndoP8al1Sk1ttoapGUqVQoFd6kmIfLJ3VqaJpivja9HYw9OPG1pN8ynYOq2uYKH1NGXgUI71Tkv/S/4f+o69ZbXZbP2QIetnm57DpL3SH9GhQe71Zuend9mQnTHQvlyOztg8BncwinlfdMmuns/f5o x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2HT3Lvbs5kI6fc/Wh6Ff48P312+uJJdnSLmotlY6HFJo3YbP0BCwwaKo3Ujr?= =?us-ascii?Q?01PniGL9hwFyPbLQAUmXSB810iBKlIugXUDVD/DhNJ0OAtOS7EwL05Tw+bEh?= =?us-ascii?Q?2o2kk+Xj5gX/EF3FruhlWJzbDocHG7QpOIa3beB4YGOJE/z+OZlOg9PxMWKi?= =?us-ascii?Q?YI1f0drvb65Nb2yy5aon4MUHx2xXEfaNRVXoaYEHS9ieX4vRQG/W6fqnpmus?= =?us-ascii?Q?8JG+k7vzuurXbUpRkKEWll5l9uNiTvpU5DbK3VQQuKU3OKZXbH/2LYS8u6tA?= =?us-ascii?Q?YhZ5IX6Tf3L2ch+w7TRA9bg20V8XCB/fNFWS1U8envdrtpDqYkUIkfnmbcDd?= =?us-ascii?Q?S30+cW3i2DaAEKjSmpDVi5rtLXynv2BXQw5/gf/7c9u93zv+5fcBUPDjI7uD?= =?us-ascii?Q?zvGFXEEjHUjwPjG5Bo1XMfVBt23rwIGIwMP1Ib5/p0YfyqAWAZAn+tASrMap?= =?us-ascii?Q?HDnjBUDhSFMuTSuCnTuqDu1vSeDpTHynqdrcXpTWJL3I4wKNOsHygOfxDQ/e?= =?us-ascii?Q?IvA36NYwkkynoNgs0XOTp8RJlZTLlVa3raCluDhXV/EXhMkTxjz6ltC8aWEw?= =?us-ascii?Q?BYpDvJSAnlUbza4qgkRkvxi55f80n+2bioIEYT5PnKiYfoGqGqP9QkdLaU/+?= =?us-ascii?Q?x2UTpIpxbIPZVZaKdyIeCGYYDjMj0K2PpNbDjUKu3Bmp3nUGiihDSzXQgZLS?= =?us-ascii?Q?UZLZVBLv8VXOSenbXYRd1dydPB89HHoG9nL/Zvi6tkgU7w/oc3Sz+t6/P0VA?= =?us-ascii?Q?3Vy6k+OOGQzofCIHv3Ifzvdng0hh5QW8NBMBISDdsJIkptgZOoEJMGi0nk4l?= =?us-ascii?Q?dKXMY7a+we8QqV1+xtC0v7qV/2q1Ev9P/EeW0d1g26Vixrq66LFMvkvoJ9o1?= =?us-ascii?Q?7bM+SYq/hjrmtavqVg+Xg6NZEzMVnfXbZdbVmIPMEAmA/A9zDowMUIr0lWzk?= =?us-ascii?Q?q0PnfHEz5rj2DV8qT5me1oM60YHLUsBg2y2WixMUp/DooOCbNFeNR58zgBuc?= =?us-ascii?Q?FdEwEWQ3DqUPCiCdXo46JKpjLdvaeTZd8pZBxS51ZIV8zyVd9DSkk3GeXKXS?= =?us-ascii?Q?NxOQmn0Itt9oHqPmNGt5nHAfnmhLGEur+rtlchN0bEw4y/U7njHBI48efsPQ?= =?us-ascii?Q?G0kR9/gbRsFH/0m6JOX6I8M/0/VL7cRKocr221C9M3FtNn1C+tpzEKYT3h1t?= =?us-ascii?Q?5DB/FDv1hOfc/zUUU1wXT8pd2ckxljWS9sD950aoWw6G48YoP551GBpQR1re?= =?us-ascii?Q?kpzseS7N4UQB7a8eV1svZu1mIBcj35MtRZiqDkOLSs+7CcL7yR5fGMgYC6H9?= =?us-ascii?Q?ebEtiqiYwR8+u133OjzBkXhoHZwpMDqtlqQRnLmCLIfMGCQ39nYY9NwegZHO?= =?us-ascii?Q?oM/OFc70Rj7aE7tGO6EnfVXQ4IdsmUOIGnHaE4FM/6q06wVKIntW4sHJDJuF?= =?us-ascii?Q?f9nFMYocImp7yCgUnn4TpREvC2xTJzslQfCWL8Bgk6IpyXhYsrnD72Wpox4q?= =?us-ascii?Q?9zvpPF/bLyzaSvIgLI/uDf5L8k1kda9P/UPsooiOFJIq94Awffh59mULBhl+?= =?us-ascii?Q?UZP9MMkGwxLkrXl/cQk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 439bb916-cab4-49d8-3cc4-08dc5cf1e6cd X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2024 02:15:20.8424 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: REMY/Cl9SYabZr0VPfcibwQCJke0drarOLXyq6+l4GPxjz+ZpduywdVOEuEgv09P/dB+MnfDgLE9Pbiihr4qOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7454 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 14 Apr 2024 19:15:24 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2llfe3V6sNj1RtwMLFtZ9N8Ix7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82444186D7579887B23732BF8C092MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=xU3h8FT3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) --_000_MN6PR11MB82444186D7579887B23732BF8C092MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Chao, I've replied all of your patches. Only for patch "[edk2-devel] [PATCH v3 10/13] UefiCpuPkg: Add a new GUID to= store the processors resource", I have one comment. Others look good to me= . Thanks, Ray ________________________________ From: Chao Li Sent: Friday, April 12, 2024 15:32 To: devel@edk2.groups.io Cc: Ni, Ray ; Kumar, Rahul R ; G= erd Hoffmann ; Sami Mujawar ; Suni= l V L ; Bibo Mao ; Dongyan Q= ian Subject: [PATCH v3 00/13] Part 2 patch set to add LoongArch support into Ue= fiCpuPkg This patch set adjusted some order in UefiCpuPig alphabetically, added LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of the first patch series v8 submitted at https://edk2.groups.io/g/devel/message/114526. And also separated from https://edk2.groups.io/g/devel/message/116583. This series only contents the changes for UefiCpuPkg. Patch1-Patch4: Reorder some INF files located in UefiCpuPkg alphabetically. Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuDxe for LoongArch, and added some PCD and header files requested by the above libraries and drivers. Modfied modules: UefiCpuPkg BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4726 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4734 PR: https://github.com/tianocore/edk2/pull/5483 V1 -> V2: 1. Removed PcdCpuMmuIsEnabled. 2. Removed API GetMemoryRegionAttributes API as it is no longer needed. 3. Patch3, added two empty line in DXE and PEI INF files. 4. Patch5, added the Status check in GetTimeInnanoSecond function. 5. Separated into two series, this is series one, and the second one is OvmfPkg. V2 -> V3: 1. Remove CpuMmuInitLib. 2. Added a new GUID HOB named PROCESSOR_RESOURCE_HOG_GUID. 3. Following Ray suggest, adjust CpuMmuLib API, rename the API name. 4. Rename the PcdCpuExceptionVectorBaseAddress to PcdLoongArch64ExceptionVectorBaseAddress. 5. Enable CpuMmio2Dxe in LoongArch. Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Sami Mujawar Cc: Sunil V L Cc: Bibo Mao Cc: Dongyan Qian Chao Li (13): UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files alphabetically UefiCpuPkg/MpInitLib: Reorder the INF files alphabetically UefiCpuPkg/CpuDxe: Reorder the INF file alphabetically UefiCpuPkg: Add LoongArch64 CPU Timer instance UefiCpuPkg: Add CPU exception library for LoongArch UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg UefiCpuPkg: Added a new PCD named PcdLoongArchExceptionVectorBaseAddress UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg UefiCpuPkg: Add a new GUID to store the processors resource UefiCpuPkg: Add multiprocessor library for LoongArch64 UefiCpuPkg: Add CpuDxe driver for LoongArch64 UefiCpuPkg/UefiCpuPkg.dsc: Add CpuMmio2Dxe.inf to LoongArch64 field UefiCpuPkg/CpuDxe/CpuDxe.inf | 39 +- UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c | 439 +++++ UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h | 288 +++ UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c | 544 ++++++ UefiCpuPkg/CpuDxe/LoongArch64/Exception.c | 159 ++ .../Include/Guid/ProcessorResourceHob.h | 29 + UefiCpuPkg/Include/Library/CpuMmuLib.h | 41 + .../DxeCpuExceptionHandlerLib.inf | 37 +- .../LoongArch/DxeExceptionLib.c | 198 ++ .../LoongArch/ExceptionCommon.c | 171 ++ .../LoongArch/ExceptionCommon.h | 131 ++ .../LoongArch64/ArchExceptionHandler.c | 268 +++ .../LoongArch64/ExceptionHandlerAsm.S | 366 ++++ .../LoongArch/SecPeiExceptionLib.c | 102 ++ .../PeiCpuExceptionHandlerLib.inf | 16 +- .../SecPeiCpuExceptionHandlerLib.inf | 31 +- .../SmmCpuExceptionHandlerLib.inf | 16 +- UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf | 39 + UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni | 14 + .../Library/CpuMmuLib/LoongArch64/CpuMmu.c | 785 ++++++++ .../Library/CpuMmuLib/LoongArch64/Page.h | 33 + .../LoongArch64/TlbExceptionHandle.S | 51 + .../LoongArch64/TlbExceptionHandle.h | 36 + .../CpuMmuLib/LoongArch64/TlbInvalid.S | 24 + .../CpuMmuLib/LoongArch64/TlbInvalid.h | 24 + .../Library/CpuTimerLib/BaseCpuTimerLib.inf | 17 +- .../CpuTimerLib/LoongArch64/CpuTimerLib.c | 250 +++ UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 42 +- .../Library/MpInitLib/LoongArch64/DxeMpLib.c | 480 +++++ .../Library/MpInitLib/LoongArch64/MpLib.c | 1626 +++++++++++++++++ .../Library/MpInitLib/LoongArch64/MpLib.h | 350 ++++ .../Library/MpInitLib/LoongArch64/PeiMpLib.c | 381 ++++ UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 40 +- UefiCpuPkg/UefiCpuPkg.dec | 13 + UefiCpuPkg/UefiCpuPkg.dsc | 7 + 35 files changed, 7008 insertions(+), 79 deletions(-) create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/Exception.c create mode 100644 UefiCpuPkg/Include/Guid/ProcessorResourceHob.h create mode 100644 UefiCpuPkg/Include/Library/CpuMmuLib.h create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Dxe= ExceptionLib.c create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Exc= eptionCommon.c create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Exc= eptionCommon.h create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Loo= ngArch64/ArchExceptionHandler.c create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Loo= ngArch64/ExceptionHandlerAsm.S create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArch/Sec= PeiExceptionLib.c create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/CpuMmu.c create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/Page.h create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbExceptionHa= ndle.S create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbExceptionHa= ndle.h create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvalid.S create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvalid.h create mode 100644 UefiCpuPkg/Library/CpuTimerLib/LoongArch64/CpuTimerLib.= c create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/DxeMpLib.c create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.c create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/PeiMpLib.c -- 2.27.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117744): https://edk2.groups.io/g/devel/message/117744 Mute This Topic: https://groups.io/mt/105478478/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82444186D7579887B23732BF8C092MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Chao,
I've replied all of your patches.
Only for patch "[edk2-devel] [PATCH v3 10/13] UefiCpuPkg: Add a new GUID to store the processors resour= ce", I have one comment. Others look good to me.

Thanks,
Ray
From: Chao Li <lichao@lo= ongson.cn>
Sent: Friday, April 12, 2024 15:32
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kum= ar@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Sami Mujawar <= ;sami.mujawar@arm.com>; Sunil V L <sunilvl@ventanamicro.com>; Bibo= Mao <maobibo@loongson.cn>; Dongyan Qian <qiandongyan@loongson.cn&= gt;
Subject: [PATCH v3 00/13] Part 2 patch set to add LoongArch support = into UefiCpuPkg
 
This patch set adjusted some order in UefiCpuPig a= lphabetically, added
LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of the first patch series v8 submitted at
https://edk2.grou= ps.io/g/devel/message/114526.

And also separated from https://edk2.groups.io/g/devel/message/116583.

This series only contents the changes for UefiCpuPkg.

Patch1-Patch4: Reorder some INF files located in UefiCpuPkg
alphabetically.

Patch5-Patch13: Added Timer, CpuMmuLib, CpuMmuInitLib, MpInitLib, CpuDxe for LoongArch, and added some PCD and header files requested by the
above libraries and drivers.

Modfied modules: UefiCpuPkg

BZ: https= ://bugzilla.tianocore.org/show_bug.cgi?id=3D4726
BZ: https= ://bugzilla.tianocore.org/show_bug.cgi?id=3D4734

PR: https://github.= com/tianocore/edk2/pull/5483

V1 -> V2:
1. Removed PcdCpuMmuIsEnabled.
2. Removed API GetMemoryRegionAttributes API as it is no longer needed.
3. Patch3, added two empty line in DXE and PEI INF files.
4. Patch5, added the Status check in GetTimeInnanoSecond function.
5. Separated into two series, this is series one, and the second one is
OvmfPkg.

V2 -> V3:
1. Remove CpuMmuInitLib.
2. Added a new GUID HOB named PROCESSOR_RESOURCE_HOG_GUID.
3. Following Ray suggest, adjust CpuMmuLib API, rename the API name.
4. Rename the PcdCpuExceptionVectorBaseAddress to
PcdLoongArch64ExceptionVectorBaseAddress.
5. Enable CpuMmio2Dxe in LoongArch.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Dongyan Qian <qiandongyan@loongson.cn>

Chao Li (13):
  UefiCpuPkg/CpuTimerLib: Reorder the INF file alphabetically
  UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files
    alphabetically
  UefiCpuPkg/MpInitLib: Reorder the INF files alphabetically
  UefiCpuPkg/CpuDxe: Reorder the INF file alphabetically
  UefiCpuPkg: Add LoongArch64 CPU Timer instance
  UefiCpuPkg: Add CPU exception library for LoongArch
  UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg
  UefiCpuPkg: Added a new PCD named
    PcdLoongArchExceptionVectorBaseAddress
  UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg
  UefiCpuPkg: Add a new GUID to store the processors resource
  UefiCpuPkg: Add multiprocessor library for LoongArch64
  UefiCpuPkg: Add CpuDxe driver for LoongArch64
  UefiCpuPkg/UefiCpuPkg.dsc: Add CpuMmio2Dxe.inf to LoongArch64 field<= br>
 UefiCpuPkg/CpuDxe/CpuDxe.inf       = ;           |  = 39 +-
 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c     &= nbsp;  |  439 +++++
 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h     &= nbsp;  |  288 +++
 UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c     &n= bsp;   |  544 ++++++
 UefiCpuPkg/CpuDxe/LoongArch64/Exception.c     |&n= bsp; 159 ++
 .../Include/Guid/ProcessorResourceHob.h     =   |   29 +
 UefiCpuPkg/Include/Library/CpuMmuLib.h     &= nbsp;  |   41 +
 .../DxeCpuExceptionHandlerLib.inf      =        |   37 +-
 .../LoongArch/DxeExceptionLib.c      &n= bsp;        |  198 ++
 .../LoongArch/ExceptionCommon.c      &n= bsp;        |  171 ++
 .../LoongArch/ExceptionCommon.h      &n= bsp;        |  131 ++
 .../LoongArch64/ArchExceptionHandler.c     &= nbsp;  |  268 +++
 .../LoongArch64/ExceptionHandlerAsm.S     &n= bsp;   |  366 ++++
 .../LoongArch/SecPeiExceptionLib.c      = ;      |  102 ++
 .../PeiCpuExceptionHandlerLib.inf      =        |   16 +-
 .../SecPeiCpuExceptionHandlerLib.inf     &nb= sp;    |   31 +-
 .../SmmCpuExceptionHandlerLib.inf      =        |   16 +-
 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf    | &= nbsp; 39 +
 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni    | &= nbsp; 14 +
 .../Library/CpuMmuLib/LoongArch64/CpuMmu.c    |  = 785 ++++++++
 .../Library/CpuMmuLib/LoongArch64/Page.h     = ; |   33 +
 .../LoongArch64/TlbExceptionHandle.S     &nb= sp;    |   51 +
 .../LoongArch64/TlbExceptionHandle.h     &nb= sp;    |   36 +
 .../CpuMmuLib/LoongArch64/TlbInvalid.S     &= nbsp;  |   24 +
 .../CpuMmuLib/LoongArch64/TlbInvalid.h     &= nbsp;  |   24 +
 .../Library/CpuTimerLib/BaseCpuTimerLib.inf   |  = 17 +-
 .../CpuTimerLib/LoongArch64/CpuTimerLib.c     |&n= bsp; 250 +++
 UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf |   42 +-
 .../Library/MpInitLib/LoongArch64/DxeMpLib.c  |  480 +++++<= br>  .../Library/MpInitLib/LoongArch64/MpLib.c     | 1= 626 +++++++++++++++++
 .../Library/MpInitLib/LoongArch64/MpLib.h     |&n= bsp; 350 ++++
 .../Library/MpInitLib/LoongArch64/PeiMpLib.c  |  381 ++++  UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf |   40 +-
 UefiCpuPkg/UefiCpuPkg.dec       &n= bsp;            = ; |   13 +
 UefiCpuPkg/UefiCpuPkg.dsc       &n= bsp;            = ; |    7 +
 35 files changed, 7008 insertions(+), 79 deletions(-)
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.c
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuDxe.h
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/CpuMp.c
 create mode 100644 UefiCpuPkg/CpuDxe/LoongArch64/Exception.c
 create mode 100644 UefiCpuPkg/Include/Guid/ProcessorResourceHob.h
 create mode 100644 UefiCpuPkg/Include/Library/CpuMmuLib.h
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArc= h/DxeExceptionLib.c
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArc= h/ExceptionCommon.c
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArc= h/ExceptionCommon.h
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArc= h/LoongArch64/ArchExceptionHandler.c
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArc= h/LoongArch64/ExceptionHandlerAsm.S
 create mode 100644 UefiCpuPkg/Library/CpuExceptionHandlerLib/LoongArc= h/SecPeiExceptionLib.c
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.inf
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/CpuMmuLib.uni
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/CpuMmu.c<= br>  create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/Page.h  create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbExcept= ionHandle.S
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbExcept= ionHandle.h
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvali= d.S
 create mode 100644 UefiCpuPkg/Library/CpuMmuLib/LoongArch64/TlbInvali= d.h
 create mode 100644 UefiCpuPkg/Library/CpuTimerLib/LoongArch64/CpuTime= rLib.c
 create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/DxeMpLib.= c
 create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.c  create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h  create mode 100644 UefiCpuPkg/Library/MpInitLib/LoongArch64/PeiMpLib.= c

--
2.27.0

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117744) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82444186D7579887B23732BF8C092MN6PR11MB8244namp_--