Re: [edk2-devel] [PATCH 2/5] UefiCpuPkg: Contiguous memory allocation and code clean-up.

["Ni, Ray" <ray.ni@intel.com>]

> 
>   Hi,
> 
> > 3) The special case you have to handle is not running on a AMD
> > Processor, but AmdSev being active (i.e. UseSevEsAPMethod == True).
> > Otherwise it should be just standard Ia32 and X64, there should be no
> > need to check whenever you are running on a AMD processor.
> >
> > I understand your point, but for both cases (check AmdSev, standard
> > Ia32 and X64), AMD related code will be changed. We would like to keep
> > the original implementation as much as possible.
> 
> Well, the original implementation never checks for an AMD Processor, it
> only checks whenever SEV-ES is active (and sets UseSevEsAPMethod in that
> case).  So why you are adding that check?

Gerd,
I understand that the patch tries to keep AMD flow as the original to avoid
breaking in AMD environment, no matter with or without SEV-ES.

Yuanhao,
I suggest you work with Tom later in a separate patch to put AMD64 non-SEV CPU
in 64bit paging mode as well, if Tom can help to test.

Thanks,
Ray