From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D79367803CC for ; Fri, 23 Feb 2024 02:33:35 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OUD6vaA8DKaAy5TZIzsWeg7JIiY/VS8a8u1bgvlNVp4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708655614; v=1; b=CaJcqS+7uv7Mr3oKmofr1vlQ5D0N36aZhR9eW/qqImg36sU22pB8Ry307ivu+RS1u9wh8jb4 Zc/5tHMiYsrPFOPD2gg0+POMLrQsDFoQWNtrW4CRpQ0rxewKbVpOBaJzVifzk/UouEwTE8+imPb KMiQ9tJ9nnOYNNFHXS6KCHjs= X-Received: by 127.0.0.2 with SMTP id fvvAYY7687511xKm2s0YDVCg; Thu, 22 Feb 2024 18:33:34 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mx.groups.io with SMTP id smtpd.web11.2421.1708655613941849665 for ; Thu, 22 Feb 2024 18:33:34 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="2806060" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="2806060" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 18:33:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="36549820" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 18:33:34 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 18:33:32 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 18:33:32 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 18:33:32 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 18:33:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GeUZkjuDVdmuyhqcXUWhc/yp4kezxYrwjyyJjUT8MdM3CfVbNCPRulqKAEK+dIZ5KQ0V2YKEdqN3AroAcPS1wp5XUa0dpAp0hX30QRbChCI3x9S1Nh5YtjYS7A4UBMtIcN9hDX+jc2OgU/kn+sgSynTBcSlrIjo/oThUX77sH3v0gwZQSW6YKyZUQlSwTqz4yUa5A/KdlNtPYki3DpDqvE40rdEkI1VpTtBheRBt5UA5pDPOFTuNdyR5o6KwtKB1/cNBGa2QStgzN7ZF5ejoLeTcAI2Wy0o0ToG/PNxMDh1j+k5yBvYr7j9of+5VwKrYwnKLELXs2Sy0Efx2FvC3ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NU+xG65ZWm3t7mx9slsb59cOI4Wel4rOY0YGAqhQA+s=; b=eHk0r0C9gErU1aB/Zct2ygneS7xRlUySHwtg2FLLdezGzmUgwhyPqVdAQ4z3q1MN0VZDZozbUA5KXeh8XcER+n0xjubBU2maXYAjg3DKeB85lSupzc6Tw8rZ24IzXa0ZCVlEb4LCNEvhm4SNWfKHM8kBhOO7adjckcg5i+/N6Glg7waOtOrPscqkj/sWiH1fQfJxdsVRayIHcKrbGOvd1cV5K3yhC4z1+AAFNB6ZxjmflbIUJuMwbcBeKUjSerwWOw9LO8YsA5NZNr81DAnSDNGj0ScO9zwLLWVmIKCHRj298MR5h8AiyDpXbrpgzFm9EOAUa3P5exEHiQrwyHT5+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CO1PR11MB4867.namprd11.prod.outlook.com (2603:10b6:303:9a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Fri, 23 Feb 2024 02:33:30 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8985:d1bc:9df6:61cf%7]) with mapi id 15.20.7339.009; Fri, 23 Feb 2024 02:33:30 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Oliver Steffen Subject: Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber() Thread-Topic: [PATCH v3 6/6] UefiCpuPkg/MpInitLib: return early in GetBspNumber() Thread-Index: AQHaZaiKj/5IBQJEmECTUHU0DX9/prEXNZVg Date: Fri, 23 Feb 2024 02:33:30 +0000 Message-ID: References: <20240222160106.686484-1-kraxel@redhat.com> <20240222160106.686484-7-kraxel@redhat.com> In-Reply-To: <20240222160106.686484-7-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CO1PR11MB4867:EE_ x-ms-office365-filtering-correlation-id: 576eb2a9-1d72-4b70-0dea-08dc3417d2a6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: uOACoEYG/qnHQGW/5/gF6LIBX/kkhP0MKlBM2+APq+H9etxYPvGX+2zGKEjFUschpsV6qnQyVocMjMB57zVdg45QUSfl7EkwoSbabs9MvPNX0FCAHveI0XE7gxsyREhVun2OPsX5qhwEBAvZpttpkOxiE9/GeGgN+9vItY9lBs4m3qww/eIddIMiTAA2zgP/4akD69S0BrtUTbe4PL1Cxp21LK4a4PsYPYsb8P9ATfIXRXBTtO82NmtDUeWl2E4eXWpHpDgfYu/d7olzIStwC5+PVF14VjKzktu37vLnGztiEsJW9PhyT1ItP5ncmb/JGTiab+spTzNfAcPYZiA2mPq4sRLdMmtM8yKLqaEo+I+cdrxNKq5wAEZGdOuXni1g7F7zT+bpAz/2GpvYEVdIQMYurz+EtEBAqZ4T4ZixTq/9aQ0Hi3dSp3QV4AL2PutElNrPkXocd5bOGGPeEFmwIIXWfBgvzy7LI6QrBdptpj9cPxH3a+4crnca5gpfFAUmiGyExJzaMoNSOxXcopVgs+Dh+i4iDJQG0OeNnW0bvaDx1DdT1gVD9TFAso9PcwzW0I6bkSzsw2SNlNvdyC5FcJStg1szfcx8eMrxINb8PARd4ZW7ntrIzMbmXtcFRO6n x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SlLQSj9tVw1/JUAotboTzfCNK+iikSfGWbRuh16z/WZUGBNntP9CmFSULvwr?= =?us-ascii?Q?9WjoBYOhIf4b4fe1ylR9Ul0rGBpqKjilBMqkxA0QJ43/HBpv1wp6xkWLUis9?= =?us-ascii?Q?CV8WYtOLiC05CIOOkYHKQJBKzhRj3o1Rlc8o84wxqasg7Sipn9pxYbR/5ynP?= =?us-ascii?Q?tcYAXNSPml+d9BOlEJQPdvZ6yYX44mL7yj3sxP0N/cvwe6Hrw6LSdOPeEE/z?= =?us-ascii?Q?hUZZeWYi7bNx3cmbqZ8JbkbbuHezA2EzUeUuyx6/vUF8HmwZNfyOshHLjB1b?= =?us-ascii?Q?U7fPTuW9SKRcNyohRuwvBEC+twFZile0XaPD4Bwb9AovUvC/jXUnn76J/M0B?= =?us-ascii?Q?XqwWewBJFCWaQW12xPWRarLKE4MsO1r4aiiRjNFuNGLZw9+AIxc/6YQiaUfX?= =?us-ascii?Q?OQ/mw6UmYUtknYiRoGrw2mifHj6on+orKNg1PGhbx8lE3RzALT8KJEbC3sRv?= =?us-ascii?Q?Lr0a6fyHKxI5kL4kQ+ZujHaPfuGbUl9SuLVeI0A6UxlXwQg53z2Fuvd5jov5?= =?us-ascii?Q?veVmIQTi9PXTXtqe+1z6chorRae2TNCpr9fCUFEkK5theCpU9ov54OxKRL58?= =?us-ascii?Q?Z5nXwo67w35bpox0kglWwZ07cDn1P4MNZm4bsibnlED0svlxjNJsCxE7R6wl?= =?us-ascii?Q?t8ScUxQruApN5FnZTDHZABT3oJ6U/XosWCLyF8P/KO96LGcK6lxvo4rOAwLZ?= =?us-ascii?Q?zNel5ZaDkLZ0gBh4O60LwEoxPGdUZWIWW42RjHhGmEzxx6hwtWdfMmfURelL?= =?us-ascii?Q?p+OHgfxdBVUO8pQj3A2khk0+z74TcJwSHETGG4F8T/6lZ6qAIXnZtFVX74Lw?= =?us-ascii?Q?e/Xq0rJssCUxDt/L5dJbmGb1Pb7FtSen7ezq8YtV2QLjZx/x+md6Y/AHRoWj?= =?us-ascii?Q?6SU3UowUS/KnEaVne4dgq3koQfikIPm3ZIftgeXVZ7PzqoYagXn+fGKAhuLQ?= =?us-ascii?Q?ThTsE5cxBNnEpWpQlmfBIAbyY0LO3faFxFTxi8YVMUtvipXUp9PmTemXTr2O?= =?us-ascii?Q?TVJnFpFKGlb56z6cbcp2hQQdrcb8NnkPC63IwvuomdG0r8KhA+2DjL7py+2H?= =?us-ascii?Q?RVwyLXVPz4cc1XdMluhxM58LR+E3eRpN2e6C6lcs+4OKPcMEejbAVb1Mmyh5?= =?us-ascii?Q?hxnDaYOM6ycurulas54tRvdnceUNLSx994DxXeofjYIqCoGtuXFoV4L/N10I?= =?us-ascii?Q?M4Mk061ViJBGRiYrQamURPYhPiko7/a1K4JD0WOmgyiZy/ew4VVisgK5DIhp?= =?us-ascii?Q?pxBIbpbF+IrsceCfb9rex1loYKO2tDONnsageW335zuHtKWXH3Suz5Kf8pmN?= =?us-ascii?Q?1tP6COf0kSxv+BefF2MzcsXQWeCJw9R6IS+z2WH/LzTXLKeJ4qb+RtI0oaSC?= =?us-ascii?Q?+PfQzwwPCZYX5umyjTJTOhqpswz9FY3E9FM8P2dZEcunZwG9aH65BvrbIXqf?= =?us-ascii?Q?9fhZ3ORAzRvRQsPPgME+2nEOLT+YkAC3i/ZXoZONKb9KKe2qgP0SkZ06GmQg?= =?us-ascii?Q?rM+aTU8qsQ+x5FCPKXwZrpu0sY1tKtQYAMetVzZLCpRI6iSczNszXvlkXzwO?= =?us-ascii?Q?G2p9KKbqNhEehjRnFSk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 576eb2a9-1d72-4b70-0dea-08dc3417d2a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 02:33:30.2478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S3fHgW0yBWmqVNsf2M+wdSQQXQeybXA76YN/U8RYK3Cjf8S4igwMzPbsg/3M5s1VbBngfgUG0AfThztsTWlFwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4867 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VjUbOlRTLEPLgbLUl9R4V9V5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CaJcqS+7; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > + ASSERT (FALSE); How about ASSERT (EFI_NOT_FOUND)? Which is more meaningful than FALSE. No matter you change or not, Reviewed-by: Ray Ni > + return 0; > } >=20 > /** > -- > 2.43.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115864): https://edk2.groups.io/g/devel/message/115864 Mute This Topic: https://groups.io/mt/104510913/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-