From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.1919.1678862134655526324 for ; Tue, 14 Mar 2023 23:35:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=m5RVmyRj; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678862134; x=1710398134; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=shNVF5u7SwJxrJUm2lHPI3SSUkTT+jg6dd2DsuOzHEI=; b=m5RVmyRjvmmjUU6ynHDFeTujGlB6EyPIB0sfp5g7Y/PuRo5qAu3a/l7U aggL0GElSm5ntxO0ReA0aiwHqmIu35b3d8fxYW1Z6v/vHuoc3I/toW7ku +sKPAzxxN+q402HMeis5lvAeXheyBZJApIk3M/r6Y1eYUVlbELpy1WNIf L4tSlLXlF2/noiQNGbM0rEFXUUNgwEcujCGtBmXmiLsCtxLFgyT1jDSd8 D/fHH2eNTQQA1xSjkfdHLJyAt5ADvo0levnP8gJlj3G8c/+HXyOGCoQ7W m3P7xfEi2WyK0tuKU4GjpXSBTJDvQc3yGQjzHHoXn6DFi3qDHx1WXIIoz A==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="317278934" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="317278934" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 23:35:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="681713588" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="681713588" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 14 Mar 2023 23:35:34 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 23:35:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 14 Mar 2023 23:35:33 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 14 Mar 2023 23:35:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m6Oi5YNoDQORWlCqmPjeytXjg1cCt70E3IIy49j0w9Yq3S1b8vlchIVAGIJZc6S5dDIvJoWw3bjxEVUNbvS6DKE0UiTJbGKIYs4jTUdafzC2Yji7dMbnFOp6TiGn5FXzwQKgWxENW2G1luJjH3/Bw/BywQQ3/qL1T92p2/IrY9LXT/gBsNG2JC5ao1OXe/q0S3iblM0rMUG0ZEbMeA0HWh8k61+k/iEcX1BZ2uhO7wWH349Ej93ZEpu+z/dG6S4jn0fy/Hf9NJ4BBuzBTdg5IQG959mQ0+bsY1G+QMDEZxSZsHxzBQuuaNRNm7hYK6roiB0f5yC1/E0uY9E49KTwFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D0A8oT7oQQNcQ17Nz2k26KKxLKDW+57JXd9vxaED1Hg=; b=S11+/7QL9/kaxeB9Y7x594lrR55n9XOQjaDO+oM7kFsn7P0XV4T2M7MGgYcDwjdvL6dgAxuS0kKkYGbeyB3GmwyS+qOvsI/eN8XwHmXb8QxcwH8Ydg4EqkTz87UHWiiOR0qh+LUDLpgx2ATvVZfb7cJEsbJdy58y6TTshQ54q3/IdtIPmLN6C5ZKpS00zXFXW6u5+NHMEHogViTy/CY5BFdjTIU/n4HjFNS7U2F1Gi8cPhR/drT3hPhlCNAMzFGuT/WYEi7+GT7EL5slaIPGo2k4p1vN+HQfR9Gcv/5+pMxhjO7h4EDKBr+62kHC+2tA4V7PQn4lbVhedJ+6aGS8eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SN7PR11MB7511.namprd11.prod.outlook.com (2603:10b6:806:347::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 06:35:32 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.024; Wed, 15 Mar 2023 06:35:31 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Liu, Zhiguang" , "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf Thread-Topic: [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf Thread-Index: AQHZUaYWyuhE+44R+UiTSwj8YzD+L677a5cw Date: Wed, 15 Mar 2023 06:35:31 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-14-dun.tan@intel.com> In-Reply-To: <20230308100758.669-14-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SN7PR11MB7511:EE_ x-ms-office365-filtering-correlation-id: 902cdecc-e4b6-44f9-372c-08db251f7975 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4/iZs/IBaXbeRrEUnP+r//z9DE1p6lMHuewXfF+0lF3j52Ws1SIS8EqjO7zCrxurL6HKco8woLwbch31Vics72zgzXTMB2NakYBmjR+6q/Po5OjpjNNfzKRWaEqHIXsjeh9KgoZ933SOg53mz5MvsD4ay7u2xIpLSNHkD3iI7t3XVc6EEMWPAgLEcCLck0pg7hSV95wwv3Uh3PH1LpjKZvlF6cCpQ48vzVL1O9t6VsWr2VMK96AxjCRChibol1rjg5HTUYjIOhdVhwgFHrCIrqxt544Zx5QaR8prUyGHrPfRi5y+go7t41KO9yduRMNwOdPsRx/W1L9QlWI/3gkK6UOjveMaqWizoV9GruFOfQO75sTOpFskPjc1/Zisn1A+SaXImFemlJnuIyRe7gLUd0WbuQgERLk8Zt4YtiMFik9rK0KbudX9kqjKmUvAMLyeOvKbkgHHCTm0LtaKDtIrefeCuFgXDQJKf27G9+2NshhpSHT40cSzW/4gDUEwhq9lVxmreIcT9skgwIylR72/JdFN1xAO+9h9b/1rF6QTqGL5C6QEs9PgeuAiPluPV0sMYqAH8SsWYFVvMqqBs0BVrHuNT8bfNIjgk7gtd3Bt5falgZldVQo/sPJRSDKgdB0qu+hntCSKsqs+nwCyUjJIAkZYnVRdwYpyC4XgpX2H9IAjrsel0W65HdTbRI6vVeDxNSjXF5EPT1fYaopVd4GScA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(396003)(366004)(346002)(136003)(451199018)(478600001)(186003)(107886003)(71200400001)(8676002)(6506007)(9686003)(54906003)(66946007)(76116006)(110136005)(316002)(7696005)(26005)(64756008)(66446008)(66476007)(66556008)(4326008)(41300700001)(52536014)(8936002)(4744005)(5660300002)(38100700002)(122000001)(82960400001)(2906002)(55016003)(86362001)(38070700005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eN7OojHwtnCi+Dz3NZaItraITSJLY+fJoT6iQD9F8zonNm91TseiuUPdgVGT?= =?us-ascii?Q?hzeSWN470jf2IL8OthyrJyUWN3odfRgIe6gGcBxE/X4BJeRIAKfwnBeCmQbT?= =?us-ascii?Q?YF2I+1ilhdgm3x8Yzmzz2IlSnyFW+XC6PYGS2PV5mIq1NzbrvQKyo0ly57YH?= =?us-ascii?Q?8V6CtKI/0R9Ra8wXn/Svptfhn3uGvPKC6JNxZ+RW+ZkhVaHrU3OqcLCRZF50?= =?us-ascii?Q?n0a1ogg0LhtH8LbaoJsgJ4kZ/SLpBnEHgGJHtdeHxEcHi+0zEutkTYpRt9CB?= =?us-ascii?Q?obNFBpavTq5nuOJVnB+HoMVu9gVpKC7E+XcqnSm4jy1xA2NJYXiBYuNYdj3O?= =?us-ascii?Q?GIMT2mN+oN9mqJ5O9H9tmKmCnoYQHZnNzWyp57yYsglL74+Qwm5Ql6PQtC3H?= =?us-ascii?Q?GoWBSHwFGOtLkqG4/rXHrihcUrE5vGBMN7bzzf1wxnPsqmV/nrpZCJoj3ueC?= =?us-ascii?Q?n6CeCiiPYLa+Ugnq7x+PPtqP8eWH0cP2u7CkxeiOOdA8GKh+oAQ4CZqmPn4W?= =?us-ascii?Q?fCzfyfN9egkamhKBBxu06Dcl0yLUjvH1LyiG9l0b6OjKm11CDEjymUNSqcqM?= =?us-ascii?Q?kq/g+izt8nqrN0qJfLj0srjNBcfrFIWNPP5J1jhGsPOdCpZ2FVd0zSDtHBa8?= =?us-ascii?Q?4nxpTLeBGKz4nf04QAngKLsaafcKit8TBe2IeFL45wHye9r0Kyyzotgjolsr?= =?us-ascii?Q?JHXG242or5+NJzQ+z8ptfAgzT2BxUH4casYIxmEPO1VdJ5PjAZbJDLdjD3Gg?= =?us-ascii?Q?4YUsP0lATOJls8bsIbujEGbopfG9afyon0IvUFZTuinFkZUXFKvCOIrx2wLu?= =?us-ascii?Q?44E8i1vJqWZK6iffKnQwZbF9b1B9DjFbVSS0mVMaw9/9AihGOfX3BERSpdn+?= =?us-ascii?Q?7IjIPb8qlJvjRGGBWRUyy1X9cy+V7MHYpGfsmewdTHIkLmnyQSi5VvF2CA0W?= =?us-ascii?Q?4UiTh3JSVW3q09vDee7lBrrNslndNTTqVMP/JuHLl5CXJbDFmwAjAJJCWUQp?= =?us-ascii?Q?c8881YyGz1oJ3rWb/+WT++cbclVH7CO38Gvm3eUJTw6ghhTDgKKRcgz/Q3aR?= =?us-ascii?Q?7Im3gomoJmqGp/5UVsw4JklmagHdyPPFQEAF7KUDGDrvN3jZ5zJUPS8D/bMg?= =?us-ascii?Q?cLdLCDsFutDuuh5CWHZCH9glphHP4EIVh8QfsjxIKw/5QUNwDEvY4jqnRTG1?= =?us-ascii?Q?Rhdli6XVYPiY2v6q6/S53yJz+9sd7OQQg/zQOFoPcofbk4lrb28KUbaUUnQq?= =?us-ascii?Q?NiXoH0nnkrYYgJP4QOB5yKwn4A/0ecpma0cVts6pvPyK7vB011Ok3PEsK/yT?= =?us-ascii?Q?OBxLaEsxnVHM1wS253vQTWcxUaX1QUVmGHcjiWTvvn/ZFlO5sN4yjnn9uc/T?= =?us-ascii?Q?qWE78Odu5GMPJu0prgDWy4zEWbsAhE81dhMQGH2jnXp814PQmihfWvixB2oa?= =?us-ascii?Q?rl2A8A1aX9MdPx0S/Kl/3x4uRh4Rg+wPmfLGLQFiGkPvNonDSNJGZDBQvvYS?= =?us-ascii?Q?BnFGXP4ADEvqryTSvcIr0/GinRGvtA1FvtKZxZ1luI8NtpJUJzNr5GfjnLI6?= =?us-ascii?Q?SkQV8dRdQewJUC1GmPw+KsrqfSYEz+9UL7y45R+w?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 902cdecc-e4b6-44f9-372c-08db251f7975 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 06:35:31.4839 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rEcvcOr/A//OkaJeJoI/RjpQTj4w1E+c39k41hqiaf/0UgCn5JO5+tiPEZfS7whUXEPWg/dK4JPdyB18n61StA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7511 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > + UINT32 PageTableBaseAddressLow : 19; // Page Table Base Address > High 1. Comments say "High". Should be "Low". > + >=20 > - MapMask.Bits.PageTableBaseAddress =3D 1; > - MapMask.Bits.Present =3D 1; > - MapMask.Bits.ReadWrite =3D 1; > + MapMask.Bits.PageTableBaseAddressLow =3D 1; > + MapMask.Bits.Present =3D 1; > + MapMask.Bits.ReadWrite =3D 1; 2. Can you please create a separate patch to initialize MapMask to 0? Missing the initialization doesn't cause functionality issue but looks conf= using. >=20 > PageTable =3D 0; > PageTableBufferSize =3D 0; > -- > 2.31.1.windows.1