From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 83307740035 for ; Mon, 5 Feb 2024 05:06:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NzCcPO0G4hjHcODpVUpbAUE/G3rJ/py9obLCpDC5/Ps=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707109569; v=1; b=HpG5fsNbzAq+nF9W0rlj+RcRAs3gFPJVxECOsiQjyhxKI+Md67921TlJ4zvRN9M8tRgEFKdc nzyMu+3vXxVHLl1syQQhsf27tVIrmcR5n9R+2TiRluo2zmzyNCqRp4Hs1NtIPYPMqPUM5DI6gnk kOUM14UpAp2irznNcU34Ir/A= X-Received: by 127.0.0.2 with SMTP id aE6dYY7687511xjrQYKNP2Ss; Sun, 04 Feb 2024 21:06:09 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.57024.1707109568275730078 for ; Sun, 04 Feb 2024 21:06:08 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="17867372" X-IronPort-AV: E=Sophos;i="6.05,242,1701158400"; d="scan'208";a="17867372" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2024 21:06:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10974"; a="909194880" X-IronPort-AV: E=Sophos;i="6.05,242,1701158400"; d="scan'208";a="909194880" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Feb 2024 21:06:06 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 4 Feb 2024 21:06:05 -0800 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 4 Feb 2024 21:06:05 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 4 Feb 2024 21:06:05 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 4 Feb 2024 21:06:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nz4JXXtaq9L875zqJ0GvrtDWkrTXIBF27CKp1z5t89TW+q4yjbIyLHTEZG8fu/sxwMgu4Z15svqvvzWh1aQ4qGTufa5wP+Lpw3oDB2I9J87mMGdMnBX5KTugk9zLKECL3EjHfV2ebDgYCg/0SlrgZB06DJ2HgeFW0UYZQXHwkSILsdjR2LZcbBmRq5je+I1wUWFmcGQcZcSP/ylKBUmK7dimCQ69N1v/L/51uw1SaMGXeCP+nddAbgwHxiRCkc8RQYn9h3hLADA2ALd6wEJLcg4PZMjWhe6X18bXm4ePaIDDRKYbt+Qx6JCe6hoT1SJBJNgDWNYwq8fpOoizpWZZ4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yry7eEa+yDe4+y4jNakudof+FJCstfotFAtaWO8mvuk=; b=kr/+dixH5X9dSqWWZ9YJl1pq3JgwkwcZSno263Rw91o0qMQRdB1+IHzb9AFNyQpMH5Qjh7goopWMH/pU9t+WKZAq5jJ7+zYWd33ftUynVTLgJlthl/fcTMHwSYHBfp1OT3YzWFXJrW4OqYwZJRwZShEyqbe35PC9PAoiOzSEuoeL0+YFMJUnElR7eVpTsP2i1PHuhkj/Bvo4O9D1lBNg0Ll89SgA6Zl5bi/5SUwGp11HjrngkPYBAG/tJgfmWATC63w+E1r+ABf3U66/eYehPHe19FeaAb2A/eMD06/+YCiJPx2kV4ZzNUGcj4h3fGy7CWTc7yKdyqSD3U8R4g4i8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SN7PR11MB7994.namprd11.prod.outlook.com (2603:10b6:806:2e6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.31; Mon, 5 Feb 2024 05:06:02 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f4e6:157c:2058:8b1d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f4e6:157c:2058:8b1d%4]) with mapi id 15.20.7249.032; Mon, 5 Feb 2024 05:06:01 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Dong, Eric" , "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex first before lock cmpxchg Thread-Topic: [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex first before lock cmpxchg Thread-Index: AQHaV0baDedcQ8Zr3kWv47Whp47uILD7MvYQ Date: Mon, 5 Feb 2024 05:06:01 +0000 Message-ID: References: <20240204084744.16464-1-jiaxin.wu@intel.com> <20240204084744.16464-3-jiaxin.wu@intel.com> In-Reply-To: <20240204084744.16464-3-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SN7PR11MB7994:EE_ x-ms-office365-filtering-correlation-id: 25e47810-327a-4a45-9fa0-08dc260825f9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: n4SCBg/ezsXs633NEUVBXp6gpOKTeZIaMtCU6sdVQy0YhikvecKEolw/Qwz3phNGdZj3sWaPrEncjCVqoNQ4L0HKgy8ImF8gKx9NEdPgFNc/CHRY9c7KT4OtkKEwwj35SVpi/gY2rrNUIfNvgvHBtwdLoDVp7kSavsvmj+o85fEbMX0XnnzwhZGWfbDgclgD21519BmV5d4AEtiUef+lgKPigDEhrDudr5rsmHy/SHuo/WGMoAPOzivgvzRfU2pAVJAx5GCFilPcolp1UU8sBIKFFFD4fsuAiGciRt8fLsQF92SnBVJMQTA17M0MNzPZDVcIOnaDijwZV9gTurNxaYX4gZ4VheTiJZl+Jus401PQUOr0jahUfLv//xsXWMlZy7qZ7TzvdABG/tDlT8B8nIbwky5VEHo7hsTX+eNDPa8i5wScxlDq/urz4DgoTwKvBHdqcvDhgzkYy7RXMrzmb+WkwdA5344Di+QhExyV9mKtd4RnXwkqpnQ5jTmQaMNVRAYq41FnS13TrlrBeczrbcvN5Ot0F0BmhqiZ9GAHBjiRsTy86l7TUsb2S19IVt48+rKDfPI0wuUJiinFZAu5PzxiKKNQCWrU8NC4RpVKfUUrgBVraAICQp+fv/0WIX5C x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s5PeNn3kYnhFR6ROBij7HQN4+a5bqE38etxBE9TaEQjsWBlaJeTiCz/nYMdm?= =?us-ascii?Q?J6qzH4WTTwI6hqGPq7QeUKiZTiOgvEvnWf2GuSdfsL8rk29vJ51vRM9fUI0b?= =?us-ascii?Q?qtSVjj3kzfWUktRunydG4YzjuVErFI4ECZYICi7CuaO82KDyzh8HITkgV7N1?= =?us-ascii?Q?VmgiiV4x9tnwmzMKkt+zdkob9um5g16OGZ/kITYXQ4yKliL2tha33QZHbwJf?= =?us-ascii?Q?JUOQbVQJBmg8ZYjIxLH16yEMEzOFE5UT5fiFAOO79//ILKIuZKfO3hD7Hs6O?= =?us-ascii?Q?cKtwpNm4FuAl/9Wao3dcLqOjyPB1pK7+MemUwY8V0OVQWJeVQF3vwrSwj/wP?= =?us-ascii?Q?NDV+aMyVyKFUz05QQvLKHvyd0P8brl8gKpBCQBtqkGnst9h/KP0PYJdtt5cu?= =?us-ascii?Q?dqkhDhs+4XojoBjStDq0X+8jHsuyGsgP8Mh3mAFQSH5EOJFmrK1wfvp9UnUm?= =?us-ascii?Q?NFdNdVkEqx8cZ35Ee/vUnlXfhAll73oQY+uqAzmth2BrtSBW7hzKwCK3/oCT?= =?us-ascii?Q?fJ1IdyCUDmuVFI8FPznqZRnN2R0HG8I8NooYAvL7Cdr6n2KUQgb8d/lShJjh?= =?us-ascii?Q?jm4NajN43PcI4uullEeuTU0LM67VIYkdgkUmJKGV9gq9Gpz+r8RCLb4T/RQ4?= =?us-ascii?Q?2o9h4RjWQSOFzThMW06XDUEvZn56Y+MCMLT5/Hz8RUITe5Bh1gVFr89R3QVQ?= =?us-ascii?Q?PZ8juI9HdxEOHmTyV2+fojkjofAajGVeooNG08nyxECEWlZg/RgMS7aDi5wD?= =?us-ascii?Q?FsV6eV8u8sNsqZpwlj2+45sttgB6ymm/hhtHusrLwljDoKWbAzFaphelPHgn?= =?us-ascii?Q?264T6WzaH7qdihzPqd2kAv0ugP+cTkfaZSWOoiLXE9OImG6cECj4LPqv+XnC?= =?us-ascii?Q?Qjm82bj1UH+VCuqfRtewWbBDvWdyvHbWFCv0S9/ZQxvxSoVNPqNoYxnMwAFQ?= =?us-ascii?Q?wI72f/ZXp3NhmpRMUuZwVoXdZyTRe1Q+RTrqdD9KjqdPIdnqB/5It/zgUs2a?= =?us-ascii?Q?gHrE58Pzp93VummMaB0mTumw661LG+QPdWcfA/ucDyqqB/TlgzOjduW6yg1e?= =?us-ascii?Q?L6Hfsbhjk0la3VYA+3TWy6AIZdao5Mh3ipmoGk/0JvVkrgV5budG16uIkkFJ?= =?us-ascii?Q?DeuUWu8QWF3fCJev6dhQ6z7vwEPpjPkNplYDA1RAnKTwIu4/csjBGeo9039W?= =?us-ascii?Q?/cH8a8IfeYGR3qdLpPaVXmlHnuYcjyd9sdT2akPbryNJ8vwY9m/Jef4jN9UF?= =?us-ascii?Q?RTlQhgzVd0yU57/A9mYy+/0/meVxlKUdajhGcRxnvfUrfNCkQjlSqUFT64g3?= =?us-ascii?Q?3FiCIckhDkuPvtUnQ/MWgZCNLjyECn/PiD0CJcVP6E6ukBFSRANw0CfhjWDY?= =?us-ascii?Q?IFHYJSWE+wOzS3nZ4thAav2VgHRmTTxysflwEsLsFp9qhUG4GioFQUhsfRiC?= =?us-ascii?Q?qZXplwhaWJTiaelMmKkVn0Wf+1oMgDQHNJyAz/zgPOINu5MTP3ngra4zN+7u?= =?us-ascii?Q?j0QwAYVh/TxFc2AFHS3sbwilf5bxh/fPQZsb71m6E8Ar/M0Ff8UIBH0Uut9P?= =?us-ascii?Q?qWZqje41TO0hBUgHgS4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25e47810-327a-4a45-9fa0-08dc260825f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2024 05:06:01.7871 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HKuU+wfPwmhj2rynYnkfuDdOyh58O2vmDpKaRjkMJs+T8Y5NMTq6Nf4NQlVNiHvnNEi9nJMYhjT3sfx7dsXc9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7994 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AiBh9Hgoj91uTYFrjic9rlXcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HpG5fsNb; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Jiaxin, Can you separate the changes in 2 patches? 1 is to change (UINT32)-1 to MAX_UINT32, the other is to add the test befor= e test-and-set. Thanks, Ray > -----Original Message----- > From: Wu, Jiaxin > Sent: Sunday, February 4, 2024 4:48 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Dong, > Eric ; Zeng, Star ; Gerd > Hoffmann ; Kumar, Rahul R ; > Kinney, Michael D > Subject: [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Check BspIndex > first before lock cmpxchg >=20 > This patch is to check BspIndex first before lock cmpxchg operation. > If BspIndex has not been set, then do the lock cmpxchg, otherwise, > the APs don't need to lock cmpxchg the BspIndex value since the BSP > election has been done. It's the optimization to lower the resource > contention caused by the atomic compare exchange operation, so as to > improve the SMI performance for BSP election. >=20 > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Eric Dong > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Kinney Michael D > Signed-off-by: Jiaxin Wu > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index e988ce0542..085aa91286 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1652,15 +1652,17 @@ SmiRendezvous ( > } > } else { > // > // Platform hook fails to determine, use default BSP electio= n > method > // > - InterlockedCompareExchange32 ( > - (UINT32 *)&mSmmMpSyncData->BspIndex, > - (UINT32)-1, > - (UINT32)CpuIndex > - ); > + if (mSmmMpSyncData->BspIndex =3D=3D MAX_UINT32) { > + InterlockedCompareExchange32 ( > + (UINT32 *)&mSmmMpSyncData->BspIndex, > + MAX_UINT32, > + (UINT32)CpuIndex > + ); > + } > } > } > } >=20 > // > -- > 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115094): https://edk2.groups.io/g/devel/message/115094 Mute This Topic: https://groups.io/mt/104153489/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-