From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 08B20740032 for ; Wed, 8 May 2024 03:25:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bnlkQZWJyuC9rwZ7A3GvIg2onnZ4z+IG+NLs7SugH2s=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715138743; v=1; b=RScX0w7Soqssfw08FHX/1ZMpix0usJO6WkdHQt2X4QyKo7y6GXNXTDnH23JA4jv6wTJbf90R lT03H8B9yTcqPHOkJcuhnWZIgTR5mAjJJeZjlXpkU0OE5BE4raeS1320xrT67iDKi+MB1/vQibY tRWDK223xz0U/QYWHROLp6MWCmCrXo8BfcGQ6inPqMcg+Z6FdCYckhQ1OcE9hbYoePPLHuQK5XM cu4DgSE0weNoXHvC66WirCDu1uP7YB4PzJHi7ajqZN+5mWh9sNQ6I0RWH+LzWWrZIPqSea4mdUc yZlIpcGybGuoj17OgTnal8qVqEQg2Q+C22SEmCsMi32Ug== X-Received: by 127.0.0.2 with SMTP id TcTnYY7687511x3Pd77RBG85; Tue, 07 May 2024 20:25:43 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mx.groups.io with SMTP id smtpd.web10.3882.1715138742496887529 for ; Tue, 07 May 2024 20:25:42 -0700 X-CSE-ConnectionGUID: Eu536tCsSVul21CZzr+31A== X-CSE-MsgGUID: WLGzj7w+Rq6bsC6PIOsRBA== X-IronPort-AV: E=McAfee;i="6600,9927,11066"; a="10842960" X-IronPort-AV: E=Sophos;i="6.08,144,1712646000"; d="scan'208,217";a="10842960" X-Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2024 20:25:42 -0700 X-CSE-ConnectionGUID: 955NuT4aS9ixHhUJ2M6nMg== X-CSE-MsgGUID: /yvvmLUESXOSNqQPwjJK6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,144,1712646000"; d="scan'208,217";a="33296785" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 May 2024 20:25:42 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 20:25:41 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 20:25:40 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 7 May 2024 20:25:40 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 7 May 2024 20:25:40 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW4PR11MB6740.namprd11.prod.outlook.com (2603:10b6:303:209::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.43; Wed, 8 May 2024 03:25:33 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.041; Wed, 8 May 2024 03:25:33 +0000 From: "Ni, Ray" To: "Hsueh, Hong-Chih (Neo)" , Laszlo Ersek , "devel@edk2.groups.io" CC: "Ding, Feng (Sunnyvale)" , "He, Jiangang" , "Chang, Abner" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Topic: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Thread-Index: AQHaZaxEF2YgSucvR06xUiEgwmbem7EbGkMAgGZxw4CAC5cEFA== Date: Wed, 8 May 2024 03:25:33 +0000 Message-ID: References: <3a640aa0f5555ccc327588ef7bb8d4ba5941442d.1708619173.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW4PR11MB6740:EE_ x-ms-office365-filtering-correlation-id: 5c26a673-1e17-4cf7-81b5-08dc6f0e8559 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?6fPjh8MBudD3ssjglsicPgtNYcRwOO4tuElyP3quiI2v0rdygV7FuNRif1LX?= =?us-ascii?Q?z86CJ15ITJgN4V85XqTr2H8kpyIFjMFtd8Xn1+tBg4rqVBOuuLUOSMkD7hIa?= =?us-ascii?Q?ooL4qr+VYwIWyv7uc+bGeNLA+R4cr7K9mjyHUcX7kJhWbTqt+1PZjspVLqvx?= =?us-ascii?Q?nPs7N2tbWOcuKFa30sko9MfZ7KhW4KfRe+olzbUVDQyIvMd3YLYXv0ImJPym?= =?us-ascii?Q?MmECiKufP3S8sKiJDV59Slnbf1LwIB4CW4/wTOQcxuwQbvN/RYt10TVVWka+?= =?us-ascii?Q?oEVIkhcI8J7wKSc1U0d9elScTy6/m03FiJuuTj1p5HngowNCgk7OsywjfTcr?= =?us-ascii?Q?NeJBzlxqj1Q0kpJ9G6wgkKQH5rEgHyBR0rQWTxkDcv0Lkw69RUjTNYf9qACu?= =?us-ascii?Q?2nQ0Ipf6MvOg1+J1MpFv61jDfWNFX+iHOQEdoYnQIs9SZ880cbJzjc67wFk3?= =?us-ascii?Q?7cs9VwTRjJGGFYw3Da1pRE+NAk0cPqY684r6Dmg8SlLkyZ5jzyUrrkVWS8jd?= =?us-ascii?Q?SbZrUFj4fmyXIImonrpvfviFWrXfh1YYmokPH3Aa0Jkj+cG5+6RQ8mW5gzf7?= =?us-ascii?Q?xNVeO8IkpIr+WOF4uLYn8DrX5NmSV7dqqS9aV2Cvw+hcdndDaT+PPkQcL/ky?= =?us-ascii?Q?XuC6S5Oy/XsYwbnqgfoezhs0DxU0zlUD2sJIGKDO6wlwaYDom949WdSFA8Cj?= =?us-ascii?Q?8oMOzx4ggzBk6sEsMsjkQUPVCOcBcxTwxMAmISYULhHtcSKl7ZjBBICaBMTN?= =?us-ascii?Q?Rr2WZ/EVZeK90Xm2XSSydCJqJH1INtxlLQwLLOQrP2QoAnyJzhPPmUYlgwEk?= =?us-ascii?Q?tC+mwe8dpmwBVyrrXMFlaLqL+d/1Uk9+UrQfd09en9/ecuh15fnuGV1rk9U9?= =?us-ascii?Q?2PUlL2vnpIL6BoDM9UYYPo1RNbxFQ+P91eGvlovEIwEtUzAnYv9BwDhbZBS8?= =?us-ascii?Q?+KM8N+eJ+tatp5xrn2wVYSkC1kKnHbVj6aJvcBIaRmPDgp+R1l5KzI05fl64?= =?us-ascii?Q?cc8hGx8y0EUEnAfH5Pgyd47Ph+dIfchAnaTO6iOwBi8fLqj04eaEM0G1jTk5?= =?us-ascii?Q?YYN3x7v2UpRlzvqBpGD3zscPtPFcBSJxgZDry9soC0og/N7qRQjsnB8PLdUW?= =?us-ascii?Q?MH5QfNkfcc4pnyqyAN72VBJUa/bAc4rPPNF8GhT1Vtx5FkPh6WTkO5DqI1xD?= =?us-ascii?Q?WNpYVr0yl3O8mLIbxtvporIY7RmkKLt+aP7i/1S3spXe8ev06IDXda4J9znO?= =?us-ascii?Q?W9c0Ic17raDWOwTC/hzoOz48Z3clcOyRBL463AbQOfDvyoQoTDqZidgdHWKx?= =?us-ascii?Q?IG3LHHPuKBWaZcjZTKdHvUIXd1ZMGTKydzlbdnO39NJNtA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ngbgLgzsa8sk5kXY3PsLD5Y4BjJgjv+Rgd+uzKXeCLfLAfMiYeSb5SDBjcO9?= =?us-ascii?Q?pE8NyWqfipEmXgiq3xELKQs2ALnXQZ3SrqjE1iRr6gfKJGw0U5s5biK783zc?= =?us-ascii?Q?y/WYE8ntOd+0vAk/OwEIln98OcvDBwf/54bS7F68GWASoJSczUubg69SQMbo?= =?us-ascii?Q?R8nZYSPoZTl2gfE4aFkMOg1QVHcGq4+L8kj8YUG+g2QggDdJr3+NeHbTm5ks?= =?us-ascii?Q?JijAblwVjUy4f5vkdHgHUFdue0C7LNPazAKOqmfmyoa/KdPWlYkLoi4twvRq?= =?us-ascii?Q?eYM+6f3iYcpT0B60rtq9bVXYwVZMvoH4XqBFaQh0do++hdkwhPBKg7BrMImA?= =?us-ascii?Q?sIQ/Fqvp3oCeKF8ZEI6avSfAdKEAmh6ClAd3yQWaZ5Ff1eeWLt4b6eLtbvyD?= =?us-ascii?Q?B13fDuIxzoPlDGLlZwe1nVDsJa8WTtGRGrUfH6UMlSM9cCDmz/bODlh3vCML?= =?us-ascii?Q?/2q+QJCyHbRiNQT1wTnLxlmFY/4rZK1px+SoFzYETbQHN+DuzMCGbm5HUH4z?= =?us-ascii?Q?16VjK1ATnS/vimGwhZHRke0UizYMgqIzGyorRgla0cpO5Dppv1LQJZgUu1h/?= =?us-ascii?Q?OXGbSIxrT3OFt8EASZINsn9XdGflXaEXlUgyjFVLcx3Qg7LsiOpC49GCwWFP?= =?us-ascii?Q?RCcHs6/Ch3qoGmNVzFiLJS9nDEk44QJkAXwowdBkHtFz0r4n8y2mqRtmIymA?= =?us-ascii?Q?kyHQXxHgy2HW4rE7UaJd2y5gT2B3S7/TwPMc8LvxPqkCiqUK1oR25gO+FXFk?= =?us-ascii?Q?gi4LOQegpYwH3poqu7mjfn6rgZofLoo7OTkUECpavk0w9ttPOb63OvByN/vA?= =?us-ascii?Q?O+MTk987cGGJekQpXrAHzfZmrgg2Fdg8z3j24ilfaPsn3zF/XItLj9mGD16i?= =?us-ascii?Q?nsrOonAtyD9mJQZrUHBEPrhj7AQJ3tp2zY9iWgVbfNXm/SLjUqwDdWLC5Yk4?= =?us-ascii?Q?8jCotPkzsRu2UUAmHjyL/5xSi2v2sY/9IU+N+iAZfeo9cJ0Bk9o0xoz8jNFF?= =?us-ascii?Q?ti8S+MGUiTVudQpLSna+kz0Whxc7CEkpBgVDkxEuqiTXN6R9EB9yHX+D7Woq?= =?us-ascii?Q?leNaw/rdra4jSxttJk9AYCi91N6QHB6mx/6unOTjObBQmBdu9VDFFhKr/cdO?= =?us-ascii?Q?1wrwMIeT+jwWEuydyKm0/XIhCi0nDBOayhsypocCz7APRDyvCBA+yUliuZl8?= =?us-ascii?Q?VqsyMPAh1h1Ak7m2cARnb4UxxllBzUe4rGsISH1ENh48thJo/15yXP79q/wq?= =?us-ascii?Q?U9Y6SlVXIcYWH+m9W7tdl0GjuiesrgLOtgQMizmTDv026uQTb+yC/SCQDaIg?= =?us-ascii?Q?layo3YdIEijDS1yTdbFlTx6BTN0qTGhKL/8wZ3RXwfRmB/ikGrLjFXxF5502?= =?us-ascii?Q?XbOj2AgKzZLzj+sRcC8PC6oEzi9TMocPpJ9gKg4EGYIxvKao4+ick0MyAolb?= =?us-ascii?Q?r6XWu0sS1JHKTfF6Me5O5VT/yHaaqlJbTaHzWuSbNmeQXnGFAgK/5DikFGsz?= =?us-ascii?Q?cWVm4taTzJofwSUjV3rO9ldsJRnWapUzKvFV0y1eCUMZh2X9XIIgpk0y89xn?= =?us-ascii?Q?VECsuAoNGoyuM0m265M=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c26a673-1e17-4cf7-81b5-08dc6f0e8559 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2024 03:25:33.6721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ea7gHNQZPuWDjXbTFYUn13yfVwiXB48nkAGMtzi0Cabrpc/tNh46jJqiexe/mi4yQuPqQQWUjpG+lKvexkpqww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6740 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 07 May 2024 20:25:42 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KPMWTN6OyWbbmnbKASIqRHxDx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB82444B9A6F7FB3AFC9C8E6A08CE52MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=RScX0w7S; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB82444B9A6F7FB3AFC9C8E6A08CE52MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Neo, I don't think your change is needed because of the following existing logic= where RemoveAllPciDeviceOnBridge() is called to destroy/free all PCI nodes= . if (Operation =3D=3D EfiPciHotplugRequestRemove) { if (*NumberOfChildren =3D=3D 0) { // // Remove all devices on the bridge // RemoveAllPciDeviceOnBridge (RootBridgeHandle, Bridge); return EFI_SUCCESS; } Thanks, Ray ________________________________ From: Hsueh, Hong-Chih (Neo) Sent: Wednesday, May 1, 2024 2:24 To: Laszlo Ersek ; devel@edk2.groups.io ; Ni, Ray Cc: Ding, Feng (Sunnyvale) ; He, Jiangang ; Chang, Abner ; gaoliming@byosoft.com.cn Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug [AMD Official Use Only - General] Hi @ray.ni@intel.com, Sorry you bother you, may I have your feedback for this patch? If it looks good to you could you help to give me an R-b ? Thank you. Regards, Neo ________________________________ From: Laszlo Ersek Sent: Sunday, February 25, 2024 7:59 AM To: Hsueh, Hong-Chih (Neo) ; devel@edk2.groups.io = Cc: Ding, Feng (Sunnyvale) ; He, Jiangang ; Chang, Abner ; ray.ni@intel.com ; gaoliming@byosoft.com.cn Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak = upon bridge hot-unplug Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. On 2/22/24 17:28, Neo Hsueh wrote: > A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The action= s require PciHotPlugRequestNotify to add a root bridge or remove a root bri= dge completely. > In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return wit= h no-action on second plug because bridge tree shows configured. > Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug ev= ent to fix this issue. > > Cc: Feng Ding > Cc: Jiangang He > Signed-off-by: Neo Hsueh > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModulePk= g/Bus/Pci/PciBusDxe/PciEnumerator.c > index 3f8c6e6da7..2b7af60e0a 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c > @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify ( > } > } > > + DestroyPciDeviceTree (Bridge); > + > // > // End for > // This looks convincing to me, but I don't now nearly enough about PciBusDxe internals (resource management in particular) to confidently approve this patch. I can give an Acked-by: Laszlo Ersek but the patch should not be merged until Ray provides an R-b. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118656): https://edk2.groups.io/g/devel/message/118656 Mute This Topic: https://groups.io/mt/104511503/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB82444B9A6F7FB3AFC9C8E6A08CE52MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Neo,
I don't think your change is needed because of the following existing logic= where RemoveAllPciDeviceOnBridge() is called to destroy/free all PCI nodes= .

  if (Operation =3D=3D EfiPciHotplugRequestRemove) {
    if (*NumberOfChildren =3D=3D 0) {
      //
      // Remove all devices on the bridge
      //
      RemoveAllPciDeviceOnBridge (RootBridgeHandle, Bridge);=
      return EFI_SUCCESS;
    }


Thanks,
Ray
From: Hsueh, Hong-Chih (Neo= ) <Hong-Chih.Hsueh@amd.com>
Sent: Wednesday, May 1, 2024 2:24
To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io <= ;devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jiangang = <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>; gaol= iming@byosoft.com.cn <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarch= y leak upon bridge hot-unplug
 

[AMD Official Use Only - General]


Hi @ray.ni@intel.com,

Sorry you bother you, may I have your feedback for this patch?
If it looks good to you could you help to give me an R-b ?

Thank you.

Regards,
Neo

From: Laszlo Erse= k <lersek@redhat.com>
Sent: Sunday, February 25, 2024 7:59 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; dev= el@edk2.groups.io <devel@edk2.groups.io>
Cc: Ding, Feng (Sunnyvale) <feng1.ding@amd.com>; He, Jian= gang <Jiangang.He@amd.com>; Chang, Abner <Abner.Chang@amd.com>;= ray.ni@intel.com <ray.ni@intel.com>; gaoliming@byosoft.com.cn <ga= oliming@byosoft.com.cn>
Subject: Re: [PATCH v2] MdeModulePkg/PciBusDxe: plug device hie= rarchy leak upon bridge hot-unplug
 
Caution: This message originated from an Exte= rnal Source. Use proper caution when opening attachments, clicking links, o= r responding.


On 2/22/24 17:28, Neo Hsueh wrote:
> A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The act= ions require PciHotPlugRequestNotify to add a root bridge or remove a root = bridge completely.
> In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return = with no-action on second plug because bridge tree shows configured.
> Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug= event to fix this issue.
>
> Cc: Feng Ding <feng1.ding@amd.com>
> Cc: Jiangang He <jiangang.he@amd.com>
> Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModul= ePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> index 3f8c6e6da7..2b7af60e0a 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c
> @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify (
>        }
>      }
>
> +    DestroyPciDeviceTree (Bridge);
> +
>      //
>      // End for
>      //

This looks convincing to me, but I don't now nearly enough about
PciBusDxe internals (resource management in particular) to confidently
approve this patch. I can give an

Acked-by: Laszlo Ersek <lersek@redhat.com>

but the patch should not be merged until Ray provides an R-b.

Laszlo

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118656) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB82444B9A6F7FB3AFC9C8E6A08CE52MN6PR11MB8244namp_--