From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 82272AC09D7 for ; Fri, 22 Dec 2023 03:30:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qQmdwFoUFjEroE8Tq7vh2xJkYHKrhRq0OSjTMApToLQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703215845; v=1; b=KIncorUxSlhCEt6LAgk+ctVQ9EcvvvcH0u2Kd/B2GUbxsrouuKYl6wbpS379ZuRENGj3dM1X 5X7S0KSl05Dr72VaJc3N8qiTI5fci1A49R4JG7FdgTLuLMYyV/Dw7Z17wTvDUTfHNTP32QOIlgh LB0OGynRi4bqpo37gMqPDTxw= X-Received: by 127.0.0.2 with SMTP id CYqdYY7687511x9LRqVTzukc; Thu, 21 Dec 2023 19:30:45 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web10.12168.1703215844163113201 for ; Thu, 21 Dec 2023 19:30:44 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="3318349" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="3318349" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 19:29:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10931"; a="842826378" X-IronPort-AV: E=Sophos;i="6.04,294,1695711600"; d="scan'208";a="842826378" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Dec 2023 19:29:03 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Dec 2023 19:29:02 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Dec 2023 19:29:02 -0800 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Dec 2023 19:29:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L4rQDgRonhFhePw4MxI2GTBPzHekZyUUHi+QmlAmVRLN2pdQPSXTGOM9GJi3Zb6FisJPQFSCmL9Ai8HSKLA2B2yT1xX0tEz9Mm/VZI60X+OwmLddoTiRIAs7lMeNaEdS2wvx/ZinQLVemh1HCABG6Qe4nfn/DFTIHdeZYXsA8lZnJhjb3YEexTzak+jCtbk8dgoUkP2LfedsrhEJHoQlnI+FXafzWh5/p/6TG19OagVtwC8iXDrlScd0p7rsfO2zS6IGsBdjITkLeHI4CUEdOe6c5wrqcZTtiR25ZvLKC6Ceqcoay2mS2OPS7IKWOULg+v6HfEUfmLiS1TmhiFmvQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dxLBAiH0i2sMh3KTOt9BbIEUK824jpT3+JIIJi/x0sE=; b=lTyyZdHewXGxfTVyU/qcxoqmO4/pP2rGmJG+hqsa69v/MGA3Y01jannOG2JQ26IMIWxqWJG9rJiSo3YBEQpQqhjfJbbwpXIVd8Ce9uJpA8MSm+6neRnshid9nEGoRpPTzKrXp47I8gK8HceWBlz/xE9exLOBHobiPj2wACN22M16yEZw8h2cCsb+kzWrwJrD3F8T3E7xSxoCVK9Dar7H/JdrnpnnOGYq0XyEHeSPRJs6IH3OBfYCgkssqtLimpGVK86rqqBmzK9Zzt3PBH2FjC9hR/Fxjk8hN1soTTQqM5olkAtv71I0TNJ+Dr8Iz27pTik+i1CUlD3hzEFg544G1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SN7PR11MB8112.namprd11.prod.outlook.com (2603:10b6:806:2ea::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 03:28:59 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 03:28:59 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" CC: Andrew Fish , "Kinney, Michael D" , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime() Thread-Topic: [edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime() Thread-Index: AQHZ8yIEllxd8PD1RkuhgWcmk7rwXrC1J3qw Date: Fri, 22 Dec 2023 03:28:59 +0000 Message-ID: References: <17897E3A091481E6.9230@groups.io> In-Reply-To: <17897E3A091481E6.9230@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SN7PR11MB8112:EE_ x-ms-office365-filtering-correlation-id: 6ea0248d-6564-419f-9acc-08dc029e22e7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kMukOJ+kVlIUdK735cUH9rRoyTewxnqCDpkAKwMu20mUbZEim5p5STGwj+lOkE69GFGxar+KKDWm/Z6d8eEUVZ2dXsr75v1TPmw8UHEM1oC3VbFGYR+s3ILHPERkTMl+j/zTDFjPgsCz/w/73XcxLzkv++ooT6hi3RO9XoTj5aadxWoAsasQLMD6kIc4FqOqTU9xYRhNXrQ97KTBVXBykM6DCeIq2JgZSCTE1x87SAdEoa/g0iGjCX0/wHnsLnHXl6c87/pz66sduSdnnoh2aadX9Ot5PfXCqlg5uIUMstISkROxdmMu5KpKPmagPQz5TIItcQVeJpAXt/cMkiqohC9e/SSPkhaW+HwJeEHklQ2BKSphh1kG1pJ5wis3abNuTrg5UUgQlBwhltV/9l2vfsa2tV++dwJEgpt7QlKRUywlCiveFU34GC5ytjwz27iANGxhFzlGS79G1VDDtt8Ywm5RSFiyEQOJslCI1PIQjVDbRmgYWLfesrsPGUCDb3aDqegUYMiZHszzYG8RwjWbbe/kqbZas6L1n2e7EvilStSESjZuWxp5lCZ3imtgi/rAdysIPF5zFcv7+UKHi2jkvnzacJzcaNOF9P35+0xpTaA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+BB7KFFybXqJzkyMkX3CCF40BX5mmhDQ4yGWe5UW54wu9+jDhWRPLbIGUfFJ?= =?us-ascii?Q?xKA5Ef4Nbp//GdYEwEkiPertKTPzpMb7poX02FZIo5eAaaYuO9b36b4EZL09?= =?us-ascii?Q?Gmf92hW1Eth6ZwHdddXmCSCL856f4bUZ6zA1FLLGKxfEKjqStlOl2jGy97bU?= =?us-ascii?Q?KL223+tCUyyeYP53jR1cpIzXu8qsZF4UXkSc6RDFqLktCq6+Qn6SD2auTGLe?= =?us-ascii?Q?il1FS8roIS3neQoElaX1YjdOPDHoLmP42v041E+jzOG7o5MqHSmPRoPxAB0g?= =?us-ascii?Q?uobCboL5ElpwXy+/KZ1g1W6yvHbD/pOMpeiaYCRtxKkqZeI/pAPrWr+diAqZ?= =?us-ascii?Q?tqlQ5fULRn/uoYZpoks8kkb95FVyFBIwq5OtM5Ty7toOvRq5PBJC57evhYkH?= =?us-ascii?Q?1aLrQQBtYnEigG4KVRseZiHNL9oUVZxwzs8NjeSB1hfkq7qa4P/KRu8nnm6c?= =?us-ascii?Q?bVZSBlZOLQosxPfzmNxCb6gHo3iDGpYHU21RSyfRwx+OjpsWmVxRVBfFxCKi?= =?us-ascii?Q?UHSp8ZwWkmlEyb+aEOuXJXLiJEgibQIGGKSRP11nhs9W5ivLkkI3eb1sWLKF?= =?us-ascii?Q?aba1iNh81chIcf1JO3BbU11dAQWK2wFDOA3NsMOdDnc59GRx2qNIeeu1aRyG?= =?us-ascii?Q?1tfmyZGW/UCXaPctcwHRc7emzA3wDV6JA6WLzE7pZVPcit/o8masKpIRRGRu?= =?us-ascii?Q?ueUjH/DlLUfzQetazQ1y8Bju798ZtYbVDT1ubRf59DV/MTLcMWMWh4FKJOg0?= =?us-ascii?Q?I2SG/nS3N9P7LdLXEXqr3QX/hw6rK80g7LA+0mERktcB8Q+dkGmybb23tHXo?= =?us-ascii?Q?Xt/KUH1C9JOHgW3HStxHApOWwEetZ2KEY2Av5lOv2SOeG2js2gbmsuHw586W?= =?us-ascii?Q?YO/CVk/AY3Dxgp6s6w9/2gYjwrLOTKREkuMsTzNfLShC35Sx7CfbOFxi2QJI?= =?us-ascii?Q?9fUFEdLTM0NqUZ37ZGweMpNo/Ba9Pm4Fkna5/Gpe1gxXOJFNK9an/b70mn06?= =?us-ascii?Q?ilx+ldK8N18mI7DfZLN1SsB7K7Wq5ravGdD3HwCjBTNoErCJrZD5LZrUtgak?= =?us-ascii?Q?JvdfKagOi/x8MOAhlUxN6tT0dJITgPrxxdPoR/vkriqy0b18NsW7ALQQ4kVZ?= =?us-ascii?Q?XNk9dBnoPisfM3yNbel6NR0Jq7tWHytsp4XM+iO5TxByH0u9g+VFVbgRDfsU?= =?us-ascii?Q?f3CEVvwUjNeAC5wW+BWgHSji1SxmcMZMW52FU6xssKFmFB+LAAAQ8umHmuFz?= =?us-ascii?Q?oCeSY/fMqeK6RfiD6ah1P2LVjA106nBGBPn39Ehgq1wDCTHnpO3kwWGAsMlp?= =?us-ascii?Q?/yXSTdMMLY8ku4Fh/etcelIZ5HR/kt2MrAFfQ/h902VIYb4fc4fPozB1aQpB?= =?us-ascii?Q?8J275qzp2Ul8n32uCB7ngvp0rWsajWAKFNOK4e2WvAaAtHLbHtyeWzIuwVGp?= =?us-ascii?Q?z8AdsLUUNyqhPcycXIRjuk11NUtg+dcGvlmwFEfiGWWBb0fRX3W2grERzyue?= =?us-ascii?Q?+unkotFhdofZEDLrrtMOcjwEia36drIXMPt/fZ7jFsosvEIYIJHHP8qjiqRn?= =?us-ascii?Q?4HAF4ETCLwf3SpwlLmk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ea0248d-6564-419f-9acc-08dc029e22e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 03:28:59.3280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6aKQ8OyY9LP7VN9qWQJgp0ZsLrbrDnPeaKflDbIGoe6jNbTjFhuWRm7QJFdHJtFrD+dm2+IQ+Bh+7j51AsvCtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8112 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: DisM8JyfiIY63zTjW2muWkTCx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KIncorUx; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Desimone, Nathaniel L > Sent: Saturday, September 30, 2023 6:12 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray ; Kinney, > Michael D ; Chiu, Chasel > > Subject: [edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to > EMU_THUNK_PROTOCOL.SetTime() >=20 > There is an inconsistency between the UNIX and Windows > implementations of EMU_THUNK_PROTOCOL.SetTime(). The Windows > version returns an EFI_STATUS value whereas the the UNIX > implementation is VOID. However, the UNIX implementation is an > unimplemented stub whereas the Windows version is implementated. >=20 > The current EMU_THUNK_PROTOCOL function pointer definition > specifies a VOID return type. However, EMU_THUNK_PROTOCOL.SetTime() > is close to the spec defined gRT->SetTime() except for missing the > EFI_STATUS return type. >=20 > Therefore, I conclude that the most sensible reconciliation is to > add the EFI_STATUS return type to the protocol definition. >=20 > Cc: Andrew Fish > Cc: Ray Ni > Cc: Michael D Kinney > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > EmulatorPkg/Include/Protocol/EmuThunk.h | 5 +++-- > EmulatorPkg/Unix/Host/EmuThunk.c | 4 ++-- > 2 files changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/EmulatorPkg/Include/Protocol/EmuThunk.h > b/EmulatorPkg/Include/Protocol/EmuThunk.h > index c419d0a677..bdd57f410b 100644 > --- a/EmulatorPkg/Include/Protocol/EmuThunk.h > +++ b/EmulatorPkg/Include/Protocol/EmuThunk.h > @@ -2,6 +2,7 @@ > Emulator Thunk to abstract OS services from pure EFI code >=20 > Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.
> + Copyright (c) 2023, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -148,12 +149,12 @@ VOID > typedef > VOID > (EFIAPI *EMU_GET_TIME)( > - OUT EFI_TIME *Time, > + OUT EFI_TIME *Time, > OUT EFI_TIME_CAPABILITIES *Capabilities OPTIONAL > ); >=20 > typedef > -VOID > +EFI_STATUS > (EFIAPI *EMU_SET_TIME)( > IN EFI_TIME *Time > ); > diff --git a/EmulatorPkg/Unix/Host/EmuThunk.c > b/EmulatorPkg/Unix/Host/EmuThunk.c > index ee0843eebf..c57c105a53 100644 > --- a/EmulatorPkg/Unix/Host/EmuThunk.c > +++ b/EmulatorPkg/Unix/Host/EmuThunk.c > @@ -387,14 +387,14 @@ SecGetTime ( > } > } >=20 > -VOID > +EFI_STATUS > SecSetTime ( > IN EFI_TIME *Time > ) > { > // Don't change the time on the system > // We could save delta to localtime() and have SecGetTime adjust retur= n > values? > - return; > + return EFI_UNSUPPORTED; > } >=20 > EFI_STATUS > -- > 2.39.2.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112829): https://edk2.groups.io/g/devel/message/112829 Mute This Topic: https://groups.io/mt/103312902/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-