From: "Ni, Ray" <ray.ni@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
"kraxel@redhat.com" <kraxel@redhat.com>
Cc: "Johnson, Brian" <brian.johnson@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Laszlo Ersek <lersek@redhat.com>,
"Dong, Eric" <eric.dong@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Zimmer, Vincent" <vincent.zimmer@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data
Date: Fri, 3 Feb 2023 13:31:17 +0000 [thread overview]
Message-ID: <MN6PR11MB82444E5CD75BF2D7EBBA53AB8CD79@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN0PR11MB6158E342A229DB08D18974BAFED79@MN0PR11MB6158.namprd11.prod.outlook.com>
I think we need to define a new chunk hob type for solution proposed by Gerd.
I will leave that to PIWG (PI spec working group) for discussion.
In this topic, I prefer to solve the problem in the CPU domain.
> -----Original Message-----
> From: Wu, Jiaxin <jiaxin.wu@intel.com>
> Sent: Friday, February 3, 2023 9:23 PM
> To: kraxel@redhat.com; Ni, Ray <ray.ni@intel.com>
> Cc: Johnson, Brian <brian.johnson@hpe.com>; devel@edk2.groups.io; Laszlo
> Ersek <lersek@redhat.com>; Dong, Eric <eric.dong@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Zimmer, Vincent
> <vincent.zimmer@intel.com>
> Subject: RE: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM
> Base HOB Data
>
> Hi Gerd,
>
> Is it still the solution with multiple hobs created for big data but you want the
> hob splitting and reassembling can be encapsulated in the Hoblib?
>
> Does it need define the new hob type for chunk?
>
> Thanks,
> Jiaxin
>
> > -----Original Message-----
> > From: kraxel@redhat.com <kraxel@redhat.com>
> > Sent: Friday, February 3, 2023 3:55 PM
> > To: Ni, Ray <ray.ni@intel.com>
> > Cc: Johnson, Brian <brian.johnson@hpe.com>; devel@edk2.groups.io; Laszlo
> > Ersek <lersek@redhat.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Dong, Eric
> > <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>; Kumar, Rahul R
> > <rahul.r.kumar@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Zimmer, Vincent <vincent.zimmer@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add
> > SMM Base HOB Data
> >
> > On Fri, Feb 03, 2023 at 03:14:42AM +0000, Ni, Ray wrote:
> > > Gerd,
> > > Can you please explain a bit more on the chunk idea?
> >
> > > > > to introduce a generic and reusable concept of chunked HOBs, so you
> can
> > > > > add helper functions to HobLib for splitting and reassembling, with a
> > > > > struct along the lines of:
> > > > >
> > > > > typedef struct {
> > > > > // offset and size of this particular chunk
> > > > > UINT32 ChunkOffset;
> > > > > UINT32 ChunkSize;
> > > > >
> > > > > // number of chunks and size of all chunks combined.
> > > > > UINT32 ChunkCount;
> > > > > UINT32 TotalSize;
> > > > >
> > > > > // chunk data
> > > > > UINT8 Data[0];
> > > > > } EFI_HOB_CHUNK;
> >
> > Reassembling would work like this:
> >
> > // once
> > AssembledHob = malloc(HobChunk->TotalSize);
> >
> > // for each chunk
> > memcpy(AssembledHob + HobChunk->ChunkOffset, HobChunk->Data,
> > HobChunk->ChunkSize);
> >
> > Possible shortcut:
> >
> > if (HobChunk->ChunkSize == HobChunk->TotalSize)
> > // data is not splitted into multiple chunks
> > AssembledHob = HobChunk->Data
> >
> > Advantage: you avoid the allocation in case the data fits into a single
> > HOB. Disadvantage: you need to track whenever AssembledHob is allocated
> > (and must eventually be freed) or not.
> >
> > HobChunk->ChunkCount is not really needed but might be useful for sanity
> > checking.
> >
> > take care,
> > Gerd
next prev parent reply other threads:[~2023-02-03 13:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 9:56 [PATCH v3 0/5] Simplify SMM Relocation Process Wu, Jiaxin
2023-01-18 9:56 ` [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Wu, Jiaxin
2023-01-18 11:19 ` Gerd Hoffmann
2023-01-18 15:06 ` Ni, Ray
2023-01-19 7:13 ` Gerd Hoffmann
2023-01-29 5:08 ` Wu, Jiaxin
2023-02-01 13:02 ` Gerd Hoffmann
2023-01-20 8:21 ` Laszlo Ersek
2023-01-29 5:24 ` Wu, Jiaxin
2023-02-01 13:14 ` Gerd Hoffmann
2023-02-02 0:44 ` Wu, Jiaxin
2023-02-02 3:54 ` [edk2-devel] " Ni, Ray
2023-02-02 3:52 ` Ni, Ray
2023-02-02 12:51 ` Gerd Hoffmann
2023-02-02 22:29 ` [edk2-devel] " Brian J. Johnson
2023-02-03 3:14 ` Ni, Ray
2023-02-03 7:54 ` Gerd Hoffmann
2023-02-03 13:22 ` Wu, Jiaxin
2023-02-03 13:31 ` Ni, Ray [this message]
2023-02-03 15:00 ` Gerd Hoffmann
2023-01-18 9:56 ` [PATCH v3 2/5] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Wu, Jiaxin
2023-01-18 9:56 ` [PATCH v3 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Wu, Jiaxin
2023-01-18 12:02 ` Gerd Hoffmann
2023-01-29 6:14 ` [edk2-devel] " Wu, Jiaxin
2023-01-18 9:56 ` [PATCH v3 4/5] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Wu, Jiaxin
2023-01-18 9:56 ` [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: " Wu, Jiaxin
2023-01-18 12:19 ` Gerd Hoffmann
2023-01-18 14:37 ` Ni, Ray
2023-01-19 7:53 ` Gerd Hoffmann
2023-01-29 5:47 ` Wu, Jiaxin
2023-02-01 13:40 ` Gerd Hoffmann
2023-02-02 1:41 ` Wu, Jiaxin
2023-02-02 9:00 ` Gerd Hoffmann
2023-02-02 11:47 ` Laszlo Ersek
2023-02-02 12:24 ` Gerd Hoffmann
2023-02-03 3:05 ` Wu, Jiaxin
2023-02-03 2:47 ` Wu, Jiaxin
2023-02-03 3:45 ` Ni, Ray
2023-02-03 7:31 ` Gerd Hoffmann
2023-02-03 7:43 ` Ni, Ray
2023-02-03 8:49 ` Gerd Hoffmann
2023-02-03 11:18 ` Wu, Jiaxin
[not found] ` <173B5EAF72B992BD.14781@groups.io>
2023-02-03 8:59 ` [edk2-devel] " Wu, Jiaxin
2023-02-03 9:04 ` Gerd Hoffmann
2023-02-03 11:15 ` Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB82444E5CD75BF2D7EBBA53AB8CD79@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox