Re: [edk2-devel] [PATCH v8 12/37] UefiCpuPkg: Add CPU exception library for LoongArch

["Ni, Ray" <ray.ni@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

The change can be either a separate patch, or be included in another patch that uses the PCD.

Thanks,
Ray
From: Chao Li <lichao@loongson.cn>
Sent: Friday, February 2, 2024 11:44 AM
To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Baoqi Zhang <zhangbaoqi@loongson.cn>
Subject: Re: [edk2-devel] [PATCH v8 12/37] UefiCpuPkg: Add CPU exception library for LoongArch


Hi Ray,

Thanks,
Chao
On 2024/2/2 11:30, Ni, Ray wrote:



1. Most of INF changes are not necessary for x86. Can you avoid them?
I just sorted them alphabetically, do you think it is unnecessary? If so, I will remove the changes in other patches in next time.






+  ## This PCD Contains the pointer to a CPU exception vector base address.

+  # @Prompt The pointer to a CPU exception vector base address.

+

gUefiCpuPkgTokenSpaceGuid.PcdCpuExceptionVectorBaseAddress|0x0|UINT

64|0x60000022

+



2. I do not see any reference to the above PCD in source/INF files.

Any mistake here?
This PCD is used in CpuDxe and MmuLib, among others. Do you think this change should be made as a separate patch?















-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115016): https://edk2.groups.io/g/devel/message/115016
Mute This Topic: https://groups.io/mt/103971651/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5822 bytes --]