From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id BF93678003C for ; Mon, 13 May 2024 02:16:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=n5/9mzUA1ZXSyBkon7kg+IghUu8vUSmU52qFweXtWVA=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715566592; v=1; b=A+2/wFMM8V2jaKkGIIW1CkCJA1RZGNQ6WeC90vTC4f4CpEIYrfMyXrQIGUfK35ngcw6D3Ta9 TPE2wK/zfrliv/04dwGDvtZ+gq5beFRtCPpS4QgPD2etdW0TXs9bURuzRiZkSY21xnlhk2SQgXa +9W+UJb5u3Wk4TTbyE9XbWEBW50F+oS276+O05gkmGnmw7EzIMCHdsc+lzDJBNuLrlONX9+XYIs fWfA/G/sTaQIMPc82bZDP4p/OpToPSXtpJ0gV2N73uCW/sYWQ6arZk0U53BF703iVE48UhueYYU NkmFZlFAD/w9gD8EUopvNFHhhG+ph/AWo/w2lh5J50UzA== X-Received: by 127.0.0.2 with SMTP id 18kMYY7687511xxdw0paUiyu; Sun, 12 May 2024 19:16:32 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web11.51175.1715566591645200985 for ; Sun, 12 May 2024 19:16:31 -0700 X-CSE-ConnectionGUID: S3MfggmoTnWx/EuHqIh9/w== X-CSE-MsgGUID: 9dOO5CpmQmW92Cst5waTjA== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="36861284" X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="36861284" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2024 19:16:31 -0700 X-CSE-ConnectionGUID: t/6W4AKWSOqThBFlZQFbfg== X-CSE-MsgGUID: FXibjSMGTzawIYr0/0THRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="30221641" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 May 2024 19:16:31 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:16:30 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:16:30 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 12 May 2024 19:16:30 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 12 May 2024 19:16:30 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7927.namprd11.prod.outlook.com (2603:10b6:8:fd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 02:16:28 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.052; Mon, 13 May 2024 02:16:27 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH 09/18] UefiCpuPkg:Move some code in DxeMpLib to common place Thread-Topic: [PATCH 09/18] UefiCpuPkg:Move some code in DxeMpLib to common place Thread-Index: AQHaosIgLdyiJTChREy5dKREdxVNGrGUcQ1C Date: Mon, 13 May 2024 02:16:27 +0000 Message-ID: References: <20240510100827.1903-1-dun.tan@intel.com> <20240510100827.1903-10-dun.tan@intel.com> In-Reply-To: <20240510100827.1903-10-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7927:EE_ x-ms-office365-filtering-correlation-id: 42764a72-1be0-425f-945a-08dc72f2b255 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?hC1BVX+7q02CuC4Z2qGY5iDvMpfnwManTrhnSjB338WT4ACjxVWbJI4MVW?= =?iso-8859-1?Q?TsdDoyZNksOeYtwkvi8EgncGg0CAnustcjVXP290VWkX3GUdsnq7xKEsBL?= =?iso-8859-1?Q?7GNoZzZUsUlFts8F7q63Efu4xyLBNxMzfAPzRkXzcPQDVvaU9J1v+iytx0?= =?iso-8859-1?Q?gEO9CLvK9oFCquMhLMd0/BYMEu2Yz/EP1vBXiIG/NrIfUQYh+NJk4cFu4e?= =?iso-8859-1?Q?TUbXyXBIXS30zuJ2jMV3MqTWqdUCG4g8uJ1t/QaIWkEA+m6wBhqgH8VzfF?= =?iso-8859-1?Q?krt/wSOpw5oif9UtvS8Dugn4Izv4eNwoRrdSmdVTuv7sTzUSztJSeywUWU?= =?iso-8859-1?Q?r321rIg5NPCe3jd6+Vf9MoxJo9858Qum9PsbcfzCMAifuiFqXdE6/8XM1T?= =?iso-8859-1?Q?xM4jKXHmgXMNmW986snkdhdzK0pHk2QFHdDalEIO1e8S0RgVItgyfV6g5Y?= =?iso-8859-1?Q?MmV524Fc93zcdZGIwka/aX8IbxFw+R8BBiyDs4YZDsjt5LReHdaefGSS5G?= =?iso-8859-1?Q?YGNAcFKnGO0lrNfk4uOoJFTJuFKrrj9MF5YI63s9PvW6a1AYAsdVkV6ZzC?= =?iso-8859-1?Q?Z0WIbJheJ1XVkGdLP5xR43AnDTa2H9jB/2MiCM2VfbvMfcPGIBKrceZUU7?= =?iso-8859-1?Q?N3oYzCAyhSElCwQkKdi6cBwbIR3Q2WaVCjFEj46a4LMvi9vRNZdhujL6tp?= =?iso-8859-1?Q?+cG4ptGwkJp1ufb/77uddojPS9FfdG49Xd5zIV8FNKGtGKSZqTjruJb3Kl?= =?iso-8859-1?Q?/10/DBbCYQu4HjTMOwBYF6qG9TymIhTfcUI5YRIAMsyn4lyZT3PXW9kKIp?= =?iso-8859-1?Q?dd5yG/Cu/Y+xQait4RSGPkAeu+Q2AzMQEdqTNETVh3tcXjxZXbNP2ExagO?= =?iso-8859-1?Q?kwfErteXBC0t3etoPl/i+Smr2u3AK8XmJu1reL07N+RBP+zQFXypqGWmrS?= =?iso-8859-1?Q?L1I+8LG1MmXod0zBX46YwxQxKgjjVMP0Kvh3K3NzagR1FTKNxHuhpYGtf7?= =?iso-8859-1?Q?z68f/o7Y4xRIXd3VEi1VJTz8JggFu7UeKkziAZj7h4spefkIcl5vn2Cq5U?= =?iso-8859-1?Q?taLFQVYCesTr7EpIeh2RejMgc3soproaC8YwkkfPZrZL4l0z9h0G2p+8vD?= =?iso-8859-1?Q?B2Kx03QNZT60/JKKFMZDoVjUlR8aI4raafsg6qWMQSCO0A91SC2SjKaXjy?= =?iso-8859-1?Q?UR0g/89HJgA62IpNTx2G9FYiKPNCiUprOEVHki1UAqvhj1qZez1BkyUa1z?= =?iso-8859-1?Q?I9LJbpYBdSVZgiiFueS220CPdNJGEhneJzIMdZcvQjAp/zGo1MAc8+v+SD?= =?iso-8859-1?Q?fol8vGXQ2hBhmhcBukg2aOyX0vOQAj5mRM2bIYqwhAn6QZQ6pYAYYk8Qcx?= =?iso-8859-1?Q?vU7guCuzWnaAXZHrI2HhQ5zSTJNo80gQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?7YI9CILeRzZocacWeRJNanWDJ2vug58LoyITjjGp1TT1bqASn0k0O25BPV?= =?iso-8859-1?Q?+0yLgJn0d3OiDQe4B6ZhTBQHOsabhX71+d2P+TI3VtnY5wxyI+WCb0bNTf?= =?iso-8859-1?Q?2haJM4pDsi9IoyIg+gpcKb/E27zfGxHuwPT40bJ/2qrQdNDqxNVvC8c778?= =?iso-8859-1?Q?5SfzCxrxtDrvVnDunBIoUtsvSWPkDOO46cCLxuFn4bJrfUKvKV3qpwCVUW?= =?iso-8859-1?Q?ia53ZDJIoeX5EKdEXs+Fc4hLYq4V8RXqe3whymI+9enkyjBdmhRq8vX7iR?= =?iso-8859-1?Q?vJkHACVxjRC6UtcKG4SX0k1RfcLxw2IMxQArCI+3/Trwe5P4Ojp8fsh3TH?= =?iso-8859-1?Q?PCma4YmvZcsRMf+xdmjVCDAqDa+x8G9Q40Mdnbr0uI0AercJ5GwBOQIXPV?= =?iso-8859-1?Q?jc89gzwgwuoKGLHpbyLQeOEhV7SvY70eyOBpUyIkUug6c6YeqEaSWTVx+D?= =?iso-8859-1?Q?cwhWmeguDrYbPL34lZeTeCWzLQpHPesk6IC7ogs/Ow0T0ef8jMdJFmABt3?= =?iso-8859-1?Q?f3tkkZIMFqsPIuip/wo+JGsBPITAiKAEc70/ukxrqpbwyA+srxV3d33eiN?= =?iso-8859-1?Q?pftCWAuvZWXwy60Y8uF4bJJn0xNGlHfzkEL1G8FJUWJHJU9FibSYJCjKXr?= =?iso-8859-1?Q?N7yMP2BLBQrBD+UTm0VI8aDwXH4QYM3sO/NSZEIukrdWNBZa4kNDQmEIVe?= =?iso-8859-1?Q?W3/YGg85F9Jmdrg8UJQ6ff3YUpxpIvoG+CNBoYqHEjd38oDmhISn0BkNma?= =?iso-8859-1?Q?+C3zsS8SoDbROeiYX0+iy4eJQ/6lOZo62R2UHExrCFtPe5EPEhCEnahisZ?= =?iso-8859-1?Q?eu8VVKnfs6oCeGkdPinUBQiKCUOFX/99eFQPABk1ah1JKOm944eLj3FEFk?= =?iso-8859-1?Q?nGLo9/xrOB4RtDafm1lYp/POgnM7pqNxvyIlQgUUVx5ck99aOfnu+J5tkU?= =?iso-8859-1?Q?G+hAzPAONpqeG94HXukap4X6OFL2uKWCiG0Eq8ukwKjYzpZtjH3xJJ24RA?= =?iso-8859-1?Q?PnXCIAgTYfp28iVw8ooAtU+4Xo+ZZBzbz8bf9souT3mpvmYqCNLEL6W2JF?= =?iso-8859-1?Q?6tIBAC0lBpFZW5bO7GiD9n+m45G+Omy9cf6dxQ6/zCm7IR35FR+ftOGh/c?= =?iso-8859-1?Q?AhwFJpMLpfD1Osjj0vMzUlwRjg4YTIPryGya1TvbF/6d+JgIi9xccfqLKo?= =?iso-8859-1?Q?6FYSrSJ2JcwIfMRJfwYyGfAD5W7zQ+2Gk6lqp9nCprXo9BQY6HcysNjb3H?= =?iso-8859-1?Q?a3ka8IIJ+7w5/fpqK8x2Gtc1tBbcVHrLhIu7fEayzt1FnzAv7tdHcN9KkF?= =?iso-8859-1?Q?pwkuNiW3ipvYCe3pGjd7dwiVbd6pVJAo4SphMmXpZs0qw6VJiGwuw3Qz6/?= =?iso-8859-1?Q?iWzBFykEle8wMZUhBRyp2nEawjXg8Gxn33QquJezrZTpkGA+Aty8xvUanE?= =?iso-8859-1?Q?GnbqGMsd/37Huhj1N+iaD8IhZlX455RLQJEp1JlbUZsaAKPSjaIUZ/lLp9?= =?iso-8859-1?Q?R0+K66HNBcogIOju6CvdM5yIFV/fU/V5s8sFz+/ztngaRjbPruhs8TRn9x?= =?iso-8859-1?Q?4TWYvQ+6p5AViXTjU0AkjBIFBlg3lrZVNkHStXqotSLL9IjAvWhWf426A1?= =?iso-8859-1?Q?1ilBj+6iKOaKg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42764a72-1be0-425f-945a-08dc72f2b255 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 02:16:27.9184 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JsVGB00ChJrdXcgNNyUU1SC9j3fMAs49k5jb35Ae8y3b5UKBdZvmWjhkp7336f5n6CxPFIW5aQXdNKrqZrJ/sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7927 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 12 May 2024 19:16:31 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 14shN59V9C7v4lQjoIYU0f8Wx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB824457442AE4FE43FBC32CFA8CE22MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="A+2/wFMM"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB824457442AE4FE43FBC32CFA8CE22MN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpIn= itLib/MpLib.h index 179f8e585b..11e0d2661f 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -357,7 +357,8 @@ typedef IN UINTN StackStart ); -extern EFI_GUID mCpuInitMpLibHobGuid; +extern EFI_GUID mCpuInitMpLibHobGuid; +extern volatile UINT32 mNumberToFinish; [Ray] It's very good that you keep other global variables in MpLib.c only. Reviewed-by: Ray Ni -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118840): https://edk2.groups.io/g/devel/message/118840 Mute This Topic: https://groups.io/mt/106018133/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB824457442AE4FE43FBC32CFA8CE22MN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpIn= itLib/MpLib.h
index 179f8e585b..11e0d2661f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -357,7 +357,8 @@ typedef
   IN UINTN    StackStart
   );
 
-extern EFI_GUID  mCpuInitMpLibHobGuid;
+extern EFI_GUID         mCpuInitMp= LibHobGuid;
+extern volatile UINT32  mNumberToFinish;

[Ray] It's very good that you keep other global variables in MpLib.c only.<= /div>

Reviewed-by: Ray Ni <ray.ni@intel.com>


_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118840) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB824457442AE4FE43FBC32CFA8CE22MN6PR11MB8244namp_--