public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Chang, Hunter" <hunter.chang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>,
	"S, Ashraf Ali" <ashraf.ali.s@intel.com>
Subject: Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
Date: Thu, 5 Jan 2023 07:05:25 +0000	[thread overview]
Message-ID: <MN6PR11MB82445C6CDF79B0635E802AFC8CFA9@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230104074715.1782-1-hunter.chang@intel.com>

Which spec defines 0xDD?

> -----Original Message-----
> From: Chang, Hunter <hunter.chang@intel.com>
> Sent: Wednesday, January 4, 2023 3:47 PM
> To: devel@edk2.groups.io
> Cc: Chang, Hunter <hunter.chang@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Oram, Isaac W <isaac.w.oram@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>
> Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h
> 
> From: Hunter Chang <hunter.chang@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4242
> 
> Define a macro for SmbiosFeaturePkg usage which named
> INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in
> IndustryStandard/FirmwareVersionInfo.h
> 
> Signed-off-by: Hunter Chang <hunter.chang@intel.com>
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> ---
>  Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> index b30bc3f9e7..466cb8e7d2 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h
> @@ -18,6 +18,7 @@
>  #include <IndustryStandard/SmBios.h>
> 
> 
> 
>  #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME    "Firmware Version Info"
> 
> +#define INTEL_FVI_SMBIOS_TYPE                     0xDD
> 
> 
> 
>  #pragma pack(1)
> 
> 
> 
> --
> 2.26.2.windows.1


  parent reply	other threads:[~2023-01-05  7:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04  7:47 [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h hunter.chang
2023-01-04  8:11 ` Ashraf Ali S
2023-01-05  7:05 ` Ni, Ray [this message]
2023-01-05  7:54   ` hunter.chang
2023-01-05  9:39     ` Ni, Ray
2023-01-05 19:25       ` Isaac Oram
2023-01-06  1:00         ` Ni, Ray
2023-01-06  2:48           ` [edk2-devel] " Chang, Hunter
2023-01-06  5:48           ` Chang, Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB82445C6CDF79B0635E802AFC8CFA9@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox