From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.16851.1674052635592503172 for ; Wed, 18 Jan 2023 06:37:16 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NRtQ8r6t; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674052635; x=1705588635; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=01VGGX1w9a+zxS1DhDGTQr8Hrc+eEzXfed+BCZKjh/M=; b=NRtQ8r6teurn9hP4pHbrcmbya5e8GNSSLTNynLOQqTilkwhc3NiPKP2P auHSDIRGMaSxBd2gby8W61z7/P0PUmcBi4bl6jzvPYVymRUFejKweJu38 KupGMNdnUl1zL6+AlZdW5ae18u2lIbZ2hHOzt1VxQzJi4xFmXqbDzJAe0 sInMJlMkxrGNsN4EYALs5SpsGQy2tCY04rQnzDt5NI7XKT2uMYIG5IA+3 WNLhKmeRfLpA8qNzRN57RCT3kCtjKlzD5jIAvKbSj53fiM5ks7pw1VtPM 6RVuLonYgI211EcLk4dge1PSb462WSttsFLY8rUGunoLdT+Bsy1tujJWE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="326260390" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="326260390" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2023 06:37:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="833602602" X-IronPort-AV: E=Sophos;i="5.97,226,1669104000"; d="scan'208";a="833602602" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 18 Jan 2023 06:37:14 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 06:37:13 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 18 Jan 2023 06:37:13 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 06:37:13 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 18 Jan 2023 06:37:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fgns7kujN08Q/5+OoRLeAmyBPqL2lRu2ZxxBs+FH89jKVz02iFixuCSVAPia2/ssJ332gvQ473fehkEoIFs7Pp4/rWZ1I/1+daVjbDQKX2Y/WwVSuiaPXR3n6QIU4N/3XtbAXhp1yknPObKy22dGP90SO90lXG37RKt6Wa3WKgbPVDN1XBQHbt+ROE8uzbUxiJ/2JG+xtoteeq33I3QNd8d6YwN9KCMZLzlQrufrgdj7r2MJiVpyRheQip8pFlMU8mLgFdk659wRx+uaLRcJ78v9wmBDVgPvbNDv8uWHxKhMtb4MiZml8/UOn0yGTCzrW+jAh9DH/1gjlMWWg4c72g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gIZL8pvzAX3BnuwpOqB5lO4RreADxY2XQSMzI1UD0ng=; b=AlUeJj5U/3f6ELJimMZYXE8rhQt8qIq3QiTINtzjyinKNscG/9R8VBwyp4Pbl0pMGlmpa7spB1pScHKaShaCnB44e+7BePbyONL2fijiHOLV2FE1vugMyE022AX/K39DN9+7nTOOI4sDNQFaxX0/kBf0xBJwPYZkE0+mztHFJwCKlpQg8bWyriGbRZkH7QZDHMPnvbobXDsMdbvpAT5KHZ0QqjuQVhP+Ff6bjWFYGhdbBvWmd1lDDo/9tuZ9/ZfaQCL0UGPjNzqMJs0Xy1f+oXZawKcSotyvjTzcL+/k/G4CvLZgpyqd2v76yuBqx3IqIPzvkOrdRz5AqlznAkZhYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CY5PR11MB6319.namprd11.prod.outlook.com (2603:10b6:930:3d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 18 Jan 2023 14:37:11 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.5986.023; Wed, 18 Jan 2023 14:37:11 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "Wu, Jiaxin" CC: "devel@edk2.groups.io" , "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , "Kumar, Rahul R" Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Topic: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Thread-Index: AQHZKyMxwGsEKVpeWUKwFvKCQ+pfJK6kGBUAgAAl/sA= Date: Wed, 18 Jan 2023 14:37:11 +0000 Message-ID: References: <20230118095620.9860-1-jiaxin.wu@intel.com> <20230118095620.9860-6-jiaxin.wu@intel.com> <20230118121958.cxbfh3fljedvebis@sirius.home.kraxel.org> In-Reply-To: <20230118121958.cxbfh3fljedvebis@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CY5PR11MB6319:EE_ x-ms-office365-filtering-correlation-id: d61fce3c-0087-47d9-f54f-08daf9617be8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CFFHD8/J1B7hDFaVoOitFdlxL37MnrDll0ORhD2H42XJv2srKHWqZ94Y9Mg3yndytQILyrWAGB2imqakM9hsiBKYIsZFmoi5w2Gs78/0Y1o+7DlN0Yw5OqHhgRM6eApOspUWfkvEoovXpyntRBEMj2VBb+/dsyoHfs5u8v15mYhEkdurU5DCgd0sLPuamsvtCo+toB47fRWwSUTUACYljlzCwFwBFBh+WiN+I25WtN+rbUqL68Peuj2vKyOeL/OkOKCMA9oZ5dx8EcfiJjbaOl6GWTDCipEykrSBfOJn08dRClpnsNZ90ylqGBB0qGdbRsJf1O7IAK9C+L+cPxCj1Q88EHk0c371ELuAXYAdsNOzKAaDgEyf92WsxQsa2y2iTT44LwfjU3RXeMlkT13/6yHj6lHiCrGXYt01HErofzHgSEUBW/CPu+NEsFOfuSSf9YMAFKMEi+3/oPnCVTHsqhp5+kopqXNC9eGalzNUIUpjRkmpd35ZV81525C/XUVfGdz9n2adwqyx5lc8iRoBWtUwPk2+0qmlD/nJ6p8lcS4U8AdizK66Fy3Mf+qTg3spcw9SdEc6FHUlNVCGQocKAeTT3ivDBY7yynH7WY6EnIpQckIF0Ca8j9KGhfVUQgy2b7Wn1IGlq1D/xtjxFZIP1btfdL9o8y17J0Z/PkrxY2x0gsUEzxUApd6YqqmklHY2MTSku8le320QpKfjAd+wDw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(346002)(39860400002)(366004)(396003)(451199015)(66556008)(64756008)(66476007)(41300700001)(110136005)(76116006)(52536014)(66446008)(8676002)(66946007)(316002)(4326008)(86362001)(82960400001)(5660300002)(38070700005)(6636002)(38100700002)(83380400001)(122000001)(33656002)(54906003)(8936002)(71200400001)(2906002)(6506007)(55016003)(53546011)(7696005)(107886003)(9686003)(186003)(478600001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kVCpUkYYcNq7tTQq2zI0dcZmhyGivH3UPxHVx3BU8O5d583wJ1+p99d8g/L4?= =?us-ascii?Q?dGLroX2gKLXfKi9v8m3OY6O9z5t+aseQEkj6Sz5oQoMZN962j3hnxf27DENw?= =?us-ascii?Q?+h5eoQny8OM9ZbF3tfnbgN20Wy9cHcpNHfhGvyHQHKcs5HPqsDFYeSE5qQgl?= =?us-ascii?Q?NDXVhFDdyLdrCFJl9CQGOl/ozhkq8Ll+msNNsex3a70OxU5wY6B4Q9bfNodj?= =?us-ascii?Q?LYC0u2rIY3RYGjIcZqKGDaeY4SVvorJxmsXnih39beOjoEdNXcLqfPAZKmam?= =?us-ascii?Q?dh/X4h9FkPNG2DowzrlP53AzIqq9BmAH7oCW1xJdusICOlkJtOMO20ohRuBS?= =?us-ascii?Q?hQ7obBHRY2CZhfeIuJ4EyCXW8hTMFRV6NqAfy3YqB8d3uW138FNmsB1y1P4F?= =?us-ascii?Q?ezMTlcD3wSwLpyGI8GdtTrRQ3HkzFVkvhomfb99/dMuliYvKtBLCzGl89tN+?= =?us-ascii?Q?vm+QNVe37Fgr6qdl6coO7r556wbAi58z4VCo98U3V9eMfygIyiYa7X9rQFoa?= =?us-ascii?Q?VZzQzwrQhZ4hfmFpI4T4lwASOLykoNUFzlCMLP0EWWifwcuGvlnqKpHAsxzY?= =?us-ascii?Q?hDOZlRsVaSy65pqPM5B35DBUosEavXnEZxD2FaKhwlmgbp12AxNNh0uPyNxp?= =?us-ascii?Q?+Y91WtA5HKUAzir5sy3/UgVg9JaFnXdD96q8agg3EW/KdD6GB4zsFTyA88YL?= =?us-ascii?Q?V/z1mZXzjf0w4bT5h8DbWrtWhqrOA/5FrGMHebqkTm43L35E4pDWZVgF+0Dk?= =?us-ascii?Q?5q+7vOZdt4a+5URhZkDGcQyQl5AvO52A1mJPL8s9NC8bBJ6kZ1QroXj/R4AQ?= =?us-ascii?Q?HhTvQBVGHn/aIqQzr4ta3wmxa38KPlbBJT5o8w+eRXjGut2Oz9YptObB95w1?= =?us-ascii?Q?x45jVaZhUiUPDTKdGeD+OGG2/pNwNnQ78aTCtIXmebZYpEqcNCJanEub1US/?= =?us-ascii?Q?nxv1Vx2L0CLqUhbS2Kjwu9GBz2FUmsYP7g/1Bcwo9Ks/7PhuLCr8cZwlB6F7?= =?us-ascii?Q?afg3SLxoeWf2iK8dFit3DNMRd+MGi1almZ/wjt/wc7thb6xRvnjAMWFDfVb2?= =?us-ascii?Q?8leUdQcImO//f6r2k7FhfICU1LgTSgMi7lap64ojwdIo89SjpA/49aWQOh5B?= =?us-ascii?Q?QEi4OvX/Htq9W4fw5hacX10lbZk8MVJKH6oRTpmLg5+Z8Y8mO0eZX1ilfi8P?= =?us-ascii?Q?4lto1AjEyLQt7+A4TkSfpm89q5c9ivagpHc0zvssFCXAYsnskxeTHoBKdtya?= =?us-ascii?Q?vdVUJBlNunX8eD1t9oh8TYil3fMF9LNSarJ6XLfTRzBgmhnkD8pUEzGRjnPq?= =?us-ascii?Q?IZubVomq4iLlQ6mCer5FNwrbgXIp0ia9KrNxuPVw2sX8/7llf05UIo8nOMUW?= =?us-ascii?Q?wdpB1/XyCLmKhmMdVSEJyhw1OPU2D6ub8E00vR8c1y/I6gkHE4DIeSJ0Wz00?= =?us-ascii?Q?9j9qaGPxk4+cCm5Kq+D6pvgKN5w9C1+0EF+U0jRhm8Ph3rGOArO1qC8OFj2+?= =?us-ascii?Q?d8E0LHmUQ5ChYOmRYzTFL/YhnpUMLa882tZSkFEtrjq+5S4P9+69cnOMpcxS?= =?us-ascii?Q?YZlfdJk8bENtJoDAIpE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d61fce3c-0087-47d9-f54f-08daf9617be8 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2023 14:37:11.2198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WadG9aPBORwZZ7qZ2BLC/56kWPWZyLw58nyEF4Kz1GqVlMqdB9K1KXbEBzdVnR+1IpY1Khgz4RXzXNvb8hTUTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6319 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, I think comments from patch #1 explains: # The default SMBASE for the x86 processor is 0x30000. When SMI happens, CP= U + runs the SMI handler at SMBASE+0x8000. Also, the SMM save state area is = within + SMBASE+0x10000. + + One of the SMM initialization from CPU perspective is to relocate and pr= ogram + the new SMBASE (in TSEG range) for each CPU thread. When the SMBASE relo= cation + happens in a PEI module, the PEI module shall produce the SMM_BASE_HOB i= n HOB + database which tells the PiSmmCpuDxeSmm driver (which runs at a later ph= ase) + about the new SMBASE for each CPU thread. PiSmmCpuDxeSmm driver installs= the + SMI handler at the SMM_BASE_HOB.SmBase[Index]+0x8000 for CPU thread Inde= x. + When the HOB doesn't exist, PiSmmCpuDxeSmm driver shall relocate and pro= gram + the new SMBASE itself. > -----Original Message----- > From: Gerd Hoffmann > Sent: Wednesday, January 18, 2023 8:20 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE > configuration >=20 > On Wed, Jan 18, 2023 at 05:56:20PM +0800, Jiaxin Wu wrote: > > This patch is to avoid configure SMBASE if SmBase relocation has been > > done. If gSmmBaseHobGuid found, means SmBase info has been relocated > > and recorded in the SmBase array. No need to do the relocation in > > SmmCpuFeaturesInitializeProcessor(). >=20 > Still not answered: Who produces the gSmmBaseHobGuid? >=20 > If you intend to submit the producer code to edk2 please do so as part > of this patch series, so it is possible to see the whole picture instead > of only some pieces of the puzzle when reviewing the code. >=20 > If you don't submit the producer code it is pointless to touch OVMF. > You are only adding dead code. That would be a rather questionable > decision though and add a big question mark to intels open source > commitment. >=20 > take care, > Gerd